[INFO] cloning repository https://github.com/azah/faramir [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/azah/faramir" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fazah%2Ffaramir", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fazah%2Ffaramir'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1b3ede168dbdd8650c0ff8acaa30758a54fc3679 [INFO] checking azah/faramir/1b3ede168dbdd8650c0ff8acaa30758a54fc3679 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fazah%2Ffaramir" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/azah/faramir on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/azah/faramir [INFO] finished tweaking git repo https://github.com/azah/faramir [INFO] tweaked toml for git repo https://github.com/azah/faramir written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/azah/faramir already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 258849cb111456b7ab49196ea7fda5f257b3c647ca4c6a8955fc7bf85cc57bac [INFO] running `Command { std: "docker" "start" "-a" "258849cb111456b7ab49196ea7fda5f257b3c647ca4c6a8955fc7bf85cc57bac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "258849cb111456b7ab49196ea7fda5f257b3c647ca4c6a8955fc7bf85cc57bac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "258849cb111456b7ab49196ea7fda5f257b3c647ca4c6a8955fc7bf85cc57bac", kill_on_drop: false }` [INFO] [stdout] 258849cb111456b7ab49196ea7fda5f257b3c647ca4c6a8955fc7bf85cc57bac [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 982c11fbcae812f8294ecc794545d2836dafd96507c872ecfc75d2d1fdcbd3fb [INFO] running `Command { std: "docker" "start" "-a" "982c11fbcae812f8294ecc794545d2836dafd96507c872ecfc75d2d1fdcbd3fb", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Compiling proc-macro2 v1.0.7 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling syn v1.0.12 [INFO] [stderr] Compiling serde v1.0.104 [INFO] [stderr] Compiling getrandom v0.1.13 [INFO] [stderr] Compiling regex-syntax v0.6.12 [INFO] [stderr] Compiling cc v1.0.48 [INFO] [stderr] Compiling pkg-config v0.3.17 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Checking linked-hash-map v0.5.2 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Checking yaml-rust v0.3.5 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking termcolor v1.0.5 [INFO] [stderr] Checking lru-cache v0.1.2 [INFO] [stderr] Compiling num-traits v0.2.10 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Compiling libsqlite3-sys v0.17.0 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Compiling regex v1.3.1 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking rand v0.7.2 [INFO] [stderr] Compiling parse-zoneinfo v0.2.1 [INFO] [stderr] Compiling chrono-tz v0.5.1 [INFO] [stderr] Compiling serde_derive v1.0.104 [INFO] [stderr] Checking chrono v0.4.10 [INFO] [stderr] Checking serde_json v1.0.44 [INFO] [stderr] Checking rusqlite v0.21.0 [INFO] [stderr] Checking faramir v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `sub_matches` [INFO] [stdout] --> src/main.rs:75:29 [INFO] [stdout] | [INFO] [stdout] 75 | fn stats(conn: &Connection, sub_matches: &ArgMatches) -> AppResult<()> { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_sub_matches` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:9:18 [INFO] [stdout] | [INFO] [stdout] 8 | pub(crate) fn new(kind: ErrorKind) -> AppError { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | AppError(Box::new(kind)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:59:23 [INFO] [stdout] | [INFO] [stdout] 58 | fn from(err: std::io::Error) -> AppError { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | AppError::new(ErrorKind::IO(err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:65:23 [INFO] [stdout] | [INFO] [stdout] 64 | fn from(err: serde_json::error::Error) -> AppError { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | AppError::new(ErrorKind::SerdeJson(err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:71:23 [INFO] [stdout] | [INFO] [stdout] 70 | fn from(err: rusqlite::Error) -> AppError { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | AppError::new(ErrorKind::Rusqlite(err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/config.rs:75:15 [INFO] [stdout] | [INFO] [stdout] 75 | match serde_json::from_str(&content) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/project.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 104 | let mut stmt = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | conn.prepare("SELECT * FROM projects WHERE name = ?1")?; [INFO] [stdout] 106 | / stmt.query_row(&[name], |row| { [INFO] [stdout] 107 | | Ok(Project { [INFO] [stdout] 108 | | id: row.get(0)?, [INFO] [stdout] 109 | | name: row.get(1)?, [INFO] [stdout] 110 | | }) [INFO] [stdout] 111 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/project.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 116 | let mut stmt = conn.prepare("SELECT * FROM projects WHERE id = ?1")?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | / stmt.query_row(&[project_id], |row| { [INFO] [stdout] 118 | | Ok(Project { [INFO] [stdout] 119 | | id: row.get(0)?, [INFO] [stdout] 120 | | name: row.get(1)?, [INFO] [stdout] 121 | | }) [INFO] [stdout] 122 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/tag.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 115 | let mut stmt = conn.prepare("SELECT * FROM tags WHERE name = ?1")?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | / stmt.query_row(&[name], |row| { [INFO] [stdout] 117 | | Ok(Tag { [INFO] [stdout] 118 | | id: row.get(0)?, [INFO] [stdout] 119 | | name: row.get(1)?, [INFO] [stdout] 120 | | }) [INFO] [stdout] 121 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/models/timer.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | &timer.stop(&conn)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 27 | let _ = &timer.stop(&conn)?; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/timer.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 43 | let tx = conn.transaction()?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | tx.commit().map_err(|e| AppError::from(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/timer.rs:191:9 [INFO] [stdout] | [INFO] [stdout] 190 | let mut stmt = conn.prepare(&sql)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | / stmt.query_row(&[val], |row| { [INFO] [stdout] 192 | | Ok(Timer { [INFO] [stdout] 193 | | id: row.get(0)?, [INFO] [stdout] 194 | | rid: row.get(1)?, [INFO] [stdout] ... | [INFO] [stdout] 198 | | }) [INFO] [stdout] 199 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/timer.rs:206:9 [INFO] [stdout] | [INFO] [stdout] 205 | let mut stmt = conn.prepare(&sql)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | / stmt.query_row(NO_PARAMS, |row| { [INFO] [stdout] 207 | | Ok(Timer { [INFO] [stdout] 208 | | id: row.get(0)?, [INFO] [stdout] 209 | | rid: row.get(1)?, [INFO] [stdout] ... | [INFO] [stdout] 213 | | }) [INFO] [stdout] 214 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/models/timer.rs:249:9 [INFO] [stdout] | [INFO] [stdout] 249 | &self.insert(&conn)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 249 | let _ = &self.insert(&conn)?; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `faramir` (bin "faramir") due to 12 previous errors; 3 warnings emitted [INFO] [stdout] warning: unused variable: `sub_matches` [INFO] [stdout] --> src/main.rs:75:29 [INFO] [stdout] | [INFO] [stdout] 75 | fn stats(conn: &Connection, sub_matches: &ArgMatches) -> AppResult<()> { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_sub_matches` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:9:18 [INFO] [stdout] | [INFO] [stdout] 8 | pub(crate) fn new(kind: ErrorKind) -> AppError { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | AppError(Box::new(kind)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:59:23 [INFO] [stdout] | [INFO] [stdout] 58 | fn from(err: std::io::Error) -> AppError { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | AppError::new(ErrorKind::IO(err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:65:23 [INFO] [stdout] | [INFO] [stdout] 64 | fn from(err: serde_json::error::Error) -> AppError { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | AppError::new(ErrorKind::SerdeJson(err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:71:23 [INFO] [stdout] | [INFO] [stdout] 70 | fn from(err: rusqlite::Error) -> AppError { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | AppError::new(ErrorKind::Rusqlite(err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/config.rs:75:15 [INFO] [stdout] | [INFO] [stdout] 75 | match serde_json::from_str(&content) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/project.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 104 | let mut stmt = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | conn.prepare("SELECT * FROM projects WHERE name = ?1")?; [INFO] [stdout] 106 | / stmt.query_row(&[name], |row| { [INFO] [stdout] 107 | | Ok(Project { [INFO] [stdout] 108 | | id: row.get(0)?, [INFO] [stdout] 109 | | name: row.get(1)?, [INFO] [stdout] 110 | | }) [INFO] [stdout] 111 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/project.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 116 | let mut stmt = conn.prepare("SELECT * FROM projects WHERE id = ?1")?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | / stmt.query_row(&[project_id], |row| { [INFO] [stdout] 118 | | Ok(Project { [INFO] [stdout] 119 | | id: row.get(0)?, [INFO] [stdout] 120 | | name: row.get(1)?, [INFO] [stdout] 121 | | }) [INFO] [stdout] 122 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/tag.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 115 | let mut stmt = conn.prepare("SELECT * FROM tags WHERE name = ?1")?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | / stmt.query_row(&[name], |row| { [INFO] [stdout] 117 | | Ok(Tag { [INFO] [stdout] 118 | | id: row.get(0)?, [INFO] [stdout] 119 | | name: row.get(1)?, [INFO] [stdout] 120 | | }) [INFO] [stdout] 121 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/models/timer.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | &timer.stop(&conn)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 27 | let _ = &timer.stop(&conn)?; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/timer.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 43 | let tx = conn.transaction()?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | tx.commit().map_err(|e| AppError::from(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/timer.rs:191:9 [INFO] [stdout] | [INFO] [stdout] 190 | let mut stmt = conn.prepare(&sql)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | / stmt.query_row(&[val], |row| { [INFO] [stdout] 192 | | Ok(Timer { [INFO] [stdout] 193 | | id: row.get(0)?, [INFO] [stdout] 194 | | rid: row.get(1)?, [INFO] [stdout] ... | [INFO] [stdout] 198 | | }) [INFO] [stdout] 199 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/timer.rs:206:9 [INFO] [stdout] | [INFO] [stdout] 205 | let mut stmt = conn.prepare(&sql)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | / stmt.query_row(NO_PARAMS, |row| { [INFO] [stdout] 207 | | Ok(Timer { [INFO] [stdout] 208 | | id: row.get(0)?, [INFO] [stdout] 209 | | rid: row.get(1)?, [INFO] [stdout] ... | [INFO] [stdout] 213 | | }) [INFO] [stdout] 214 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/models/timer.rs:249:9 [INFO] [stdout] | [INFO] [stdout] 249 | &self.insert(&conn)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 249 | let _ = &self.insert(&conn)?; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `faramir` (bin "faramir" test) due to 12 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "982c11fbcae812f8294ecc794545d2836dafd96507c872ecfc75d2d1fdcbd3fb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "982c11fbcae812f8294ecc794545d2836dafd96507c872ecfc75d2d1fdcbd3fb", kill_on_drop: false }` [INFO] [stdout] 982c11fbcae812f8294ecc794545d2836dafd96507c872ecfc75d2d1fdcbd3fb