[INFO] cloning repository https://github.com/aujxn/recipe_analysis [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/aujxn/recipe_analysis" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faujxn%2Frecipe_analysis", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faujxn%2Frecipe_analysis'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] bcc8cb5f62f8266a3a521b40607a7a5fa34949ac [INFO] checking aujxn/recipe_analysis/bcc8cb5f62f8266a3a521b40607a7a5fa34949ac against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faujxn%2Frecipe_analysis" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/aujxn/recipe_analysis on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/aujxn/recipe_analysis [INFO] finished tweaking git repo https://github.com/aujxn/recipe_analysis [INFO] tweaked toml for git repo https://github.com/aujxn/recipe_analysis written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/aujxn/recipe_analysis already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cc14faaca4884ab1baae6e364ac58dec1d79b6d85a5820f6fee2da3e6c4c8aaf [INFO] running `Command { std: "docker" "start" "-a" "cc14faaca4884ab1baae6e364ac58dec1d79b6d85a5820f6fee2da3e6c4c8aaf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cc14faaca4884ab1baae6e364ac58dec1d79b6d85a5820f6fee2da3e6c4c8aaf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cc14faaca4884ab1baae6e364ac58dec1d79b6d85a5820f6fee2da3e6c4c8aaf", kill_on_drop: false }` [INFO] [stdout] cc14faaca4884ab1baae6e364ac58dec1d79b6d85a5820f6fee2da3e6c4c8aaf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 616b1b11e28e2e5a05e8fb7b5a7c978f4575a3a7b4f32e6d358124f0cde5e699 [INFO] running `Command { std: "docker" "start" "-a" "616b1b11e28e2e5a05e8fb7b5a7c978f4575a3a7b4f32e6d358124f0cde5e699", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.117 [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Compiling crossbeam-utils v0.8.7 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling crossbeam-epoch v0.9.7 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Checking lock_api v0.4.6 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Checking cpufeatures v0.2.1 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Checking stringprep v0.1.2 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Checking siphasher v0.3.9 [INFO] [stderr] Checking once_cell v1.9.0 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling ndarray v0.13.1 [INFO] [stderr] Compiling async-trait v0.1.52 [INFO] [stderr] Checking matrixmultiply v0.2.4 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Compiling serde_json v1.0.79 [INFO] [stderr] Compiling anyhow v1.0.53 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Checking phf_shared v0.10.0 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking crossbeam-channel v0.5.2 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking bimap v0.6.2 [INFO] [stderr] Checking phf v0.10.1 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Compiling quote v1.0.15 [INFO] [stderr] Checking block-buffer v0.10.2 [INFO] [stderr] Checking crypto-common v0.1.2 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking getrandom v0.2.4 [INFO] [stderr] Checking parking_lot_core v0.8.5 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking mio v0.7.14 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking digest v0.10.2 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking md-5 v0.10.0 [INFO] [stderr] Checking sha2 v0.10.1 [INFO] [stderr] Checking hmac v0.12.0 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking postgres-protocol v0.6.3 [INFO] [stderr] Checking postgres-types v0.2.2 [INFO] [stderr] Checking matrixlab v0.2.0 (https://github.com/aujxn/matrixlab#f4fe3a0a) [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Checking tokio v1.16.1 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking tokio-util v0.6.9 [INFO] [stderr] Checking tokio-postgres v0.7.5 [INFO] [stderr] Checking recipe_analysis v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: multiple fields are never read [INFO] [stdout] --> src/recipe.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct Recipe { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 11 | id: Option, [INFO] [stdout] | ^^ [INFO] [stdout] 12 | title: String, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 13 | source: Publisher, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 14 | url: String, [INFO] [stdout] | ^^^ [INFO] [stdout] 15 | yields: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 16 | /// Prep + Cooking time in minutes [INFO] [stdout] 17 | time: Option, [INFO] [stdout] | ^^^^ [INFO] [stdout] 18 | description: Option, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 19 | tags: Option>, [INFO] [stdout] | ^^^^ [INFO] [stdout] 20 | num_ratings: usize, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 21 | avg_rating: f32, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 22 | ingredients: Vec, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 23 | steps: Vec, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 24 | comments: Option>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Recipe` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `NYTCooking` and `AllRecipes` are never constructed [INFO] [stdout] --> src/recipe.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 28 | enum Publisher { [INFO] [stdout] | --------- variants in this enum [INFO] [stdout] 29 | /// New York Times Cooking [INFO] [stdout] 30 | NYTCooking = 0, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 31 | /// allrecipes.com [INFO] [stdout] 32 | AllRecipes = 1, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Publisher` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/recipe.rs:36:8 [INFO] [stdout] | [INFO] [stdout] 35 | impl Publisher { [INFO] [stdout] | -------------- associated function in this implementation [INFO] [stdout] 36 | fn new(value: i32) -> Result { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple fields are never read [INFO] [stdout] --> src/recipe.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct Recipe { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 11 | id: Option, [INFO] [stdout] | ^^ [INFO] [stdout] 12 | title: String, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 13 | source: Publisher, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 14 | url: String, [INFO] [stdout] | ^^^ [INFO] [stdout] 15 | yields: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 16 | /// Prep + Cooking time in minutes [INFO] [stdout] 17 | time: Option, [INFO] [stdout] | ^^^^ [INFO] [stdout] 18 | description: Option, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 19 | tags: Option>, [INFO] [stdout] | ^^^^ [INFO] [stdout] 20 | num_ratings: usize, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 21 | avg_rating: f32, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 22 | ingredients: Vec, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 23 | steps: Vec, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 24 | comments: Option>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Recipe` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `NYTCooking` and `AllRecipes` are never constructed [INFO] [stdout] --> src/recipe.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 28 | enum Publisher { [INFO] [stdout] | --------- variants in this enum [INFO] [stdout] 29 | /// New York Times Cooking [INFO] [stdout] 30 | NYTCooking = 0, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 31 | /// allrecipes.com [INFO] [stdout] 32 | AllRecipes = 1, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Publisher` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/recipe.rs:36:8 [INFO] [stdout] | [INFO] [stdout] 35 | impl Publisher { [INFO] [stdout] | -------------- associated function in this implementation [INFO] [stdout] 36 | fn new(value: i32) -> Result { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `expanded`, `hierarchy`, and `louvain` [INFO] [stdout] --> src/bin/expand.rs:2:38 [INFO] [stdout] | [INFO] [stdout] 2 | use recipe_analysis::{co_occurrence, expanded, hierarchy, louvain, recipe}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^ ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::prelude::*` [INFO] [stdout] --> src/bin/expand.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/bin/expand.rs:5:15 [INFO] [stdout] | [INFO] [stdout] 5 | use std::io::{self, Write}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `expanded`, `hierarchy`, and `louvain` [INFO] [stdout] --> src/bin/expand.rs:2:38 [INFO] [stdout] | [INFO] [stdout] 2 | use recipe_analysis::{co_occurrence, expanded, hierarchy, louvain, recipe}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^ ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::prelude::*` [INFO] [stdout] --> src/bin/expand.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/bin/expand.rs:5:15 [INFO] [stdout] | [INFO] [stdout] 5 | use std::io::{self, Write}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/expand.rs:107:5 [INFO] [stdout] | [INFO] [stdout] 107 | Ok(()) [INFO] [stdout] | ^^---- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/expand.rs:107:5 [INFO] [stdout] | [INFO] [stdout] 107 | Ok(()) [INFO] [stdout] | ^^---- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/bin/expand.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | drop(child_stdin); [INFO] [stdout] | ^^^^^-----------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut tokio::process::ChildStdin` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 47 - drop(child_stdin); [INFO] [stdout] 47 + let _ = child_stdin; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/bin/expand.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | drop(child_stdin); [INFO] [stdout] | ^^^^^-----------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut tokio::process::ChildStdin` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 47 - drop(child_stdin); [INFO] [stdout] 47 + let _ = child_stdin; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `recipe_analysis` (bin "expand") due to 2 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `recipe_analysis` (bin "expand" test) due to 2 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "616b1b11e28e2e5a05e8fb7b5a7c978f4575a3a7b4f32e6d358124f0cde5e699", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "616b1b11e28e2e5a05e8fb7b5a7c978f4575a3a7b4f32e6d358124f0cde5e699", kill_on_drop: false }` [INFO] [stdout] 616b1b11e28e2e5a05e8fb7b5a7c978f4575a3a7b4f32e6d358124f0cde5e699