[INFO] cloning repository https://github.com/atomicincrement/randtest [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/atomicincrement/randtest" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fatomicincrement%2Frandtest", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fatomicincrement%2Frandtest'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 069c4eadac6344d66dfd2ada397158ac9549813b [INFO] checking atomicincrement/randtest/069c4eadac6344d66dfd2ada397158ac9549813b against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fatomicincrement%2Frandtest" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/atomicincrement/randtest on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-5-tc2/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/atomicincrement/randtest [INFO] finished tweaking git repo https://github.com/atomicincrement/randtest [INFO] tweaked toml for git repo https://github.com/atomicincrement/randtest written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/atomicincrement/randtest already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ced98110d16a8767170db95b548cafb3813570c283f2db2058523c40893f15a0 [INFO] running `Command { std: "docker" "start" "-a" "ced98110d16a8767170db95b548cafb3813570c283f2db2058523c40893f15a0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ced98110d16a8767170db95b548cafb3813570c283f2db2058523c40893f15a0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ced98110d16a8767170db95b548cafb3813570c283f2db2058523c40893f15a0", kill_on_drop: false }` [INFO] [stdout] ced98110d16a8767170db95b548cafb3813570c283f2db2058523c40893f15a0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7496f1926a954adc3de38760a59d51736d136a7250ec0a97e94f3e641ee5825d [INFO] running `Command { std: "docker" "start" "-a" "7496f1926a954adc3de38760a59d51736d136a7250ec0a97e94f3e641ee5825d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.107 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling libm v0.2.1 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking ppv-lite86 v0.2.15 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking crossbeam-epoch v0.9.5 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking rand_distr v0.4.2 [INFO] [stderr] Checking randtest v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: type `fty` should have an upper camel case name [INFO] [stdout] --> src/main.rs:7:6 [INFO] [stdout] | [INFO] [stdout] 7 | type fty = f64; [INFO] [stdout] | ^^^ help: convert the identifier to upper camel case (notice the capitalization): `Fty` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `ity` should have an upper camel case name [INFO] [stdout] --> src/main.rs:8:6 [INFO] [stdout] | [INFO] [stdout] 8 | type ity = i64; [INFO] [stdout] | ^^^ help: convert the identifier to upper camel case (notice the capitalization): `Ity` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `uty` should have an upper camel case name [INFO] [stdout] --> src/main.rs:9:6 [INFO] [stdout] | [INFO] [stdout] 9 | type uty = u64; [INFO] [stdout] | ^^^ help: convert the identifier to upper camel case (notice the capitalization): `Uty` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::f64::consts::LOG2_10` [INFO] [stdout] --> src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use std::f64::consts::LOG2_10; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::f64::consts::PI` [INFO] [stdout] --> src/main.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use std::f64::consts::PI; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `fty` should have an upper camel case name [INFO] [stdout] --> src/main.rs:7:6 [INFO] [stdout] | [INFO] [stdout] 7 | type fty = f64; [INFO] [stdout] | ^^^ help: convert the identifier to upper camel case (notice the capitalization): `Fty` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `ity` should have an upper camel case name [INFO] [stdout] --> src/main.rs:8:6 [INFO] [stdout] | [INFO] [stdout] 8 | type ity = i64; [INFO] [stdout] | ^^^ help: convert the identifier to upper camel case (notice the capitalization): `Ity` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `uty` should have an upper camel case name [INFO] [stdout] --> src/main.rs:9:6 [INFO] [stdout] | [INFO] [stdout] 9 | type uty = u64; [INFO] [stdout] | ^^^ help: convert the identifier to upper camel case (notice the capitalization): `Uty` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::f64::consts::LOG2_10` [INFO] [stdout] --> src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use std::f64::consts::LOG2_10; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::f64::consts::PI` [INFO] [stdout] --> src/main.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use std::f64::consts::PI; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `normal` [INFO] [stdout] --> src/main.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 146 | let normal = Normal::new(1.0, 1.0).unwrap(); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_normal` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `ity` is never used [INFO] [stdout] --> src/main.rs:8:6 [INFO] [stdout] | [INFO] [stdout] 8 | type ity = i64; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `select` is never used [INFO] [stdout] --> src/main.rs:15:4 [INFO] [stdout] | [INFO] [stdout] 15 | fn select(a: bool, b: fty, c: fty) -> fty { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `iabs` is never used [INFO] [stdout] --> src/main.rs:23:4 [INFO] [stdout] | [INFO] [stdout] 23 | fn iabs(i: ity) -> ity { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `f` is never used [INFO] [stdout] --> src/main.rs:27:4 [INFO] [stdout] | [INFO] [stdout] 27 | fn f(f: fty) -> fty { [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `to_bits` is never used [INFO] [stdout] --> src/main.rs:35:4 [INFO] [stdout] | [INFO] [stdout] 35 | fn to_bits(f: fty) -> uty { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `negate_on_odd` is never used [INFO] [stdout] --> src/main.rs:59:4 [INFO] [stdout] | [INFO] [stdout] 59 | fn negate_on_odd(x: fty, y: fty) -> fty { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `recip_approx` is never used [INFO] [stdout] --> src/main.rs:63:4 [INFO] [stdout] | [INFO] [stdout] 63 | fn recip_approx(x: fty) -> fty { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `sqrt_approx` is never used [INFO] [stdout] --> src/main.rs:69:4 [INFO] [stdout] | [INFO] [stdout] 69 | fn sqrt_approx(x: fty) -> fty { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `cbrt_approx` is never used [INFO] [stdout] --> src/main.rs:75:4 [INFO] [stdout] | [INFO] [stdout] 75 | fn cbrt_approx(x: fty) -> fty { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:122:45 [INFO] [stdout] | [INFO] [stdout] 122 | .for_each(|c| c.iter_mut().for_each(f.clone())); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `randtest` (bin "randtest" test) due to 2 previous errors; 15 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `normal` [INFO] [stdout] --> src/main.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 146 | let normal = Normal::new(1.0, 1.0).unwrap(); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_normal` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `ity` is never used [INFO] [stdout] --> src/main.rs:8:6 [INFO] [stdout] | [INFO] [stdout] 8 | type ity = i64; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `select` is never used [INFO] [stdout] --> src/main.rs:15:4 [INFO] [stdout] | [INFO] [stdout] 15 | fn select(a: bool, b: fty, c: fty) -> fty { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `iabs` is never used [INFO] [stdout] --> src/main.rs:23:4 [INFO] [stdout] | [INFO] [stdout] 23 | fn iabs(i: ity) -> ity { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `f` is never used [INFO] [stdout] --> src/main.rs:27:4 [INFO] [stdout] | [INFO] [stdout] 27 | fn f(f: fty) -> fty { [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `to_bits` is never used [INFO] [stdout] --> src/main.rs:35:4 [INFO] [stdout] | [INFO] [stdout] 35 | fn to_bits(f: fty) -> uty { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `negate_on_odd` is never used [INFO] [stdout] --> src/main.rs:59:4 [INFO] [stdout] | [INFO] [stdout] 59 | fn negate_on_odd(x: fty, y: fty) -> fty { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `recip_approx` is never used [INFO] [stdout] --> src/main.rs:63:4 [INFO] [stdout] | [INFO] [stdout] 63 | fn recip_approx(x: fty) -> fty { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `sqrt_approx` is never used [INFO] [stdout] --> src/main.rs:69:4 [INFO] [stdout] | [INFO] [stdout] 69 | fn sqrt_approx(x: fty) -> fty { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `cbrt_approx` is never used [INFO] [stdout] --> src/main.rs:75:4 [INFO] [stdout] | [INFO] [stdout] 75 | fn cbrt_approx(x: fty) -> fty { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:122:45 [INFO] [stdout] | [INFO] [stdout] 122 | .for_each(|c| c.iter_mut().for_each(f.clone())); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `randtest` (bin "randtest") due to 2 previous errors; 15 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7496f1926a954adc3de38760a59d51736d136a7250ec0a97e94f3e641ee5825d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7496f1926a954adc3de38760a59d51736d136a7250ec0a97e94f3e641ee5825d", kill_on_drop: false }` [INFO] [stdout] 7496f1926a954adc3de38760a59d51736d136a7250ec0a97e94f3e641ee5825d