[INFO] cloning repository https://github.com/atomberg/grove [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/atomberg/grove" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fatomberg%2Fgrove", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fatomberg%2Fgrove'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b64112d06652dcf8b4862e8dfd519a24d91d5f75 [INFO] checking atomberg/grove/b64112d06652dcf8b4862e8dfd519a24d91d5f75 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fatomberg%2Fgrove" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/atomberg/grove on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/atomberg/grove [INFO] finished tweaking git repo https://github.com/atomberg/grove [INFO] tweaked toml for git repo https://github.com/atomberg/grove written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/atomberg/grove already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4bf34242e789aa6840e4456b428c7e35c3c1f18d3dd1b57625bb8d03367ca6ce [INFO] running `Command { std: "docker" "start" "-a" "4bf34242e789aa6840e4456b428c7e35c3c1f18d3dd1b57625bb8d03367ca6ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4bf34242e789aa6840e4456b428c7e35c3c1f18d3dd1b57625bb8d03367ca6ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4bf34242e789aa6840e4456b428c7e35c3c1f18d3dd1b57625bb8d03367ca6ce", kill_on_drop: false }` [INFO] [stdout] 4bf34242e789aa6840e4456b428c7e35c3c1f18d3dd1b57625bb8d03367ca6ce [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ddb36a253d1b44800e51ac481614640c8882358f4896e6ec7195f48b0bf20328 [INFO] running `Command { std: "docker" "start" "-a" "ddb36a253d1b44800e51ac481614640c8882358f4896e6ec7195f48b0bf20328", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.80 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.53 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling getrandom v0.1.15 [INFO] [stderr] Compiling serde_derive v1.0.117 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Compiling serde v1.0.117 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling num-bigint v0.2.6 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling matrixmultiply v0.1.15 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling num-rational v0.2.4 [INFO] [stderr] Compiling num-iter v0.1.42 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Checking rawpointer v0.1.0 [INFO] [stderr] Compiling ndarray v0.12.1 [INFO] [stderr] Checking itertools v0.7.11 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking regex-syntax v0.6.21 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking aho-corasick v0.7.15 [INFO] [stderr] Checking crossbeam-channel v0.4.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking pbr v1.0.3 [INFO] [stderr] Checking twox-hash v1.6.0 [INFO] [stderr] Checking regex v1.4.2 [INFO] [stderr] Checking num v0.2.1 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking bincode v1.3.1 [INFO] [stderr] Checking hogwild v0.6.1 [INFO] [stderr] Checking grove v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `max_size` and `max_prod` are never read [INFO] [stdout] --> src/sparse.rs:119:5 [INFO] [stdout] | [INFO] [stdout] 118 | pub struct SymmetricCornerMatrix { [INFO] [stdout] | --------------------- fields in this struct [INFO] [stdout] 119 | max_size: usize, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 120 | max_prod: usize, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SymmetricCornerMatrix` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/glove_model.rs:33:15 [INFO] [stdout] | [INFO] [stdout] 27 | Err(_e) => return Err(ReadWriteError::EncodeError), [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | }; [INFO] [stdout] 29 | let mut fout = BufWriter::new(match fs::File::create(path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | Ok(fout) => fout, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | Err(e) => return Err(ReadWriteError::IoError(e)), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | }); [INFO] [stdout] 33 | match fout.write_all(bytes.as_slice()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/glove_model.rs:44:15 [INFO] [stdout] | [INFO] [stdout] 40 | let fin = BufReader::new(match fs::File::open(path) { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | Ok(fin) => fin, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | Err(e) => return Err(ReadWriteError::IoError(e)), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | }); [INFO] [stdout] 44 | match bincode::deserialize_from(fin) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/glove_model.rs:133:12 [INFO] [stdout] | [INFO] [stdout] 119 | Err(e) => return Err(e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | Err(e) => return Err(e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | Ok(Model { [INFO] [stdout] | ____________^ [INFO] [stdout] 134 | | focus_vectors: weights.focus_vectors.into(), [INFO] [stdout] 135 | | focus_bias: weights.focus_bias.into(), [INFO] [stdout] 136 | | context_vector: weights.context_vector.into(), [INFO] [stdout] ... | [INFO] [stdout] 142 | | grad_context_bias: grads.context_bias.into(), [INFO] [stdout] 143 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/glove_train.rs:31:32 [INFO] [stdout] | [INFO] [stdout] 28 | let model = model.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | std::thread::spawn(move || glove_thread(model, params, path, start, end)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/glove_train.rs:36:24 [INFO] [stdout] | [INFO] [stdout] 36 | .map(|t| match t.join() { [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `grove` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `max_size` and `max_prod` are never read [INFO] [stdout] --> src/sparse.rs:119:5 [INFO] [stdout] | [INFO] [stdout] 118 | pub struct SymmetricCornerMatrix { [INFO] [stdout] | --------------------- fields in this struct [INFO] [stdout] 119 | max_size: usize, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 120 | max_prod: usize, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SymmetricCornerMatrix` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/glove_model.rs:33:15 [INFO] [stdout] | [INFO] [stdout] 27 | Err(_e) => return Err(ReadWriteError::EncodeError), [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | }; [INFO] [stdout] 29 | let mut fout = BufWriter::new(match fs::File::create(path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | Ok(fout) => fout, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | Err(e) => return Err(ReadWriteError::IoError(e)), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | }); [INFO] [stdout] 33 | match fout.write_all(bytes.as_slice()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/glove_model.rs:44:15 [INFO] [stdout] | [INFO] [stdout] 40 | let fin = BufReader::new(match fs::File::open(path) { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | Ok(fin) => fin, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | Err(e) => return Err(ReadWriteError::IoError(e)), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | }); [INFO] [stdout] 44 | match bincode::deserialize_from(fin) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/glove_model.rs:133:12 [INFO] [stdout] | [INFO] [stdout] 119 | Err(e) => return Err(e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | Err(e) => return Err(e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | Ok(Model { [INFO] [stdout] | ____________^ [INFO] [stdout] 134 | | focus_vectors: weights.focus_vectors.into(), [INFO] [stdout] 135 | | focus_bias: weights.focus_bias.into(), [INFO] [stdout] 136 | | context_vector: weights.context_vector.into(), [INFO] [stdout] ... | [INFO] [stdout] 142 | | grad_context_bias: grads.context_bias.into(), [INFO] [stdout] 143 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/glove_train.rs:31:32 [INFO] [stdout] | [INFO] [stdout] 28 | let model = model.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | std::thread::spawn(move || glove_thread(model, params, path, start, end)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/glove_train.rs:36:24 [INFO] [stdout] | [INFO] [stdout] 36 | .map(|t| match t.join() { [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `grove` (lib test) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "ddb36a253d1b44800e51ac481614640c8882358f4896e6ec7195f48b0bf20328", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ddb36a253d1b44800e51ac481614640c8882358f4896e6ec7195f48b0bf20328", kill_on_drop: false }` [INFO] [stdout] ddb36a253d1b44800e51ac481614640c8882358f4896e6ec7195f48b0bf20328