[INFO] updating cached repository https://github.com/athorwall/parser-combinators [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "-c" "remote.origin.fetch=refs/heads/*:refs/heads/*" "fetch" "origin" "--force" "--prune", kill_on_drop: false }` [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e9dc572158cc0e1493cb8b3c0637a4d8d7013b8b [INFO] checking athorwall/parser-combinators/e9dc572158cc0e1493cb8b3c0637a4d8d7013b8b against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fathorwall%2Fparser-combinators" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/athorwall/parser-combinators on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/athorwall/parser-combinators [INFO] finished tweaking git repo https://github.com/athorwall/parser-combinators [INFO] tweaked toml for git repo https://github.com/athorwall/parser-combinators written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/athorwall/parser-combinators already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ebc96006dc17287f097d24138f44fa1e6ad34863a9ee276af688a1bc37b755b8 [INFO] running `Command { std: "docker" "start" "-a" "ebc96006dc17287f097d24138f44fa1e6ad34863a9ee276af688a1bc37b755b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ebc96006dc17287f097d24138f44fa1e6ad34863a9ee276af688a1bc37b755b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ebc96006dc17287f097d24138f44fa1e6ad34863a9ee276af688a1bc37b755b8", kill_on_drop: false }` [INFO] [stdout] ebc96006dc17287f097d24138f44fa1e6ad34863a9ee276af688a1bc37b755b8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f219a1bc5661345191eae8d150cdf8b45c773018b2b6214551210cfabfc3c17c [INFO] running `Command { std: "docker" "start" "-a" "f219a1bc5661345191eae8d150cdf8b45c773018b2b6214551210cfabfc3c17c", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking parser-combinators v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/parser.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | f: Box Vec<(T, String)> + 'a>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 4 | f: Box Vec<(T, String)> + 'a>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/parser.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | f: Box Vec<(T, String)> + 'a>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 4 | f: Box Vec<(T, String)> + 'a>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/parser.rs:24:35 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn map(self, func: Box U>) -> Parser<'a, U> where T: 'a, U: 'a { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 24 | pub fn map(self, func: Box U>) -> Parser<'a, U> where T: 'a, U: 'a { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/parser.rs:24:35 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn map(self, func: Box U>) -> Parser<'a, U> where T: 'a, U: 'a { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 24 | pub fn map(self, func: Box U>) -> Parser<'a, U> where T: 'a, U: 'a { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/parser.rs:90:54 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn bind<'b, U, V>(p1: Parser<'b, U>, p2: Box Parser<'b, V>>) -> Parser<'b, V> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 90 | pub fn bind<'b, U, V>(p1: Parser<'b, U>, p2: Box Parser<'b, V>>) -> Parser<'b, V> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/parser.rs:90:54 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn bind<'b, U, V>(p1: Parser<'b, U>, p2: Box Parser<'b, V>>) -> Parser<'b, V> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 90 | pub fn bind<'b, U, V>(p1: Parser<'b, U>, p2: Box Parser<'b, V>>) -> Parser<'b, V> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/parser.rs:42:26 [INFO] [stdout] | [INFO] [stdout] 42 | Some(value) => { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `new_input` [INFO] [stdout] --> src/parser.rs:43:33 [INFO] [stdout] | [INFO] [stdout] 43 | let mut new_input = input.clone(); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_new_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/parser.rs:43:29 [INFO] [stdout] | [INFO] [stdout] 43 | let mut new_input = input.clone(); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Parser` is never constructed [INFO] [stdout] --> src/parser.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | struct Parser<'a, T> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `parse`, `map`, `one`, `combine`, `option`, and `bind` are never used [INFO] [stdout] --> src/parser.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 7 | impl <'a, T> Parser<'a, T> { [INFO] [stdout] | -------------------------- associated items in this implementation [INFO] [stdout] 8 | pub fn parse(&self, input: &String) -> Result { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 24 | pub fn map(self, func: Box U>) -> Parser<'a, U> where T: 'a, U: 'a { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 38 | pub fn one(t: char) -> Parser<'a, char> { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 62 | pub fn combine<'b, U>(p1: Parser<'b, U>, p2: Parser<'b, U>) -> Parser<'b, U> [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 75 | pub fn option<'b, U>(p1: Parser<'b, U>, p2: Parser<'b, U>) -> Parser<'b, U> [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 90 | pub fn bind<'b, U, V>(p1: Parser<'b, U>, p2: Box Parser<'b, V>>) -> Parser<'b, V> [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:26:16 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn map(self, func: Box U>) -> Parser<'a, U> where T: 'a, U: 'a { [INFO] [stdout] | ---- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Parser{ [INFO] [stdout] 26 | f: Box::from(move |input: &String| { [INFO] [stdout] | ________________^ [INFO] [stdout] 27 | | let results = (self.f)(input); [INFO] [stdout] 28 | | return results.iter() [INFO] [stdout] 29 | | .map(|(u, rest)| { [INFO] [stdout] ... | [INFO] [stdout] 32 | | .collect(); [INFO] [stdout] 33 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/parser.rs:42:26 [INFO] [stdout] | [INFO] [stdout] 42 | Some(value) => { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `new_input` [INFO] [stdout] --> src/parser.rs:43:33 [INFO] [stdout] | [INFO] [stdout] 43 | let mut new_input = input.clone(); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_new_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/parser.rs:43:29 [INFO] [stdout] | [INFO] [stdout] 43 | let mut new_input = input.clone(); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:65:16 [INFO] [stdout] | [INFO] [stdout] 62 | pub fn combine<'b, U>(p1: Parser<'b, U>, p2: Parser<'b, U>) -> Parser<'b, U> [INFO] [stdout] | ----------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | f: Box::from(move |input: &String| { [INFO] [stdout] | ________________^ [INFO] [stdout] 66 | | let mut p1_results = (p1.f)(input); [INFO] [stdout] 67 | | let mut results = (p2.f)(input); [INFO] [stdout] 68 | | results.append(&mut p1_results); [INFO] [stdout] 69 | | results [INFO] [stdout] 70 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:78:16 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn option<'b, U>(p1: Parser<'b, U>, p2: Parser<'b, U>) -> Parser<'b, U> [INFO] [stdout] | ----------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | f: Box::from(move |input: &String| { [INFO] [stdout] | ________________^ [INFO] [stdout] 79 | | let p1_results = (p1.f)(input); [INFO] [stdout] 80 | | if p1_results.is_empty() { [INFO] [stdout] 81 | | (p2.f)(input) [INFO] [stdout] ... | [INFO] [stdout] 84 | | } [INFO] [stdout] 85 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:93:16 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn bind<'b, U, V>(p1: Parser<'b, U>, p2: Box Parser<'b, V>>) -> Parser<'b, V> [INFO] [stdout] | ----------------- ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | f: Box::from(move |input: &String| { [INFO] [stdout] | ________________^ [INFO] [stdout] 94 | | (p1.f)(input).iter() [INFO] [stdout] 95 | | .flat_map(|(value, remaining)| { [INFO] [stdout] 96 | | (p2(*value).f)(remaining) [INFO] [stdout] 97 | | }) [INFO] [stdout] 98 | | .collect() [INFO] [stdout] 99 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:94:17 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn bind<'b, U, V>(p1: Parser<'b, U>, p2: Box Parser<'b, V>>) -> Parser<'b, V> [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | / (p1.f)(input).iter() [INFO] [stdout] 95 | | .flat_map(|(value, remaining)| { [INFO] [stdout] 96 | | (p2(*value).f)(remaining) [INFO] [stdout] 97 | | }) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `parser-combinators` (lib) due to 6 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/parser.rs:153:21 [INFO] [stdout] | [INFO] [stdout] 153 | let mut s = a.to_string(); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:26:16 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn map(self, func: Box U>) -> Parser<'a, U> where T: 'a, U: 'a { [INFO] [stdout] | ---- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Parser{ [INFO] [stdout] 26 | f: Box::from(move |input: &String| { [INFO] [stdout] | ________________^ [INFO] [stdout] 27 | | let results = (self.f)(input); [INFO] [stdout] 28 | | return results.iter() [INFO] [stdout] 29 | | .map(|(u, rest)| { [INFO] [stdout] ... | [INFO] [stdout] 32 | | .collect(); [INFO] [stdout] 33 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:65:16 [INFO] [stdout] | [INFO] [stdout] 62 | pub fn combine<'b, U>(p1: Parser<'b, U>, p2: Parser<'b, U>) -> Parser<'b, U> [INFO] [stdout] | ----------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | f: Box::from(move |input: &String| { [INFO] [stdout] | ________________^ [INFO] [stdout] 66 | | let mut p1_results = (p1.f)(input); [INFO] [stdout] 67 | | let mut results = (p2.f)(input); [INFO] [stdout] 68 | | results.append(&mut p1_results); [INFO] [stdout] 69 | | results [INFO] [stdout] 70 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:78:16 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn option<'b, U>(p1: Parser<'b, U>, p2: Parser<'b, U>) -> Parser<'b, U> [INFO] [stdout] | ----------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | f: Box::from(move |input: &String| { [INFO] [stdout] | ________________^ [INFO] [stdout] 79 | | let p1_results = (p1.f)(input); [INFO] [stdout] 80 | | if p1_results.is_empty() { [INFO] [stdout] 81 | | (p2.f)(input) [INFO] [stdout] ... | [INFO] [stdout] 84 | | } [INFO] [stdout] 85 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:93:16 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn bind<'b, U, V>(p1: Parser<'b, U>, p2: Box Parser<'b, V>>) -> Parser<'b, V> [INFO] [stdout] | ----------------- ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | f: Box::from(move |input: &String| { [INFO] [stdout] | ________________^ [INFO] [stdout] 94 | | (p1.f)(input).iter() [INFO] [stdout] 95 | | .flat_map(|(value, remaining)| { [INFO] [stdout] 96 | | (p2(*value).f)(remaining) [INFO] [stdout] 97 | | }) [INFO] [stdout] 98 | | .collect() [INFO] [stdout] 99 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:94:17 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn bind<'b, U, V>(p1: Parser<'b, U>, p2: Box Parser<'b, V>>) -> Parser<'b, V> [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | / (p1.f)(input).iter() [INFO] [stdout] 95 | | .flat_map(|(value, remaining)| { [INFO] [stdout] 96 | | (p2(*value).f)(remaining) [INFO] [stdout] 97 | | }) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `parser-combinators` (lib test) due to 6 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f219a1bc5661345191eae8d150cdf8b45c773018b2b6214551210cfabfc3c17c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f219a1bc5661345191eae8d150cdf8b45c773018b2b6214551210cfabfc3c17c", kill_on_drop: false }` [INFO] [stdout] f219a1bc5661345191eae8d150cdf8b45c773018b2b6214551210cfabfc3c17c