[INFO] cloning repository https://github.com/atharvakale343/adventure [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/atharvakale343/adventure" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fatharvakale343%2Fadventure", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fatharvakale343%2Fadventure'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d54f7db6935f87f7406645f3aa0fa805d99a8e92 [INFO] checking atharvakale343/adventure/d54f7db6935f87f7406645f3aa0fa805d99a8e92 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fatharvakale343%2Fadventure" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/atharvakale343/adventure on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/atharvakale343/adventure [INFO] finished tweaking git repo https://github.com/atharvakale343/adventure [INFO] tweaked toml for git repo https://github.com/atharvakale343/adventure written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/atharvakale343/adventure already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cd158f0b83dc9dfee4a9feae853d05a0d852b3d282b27e5006a82f667f7e266c [INFO] running `Command { std: "docker" "start" "-a" "cd158f0b83dc9dfee4a9feae853d05a0d852b3d282b27e5006a82f667f7e266c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cd158f0b83dc9dfee4a9feae853d05a0d852b3d282b27e5006a82f667f7e266c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cd158f0b83dc9dfee4a9feae853d05a0d852b3d282b27e5006a82f667f7e266c", kill_on_drop: false }` [INFO] [stdout] cd158f0b83dc9dfee4a9feae853d05a0d852b3d282b27e5006a82f667f7e266c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0b0c7b85db236ef627eedcff0aa8372979c14131364317436ea863ecded26c71 [INFO] running `Command { std: "docker" "start" "-a" "0b0c7b85db236ef627eedcff0aa8372979c14131364317436ea863ecded26c71", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.131 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking adventure v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/main.rs:517:24 [INFO] [stdout] | [INFO] [stdout] 517 | Some(r) => (r.borrow().name.clone()), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 517 - Some(r) => (r.borrow().name.clone()), [INFO] [stdout] 517 + Some(r) => r.borrow().name.clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/main.rs:521:24 [INFO] [stdout] | [INFO] [stdout] 521 | Some(r) => (r.borrow().name.clone()), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 521 - Some(r) => (r.borrow().name.clone()), [INFO] [stdout] 521 + Some(r) => r.borrow().name.clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/main.rs:525:24 [INFO] [stdout] | [INFO] [stdout] 525 | Some(r) => (r.borrow().name.clone()), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 525 - Some(r) => (r.borrow().name.clone()), [INFO] [stdout] 525 + Some(r) => r.borrow().name.clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/main.rs:529:24 [INFO] [stdout] | [INFO] [stdout] 529 | Some(r) => (r.borrow().name.clone()), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 529 - Some(r) => (r.borrow().name.clone()), [INFO] [stdout] 529 + Some(r) => r.borrow().name.clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/main.rs:517:24 [INFO] [stdout] | [INFO] [stdout] 517 | Some(r) => (r.borrow().name.clone()), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 517 - Some(r) => (r.borrow().name.clone()), [INFO] [stdout] 517 + Some(r) => r.borrow().name.clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/main.rs:521:24 [INFO] [stdout] | [INFO] [stdout] 521 | Some(r) => (r.borrow().name.clone()), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 521 - Some(r) => (r.borrow().name.clone()), [INFO] [stdout] 521 + Some(r) => r.borrow().name.clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/main.rs:525:24 [INFO] [stdout] | [INFO] [stdout] 525 | Some(r) => (r.borrow().name.clone()), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 525 - Some(r) => (r.borrow().name.clone()), [INFO] [stdout] 525 + Some(r) => r.borrow().name.clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/main.rs:529:24 [INFO] [stdout] | [INFO] [stdout] 529 | Some(r) => (r.borrow().name.clone()), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 529 - Some(r) => (r.borrow().name.clone()), [INFO] [stdout] 529 + Some(r) => r.borrow().name.clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:442:27 [INFO] [stdout] | [INFO] [stdout] 442 | .position(|x| x.borrow().name.eq_ignore_ascii_case(name)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:442:27 [INFO] [stdout] | [INFO] [stdout] 442 | .position(|x| x.borrow().name.eq_ignore_ascii_case(name)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `adventure` (bin "adventure") due to 2 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `adventure` (bin "adventure" test) due to 2 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0b0c7b85db236ef627eedcff0aa8372979c14131364317436ea863ecded26c71", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0b0c7b85db236ef627eedcff0aa8372979c14131364317436ea863ecded26c71", kill_on_drop: false }` [INFO] [stdout] 0b0c7b85db236ef627eedcff0aa8372979c14131364317436ea863ecded26c71