[INFO] cloning repository https://github.com/astrinxit66/rust-common [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/astrinxit66/rust-common" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fastrinxit66%2Frust-common", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fastrinxit66%2Frust-common'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 88eee2e7010bb7bebeeaf9f7aa626533d987adbd [INFO] checking astrinxit66/rust-common/88eee2e7010bb7bebeeaf9f7aa626533d987adbd against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fastrinxit66%2Frust-common" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/astrinxit66/rust-common on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/astrinxit66/rust-common [INFO] finished tweaking git repo https://github.com/astrinxit66/rust-common [INFO] tweaked toml for git repo https://github.com/astrinxit66/rust-common written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/astrinxit66/rust-common already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 50b3406758197388bb0c5dc1587f5db02c7cd0b6a2df2ab973630352629fb4cc [INFO] running `Command { std: "docker" "start" "-a" "50b3406758197388bb0c5dc1587f5db02c7cd0b6a2df2ab973630352629fb4cc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "50b3406758197388bb0c5dc1587f5db02c7cd0b6a2df2ab973630352629fb4cc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "50b3406758197388bb0c5dc1587f5db02c7cd0b6a2df2ab973630352629fb4cc", kill_on_drop: false }` [INFO] [stdout] 50b3406758197388bb0c5dc1587f5db02c7cd0b6a2df2ab973630352629fb4cc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 42ce68725d7936febaffdeaa84b2c907e7cd4ddf9cfaf3e75c70c9d9e7c3414b [INFO] running `Command { std: "docker" "start" "-a" "42ce68725d7936febaffdeaa84b2c907e7cd4ddf9cfaf3e75c70c9d9e7c3414b", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling proc-macro2 v1.0.12 [INFO] [stderr] Compiling syn v1.0.18 [INFO] [stderr] Compiling libc v0.2.69 [INFO] [stderr] Compiling serde v1.0.106 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling cc v1.0.52 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking once_cell v1.3.1 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Compiling ryu v1.0.4 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Checking base64 v0.11.0 [INFO] [stderr] Checking futures-timer v2.0.2 [INFO] [stderr] Checking futures-io v0.3.4 [INFO] [stderr] Checking pin-project-lite v0.1.5 [INFO] [stderr] Checking futures-core v0.3.4 [INFO] [stderr] Checking bytes v0.5.4 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling memoffset v0.5.4 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Compiling ring v0.16.13 [INFO] [stderr] Compiling quote v1.0.4 [INFO] [stderr] Checking net2 v0.2.34 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking async-task v1.3.1 [INFO] [stderr] Checking crossbeam-channel v0.4.2 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking rmp v0.8.9 [INFO] [stderr] Checking webpki v0.21.2 [INFO] [stderr] Checking sct v0.6.0 [INFO] [stderr] Compiling serde_derive v1.0.106 [INFO] [stderr] Compiling trackable_derive v0.1.3 [INFO] [stderr] Checking trackable v0.2.23 [INFO] [stderr] Checking rmp-serde v0.13.7 [INFO] [stderr] Checking toml v0.4.10 [INFO] [stderr] Checking serde_json v1.0.52 [INFO] [stderr] Checking chrono v0.4.11 [INFO] [stderr] Checking mio v0.6.22 [INFO] [stderr] Checking kv-log-macro v1.0.4 [INFO] [stderr] Checking rustls v0.17.0 [INFO] [stderr] Checking serdeconv v0.3.0 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Checking async-std v1.5.0 [INFO] [stderr] Checking astrinxit v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logit.rs:62:8 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn init

(cfg: P) -> Result [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let file_apdrs = if log_cfg.file_apdrs.is_some() { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let term_apdrs = if log_cfg.term_apdrs.is_some() { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let appenders = Arc::new(SyncRwLock::new(Vec::new())); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | [INFO] [stdout] 62 | Ok(task::block_on(async { [INFO] [stdout] | ________^ [INFO] [stdout] 63 | | let mut apdrs_guard = appenders.write().unwrap(); [INFO] [stdout] 64 | | apdrs_guard.extend(file_apdrs); [INFO] [stdout] 65 | | apdrs_guard.extend(term_apdrs); [INFO] [stdout] ... | [INFO] [stdout] 86 | | handle [INFO] [stdout] 87 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logit.rs:49:30 [INFO] [stdout] | [INFO] [stdout] 49 | .map(|file_apdr| Box::new(FileAppender::new(file_apdr)) as Box) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logit.rs:56:30 [INFO] [stdout] | [INFO] [stdout] 56 | .map(|term_apdr| Box::new(TermAppender::new(term_apdr, false)) as Box) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cfg.rs:19:20 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn from_file_path

(path: P) -> io::Result> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | where P: AsRef { [INFO] [stdout] 19 | certs(&mut BufReader::new(File::open(path)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cfg.rs:25:31 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn pk_from_path

(path: P) -> io::Result> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | where P: AsRef { [INFO] [stdout] 25 | rsa_private_keys(&mut BufReader::new(File::open(path)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `astrinxit` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logit.rs:62:8 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn init

(cfg: P) -> Result [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let file_apdrs = if log_cfg.file_apdrs.is_some() { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let term_apdrs = if log_cfg.term_apdrs.is_some() { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let appenders = Arc::new(SyncRwLock::new(Vec::new())); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | [INFO] [stdout] 62 | Ok(task::block_on(async { [INFO] [stdout] | ________^ [INFO] [stdout] 63 | | let mut apdrs_guard = appenders.write().unwrap(); [INFO] [stdout] 64 | | apdrs_guard.extend(file_apdrs); [INFO] [stdout] 65 | | apdrs_guard.extend(term_apdrs); [INFO] [stdout] ... | [INFO] [stdout] 86 | | handle [INFO] [stdout] 87 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logit.rs:49:30 [INFO] [stdout] | [INFO] [stdout] 49 | .map(|file_apdr| Box::new(FileAppender::new(file_apdr)) as Box) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logit.rs:56:30 [INFO] [stdout] | [INFO] [stdout] 56 | .map(|term_apdr| Box::new(TermAppender::new(term_apdr, false)) as Box) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cfg.rs:19:20 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn from_file_path

(path: P) -> io::Result> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | where P: AsRef { [INFO] [stdout] 19 | certs(&mut BufReader::new(File::open(path)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cfg.rs:25:31 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn pk_from_path

(path: P) -> io::Result> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | where P: AsRef { [INFO] [stdout] 25 | rsa_private_keys(&mut BufReader::new(File::open(path)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `astrinxit` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "42ce68725d7936febaffdeaa84b2c907e7cd4ddf9cfaf3e75c70c9d9e7c3414b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "42ce68725d7936febaffdeaa84b2c907e7cd4ddf9cfaf3e75c70c9d9e7c3414b", kill_on_drop: false }` [INFO] [stdout] 42ce68725d7936febaffdeaa84b2c907e7cd4ddf9cfaf3e75c70c9d9e7c3414b