[INFO] cloning repository https://github.com/astaugaard/progthing [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/astaugaard/progthing" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fastaugaard%2Fprogthing", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fastaugaard%2Fprogthing'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] da82858bd2a9bdd497e44e76af9aae67f7922227 [INFO] checking astaugaard/progthing/da82858bd2a9bdd497e44e76af9aae67f7922227 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fastaugaard%2Fprogthing" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/astaugaard/progthing on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/astaugaard/progthing [INFO] finished tweaking git repo https://github.com/astaugaard/progthing [INFO] tweaked toml for git repo https://github.com/astaugaard/progthing written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/astaugaard/progthing already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bb1c790590bc15545265cd7223afeb63dcbe809b0bbadd261299b6f849275043 [INFO] running `Command { std: "docker" "start" "-a" "bb1c790590bc15545265cd7223afeb63dcbe809b0bbadd261299b6f849275043", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bb1c790590bc15545265cd7223afeb63dcbe809b0bbadd261299b6f849275043", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bb1c790590bc15545265cd7223afeb63dcbe809b0bbadd261299b6f849275043", kill_on_drop: false }` [INFO] [stdout] bb1c790590bc15545265cd7223afeb63dcbe809b0bbadd261299b6f849275043 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 959bb1accf2494e52746a934072116ec495674e94676feedb3b5f4be67d0a3e0 [INFO] running `Command { std: "docker" "start" "-a" "959bb1accf2494e52746a934072116ec495674e94676feedb3b5f4be67d0a3e0", kill_on_drop: false }` [INFO] [stderr] Checking regex-automata v0.4.2 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking bstr v1.7.0 [INFO] [stderr] Checking pom v3.3.0 [INFO] [stderr] Checking mylanguage v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::rc::Rc` [INFO] [stdout] --> src/bytecodevm.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::rc::Rc; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused macro definition: `value2_function` [INFO] [stdout] --> src/values.rs:44:14 [INFO] [stdout] | [INFO] [stdout] 44 | macro_rules! value2_function { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_macros)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused macro definition: `call2_value_numeric` [INFO] [stdout] --> src/values.rs:68:14 [INFO] [stdout] | [INFO] [stdout] 68 | macro_rules! call2_value_numeric { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `arch::x86_64::_mm256_movemask_pd` [INFO] [stdout] --> src/builtins.rs:1:11 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{arch::x86_64::_mm256_movemask_pd, collections::HashMap}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/compiler.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BuiltinFunc`, `Value`, `builtins::BuiltinMaps`, `bytecodevm::OpCode`, and `parser::Decleration` [INFO] [stdout] --> src/compiler.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::{builtins::BuiltinMaps, parser::Decleration, bytecodevm::OpCode, values::{Value, BuiltinFunc}}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ ^^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused macro definition: `value2_function` [INFO] [stdout] --> src/values.rs:44:14 [INFO] [stdout] | [INFO] [stdout] 44 | macro_rules! value2_function { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_macros)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused macro definition: `call2_value_numeric` [INFO] [stdout] --> src/values.rs:68:14 [INFO] [stdout] | [INFO] [stdout] 68 | macro_rules! call2_value_numeric { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `arch::x86_64::_mm256_movemask_pd` [INFO] [stdout] --> src/builtins.rs:1:11 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{arch::x86_64::_mm256_movemask_pd, collections::HashMap}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/compiler.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BuiltinFunc`, `Value`, `builtins::BuiltinMaps`, `bytecodevm::OpCode`, and `parser::Decleration` [INFO] [stdout] --> src/compiler.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::{builtins::BuiltinMaps, parser::Decleration, bytecodevm::OpCode, values::{Value, BuiltinFunc}}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ ^^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name_id_map`, `builtin_table`, `constant_table`, `builtin_name_table`, and `constant_name_table` are never read [INFO] [stdout] --> src/builtins.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 20 | pub struct BuiltinMaps<'a> { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 21 | name_id_map: HashMap<&'a str, BuiltinId>, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 22 | builtin_table: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 23 | constant_table: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 24 | builtin_name_table: Vec<&'a str>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 25 | constant_name_table: Vec<&'a str>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `executeInstr` should have a snake case name [INFO] [stdout] --> src/bytecodevm.rs:87:4 [INFO] [stdout] | [INFO] [stdout] 87 | fn executeInstr( [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `execute_instr` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 68 | let public = token("pub").opt().map(|a| a.is_some()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let decleration_var = import() | function() | value(); // | adt(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | [INFO] [stdout] 71 | (public + decleration_var).map(|(public, value)| Decleration { public, value }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:138:5 [INFO] [stdout] | [INFO] [stdout] 137 | let operator_token = one_of("+-&^%$@!=:<>\\/*"); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | (operator_token.repeat(1..).map(|a| a.iter().collect()) - spaces()).name("operator") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:247:5 [INFO] [stdout] | [INFO] [stdout] 243 | fn sep_by1<'a, B>(variable_name: fn() -> Parser<'a, B>, token: Parser<'a, ()>) -> Parser<'a, Vec> [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | (call(variable_name) + (token * call(variable_name)).repeat(0..)).map(|(a, mut b)| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:257:5 [INFO] [stdout] | [INFO] [stdout] 253 | fn sep_by<'a, B>(variable_name: fn() -> Parser<'a, B>, token: Parser<'a, ()>) -> Parser<'a, Vec> [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 257 | sep_by1(variable_name, token).opt().map(|opt| opt.unwrap_or(vec![])) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:262:5 [INFO] [stdout] | [INFO] [stdout] 261 | let variable_token = is_a(|a| a.is_alphanumeric()); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | / ((is_a(|a| a.is_alphabetic()) + variable_token.repeat(0..)) [INFO] [stdout] 263 | | .map(|(a, b)| iter::once(&a).chain(b.iter()).collect()) [INFO] [stdout] 264 | | - spaces()) [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/builtins.rs:42:37 [INFO] [stdout] | [INFO] [stdout] 42 | name_id_map.insert(k.clone(), BuiltinId::Builtin(builtin_table.len())); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/builtins.rs:44:42 [INFO] [stdout] | [INFO] [stdout] 44 | builtin_name_table.push(k.clone()) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/builtins.rs:47:37 [INFO] [stdout] | [INFO] [stdout] 47 | name_id_map.insert(k.clone(),BuiltinId::Operator(op)); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mylanguage` (lib) due to 6 previous errors; 11 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `name_id_map`, `builtin_table`, `constant_table`, `builtin_name_table`, and `constant_name_table` are never read [INFO] [stdout] --> src/builtins.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 20 | pub struct BuiltinMaps<'a> { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 21 | name_id_map: HashMap<&'a str, BuiltinId>, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 22 | builtin_table: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 23 | constant_table: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 24 | builtin_name_table: Vec<&'a str>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 25 | constant_name_table: Vec<&'a str>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `executeInstr` should have a snake case name [INFO] [stdout] --> src/bytecodevm.rs:87:4 [INFO] [stdout] | [INFO] [stdout] 87 | fn executeInstr( [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `execute_instr` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 68 | let public = token("pub").opt().map(|a| a.is_some()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let decleration_var = import() | function() | value(); // | adt(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | [INFO] [stdout] 71 | (public + decleration_var).map(|(public, value)| Decleration { public, value }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:138:5 [INFO] [stdout] | [INFO] [stdout] 137 | let operator_token = one_of("+-&^%$@!=:<>\\/*"); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | (operator_token.repeat(1..).map(|a| a.iter().collect()) - spaces()).name("operator") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:247:5 [INFO] [stdout] | [INFO] [stdout] 243 | fn sep_by1<'a, B>(variable_name: fn() -> Parser<'a, B>, token: Parser<'a, ()>) -> Parser<'a, Vec> [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | (call(variable_name) + (token * call(variable_name)).repeat(0..)).map(|(a, mut b)| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:257:5 [INFO] [stdout] | [INFO] [stdout] 253 | fn sep_by<'a, B>(variable_name: fn() -> Parser<'a, B>, token: Parser<'a, ()>) -> Parser<'a, Vec> [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 257 | sep_by1(variable_name, token).opt().map(|opt| opt.unwrap_or(vec![])) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:262:5 [INFO] [stdout] | [INFO] [stdout] 261 | let variable_token = is_a(|a| a.is_alphanumeric()); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | / ((is_a(|a| a.is_alphabetic()) + variable_token.repeat(0..)) [INFO] [stdout] 263 | | .map(|(a, b)| iter::once(&a).chain(b.iter()).collect()) [INFO] [stdout] 264 | | - spaces()) [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/builtins.rs:42:37 [INFO] [stdout] | [INFO] [stdout] 42 | name_id_map.insert(k.clone(), BuiltinId::Builtin(builtin_table.len())); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/builtins.rs:44:42 [INFO] [stdout] | [INFO] [stdout] 44 | builtin_name_table.push(k.clone()) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/builtins.rs:47:37 [INFO] [stdout] | [INFO] [stdout] 47 | name_id_map.insert(k.clone(),BuiltinId::Operator(op)); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mylanguage` (lib test) due to 6 previous errors; 10 warnings emitted [INFO] running `Command { std: "docker" "inspect" "959bb1accf2494e52746a934072116ec495674e94676feedb3b5f4be67d0a3e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "959bb1accf2494e52746a934072116ec495674e94676feedb3b5f4be67d0a3e0", kill_on_drop: false }` [INFO] [stdout] 959bb1accf2494e52746a934072116ec495674e94676feedb3b5f4be67d0a3e0