[INFO] cloning repository https://github.com/ashish173/blog_redis [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ashish173/blog_redis" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fashish173%2Fblog_redis", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fashish173%2Fblog_redis'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4ca144d851197a8b9e3ad501d3000cc79481daf9 [INFO] checking ashish173/blog_redis/4ca144d851197a8b9e3ad501d3000cc79481daf9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fashish173%2Fblog_redis" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ashish173/blog_redis on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ashish173/blog_redis [INFO] finished tweaking git repo https://github.com/ashish173/blog_redis [INFO] tweaked toml for git repo https://github.com/ashish173/blog_redis written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ashish173/blog_redis already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 18c4f5246e85724f73292d284324a0b6426fa55f1b4179540a3ccf954ce1550b [INFO] running `Command { std: "docker" "start" "-a" "18c4f5246e85724f73292d284324a0b6426fa55f1b4179540a3ccf954ce1550b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "18c4f5246e85724f73292d284324a0b6426fa55f1b4179540a3ccf954ce1550b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "18c4f5246e85724f73292d284324a0b6426fa55f1b4179540a3ccf954ce1550b", kill_on_drop: false }` [INFO] [stdout] 18c4f5246e85724f73292d284324a0b6426fa55f1b4179540a3ccf954ce1550b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4d5b95138779e8ea76fdfd0b8ff3d78f64d6059e7a938e940706b0a7027c7ed1 [INFO] running `Command { std: "docker" "start" "-a" "4d5b95138779e8ea76fdfd0b8ff3d78f64d6059e7a938e940706b0a7027c7ed1", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.127 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Compiling parking_lot_core v0.9.3 [INFO] [stderr] Checking smallvec v1.9.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling tokio v1.20.1 [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Checking bytes v1.2.1 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking mio v0.8.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling clap_derive v3.2.15 [INFO] [stderr] Compiling tokio-macros v1.8.0 [INFO] [stderr] Checking clap v3.2.16 [INFO] [stderr] Checking blog_redis v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `p` [INFO] [stdout] --> src/db.rs:31:18 [INFO] [stdout] | [INFO] [stdout] 31 | Some(p) => Ok("r Ok"), // if they key was already present [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_p` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `p` [INFO] [stdout] --> src/db.rs:31:18 [INFO] [stdout] | [INFO] [stdout] 31 | Some(p) => Ok("r Ok"), // if they key was already present [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_p` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/listener.rs:25:17 [INFO] [stdout] | [INFO] [stdout] 18 | listener: TcpListener, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | notify_shutdown: broadcast::Sender<()>, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | shutdown_complete_tx: mpsc::Sender<()>, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | shutdown_complete_rx: mpsc::Receiver<()>, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | db: Db::new(), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:65:25 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn new(listener: &Listener, socket: TcpStream) -> Handler { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | Handler { [INFO] [stdout] 65 | connection: Connection::new(socket), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:66:17 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn new(listener: &Listener, socket: TcpStream) -> Handler { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | db: listener.db.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/listener.rs:25:17 [INFO] [stdout] | [INFO] [stdout] 18 | listener: TcpListener, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | notify_shutdown: broadcast::Sender<()>, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | shutdown_complete_tx: mpsc::Sender<()>, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | shutdown_complete_rx: mpsc::Receiver<()>, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | db: Db::new(), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:67:23 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn new(listener: &Listener, socket: TcpStream) -> Handler { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | shutdown: Shutdown::new(false, listener.notify_shutdown.subscribe()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:68:33 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn new(listener: &Listener, socket: TcpStream) -> Handler { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | _shutdown_complete: listener.shutdown_complete_tx.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:65:25 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn new(listener: &Listener, socket: TcpStream) -> Handler { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | Handler { [INFO] [stdout] 65 | connection: Connection::new(socket), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:66:17 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn new(listener: &Listener, socket: TcpStream) -> Handler { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | db: listener.db.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:67:23 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn new(listener: &Listener, socket: TcpStream) -> Handler { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | shutdown: Shutdown::new(false, listener.notify_shutdown.subscribe()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:68:33 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn new(listener: &Listener, socket: TcpStream) -> Handler { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | _shutdown_complete: listener.shutdown_complete_tx.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `blog_redis` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `blog_redis` (lib test) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "4d5b95138779e8ea76fdfd0b8ff3d78f64d6059e7a938e940706b0a7027c7ed1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4d5b95138779e8ea76fdfd0b8ff3d78f64d6059e7a938e940706b0a7027c7ed1", kill_on_drop: false }` [INFO] [stdout] 4d5b95138779e8ea76fdfd0b8ff3d78f64d6059e7a938e940706b0a7027c7ed1