[INFO] cloning repository https://github.com/asayers/orpa [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/asayers/orpa" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fasayers%2Forpa", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fasayers%2Forpa'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 39a5d0522b7d77eb0baa57d74fe4e328dbb406a9 [INFO] checking asayers/orpa/39a5d0522b7d77eb0baa57d74fe4e328dbb406a9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fasayers%2Forpa" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/asayers/orpa on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/asayers/orpa [INFO] finished tweaking git repo https://github.com/asayers/orpa [INFO] tweaked toml for git repo https://github.com/asayers/orpa written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/asayers/orpa already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d0a487b5a4e0b8fcc3531fd8e13875e1ed44ad2c78bebaad772e569d57489c7a [INFO] running `Command { std: "docker" "start" "-a" "d0a487b5a4e0b8fcc3531fd8e13875e1ed44ad2c78bebaad772e569d57489c7a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d0a487b5a4e0b8fcc3531fd8e13875e1ed44ad2c78bebaad772e569d57489c7a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d0a487b5a4e0b8fcc3531fd8e13875e1ed44ad2c78bebaad772e569d57489c7a", kill_on_drop: false }` [INFO] [stdout] d0a487b5a4e0b8fcc3531fd8e13875e1ed44ad2c78bebaad772e569d57489c7a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 05bffc62a97f7cdb5b30a206c9fca4b8ca694190d25bf5e6e61f5543fe9a3237 [INFO] running `Command { std: "docker" "start" "-a" "05bffc62a97f7cdb5b30a206c9fca4b8ca694190d25bf5e6e61f5543fe9a3237", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.150 [INFO] [stderr] Compiling proc-macro2 v1.0.70 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Compiling serde v1.0.193 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Compiling futures-core v0.3.29 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling futures-task v0.3.29 [INFO] [stderr] Compiling thiserror v1.0.50 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Compiling serde_json v1.0.108 [INFO] [stderr] Compiling futures-util v0.3.29 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking futures-sink v0.3.29 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling void v1.0.2 [INFO] [stderr] Compiling openssl v0.10.56 [INFO] [stderr] Checking futures-io v0.3.29 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling futures-channel v0.3.29 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking mio v0.8.9 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Compiling jobserver v0.1.27 [INFO] [stderr] Compiling unreachable v1.0.0 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking indexmap v2.1.0 [INFO] [stderr] Checking tokio v1.33.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling either v1.9.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Compiling ascii v0.9.3 [INFO] [stderr] Checking percent-encoding v2.3.0 [INFO] [stderr] Compiling rustls v0.21.9 [INFO] [stderr] Checking try-lock v0.2.4 [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking form_urlencoded v1.2.0 [INFO] [stderr] Compiling combine v3.8.1 [INFO] [stderr] Compiling openssl-sys v0.9.91 [INFO] [stderr] Compiling ring v0.17.7 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling libz-sys v1.1.8 [INFO] [stderr] Compiling darling_core v0.14.4 [INFO] [stderr] Compiling libssh2-sys v0.2.23 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Compiling ryu v1.0.15 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling darling_macro v0.14.4 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Checking siphasher v0.3.11 [INFO] [stderr] Compiling darling v0.14.4 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking sct v0.7.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking iana-time-zone v0.1.58 [INFO] [stderr] Checking phf_shared v0.11.2 [INFO] [stderr] Compiling derive_builder_core v0.11.2 [INFO] [stderr] Checking url v2.4.1 [INFO] [stderr] Compiling libgit2-sys v0.14.0+1.5.0 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Compiling graphql-parser v0.4.0 [INFO] [stderr] Compiling async-trait v0.1.74 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking base64 v0.21.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking rustls-pemfile v1.0.3 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Compiling derive_builder_macro v0.11.2 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking h2 v0.3.22 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking webpki-roots v0.25.3 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking ipnet v2.8.0 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking textwrap v0.16.0 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking isolang v2.4.0 [INFO] [stderr] Compiling clap_derive v3.2.25 [INFO] [stderr] Checking derive_builder v0.11.2 [INFO] [stderr] Checking hyper v0.14.27 [INFO] [stderr] Compiling enum-map-derive v0.17.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking errno v0.2.8 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking bstr v1.8.0 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking cpufeatures v0.2.9 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking termcolor v1.3.0 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking pager v0.16.1 [INFO] [stderr] Checking sled v0.34.7 [INFO] [stderr] Checking enum-map v2.7.3 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking tabwriter v1.3.0 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking cron v0.12.0 [INFO] [stderr] Compiling graphql-introspection-query v0.2.0 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Compiling graphql_client_codegen v0.11.0 [INFO] [stderr] Checking timeago v0.4.2 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Compiling graphql_query_derive v0.11.0 [INFO] [stderr] Checking graphql_client v0.11.0 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking reqwest v0.11.22 [INFO] [stderr] Checking gitlab v0.1606.0 [INFO] [stderr] Checking git2 v0.15.0 [INFO] [stderr] Checking orpa v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:444:23 [INFO] [stdout] | [INFO] [stdout] 444 | .and_then(|x| repo.find_commit(version.head).map(|y| (x, y))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:444:58 [INFO] [stdout] | [INFO] [stdout] 444 | .and_then(|x| repo.find_commit(version.head).map(|y| (x, y))) [INFO] [stdout] | - ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:573:8 [INFO] [stdout] | [INFO] [stdout] 564 | let base = repo.find_commit(mr.base)?.tree()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 565 | let head = repo.find_commit(mr.head)?.tree()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 566 | let diff = repo.diff_tree_to_tree(Some(&base), Some(&head), None)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 567 | let mut paths = HashSet::<&Path>::default(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 573 | Ok(paths.into_iter().map(|x| x.to_path_buf()).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mr_db.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 89 | let mut val = Box::new([0; 40]); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | / self.0 [INFO] [stdout] 93 | | .insert(key, val as Box<[u8]>)? [INFO] [stdout] 94 | | .map(|xs| { [INFO] [stdout] 95 | | anyhow::Ok(VersionInfo { [INFO] [stdout] ... | [INFO] [stdout] 99 | | }) [INFO] [stdout] 100 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:444:23 [INFO] [stdout] | [INFO] [stdout] 444 | .and_then(|x| repo.find_commit(version.head).map(|y| (x, y))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:444:58 [INFO] [stdout] | [INFO] [stdout] 444 | .and_then(|x| repo.find_commit(version.head).map(|y| (x, y))) [INFO] [stdout] | - ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/review_db.rs:186:12 [INFO] [stdout] | [INFO] [stdout] 177 | let db = sled::open(path)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | let forward = db.open_tree("forward")?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | let reverse = db.open_tree("reverse")?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | Ok(LineIdx { forward, reverse }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/review_db.rs:307:8 [INFO] [stdout] | [INFO] [stdout] 305 | let mut walk = repo.revwalk()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 306 | walk.push_range(&format!("{}..{}", ver.base, ver.head))?; [INFO] [stdout] 307 | Ok(walk [INFO] [stdout] | ________^ [INFO] [stdout] 308 | | .map(move |oid| { [INFO] [stdout] 309 | | let oid = oid?; [INFO] [stdout] 310 | | let status = lookup(repo, oid)?; [INFO] [stdout] 311 | | Ok((oid, status)) [INFO] [stdout] 312 | | }) [INFO] [stdout] 313 | | .take_while(|x| !matches!(x, Ok((_, Status::Checkpoint))))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/review_db.rs:350:8 [INFO] [stdout] | [INFO] [stdout] 345 | let base = match c.parent(0) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 346 | Ok(parent) => parent.tree()?, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 350 | Ok(repo.diff_tree_to_tree(Some(&base), Some(&c.tree()?), None)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/review_db.rs:361:8 [INFO] [stdout] | [INFO] [stdout] 361 | Ok(repo.find_tree(oid)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:573:8 [INFO] [stdout] | [INFO] [stdout] 564 | let base = repo.find_commit(mr.base)?.tree()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 565 | let head = repo.find_commit(mr.head)?.tree()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 566 | let diff = repo.diff_tree_to_tree(Some(&base), Some(&head), None)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 567 | let mut paths = HashSet::<&Path>::default(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 573 | Ok(paths.into_iter().map(|x| x.to_path_buf()).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mr_db.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 89 | let mut val = Box::new([0; 40]); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | / self.0 [INFO] [stdout] 93 | | .insert(key, val as Box<[u8]>)? [INFO] [stdout] 94 | | .map(|xs| { [INFO] [stdout] 95 | | anyhow::Ok(VersionInfo { [INFO] [stdout] ... | [INFO] [stdout] 99 | | }) [INFO] [stdout] 100 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/review_db.rs:186:12 [INFO] [stdout] | [INFO] [stdout] 177 | let db = sled::open(path)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | let forward = db.open_tree("forward")?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | let reverse = db.open_tree("reverse")?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | Ok(LineIdx { forward, reverse }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/review_db.rs:307:8 [INFO] [stdout] | [INFO] [stdout] 305 | let mut walk = repo.revwalk()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 306 | walk.push_range(&format!("{}..{}", ver.base, ver.head))?; [INFO] [stdout] 307 | Ok(walk [INFO] [stdout] | ________^ [INFO] [stdout] 308 | | .map(move |oid| { [INFO] [stdout] 309 | | let oid = oid?; [INFO] [stdout] 310 | | let status = lookup(repo, oid)?; [INFO] [stdout] 311 | | Ok((oid, status)) [INFO] [stdout] 312 | | }) [INFO] [stdout] 313 | | .take_while(|x| !matches!(x, Ok((_, Status::Checkpoint))))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/review_db.rs:350:8 [INFO] [stdout] | [INFO] [stdout] 345 | let base = match c.parent(0) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 346 | Ok(parent) => parent.tree()?, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 350 | Ok(repo.diff_tree_to_tree(Some(&base), Some(&c.tree()?), None)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/review_db.rs:361:8 [INFO] [stdout] | [INFO] [stdout] 361 | Ok(repo.find_tree(oid)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `orpa` (bin "orpa" test) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `orpa` (bin "orpa") due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "05bffc62a97f7cdb5b30a206c9fca4b8ca694190d25bf5e6e61f5543fe9a3237", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "05bffc62a97f7cdb5b30a206c9fca4b8ca694190d25bf5e6e61f5543fe9a3237", kill_on_drop: false }` [INFO] [stdout] 05bffc62a97f7cdb5b30a206c9fca4b8ca694190d25bf5e6e61f5543fe9a3237