[INFO] cloning repository https://github.com/asakhar/control_srv [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/asakhar/control_srv" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fasakhar%2Fcontrol_srv", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fasakhar%2Fcontrol_srv'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 37627424c2c5f03afe8b06ca3a06b2a4dc352a8d [INFO] checking asakhar/control_srv/37627424c2c5f03afe8b06ca3a06b2a4dc352a8d against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fasakhar%2Fcontrol_srv" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/asakhar/control_srv on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/asakhar/control_srv [INFO] finished tweaking git repo https://github.com/asakhar/control_srv [INFO] tweaked toml for git repo https://github.com/asakhar/control_srv written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/asakhar/control_srv already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6aaefed55520bb386807962feba33cdb35e54809e42b9089ad03ec1c9962cad4 [INFO] running `Command { std: "docker" "start" "-a" "6aaefed55520bb386807962feba33cdb35e54809e42b9089ad03ec1c9962cad4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6aaefed55520bb386807962feba33cdb35e54809e42b9089ad03ec1c9962cad4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6aaefed55520bb386807962feba33cdb35e54809e42b9089ad03ec1c9962cad4", kill_on_drop: false }` [INFO] [stdout] 6aaefed55520bb386807962feba33cdb35e54809e42b9089ad03ec1c9962cad4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dc9c6e8f5623911416c13ffa477f5e7aed8995c0c704de0b3e13447216672cfa [INFO] running `Command { std: "docker" "start" "-a" "dc9c6e8f5623911416c13ffa477f5e7aed8995c0c704de0b3e13447216672cfa", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.132 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking dotenv v0.15.0 [INFO] [stderr] Checking aho-corasick v0.7.19 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Checking controls_srv v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: methods `lerp` and `inv_lerp` are never used [INFO] [stdout] --> src/utils.rs:2:6 [INFO] [stdout] | [INFO] [stdout] 1 | pub trait Lerpable { [INFO] [stdout] | -------- methods in this trait [INFO] [stdout] 2 | fn lerp(self, left: Self, right: Self) -> Self; [INFO] [stdout] | ^^^^ [INFO] [stdout] 3 | fn inv_lerp(self, left: Self, right: Self) -> Self; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `lerp` and `inv_lerp` are never used [INFO] [stdout] --> src/utils.rs:2:6 [INFO] [stdout] | [INFO] [stdout] 1 | pub trait Lerpable { [INFO] [stdout] | -------- methods in this trait [INFO] [stdout] 2 | fn lerp(self, left: Self, right: Self) -> Self; [INFO] [stdout] | ^^^^ [INFO] [stdout] 3 | fn inv_lerp(self, left: Self, right: Self) -> Self; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `write_sized` is never used [INFO] [stdout] --> src/utils.rs:23:6 [INFO] [stdout] | [INFO] [stdout] 22 | pub trait WriteSizedExt { [INFO] [stdout] | ------------- method in this trait [INFO] [stdout] 23 | fn write_sized(&mut self, buf: &[u8]) -> std::io::Result<()>; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/main.rs:19:19 [INFO] [stdout] | [INFO] [stdout] 19 | for client in listener.accept() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 19 | while let Ok(client) = listener.accept() { [INFO] [stdout] | ~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 19 | if let Ok(client) = listener.accept() { [INFO] [stdout] | ~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command_info.rs:74:28 [INFO] [stdout] | [INFO] [stdout] 70 | let (sender, receiver) = mpsc::channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let receiver = Mutex::new(receiver); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | let sender = Mutex::new(sender); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Self { [INFO] [stdout] 74 | inner: Box::into_raw(Box::new(HostChannelInner { sender, receiver })), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `controls_srv` (bin "controls_srv") due to 2 previous errors; 3 warnings emitted [INFO] [stdout] warning: method `write_sized` is never used [INFO] [stdout] --> src/utils.rs:23:6 [INFO] [stdout] | [INFO] [stdout] 22 | pub trait WriteSizedExt { [INFO] [stdout] | ------------- method in this trait [INFO] [stdout] 23 | fn write_sized(&mut self, buf: &[u8]) -> std::io::Result<()>; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/main.rs:19:19 [INFO] [stdout] | [INFO] [stdout] 19 | for client in listener.accept() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 19 | while let Ok(client) = listener.accept() { [INFO] [stdout] | ~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 19 | if let Ok(client) = listener.accept() { [INFO] [stdout] | ~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command_info.rs:74:28 [INFO] [stdout] | [INFO] [stdout] 70 | let (sender, receiver) = mpsc::channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let receiver = Mutex::new(receiver); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | let sender = Mutex::new(sender); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Self { [INFO] [stdout] 74 | inner: Box::into_raw(Box::new(HostChannelInner { sender, receiver })), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `controls_srv` (bin "controls_srv" test) due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "dc9c6e8f5623911416c13ffa477f5e7aed8995c0c704de0b3e13447216672cfa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dc9c6e8f5623911416c13ffa477f5e7aed8995c0c704de0b3e13447216672cfa", kill_on_drop: false }` [INFO] [stdout] dc9c6e8f5623911416c13ffa477f5e7aed8995c0c704de0b3e13447216672cfa