[INFO] cloning repository https://github.com/arron-speake-bluefruit/phal [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/arron-speake-bluefruit/phal" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Farron-speake-bluefruit%2Fphal", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Farron-speake-bluefruit%2Fphal'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1c6ad989c565242dafcbcdb16bf779ad1e177cee [INFO] checking arron-speake-bluefruit/phal/1c6ad989c565242dafcbcdb16bf779ad1e177cee against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Farron-speake-bluefruit%2Fphal" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/arron-speake-bluefruit/phal on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/arron-speake-bluefruit/phal [INFO] finished tweaking git repo https://github.com/arron-speake-bluefruit/phal [INFO] tweaked toml for git repo https://github.com/arron-speake-bluefruit/phal written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/arron-speake-bluefruit/phal already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3e4302a4d81990b1a7fd26f03fb9265db6cec559ab34121e40cfe7fba11bcff5 [INFO] running `Command { std: "docker" "start" "-a" "3e4302a4d81990b1a7fd26f03fb9265db6cec559ab34121e40cfe7fba11bcff5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3e4302a4d81990b1a7fd26f03fb9265db6cec559ab34121e40cfe7fba11bcff5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3e4302a4d81990b1a7fd26f03fb9265db6cec559ab34121e40cfe7fba11bcff5", kill_on_drop: false }` [INFO] [stdout] 3e4302a4d81990b1a7fd26f03fb9265db6cec559ab34121e40cfe7fba11bcff5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 03257a6b9d0f06c5edd43e1ca20a63e6d364d133c40a38f15e26b2235fe0cec4 [INFO] running `Command { std: "docker" "start" "-a" "03257a6b9d0f06c5edd43e1ca20a63e6d364d133c40a38f15e26b2235fe0cec4", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.71 [INFO] [stderr] Compiling cc v1.0.54 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling version_check v0.9.1 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling proc-macro2 v1.0.18 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling standback v0.2.8 [INFO] [stderr] Compiling syn v1.0.30 [INFO] [stderr] Checking smallvec v1.2.0 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking once_cell v1.4.0 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Compiling nix v0.11.1 [INFO] [stderr] Compiling proc-macro-hack v0.5.16 [INFO] [stderr] Checking unicode-bidi v0.3.4 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Compiling serde v1.0.104 [INFO] [stderr] Checking unicode-normalization v0.1.12 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking chunked_transfer v1.1.0 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Checking ascii v1.0.0 [INFO] [stderr] Checking base64 v0.11.0 [INFO] [stderr] Compiling error-chain v0.12.2 [INFO] [stderr] Compiling time v0.2.16 [INFO] [stderr] Checking qstring v0.7.2 [INFO] [stderr] Checking base64 v0.12.1 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Checking ioctl-rs v0.1.6 [INFO] [stderr] Checking serial-core v0.4.0 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking termios v0.2.2 [INFO] [stderr] Checking serial-unix v0.4.0 [INFO] [stderr] Compiling quote v1.0.6 [INFO] [stderr] Compiling ring v0.16.14 [INFO] [stderr] Compiling backtrace-sys v0.1.32 [INFO] [stderr] Checking idna v0.2.0 [INFO] [stderr] Checking serial v0.4.0 [INFO] [stderr] Checking url v2.1.1 [INFO] [stderr] Checking chrono v0.4.11 [INFO] [stderr] Checking backtrace v0.3.44 [INFO] [stderr] Checking gpio-cdev v0.2.0 [INFO] [stderr] Checking tiny_http v0.7.0 [INFO] [stderr] Checking serde_json v1.0.48 [INFO] [stderr] Checking webpki v0.21.3 [INFO] [stderr] Checking sct v0.6.0 [INFO] [stderr] Checking rustls v0.17.0 [INFO] [stderr] Checking webpki-roots v0.19.0 [INFO] [stderr] Checking phal v0.5.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/limb.rs:80:14 [INFO] [stdout] | [INFO] [stdout] 64 | let mut limbs = HashMap::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | Some(LimbBindings(limbs)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pin.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 74 | let mut chip = match &config["chip"] { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | / chip.get_line(line) [INFO] [stdout] 91 | | .ok()? [INFO] [stdout] 92 | | .request(flags | type_flag, 0, "Phal server") [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xmodem/mod.rs:82:14 [INFO] [stdout] | [INFO] [stdout] 70 | let mut port = serial::open(device).ok()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | Some(Self { [INFO] [stdout] | ______________^ [INFO] [stdout] 83 | | port, [INFO] [stdout] 84 | | last_status: None, [INFO] [stdout] 85 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(types: LimbTypes, address: impl ToSocketAddrs) -> Result { [INFO] [stdout] | ---------------- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let limbs = LimbBindings::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Server::http(address).map(|server| Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:25:35 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(types: LimbTypes, address: impl ToSocketAddrs) -> Result { [INFO] [stdout] | ---------------- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let limbs = LimbBindings::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Server::http(address).map(|server| Self { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 26 | | types, [INFO] [stdout] 27 | | limbs, [INFO] [stdout] 28 | | server: Some(server), [INFO] [stdout] 29 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:28:21 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(types: LimbTypes, address: impl ToSocketAddrs) -> Result { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let limbs = LimbBindings::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Server::http(address).map(|server| Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | server: Some(server), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `phal` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "03257a6b9d0f06c5edd43e1ca20a63e6d364d133c40a38f15e26b2235fe0cec4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "03257a6b9d0f06c5edd43e1ca20a63e6d364d133c40a38f15e26b2235fe0cec4", kill_on_drop: false }` [INFO] [stdout] 03257a6b9d0f06c5edd43e1ca20a63e6d364d133c40a38f15e26b2235fe0cec4