[INFO] cloning repository https://github.com/aricooperman/orderbook_aggregator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/aricooperman/orderbook_aggregator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faricooperman%2Forderbook_aggregator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faricooperman%2Forderbook_aggregator'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ffda70945a4e6a8e1fc5799d707c221f7daf59b4 [INFO] checking aricooperman/orderbook_aggregator/ffda70945a4e6a8e1fc5799d707c221f7daf59b4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faricooperman%2Forderbook_aggregator" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/aricooperman/orderbook_aggregator on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/aricooperman/orderbook_aggregator [INFO] finished tweaking git repo https://github.com/aricooperman/orderbook_aggregator [INFO] tweaked toml for git repo https://github.com/aricooperman/orderbook_aggregator written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/aricooperman/orderbook_aggregator already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 91ad748ce3796c774d86f4d14f07e322e235d9ba118e8434b7ddb613ed3579b8 [INFO] running `Command { std: "docker" "start" "-a" "91ad748ce3796c774d86f4d14f07e322e235d9ba118e8434b7ddb613ed3579b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "91ad748ce3796c774d86f4d14f07e322e235d9ba118e8434b7ddb613ed3579b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "91ad748ce3796c774d86f4d14f07e322e235d9ba118e8434b7ddb613ed3579b8", kill_on_drop: false }` [INFO] [stdout] 91ad748ce3796c774d86f4d14f07e322e235d9ba118e8434b7ddb613ed3579b8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f40457d418733f001eec82621ac54eeee8bbfc3445607ccc04325109b11fff7d [INFO] running `Command { std: "docker" "start" "-a" "f40457d418733f001eec82621ac54eeee8bbfc3445607ccc04325109b11fff7d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.83 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling cc v1.0.98 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling either v1.12.0 [INFO] [stderr] Compiling serde v1.0.202 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling syn v2.0.65 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Compiling prettyplease v0.2.20 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking parking_lot v0.12.2 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Compiling indexmap v2.2.6 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Compiling petgraph v0.6.5 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Compiling multimap v0.10.0 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Compiling tempfile v3.10.1 [INFO] [stderr] Compiling rust_decimal v1.35.0 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Compiling axum-core v0.3.4 [INFO] [stderr] Compiling axum v0.6.20 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking matchit v0.7.3 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.202 [INFO] [stderr] Compiling prost-derive v0.12.6 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Compiling prost v0.12.6 [INFO] [stderr] Compiling prost-types v0.12.6 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Compiling prost-build v0.12.6 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tungstenite v0.21.0 [INFO] [stderr] Compiling tonic-build v0.11.0 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tokio-io-timeout v1.2.0 [INFO] [stderr] Compiling orderbook_aggregator_client v0.1.0 (/opt/rustwide/workdir/orderbook_aggregator_client) [INFO] [stderr] Compiling orderbook_aggregator_service v0.1.0 (/opt/rustwide/workdir/orderbook_aggregator_service) [INFO] [stderr] Checking tokio-tungstenite v0.21.0 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking orderbook_aggregator_common v0.1.0 (/opt/rustwide/workdir/orderbook_aggregator_common) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> orderbook_aggregator_common/src/ws.rs:466:7 [INFO] [stdout] | [INFO] [stdout] 463 | mut websocket_stream: SplitStream>>, [INFO] [stdout] | ------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 464 | command_in_tx: Sender, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 465 | orderbook_subscriptions: OrderbookSubscriptions, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 466 | ) { [INFO] [stdout] | _______^ [INFO] [stdout] 467 | | loop { [INFO] [stdout] 468 | | // We should get at a minimum of a pong message within 2 minutes, if not something is [INFO] [stdout] 469 | | // wrong with the connection [INFO] [stdout] ... | [INFO] [stdout] 557 | | log::debug!("websocket_incoming_loop ending"); [INFO] [stdout] 558 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> orderbook_aggregator_common/src/ws.rs:574:7 [INFO] [stdout] | [INFO] [stdout] 570 | mut command_in_rx: Receiver, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 571 | mut websocket_sink: SplitSink>, Message>, [INFO] [stdout] | ------------------------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 572 | orderbook_subscriptions: OrderbookSubscriptions, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 573 | disconnect_flag: Arc>, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 574 | ) { [INFO] [stdout] | _______^ [INFO] [stdout] 575 | | loop { [INFO] [stdout] 576 | | // Minimally send a ping every 60 seconds if we have not received any other commands to [INFO] [stdout] 577 | | // keep connection open and check if there are any issues with it [INFO] [stdout] ... | [INFO] [stdout] 688 | | log::debug!("command_incoming_loop ending"); [INFO] [stdout] 689 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `orderbook_aggregator_common` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> orderbook_aggregator_common/src/ws.rs:466:7 [INFO] [stdout] | [INFO] [stdout] 463 | mut websocket_stream: SplitStream>>, [INFO] [stdout] | ------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 464 | command_in_tx: Sender, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 465 | orderbook_subscriptions: OrderbookSubscriptions, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 466 | ) { [INFO] [stdout] | _______^ [INFO] [stdout] 467 | | loop { [INFO] [stdout] 468 | | // We should get at a minimum of a pong message within 2 minutes, if not something is [INFO] [stdout] 469 | | // wrong with the connection [INFO] [stdout] ... | [INFO] [stdout] 557 | | log::debug!("websocket_incoming_loop ending"); [INFO] [stdout] 558 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> orderbook_aggregator_common/src/ws.rs:574:7 [INFO] [stdout] | [INFO] [stdout] 570 | mut command_in_rx: Receiver, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 571 | mut websocket_sink: SplitSink>, Message>, [INFO] [stdout] | ------------------------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 572 | orderbook_subscriptions: OrderbookSubscriptions, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 573 | disconnect_flag: Arc>, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 574 | ) { [INFO] [stdout] | _______^ [INFO] [stdout] 575 | | loop { [INFO] [stdout] 576 | | // Minimally send a ping every 60 seconds if we have not received any other commands to [INFO] [stdout] 577 | | // keep connection open and check if there are any issues with it [INFO] [stdout] ... | [INFO] [stdout] 688 | | log::debug!("command_incoming_loop ending"); [INFO] [stdout] 689 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `orderbook_aggregator_common` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "f40457d418733f001eec82621ac54eeee8bbfc3445607ccc04325109b11fff7d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f40457d418733f001eec82621ac54eeee8bbfc3445607ccc04325109b11fff7d", kill_on_drop: false }` [INFO] [stdout] f40457d418733f001eec82621ac54eeee8bbfc3445607ccc04325109b11fff7d