[INFO] cloning repository https://github.com/archer884/subman [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/archer884/subman" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Farcher884%2Fsubman", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Farcher884%2Fsubman'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0d1c143980b826c0d0a9ac83670c8af72b1431da [INFO] checking archer884/subman/0d1c143980b826c0d0a9ac83670c8af72b1431da against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Farcher884%2Fsubman" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/archer884/subman on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/archer884/subman [INFO] finished tweaking git repo https://github.com/archer884/subman [INFO] tweaked toml for git repo https://github.com/archer884/subman written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/archer884/subman already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 64caa6fd945101954947ada6a83ef2c75d213abc66ba654492c7581661a0f0b5 [INFO] running `Command { std: "docker" "start" "-a" "64caa6fd945101954947ada6a83ef2c75d213abc66ba654492c7581661a0f0b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "64caa6fd945101954947ada6a83ef2c75d213abc66ba654492c7581661a0f0b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "64caa6fd945101954947ada6a83ef2c75d213abc66ba654492c7581661a0f0b5", kill_on_drop: false }` [INFO] [stdout] 64caa6fd945101954947ada6a83ef2c75d213abc66ba654492c7581661a0f0b5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c2ea54a82d7c8c44073a230322ea77eebb5266bc63253803a07f7732b4bf6648 [INFO] running `Command { std: "docker" "start" "-a" "c2ea54a82d7c8c44073a230322ea77eebb5266bc63253803a07f7732b4bf6648", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.62 [INFO] [stderr] Compiling proc-macro2 v1.0.4 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.5 [INFO] [stderr] Compiling getrandom v0.1.12 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling ppv-lite86 v0.2.5 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling bitflags v1.2.0 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Compiling autocfg v0.1.6 [INFO] [stderr] Compiling unicode-segmentation v1.3.0 [INFO] [stderr] Compiling c2-chacha v0.2.2 [INFO] [stderr] Compiling hashbrown v0.6.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Compiling serde v1.0.98 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking same-file v1.0.5 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking walkdir v2.2.9 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Compiling rand_core v0.5.1 [INFO] [stderr] Compiling rand_chacha v0.2.1 [INFO] [stderr] Compiling rand v0.7.2 [INFO] [stderr] Compiling serde_derive v1.0.98 [INFO] [stderr] Compiling proc-macro-error v0.2.6 [INFO] [stderr] Compiling proc-macro-hack v0.5.10 [INFO] [stderr] Compiling structopt-derive v0.3.2 [INFO] [stderr] Compiling const-random-macro v0.1.6 [INFO] [stderr] Checking structopt v0.3.2 [INFO] [stderr] Checking const-random v0.1.6 [INFO] [stderr] Checking ahash v0.2.13 [INFO] [stderr] Checking subman v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `MissionProfile` [INFO] [stdout] --> src/cw.rs:5:19 [INFO] [stdout] | [INFO] [stdout] 5 | pub use mission::{MissionProfile, MissionProfileData}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `MissionProfile` [INFO] [stdout] --> src/cw.rs:5:19 [INFO] [stdout] | [INFO] [stdout] 5 | pub use mission::{MissionProfile, MissionProfileData}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `default_path` and `output_path` are never read [INFO] [stdout] --> src/main.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 14 | struct Paths { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 15 | default_path: String, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 16 | override_path: String, [INFO] [stdout] 17 | output_path: Option, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Paths` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `world_objects_data`, `vessels_and_traffic`, `date`, `enemy_ship_classes`, and `player_vessels` are never read [INFO] [stdout] --> src/cw/mission.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct MissionProfile { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 8 | world_objects_data: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 9 | vessels_and_traffic: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 10 | date: u16, [INFO] [stdout] | ^^^^ [INFO] [stdout] 11 | enemy_ship_classes: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 12 | player_vessels: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MissionProfile` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `ship_type` is never read [INFO] [stdout] --> src/cw/vessel.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct Vessel { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 9 | pub ship_type: ShipType, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Vessel` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 64 | fn read_vessels(path: impl AsRef) -> impl Iterator { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | / walkdir::WalkDir::new(path.as_ref()) [INFO] [stdout] 70 | | .max_depth(1) [INFO] [stdout] 71 | | .into_iter() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cw/vessel.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn with_key(self, key: impl Into) -> crate::Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | Ok(Vessel { [INFO] [stdout] | ____________^ [INFO] [stdout] 30 | | key: key.into(), [INFO] [stdout] 31 | | ship_type: ship_type.parse()?, [INFO] [stdout] 32 | | year: year.parse()?, [INFO] [stdout] 33 | | op_force_regions: deserialize_regions(&op_force_regions)?, [INFO] [stdout] 34 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ini.rs:19:21 [INFO] [stdout] | [INFO] [stdout] 16 | fn new(events: impl Iterator + 'input) -> Self { [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let events: Box> = Box::new(events); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Self { [INFO] [stdout] 19 | events: events.peekable(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ini.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 29 | fn next_key_seed(&mut self, seed: K) -> Result> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | seed.deserialize(&mut *self.0).map(Some) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `subman` (bin "subman" test) due to 5 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `default_path` and `output_path` are never read [INFO] [stdout] --> src/main.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 14 | struct Paths { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 15 | default_path: String, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 16 | override_path: String, [INFO] [stdout] 17 | output_path: Option, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Paths` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `world_objects_data`, `vessels_and_traffic`, `date`, `enemy_ship_classes`, and `player_vessels` are never read [INFO] [stdout] --> src/cw/mission.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct MissionProfile { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 8 | world_objects_data: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 9 | vessels_and_traffic: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 10 | date: u16, [INFO] [stdout] | ^^^^ [INFO] [stdout] 11 | enemy_ship_classes: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 12 | player_vessels: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MissionProfile` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `ship_type` is never read [INFO] [stdout] --> src/cw/vessel.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct Vessel { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 9 | pub ship_type: ShipType, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Vessel` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 64 | fn read_vessels(path: impl AsRef) -> impl Iterator { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | / walkdir::WalkDir::new(path.as_ref()) [INFO] [stdout] 70 | | .max_depth(1) [INFO] [stdout] 71 | | .into_iter() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cw/vessel.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn with_key(self, key: impl Into) -> crate::Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | Ok(Vessel { [INFO] [stdout] | ____________^ [INFO] [stdout] 30 | | key: key.into(), [INFO] [stdout] 31 | | ship_type: ship_type.parse()?, [INFO] [stdout] 32 | | year: year.parse()?, [INFO] [stdout] 33 | | op_force_regions: deserialize_regions(&op_force_regions)?, [INFO] [stdout] 34 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ini.rs:19:21 [INFO] [stdout] | [INFO] [stdout] 16 | fn new(events: impl Iterator + 'input) -> Self { [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let events: Box> = Box::new(events); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Self { [INFO] [stdout] 19 | events: events.peekable(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ini.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 29 | fn next_key_seed(&mut self, seed: K) -> Result> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | seed.deserialize(&mut *self.0).map(Some) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `subman` (bin "subman") due to 5 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c2ea54a82d7c8c44073a230322ea77eebb5266bc63253803a07f7732b4bf6648", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c2ea54a82d7c8c44073a230322ea77eebb5266bc63253803a07f7732b4bf6648", kill_on_drop: false }` [INFO] [stdout] c2ea54a82d7c8c44073a230322ea77eebb5266bc63253803a07f7732b4bf6648