[INFO] cloning repository https://github.com/ar90n/ray-tracing-in-weekends-with-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ar90n/ray-tracing-in-weekends-with-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Far90n%2Fray-tracing-in-weekends-with-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Far90n%2Fray-tracing-in-weekends-with-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] dea0460977db2832dd6434aeb7eace6f8ae9e56f [INFO] checking ar90n/ray-tracing-in-weekends-with-rust/dea0460977db2832dd6434aeb7eace6f8ae9e56f against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Far90n%2Fray-tracing-in-weekends-with-rust" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ar90n/ray-tracing-in-weekends-with-rust on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ar90n/ray-tracing-in-weekends-with-rust [INFO] finished tweaking git repo https://github.com/ar90n/ray-tracing-in-weekends-with-rust [INFO] tweaked toml for git repo https://github.com/ar90n/ray-tracing-in-weekends-with-rust written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ar90n/ray-tracing-in-weekends-with-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 74f9446db924e2eee66acfc59061739c9f83f1b8ad78352ace53dd6cbbf2eb73 [INFO] running `Command { std: "docker" "start" "-a" "74f9446db924e2eee66acfc59061739c9f83f1b8ad78352ace53dd6cbbf2eb73", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "74f9446db924e2eee66acfc59061739c9f83f1b8ad78352ace53dd6cbbf2eb73", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "74f9446db924e2eee66acfc59061739c9f83f1b8ad78352ace53dd6cbbf2eb73", kill_on_drop: false }` [INFO] [stdout] 74f9446db924e2eee66acfc59061739c9f83f1b8ad78352ace53dd6cbbf2eb73 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 583af8624474fe80b0cfbf495befaf8f96042943cb7525b91bc92504a773888a [INFO] running `Command { std: "docker" "start" "-a" "583af8624474fe80b0cfbf495befaf8f96042943cb7525b91bc92504a773888a", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.88 [INFO] [stderr] Compiling crossbeam-utils v0.8.3 [INFO] [stderr] Compiling memoffset v0.6.3 [INFO] [stderr] Compiling rayon-core v1.9.0 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Compiling rayon v1.5.0 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Compiling crc32fast v1.2.1 [INFO] [stderr] Checking weezl v0.1.4 [INFO] [stderr] Checking bitflags v1.2.1 [INFO] [stderr] Checking bytemuck v1.5.1 [INFO] [stderr] Checking ordered-float v2.1.1 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Checking gif v0.11.2 [INFO] [stderr] Checking crossbeam-epoch v0.9.3 [INFO] [stderr] Checking crossbeam-channel v0.5.0 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Checking first_weekend v0.1.0 (/opt/rustwide/workdir/first_weekend) [INFO] [stdout] warning: unused variable: `n` [INFO] [stdout] --> first_weekend/src/main.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | let n = 500; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_n` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `w` is never read [INFO] [stdout] --> first_weekend/src/camera.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct Camera { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 16 | w: Vec3, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> first_weekend/src/hitable_list.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 7 | impl HitableList { [INFO] [stdout] | ---------------- associated function in this implementation [INFO] [stdout] 8 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> first_weekend/src/main.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 39 | let mut world: Vec> = vec![Box::new(Sphere::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | world.into_iter().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> first_weekend/src/hitable_list.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 14 | self.0.iter().fold(None, |result, obj| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | let t_far = result.as_ref().map(|obj| obj.t).unwrap_or(t_max); [INFO] [stdout] 16 | obj.hit(r, t_min, t_far).or(result) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> first_weekend/src/hitable_list.rs:23:21 [INFO] [stdout] | [INFO] [stdout] 22 | fn from_iter>>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | HitableList(iter.into_iter().collect::>()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `A` should have a snake case name [INFO] [stdout] --> first_weekend/src/ray.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | A: Vec3, [INFO] [stdout] | ^ help: convert the identifier to snake case: `a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `B` should have a snake case name [INFO] [stdout] --> first_weekend/src/ray.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | B: Vec3, [INFO] [stdout] | ^ help: convert the identifier to snake case: `b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `first_weekend` (bin "first_weekend") due to 4 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `n` [INFO] [stdout] --> first_weekend/src/main.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | let n = 500; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_n` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `w` is never read [INFO] [stdout] --> first_weekend/src/camera.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct Camera { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 16 | w: Vec3, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> first_weekend/src/hitable_list.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 7 | impl HitableList { [INFO] [stdout] | ---------------- associated function in this implementation [INFO] [stdout] 8 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> first_weekend/src/main.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 39 | let mut world: Vec> = vec![Box::new(Sphere::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | world.into_iter().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> first_weekend/src/hitable_list.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 14 | self.0.iter().fold(None, |result, obj| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | let t_far = result.as_ref().map(|obj| obj.t).unwrap_or(t_max); [INFO] [stdout] 16 | obj.hit(r, t_min, t_far).or(result) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> first_weekend/src/hitable_list.rs:23:21 [INFO] [stdout] | [INFO] [stdout] 22 | fn from_iter>>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | HitableList(iter.into_iter().collect::>()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `A` should have a snake case name [INFO] [stdout] --> first_weekend/src/ray.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | A: Vec3, [INFO] [stdout] | ^ help: convert the identifier to snake case: `a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `B` should have a snake case name [INFO] [stdout] --> first_weekend/src/ray.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | B: Vec3, [INFO] [stdout] | ^ help: convert the identifier to snake case: `b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `first_weekend` (bin "first_weekend" test) due to 4 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "583af8624474fe80b0cfbf495befaf8f96042943cb7525b91bc92504a773888a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "583af8624474fe80b0cfbf495befaf8f96042943cb7525b91bc92504a773888a", kill_on_drop: false }` [INFO] [stdout] 583af8624474fe80b0cfbf495befaf8f96042943cb7525b91bc92504a773888a