[INFO] cloning repository https://github.com/aptend/rlox [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/aptend/rlox" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faptend%2Frlox", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faptend%2Frlox'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 04bc68c436826c76a648bacc401fe6e1ece4294c [INFO] checking aptend/rlox/04bc68c436826c76a648bacc401fe6e1ece4294c against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faptend%2Frlox" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/aptend/rlox on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/aptend/rlox [INFO] finished tweaking git repo https://github.com/aptend/rlox [INFO] tweaked toml for git repo https://github.com/aptend/rlox written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/aptend/rlox already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 51bf6812d1dc242d62ab6a08dc8ff96fa1ebd75feb66a787fcfcee5534b1b674 [INFO] running `Command { std: "docker" "start" "-a" "51bf6812d1dc242d62ab6a08dc8ff96fa1ebd75feb66a787fcfcee5534b1b674", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "51bf6812d1dc242d62ab6a08dc8ff96fa1ebd75feb66a787fcfcee5534b1b674", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "51bf6812d1dc242d62ab6a08dc8ff96fa1ebd75feb66a787fcfcee5534b1b674", kill_on_drop: false }` [INFO] [stdout] 51bf6812d1dc242d62ab6a08dc8ff96fa1ebd75feb66a787fcfcee5534b1b674 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7b0e5aa2591981f7a281f47d2b6dd46c13ff3c99f57c3c7453edbeeeccc4c064 [INFO] running `Command { std: "docker" "start" "-a" "7b0e5aa2591981f7a281f47d2b6dd46c13ff3c99f57c3c7453edbeeeccc4c064", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling libc v0.2.80 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking regex-syntax v0.6.21 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking aho-corasick v0.7.15 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking regex v1.4.2 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking vm v0.1.0 (/opt/rustwide/workdir/vm) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> vm/src/common/lox_closure.rs:108:20 [INFO] [stdout] | [INFO] [stdout] 107 | pub fn new(function: LoxFunction, upvalues: Vec) -> Self { [INFO] [stdout] | --------------------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | LoxClosure(Rc::new(Closure { function, upvalues })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> vm/src/common/lox_function.rs:25:21 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(inner: LoxFunInner) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | LoxFunction(Rc::new(inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> vm/src/compiler/compile.rs:96:23 [INFO] [stdout] | [INFO] [stdout] 92 | pub fn end_compile(mut self) -> ClosureCompileBundle { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | function: LoxFunction::new(LoxFunInner::new( [INFO] [stdout] | _______________________^ [INFO] [stdout] 97 | | self.arity, self.name, self.chunk, [INFO] [stdout] 98 | | )), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> vm/src/compiler/compile.rs:151:20 [INFO] [stdout] | [INFO] [stdout] 145 | let mut unit = CompileUnit::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | arena: Arena::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> vm/src/compiler/compile.rs:421:25 [INFO] [stdout] | [INFO] [stdout] 413 | let value = match &tk.kind { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 421 | self.emit_instr(Instruction::LoadConstant(value), tk.position) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> vm/src/compiler/compile.rs:701:25 [INFO] [stdout] | [INFO] [stdout] 699 | let bundle = self.end_unit(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 700 | // bundle.function.disassemble(); [INFO] [stdout] 701 | self.emit_instr(Instruction::Closure(Box::new(bundle)), name.position) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> vm/src/vm/machine.rs:58:20 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn new(bundle: ClosureCompileBundle, mut arena: Arena) -> Self { [INFO] [stdout] | ---------------------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let init_closure = LoxClosure::new(bundle.function, Vec::new()); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | Machine { [INFO] [stdout] 58 | frame: CallFrame::new(init_closure.clone(), 0, 0), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> vm/src/vm/machine.rs:59:31 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn new(bundle: ClosureCompileBundle, mut arena: Arena) -> Self { [INFO] [stdout] | ---------------------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let init_closure = LoxClosure::new(bundle.function, Vec::new()); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | enclosing_frames: Vec::with_capacity(64), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> vm/src/vm/machine.rs:60:25 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn new(bundle: ClosureCompileBundle, mut arena: Arena) -> Self { [INFO] [stdout] | ---------------------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let init_closure = LoxClosure::new(bundle.function, Vec::new()); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | open_cells: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vm` (lib) due to 10 previous errors [INFO] running `Command { std: "docker" "inspect" "7b0e5aa2591981f7a281f47d2b6dd46c13ff3c99f57c3c7453edbeeeccc4c064", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7b0e5aa2591981f7a281f47d2b6dd46c13ff3c99f57c3c7453edbeeeccc4c064", kill_on_drop: false }` [INFO] [stdout] 7b0e5aa2591981f7a281f47d2b6dd46c13ff3c99f57c3c7453edbeeeccc4c064