[INFO] cloning repository https://github.com/apoelstra/rsgit [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/apoelstra/rsgit" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fapoelstra%2Frsgit", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fapoelstra%2Frsgit'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9a19f3342fc466622de5d052d418a93a1510bfab [INFO] checking apoelstra/rsgit/9a19f3342fc466622de5d052d418a93a1510bfab against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fapoelstra%2Frsgit" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/apoelstra/rsgit on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/apoelstra/rsgit [INFO] finished tweaking git repo https://github.com/apoelstra/rsgit [INFO] tweaked toml for git repo https://github.com/apoelstra/rsgit written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/apoelstra/rsgit already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `git2` dependency) [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 13d2717ead5de2b78702f5d4c61e9098a6107e2fed187c7ff2c11bd05fb0817c [INFO] running `Command { std: "docker" "start" "-a" "13d2717ead5de2b78702f5d4c61e9098a6107e2fed187c7ff2c11bd05fb0817c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "13d2717ead5de2b78702f5d4c61e9098a6107e2fed187c7ff2c11bd05fb0817c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "13d2717ead5de2b78702f5d4c61e9098a6107e2fed187c7ff2c11bd05fb0817c", kill_on_drop: false }` [INFO] [stdout] 13d2717ead5de2b78702f5d4c61e9098a6107e2fed187c7ff2c11bd05fb0817c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0f60855631140f6ad388aab77f052b93a4ff3b95d12b5dc72066e1c68f08aef6 [INFO] running `Command { std: "docker" "start" "-a" "0f60855631140f6ad388aab77f052b93a4ff3b95d12b5dc72066e1c68f08aef6", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `git2` dependency) [INFO] [stderr] Compiling libc v0.2.132 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling pkg-config v0.3.25 [INFO] [stderr] Compiling crossbeam-utils v0.8.11 [INFO] [stderr] Checking once_cell v1.14.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling crossbeam-epoch v0.9.10 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling serde v1.0.144 [INFO] [stderr] Compiling rayon-core v1.9.3 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking percent-encoding v2.2.0 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling unicode-segmentation v1.9.0 [INFO] [stderr] Checking unicode-bidi v0.3.8 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling rayon v1.5.3 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking form_urlencoded v1.1.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling anyhow v1.0.64 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking gimli v0.26.2 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking miniz_oxide v0.5.4 [INFO] [stderr] Checking either v1.8.0 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking fastrand v1.8.0 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking rustc-demangle v0.1.21 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking subprocess v0.2.9 [INFO] [stderr] Checking crossbeam-channel v0.5.6 [INFO] [stderr] Checking object v0.29.0 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Checking unicode-normalization v0.1.21 [INFO] [stderr] Compiling jobserver v0.1.24 [INFO] [stderr] Checking crossbeam-deque v0.8.2 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Checking idna v0.3.0 [INFO] [stderr] Compiling libz-sys v1.1.8 [INFO] [stderr] Compiling libgit2-sys v0.12.26+1.3.0 [INFO] [stderr] Compiling backtrace v0.3.66 [INFO] [stderr] Checking url v2.3.1 [INFO] [stderr] Checking addr2line v0.17.0 [INFO] [stderr] Compiling serde_derive v1.0.144 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Checking git2 v0.13.25 [INFO] [stderr] Checking toml v0.5.9 [INFO] [stderr] Checking serde_json v1.0.85 [INFO] [stderr] Checking git-utils v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/git.rs:25:24 [INFO] [stdout] | [INFO] [stdout] 25 | pub struct RepoRef<'a>(&'a ()); [INFO] [stdout] | ------- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `number` is never read [INFO] [stdout] --> src/pr.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 24 | pub struct PullRequest { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 25 | /// Number of the PR on Github/Gitlab [INFO] [stdout] 26 | pub number: usize, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/check-pr.rs:249:17 [INFO] [stdout] | [INFO] [stdout] 238 | let fresh_repo = match self::git::temp_repo(&repo, id) [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 248 | s.spawn(move |_| { [INFO] [stdout] 249 | / tx.send( [INFO] [stdout] 250 | | check [INFO] [stdout] 251 | | .execute(fresh_repo, build_pool) [INFO] [stdout] 252 | | .with_context(|| format!("executing check {} on commit {}", check, id)), [INFO] [stdout] 253 | | ) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/check-pr.rs:327:5 [INFO] [stdout] | [INFO] [stdout] 313 | let build_pool = ThreadPoolBuilder::new() [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 319 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 327 | rx.recv().expect("main alive") [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cargo.rs:81:15 [INFO] [stdout] | [INFO] [stdout] 71 | let mut popen = self [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | let bufread = io::BufReader::new(popen.stdout.take().unwrap()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | match bufread.lines().next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cargo.rs:106:15 [INFO] [stdout] | [INFO] [stdout] 96 | let exec = subprocess::Exec::cmd("rustc") [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | let mut popen = exec.popen().context("constructing rustc -V process")?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | let exit_status = popen.wait().context("waiting on rustc -V")?; [INFO] [stdout] 105 | let bufread = io::BufReader::new(popen.stdout.take().unwrap()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | match bufread.lines().next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/checks/mod.rs:58:38 [INFO] [stdout] | [INFO] [stdout] 54 | fn visit_seq(self, visitor: S) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Deserialize::deserialize(de::value::SeqAccessDeserializer::new(visitor)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/checks/rust.rs:42:79 [INFO] [stdout] | [INFO] [stdout] 42 | #[derive(Copy, Clone, Debug, PartialOrd, Ord, PartialEq, Eq, Hash, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 45 | let new_dir = [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let worktree = repo [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | Ok(TempWorktree { [INFO] [stdout] | ____________^ [INFO] [stdout] 66 | | worktree: worktree, [INFO] [stdout] 67 | | dir: new_dir, [INFO] [stdout] 68 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 115 | let new_repo_dir = [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | let new_repo = Repository::init(new_repo_dir.path()) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | Ok(TempRepo { [INFO] [stdout] | ____________^ [INFO] [stdout] 122 | | repo: new_repo, [INFO] [stdout] 123 | | dir: new_repo_dir, [INFO] [stdout] 124 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/job.rs:42:34 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn spawn(pool: &ThreadPool, ext_data: T, f: F) -> Self [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | pool.spawn(move || match panic::catch_unwind(f) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-utils` (bin "check-pr") due to 10 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/git.rs:25:24 [INFO] [stdout] | [INFO] [stdout] 25 | pub struct RepoRef<'a>(&'a ()); [INFO] [stdout] | ------- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `number` is never read [INFO] [stdout] --> src/pr.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 24 | pub struct PullRequest { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 25 | /// Number of the PR on Github/Gitlab [INFO] [stdout] 26 | pub number: usize, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/check-pr.rs:249:17 [INFO] [stdout] | [INFO] [stdout] 238 | let fresh_repo = match self::git::temp_repo(&repo, id) [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 248 | s.spawn(move |_| { [INFO] [stdout] 249 | / tx.send( [INFO] [stdout] 250 | | check [INFO] [stdout] 251 | | .execute(fresh_repo, build_pool) [INFO] [stdout] 252 | | .with_context(|| format!("executing check {} on commit {}", check, id)), [INFO] [stdout] 253 | | ) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/check-pr.rs:327:5 [INFO] [stdout] | [INFO] [stdout] 313 | let build_pool = ThreadPoolBuilder::new() [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 319 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 327 | rx.recv().expect("main alive") [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cargo.rs:81:15 [INFO] [stdout] | [INFO] [stdout] 71 | let mut popen = self [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | let bufread = io::BufReader::new(popen.stdout.take().unwrap()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | match bufread.lines().next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cargo.rs:106:15 [INFO] [stdout] | [INFO] [stdout] 96 | let exec = subprocess::Exec::cmd("rustc") [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | let mut popen = exec.popen().context("constructing rustc -V process")?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | let exit_status = popen.wait().context("waiting on rustc -V")?; [INFO] [stdout] 105 | let bufread = io::BufReader::new(popen.stdout.take().unwrap()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | match bufread.lines().next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/checks/mod.rs:58:38 [INFO] [stdout] | [INFO] [stdout] 54 | fn visit_seq(self, visitor: S) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Deserialize::deserialize(de::value::SeqAccessDeserializer::new(visitor)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/checks/rust.rs:42:79 [INFO] [stdout] | [INFO] [stdout] 42 | #[derive(Copy, Clone, Debug, PartialOrd, Ord, PartialEq, Eq, Hash, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 45 | let new_dir = [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let worktree = repo [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | Ok(TempWorktree { [INFO] [stdout] | ____________^ [INFO] [stdout] 66 | | worktree: worktree, [INFO] [stdout] 67 | | dir: new_dir, [INFO] [stdout] 68 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 115 | let new_repo_dir = [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | let new_repo = Repository::init(new_repo_dir.path()) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | Ok(TempRepo { [INFO] [stdout] | ____________^ [INFO] [stdout] 122 | | repo: new_repo, [INFO] [stdout] 123 | | dir: new_repo_dir, [INFO] [stdout] 124 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/job.rs:42:34 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn spawn(pool: &ThreadPool, ext_data: T, f: F) -> Self [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | pool.spawn(move || match panic::catch_unwind(f) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-utils` (bin "check-pr" test) due to 10 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0f60855631140f6ad388aab77f052b93a4ff3b95d12b5dc72066e1c68f08aef6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0f60855631140f6ad388aab77f052b93a4ff3b95d12b5dc72066e1c68f08aef6", kill_on_drop: false }` [INFO] [stdout] 0f60855631140f6ad388aab77f052b93a4ff3b95d12b5dc72066e1c68f08aef6