[INFO] cloning repository https://github.com/aokblast/moodle-grading-tool [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/aokblast/moodle-grading-tool" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faokblast%2Fmoodle-grading-tool", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faokblast%2Fmoodle-grading-tool'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 364f466179516d79661af96544d3b8085a878cdd [INFO] checking aokblast/moodle-grading-tool/364f466179516d79661af96544d3b8085a878cdd against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faokblast%2Fmoodle-grading-tool" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/aokblast/moodle-grading-tool on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/aokblast/moodle-grading-tool [INFO] finished tweaking git repo https://github.com/aokblast/moodle-grading-tool [INFO] tweaked toml for git repo https://github.com/aokblast/moodle-grading-tool written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/aokblast/moodle-grading-tool already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a7d8847f9729c3dfa0838789011d3cb0e9ca9415c9c1eed533cd2b91a48ad36a [INFO] running `Command { std: "docker" "start" "-a" "a7d8847f9729c3dfa0838789011d3cb0e9ca9415c9c1eed533cd2b91a48ad36a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a7d8847f9729c3dfa0838789011d3cb0e9ca9415c9c1eed533cd2b91a48ad36a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a7d8847f9729c3dfa0838789011d3cb0e9ca9415c9c1eed533cd2b91a48ad36a", kill_on_drop: false }` [INFO] [stdout] a7d8847f9729c3dfa0838789011d3cb0e9ca9415c9c1eed533cd2b91a48ad36a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7189beb64591399be21f9bc695bc35cbb3b00cdc451366acbd2ead7a3f0079f2 [INFO] running `Command { std: "docker" "start" "-a" "7189beb64591399be21f9bc695bc35cbb3b00cdc451366acbd2ead7a3f0079f2", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking quick-xml v0.31.0 [INFO] [stderr] Checking codepage v0.1.1 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking fuzzy-matcher v0.3.7 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.57 [INFO] [stderr] Checking zip v0.6.6 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking calamine v0.24.0 [INFO] [stderr] Checking moodle-grading-tool v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `Path`, `collections::HashSet`, and `result` [INFO] [stdout] --> src/main.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | collections::HashSet, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 5 | path::{Path, PathBuf}, [INFO] [stdout] | ^^^^ [INFO] [stdout] 6 | process::Stdio, [INFO] [stdout] 7 | result, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `RangeDeserializer`, `Xlsx`, and `open_workbook` [INFO] [stdout] --> src/main.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | open_workbook, open_workbook_auto, Error, RangeDeserializer, RangeDeserializerBuilder, Reader, [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 13 | Xlsx, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `de::value::BytesDeserializer` [INFO] [stdout] --> src/main.rs:17:13 [INFO] [stdout] | [INFO] [stdout] 17 | use serde::{de::value::BytesDeserializer, Deserialize, Serialize}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Path`, `collections::HashSet`, and `result` [INFO] [stdout] --> src/main.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | collections::HashSet, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 5 | path::{Path, PathBuf}, [INFO] [stdout] | ^^^^ [INFO] [stdout] 6 | process::Stdio, [INFO] [stdout] 7 | result, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `RangeDeserializer`, `Xlsx`, and `open_workbook` [INFO] [stdout] --> src/main.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | open_workbook, open_workbook_auto, Error, RangeDeserializer, RangeDeserializerBuilder, Reader, [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 13 | Xlsx, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `de::value::BytesDeserializer` [INFO] [stdout] --> src/main.rs:17:13 [INFO] [stdout] | [INFO] [stdout] 17 | use serde::{de::value::BytesDeserializer, Deserialize, Serialize}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/main.rs:4:36 [INFO] [stdout] | [INFO] [stdout] 4 | io::{self, BufRead, BufReader, Read, Write}, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/main.rs:4:36 [INFO] [stdout] | [INFO] [stdout] 4 | io::{self, BufRead, BufReader, Read, Write}, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Patch` is never constructed [INFO] [stdout] --> src/assignment.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 40 | pub enum FileType { [INFO] [stdout] | -------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 44 | Patch(Option<&'static str>), [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FileType` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new_with_problems` is never used [INFO] [stdout] --> src/assignment.rs:188:12 [INFO] [stdout] | [INFO] [stdout] 183 | impl Assignment { [INFO] [stdout] | --------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 188 | pub fn new_with_problems(problems: &[Problem]) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:139:6 [INFO] [stdout] | [INFO] [stdout] 126 | fn count_line(f: File) -> (File, u32) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | let mut cur = 0; [INFO] [stdout] 128 | let mut reader = BufReader::new(f); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | (reader.into_inner(), cur) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `moodle-grading-tool` (bin "moodle-grading-tool") due to 2 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variant `Patch` is never constructed [INFO] [stdout] --> src/assignment.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 40 | pub enum FileType { [INFO] [stdout] | -------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 44 | Patch(Option<&'static str>), [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FileType` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new_with_problems` is never used [INFO] [stdout] --> src/assignment.rs:188:12 [INFO] [stdout] | [INFO] [stdout] 183 | impl Assignment { [INFO] [stdout] | --------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 188 | pub fn new_with_problems(problems: &[Problem]) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:139:6 [INFO] [stdout] | [INFO] [stdout] 126 | fn count_line(f: File) -> (File, u32) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | let mut cur = 0; [INFO] [stdout] 128 | let mut reader = BufReader::new(f); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | (reader.into_inner(), cur) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `moodle-grading-tool` (bin "moodle-grading-tool" test) due to 2 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7189beb64591399be21f9bc695bc35cbb3b00cdc451366acbd2ead7a3f0079f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7189beb64591399be21f9bc695bc35cbb3b00cdc451366acbd2ead7a3f0079f2", kill_on_drop: false }` [INFO] [stdout] 7189beb64591399be21f9bc695bc35cbb3b00cdc451366acbd2ead7a3f0079f2