[INFO] cloning repository https://github.com/antonxy/h264_glitcher [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/antonxy/h264_glitcher" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fantonxy%2Fh264_glitcher", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fantonxy%2Fh264_glitcher'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c72ed7b836cd32691857be16c1ab82f0ef0ad1b3 [INFO] checking antonxy/h264_glitcher/c72ed7b836cd32691857be16c1ab82f0ef0ad1b3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fantonxy%2Fh264_glitcher" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/antonxy/h264_glitcher on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/antonxy/h264_glitcher [INFO] finished tweaking git repo https://github.com/antonxy/h264_glitcher [INFO] tweaked toml for git repo https://github.com/antonxy/h264_glitcher written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/antonxy/h264_glitcher already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9ace7c7ed893a0db085c1460b112aceefdbed5a3e493ce94141ccd8f27784d12 [INFO] running `Command { std: "docker" "start" "-a" "9ace7c7ed893a0db085c1460b112aceefdbed5a3e493ce94141ccd8f27784d12", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9ace7c7ed893a0db085c1460b112aceefdbed5a3e493ce94141ccd8f27784d12", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9ace7c7ed893a0db085c1460b112aceefdbed5a3e493ce94141ccd8f27784d12", kill_on_drop: false }` [INFO] [stdout] 9ace7c7ed893a0db085c1460b112aceefdbed5a3e493ce94141ccd8f27784d12 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4e8d4993f7bbc271cb5755baca50ac46f8cf12e406bc75c4cc8921c181427c0a [INFO] running `Command { std: "docker" "start" "-a" "4e8d4993f7bbc271cb5755baca50ac46f8cf12e406bc75c4cc8921c181427c0a", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.81 [INFO] [stderr] Compiling rand_core v0.4.2 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling siphasher v0.2.3 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Checking traitobject v0.1.0 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Compiling unicase v1.4.2 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Checking unicode-bidi v0.3.8 [INFO] [stderr] Checking safemem v0.3.3 [INFO] [stderr] Compiling getrandom v0.2.0 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Checking unsafe-any v0.4.2 [INFO] [stderr] Compiling syn v1.0.56 [INFO] [stderr] Checking base64 v0.9.3 [INFO] [stderr] Compiling rand_core v0.3.1 [INFO] [stderr] Compiling rand_jitter v0.1.4 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling rand_hc v0.1.0 [INFO] [stderr] Compiling rand_xorshift v0.1.1 [INFO] [stderr] Compiling rand_isaac v0.1.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking typemap v0.3.3 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Compiling phf_shared v0.7.24 [INFO] [stderr] Checking language-tags v0.2.2 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Checking typeable v0.1.2 [INFO] [stderr] Compiling phf v0.7.24 [INFO] [stderr] Compiling nom v7.1.0 [INFO] [stderr] Checking plugin v0.2.6 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Checking modifier v0.1.0 [INFO] [stderr] Checking mime v0.2.6 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking sequence_trie v0.3.6 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Compiling rand_os v0.1.3 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Compiling quote v1.0.8 [INFO] [stderr] Checking num_cpus v1.15.0 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking rand_core v0.6.0 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking bitstream-io v1.3.0 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking spin_sleep v1.1.1 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking rand v0.8.0 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Compiling phf_generator v0.7.24 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Compiling phf_codegen v0.7.24 [INFO] [stderr] Compiling mime_guess v1.8.8 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking hyper v0.10.16 [INFO] [stderr] Checking rosc v0.6.0 [INFO] [stderr] Compiling visit_diff_derive v0.1.0 [INFO] [stderr] Checking iron v0.6.1 [INFO] [stderr] Checking visit_diff v0.1.1 [INFO] [stderr] Checking mount v0.4.0 [INFO] [stderr] Checking staticfile v0.5.0 [INFO] [stderr] Compiling structopt-derive v0.4.14 [INFO] [stderr] Checking structopt v0.3.21 [INFO] [stderr] Checking h264_glitcher v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `header` [INFO] [stdout] --> src/h264/slice_header.rs:106:25 [INFO] [stdout] | [INFO] [stdout] 106 | let header = SliceHeader::from_bytes(&unit.rbsp).unwrap(); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_header` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::convert::TryInto` [INFO] [stdout] --> src/bin/h264_glitcher.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::convert::TryInto; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Add` and `Deref` [INFO] [stdout] --> src/bin/h264_glitcher.rs:12:16 [INFO] [stdout] | [INFO] [stdout] 12 | use std::ops::{Add, Deref}; [INFO] [stdout] | ^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `SyncSender` and `TrySendError` [INFO] [stdout] --> src/bin/h264_glitcher.rs:16:23 [INFO] [stdout] | [INFO] [stdout] 16 | use std::sync::mpsc::{SyncSender, TrySendError}; [INFO] [stdout] | ^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Instant` [INFO] [stdout] --> src/bin/h264_glitcher.rs:17:27 [INFO] [stdout] | [INFO] [stdout] 17 | use std::time::{Duration, Instant}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::convert::TryInto` [INFO] [stdout] --> src/bin/h264_glitcher.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::convert::TryInto; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Add` and `Deref` [INFO] [stdout] --> src/bin/h264_glitcher.rs:12:16 [INFO] [stdout] | [INFO] [stdout] 12 | use std::ops::{Add, Deref}; [INFO] [stdout] | ^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `SyncSender` and `TrySendError` [INFO] [stdout] --> src/bin/h264_glitcher.rs:16:23 [INFO] [stdout] | [INFO] [stdout] 16 | use std::sync::mpsc::{SyncSender, TrySendError}; [INFO] [stdout] | ^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Instant` [INFO] [stdout] --> src/bin/h264_glitcher.rs:17:27 [INFO] [stdout] | [INFO] [stdout] 17 | use std::time::{Duration, Instant}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/validate_video_parameters/main.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 59 | let input_file = File::open(path)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let file = std::io::BufReader::with_capacity(1 << 20, input_file); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | [INFO] [stdout] 62 | let it = NalIterator::new(file.bytes().map(|x| x.unwrap())); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | Ok(it.map(|v| NalUnit::from_bytes(&v))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/validate_video_parameters/diff_printing.rs:9:27 [INFO] [stdout] | [INFO] [stdout] 9 | .map(|(k, v)| (k, v.and_then(remove_same))) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `h264_glitcher` (bin "validate_video_parameters" test) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/validate_video_parameters/main.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 59 | let input_file = File::open(path)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let file = std::io::BufReader::with_capacity(1 << 20, input_file); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | [INFO] [stdout] 62 | let it = NalIterator::new(file.bytes().map(|x| x.unwrap())); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | Ok(it.map(|v| NalUnit::from_bytes(&v))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/validate_video_parameters/diff_printing.rs:9:27 [INFO] [stdout] | [INFO] [stdout] 9 | .map(|(k, v)| (k, v.and_then(remove_same))) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/h264_glitcher.rs:481:13 [INFO] [stdout] | [INFO] [stdout] 481 | let mut params = streaming_params.lock().unwrap().clone(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/h264_glitcher.rs:516:13 [INFO] [stdout] | [INFO] [stdout] 516 | let mut nal_unit = ¤t_video.frames[current_frame]; [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `loop_controller` [INFO] [stdout] --> src/bin/h264_glitcher.rs:555:103 [INFO] [stdout] | [INFO] [stdout] 555 | ...>, loop_controller: LoopController, paths: Vec, thumbnails: Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_loop_controller` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/bin/h264_glitcher.rs:602:93 [INFO] [stdout] | [INFO] [stdout] 602 | ...d_sock: Arc>, addr: &SocketAddr, streaming_params: Arc>, mut fps_controller: LoopController) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `edit_state` is never used [INFO] [stdout] --> src/bin/h264_glitcher.rs:216:8 [INFO] [stdout] | [INFO] [stdout] 191 | impl StreamingParams { [INFO] [stdout] | -------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 216 | fn edit_state(&self) -> &State { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Video` is never constructed [INFO] [stdout] --> src/bin/h264_glitcher.rs:242:8 [INFO] [stdout] | [INFO] [stdout] 242 | struct Video { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `loadedVideo` should have a snake case name [INFO] [stdout] --> src/bin/h264_glitcher.rs:244:5 [INFO] [stdout] | [INFO] [stdout] 244 | loadedVideo : Option>>, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `loaded_video` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/h264_glitcher.rs:300:54 [INFO] [stdout] | [INFO] [stdout] 300 | loaded_videos = paths.iter().map(|p| Rc::new(LoadedVideo::load(p).unwrap())).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/bin/h264_glitcher.rs:431:17 [INFO] [stdout] | [INFO] [stdout] 431 | assert!(from_incl >= 0); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `h264_glitcher` (bin "validate_video_parameters") due to 3 previous errors [INFO] [stdout] error: aborting due to 1 previous error; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `h264_glitcher` (bin "h264_glitcher") due to 2 previous errors; 12 warnings emitted [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/h264_glitcher.rs:481:13 [INFO] [stdout] | [INFO] [stdout] 481 | let mut params = streaming_params.lock().unwrap().clone(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/h264_glitcher.rs:516:13 [INFO] [stdout] | [INFO] [stdout] 516 | let mut nal_unit = ¤t_video.frames[current_frame]; [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `loop_controller` [INFO] [stdout] --> src/bin/h264_glitcher.rs:555:103 [INFO] [stdout] | [INFO] [stdout] 555 | ...>, loop_controller: LoopController, paths: Vec, thumbnails: Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_loop_controller` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/bin/h264_glitcher.rs:602:93 [INFO] [stdout] | [INFO] [stdout] 602 | ...d_sock: Arc>, addr: &SocketAddr, streaming_params: Arc>, mut fps_controller: LoopController) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `edit_state` is never used [INFO] [stdout] --> src/bin/h264_glitcher.rs:216:8 [INFO] [stdout] | [INFO] [stdout] 191 | impl StreamingParams { [INFO] [stdout] | -------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 216 | fn edit_state(&self) -> &State { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Video` is never constructed [INFO] [stdout] --> src/bin/h264_glitcher.rs:242:8 [INFO] [stdout] | [INFO] [stdout] 242 | struct Video { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `loadedVideo` should have a snake case name [INFO] [stdout] --> src/bin/h264_glitcher.rs:244:5 [INFO] [stdout] | [INFO] [stdout] 244 | loadedVideo : Option>>, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `loaded_video` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/h264_glitcher.rs:300:54 [INFO] [stdout] | [INFO] [stdout] 300 | loaded_videos = paths.iter().map(|p| Rc::new(LoadedVideo::load(p).unwrap())).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/bin/h264_glitcher.rs:431:17 [INFO] [stdout] | [INFO] [stdout] 431 | assert!(from_incl >= 0); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `h264_glitcher` (bin "h264_glitcher" test) due to 2 previous errors; 12 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4e8d4993f7bbc271cb5755baca50ac46f8cf12e406bc75c4cc8921c181427c0a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4e8d4993f7bbc271cb5755baca50ac46f8cf12e406bc75c4cc8921c181427c0a", kill_on_drop: false }` [INFO] [stdout] 4e8d4993f7bbc271cb5755baca50ac46f8cf12e406bc75c4cc8921c181427c0a