[INFO] cloning repository https://github.com/antonio-hickey/matrix_oxide [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/antonio-hickey/matrix_oxide" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fantonio-hickey%2Fmatrix_oxide", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fantonio-hickey%2Fmatrix_oxide'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 02c10bc6964cf35040f4723d8c82c60a76c3bb11 [INFO] checking antonio-hickey/matrix_oxide/02c10bc6964cf35040f4723d8c82c60a76c3bb11 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fantonio-hickey%2Fmatrix_oxide" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/antonio-hickey/matrix_oxide on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/antonio-hickey/matrix_oxide [INFO] finished tweaking git repo https://github.com/antonio-hickey/matrix_oxide [INFO] tweaked toml for git repo https://github.com/antonio-hickey/matrix_oxide written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/antonio-hickey/matrix_oxide already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bc6e2cae6763ff2bd121a5ccc06e68209b5c08f39fedfba53f9de9fe0797c6e2 [INFO] running `Command { std: "docker" "start" "-a" "bc6e2cae6763ff2bd121a5ccc06e68209b5c08f39fedfba53f9de9fe0797c6e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bc6e2cae6763ff2bd121a5ccc06e68209b5c08f39fedfba53f9de9fe0797c6e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bc6e2cae6763ff2bd121a5ccc06e68209b5c08f39fedfba53f9de9fe0797c6e2", kill_on_drop: false }` [INFO] [stdout] bc6e2cae6763ff2bd121a5ccc06e68209b5c08f39fedfba53f9de9fe0797c6e2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 21400b8587e3993eeca330012be95a2d1b7d926771cf2e7c9589ccbad61bddc8 [INFO] running `Command { std: "docker" "start" "-a" "21400b8587e3993eeca330012be95a2d1b7d926771cf2e7c9589ccbad61bddc8", kill_on_drop: false }` [INFO] [stderr] Checking matrix-oxide v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matrix.rs:186:17 [INFO] [stdout] | [INFO] [stdout] 184 | let row_a = self.try_get_row(row).expect("Invalid row in self"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | let row_b = rhs.try_get_row(row).expect("Invalid row in rhs"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | row_a.into_iter().zip(row_b).map(|(a, b)| a + b) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matrix.rs:225:17 [INFO] [stdout] | [INFO] [stdout] 223 | let row_a = self.try_get_row(row).expect("Invalid row in self"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | let row_b = rhs.try_get_row(row).expect("Invalid row in rhs"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | row_a.into_iter().zip(row_b).map(|(a, b)| a - b) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matrix.rs:246:26 [INFO] [stdout] | [INFO] [stdout] 246 | .map(|value| value.clone() * scalar.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matrix.rs:246:42 [INFO] [stdout] | [INFO] [stdout] 246 | .map(|value| value.clone() * scalar.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matrix.rs:277:14 [INFO] [stdout] | [INFO] [stdout] 264 | let data: Vec = (0..self.row_size) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 277 | Some(Matrix { [INFO] [stdout] | ______________^ [INFO] [stdout] 278 | | data, [INFO] [stdout] 279 | | col_size: multiplier.col_size, [INFO] [stdout] 280 | | row_size: self.row_size, [INFO] [stdout] 281 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matrix.rs:295:30 [INFO] [stdout] | [INFO] [stdout] 295 | .map(|j| self.data[i * self.col_size + j].clone() * multiplier[j].clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matrix.rs:295:73 [INFO] [stdout] | [INFO] [stdout] 295 | .map(|j| self.data[i * self.col_size + j].clone() * multiplier[j].clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `matrix-oxide` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matrix.rs:186:17 [INFO] [stdout] | [INFO] [stdout] 184 | let row_a = self.try_get_row(row).expect("Invalid row in self"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | let row_b = rhs.try_get_row(row).expect("Invalid row in rhs"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | row_a.into_iter().zip(row_b).map(|(a, b)| a + b) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matrix.rs:225:17 [INFO] [stdout] | [INFO] [stdout] 223 | let row_a = self.try_get_row(row).expect("Invalid row in self"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | let row_b = rhs.try_get_row(row).expect("Invalid row in rhs"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | row_a.into_iter().zip(row_b).map(|(a, b)| a - b) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matrix.rs:246:26 [INFO] [stdout] | [INFO] [stdout] 246 | .map(|value| value.clone() * scalar.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matrix.rs:246:42 [INFO] [stdout] | [INFO] [stdout] 246 | .map(|value| value.clone() * scalar.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matrix.rs:277:14 [INFO] [stdout] | [INFO] [stdout] 264 | let data: Vec = (0..self.row_size) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 277 | Some(Matrix { [INFO] [stdout] | ______________^ [INFO] [stdout] 278 | | data, [INFO] [stdout] 279 | | col_size: multiplier.col_size, [INFO] [stdout] 280 | | row_size: self.row_size, [INFO] [stdout] 281 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matrix.rs:295:30 [INFO] [stdout] | [INFO] [stdout] 295 | .map(|j| self.data[i * self.col_size + j].clone() * multiplier[j].clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matrix.rs:295:73 [INFO] [stdout] | [INFO] [stdout] 295 | .map(|j| self.data[i * self.col_size + j].clone() * multiplier[j].clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `matrix-oxide` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "21400b8587e3993eeca330012be95a2d1b7d926771cf2e7c9589ccbad61bddc8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "21400b8587e3993eeca330012be95a2d1b7d926771cf2e7c9589ccbad61bddc8", kill_on_drop: false }` [INFO] [stdout] 21400b8587e3993eeca330012be95a2d1b7d926771cf2e7c9589ccbad61bddc8