[INFO] cloning repository https://github.com/anthdm/avalanche [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/anthdm/avalanche" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fanthdm%2Favalanche", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fanthdm%2Favalanche'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ab7656cd7f137c214177ae888c986eab80a8a3b8 [INFO] checking anthdm/avalanche/ab7656cd7f137c214177ae888c986eab80a8a3b8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fanthdm%2Favalanche" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/anthdm/avalanche on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/anthdm/avalanche [INFO] finished tweaking git repo https://github.com/anthdm/avalanche [INFO] tweaked toml for git repo https://github.com/anthdm/avalanche written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/anthdm/avalanche already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d919415f731589df9d0f4479b1968f0825478b480afff0daec3ab12ebbc32a26 [INFO] running `Command { std: "docker" "start" "-a" "d919415f731589df9d0f4479b1968f0825478b480afff0daec3ab12ebbc32a26", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d919415f731589df9d0f4479b1968f0825478b480afff0daec3ab12ebbc32a26", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d919415f731589df9d0f4479b1968f0825478b480afff0daec3ab12ebbc32a26", kill_on_drop: false }` [INFO] [stdout] d919415f731589df9d0f4479b1968f0825478b480afff0daec3ab12ebbc32a26 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 941d4ff95c8aa9d19924edc7cae6658d22695a6340927fc51fc3f26f435693e8 [INFO] running `Command { std: "docker" "start" "-a" "941d4ff95c8aa9d19924edc7cae6658d22695a6340927fc51fc3f26f435693e8", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling cc v1.0.18 [INFO] [stderr] Checking libc v0.2.42 [INFO] [stderr] Checking lazy_static v1.0.2 [INFO] [stderr] Checking untrusted v0.6.2 [INFO] [stderr] Checking rand_core v0.2.1 [INFO] [stderr] Checking hex v0.3.2 [INFO] [stderr] Checking byteorder v1.2.3 [INFO] [stderr] Checking rand v0.5.4 [INFO] [stderr] Compiling ring v0.13.2 [INFO] [stderr] Checking avalanche v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated function `rand::sample`: renamed to seq::sample_iter [INFO] [stdout] --> src/main.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | use rand::{sample, thread_rng, Rng}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::thread::sleep_ms`: replaced by `std::thread::sleep` [INFO] [stdout] --> src/main.rs:32:17 [INFO] [stdout] | [INFO] [stdout] 32 | thread::sleep_ms(500); // cpu ded [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `rand::sample`: renamed to seq::sample_iter [INFO] [stdout] --> src/main.rs:171:5 [INFO] [stdout] | [INFO] [stdout] 171 | sample(&mut thread_rng(), ids, n) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `rand::sample`: renamed to seq::sample_iter [INFO] [stdout] --> src/main.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | use rand::{sample, thread_rng, Rng}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::thread::sleep_ms`: replaced by `std::thread::sleep` [INFO] [stdout] --> src/main.rs:32:17 [INFO] [stdout] | [INFO] [stdout] 32 | thread::sleep_ms(500); // cpu ded [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `rand::sample`: renamed to seq::sample_iter [INFO] [stdout] --> src/main.rs:171:5 [INFO] [stdout] | [INFO] [stdout] 171 | sample(&mut thread_rng(), ids, n) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:142:25 [INFO] [stdout] | [INFO] [stdout] 142 | let mut sampled = sample_nodes(&nodes, SAMPLES, origin); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:156:25 [INFO] [stdout] | [INFO] [stdout] 156 | let mut node = nodes.get_mut(&to).unwrap(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:142:25 [INFO] [stdout] | [INFO] [stdout] 142 | let mut sampled = sample_nodes(&nodes, SAMPLES, origin); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:156:25 [INFO] [stdout] | [INFO] [stdout] 156 | let mut node = nodes.get_mut(&to).unwrap(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:127:20 [INFO] [stdout] | [INFO] [stdout] 125 | let (sender, receiver) = channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | Network { [INFO] [stdout] 127 | nodes: (0..n) [INFO] [stdout] | ____________________^ [INFO] [stdout] 128 | | .map(|id| (id, Arc::new(Mutex::new(Node::new(id, sender.clone()))))) [INFO] [stdout] 129 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:130:23 [INFO] [stdout] | [INFO] [stdout] 125 | let (sender, receiver) = channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | receiver: Arc::new(Mutex::new(receiver)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:128:32 [INFO] [stdout] | [INFO] [stdout] 128 | .map(|id| (id, Arc::new(Mutex::new(Node::new(id, sender.clone()))))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:127:20 [INFO] [stdout] | [INFO] [stdout] 125 | let (sender, receiver) = channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | Network { [INFO] [stdout] 127 | nodes: (0..n) [INFO] [stdout] | ____________________^ [INFO] [stdout] 128 | | .map(|id| (id, Arc::new(Mutex::new(Node::new(id, sender.clone()))))) [INFO] [stdout] 129 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:130:23 [INFO] [stdout] | [INFO] [stdout] 125 | let (sender, receiver) = channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | receiver: Arc::new(Mutex::new(receiver)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:128:32 [INFO] [stdout] | [INFO] [stdout] 128 | .map(|id| (id, Arc::new(Mutex::new(Node::new(id, sender.clone()))))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `collect` that must be used [INFO] [stdout] --> src/main.rs:143:21 [INFO] [stdout] | [INFO] [stdout] 143 | / sampled [INFO] [stdout] 144 | | .iter() [INFO] [stdout] 145 | | .map(|id| { [INFO] [stdout] 146 | | nodes [INFO] [stdout] ... | [INFO] [stdout] 152 | | }) [INFO] [stdout] 153 | | .collect::>(); [INFO] [stdout] | |____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 143 | let _ = sampled [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:352:9 [INFO] [stdout] | [INFO] [stdout] 352 | self.sender.send((self.id, msg)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 352 | let _ = self.sender.send((self.id, msg)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:357:9 [INFO] [stdout] | [INFO] [stdout] 357 | self.sender.send((self.id, msg)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 357 | let _ = self.sender.send((self.id, msg)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `collect` that must be used [INFO] [stdout] --> src/main.rs:143:21 [INFO] [stdout] | [INFO] [stdout] 143 | / sampled [INFO] [stdout] 144 | | .iter() [INFO] [stdout] 145 | | .map(|id| { [INFO] [stdout] 146 | | nodes [INFO] [stdout] ... | [INFO] [stdout] 152 | | }) [INFO] [stdout] 153 | | .collect::>(); [INFO] [stdout] | |____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 143 | let _ = sampled [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:352:9 [INFO] [stdout] | [INFO] [stdout] 352 | self.sender.send((self.id, msg)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 352 | let _ = self.sender.send((self.id, msg)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:357:9 [INFO] [stdout] | [INFO] [stdout] 357 | self.sender.send((self.id, msg)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 357 | let _ = self.sender.send((self.id, msg)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `avalanche` (bin "avalanche") due to 4 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `avalanche` (bin "avalanche" test) due to 4 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "941d4ff95c8aa9d19924edc7cae6658d22695a6340927fc51fc3f26f435693e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "941d4ff95c8aa9d19924edc7cae6658d22695a6340927fc51fc3f26f435693e8", kill_on_drop: false }` [INFO] [stdout] 941d4ff95c8aa9d19924edc7cae6658d22695a6340927fc51fc3f26f435693e8