[INFO] cloning repository https://github.com/anotherhollow1125/ncsync [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/anotherhollow1125/ncsync" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fanotherhollow1125%2Fncsync", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fanotherhollow1125%2Fncsync'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3b047089b1c61fd5d81550fc42a3a40369d1c5e3 [INFO] checking anotherhollow1125/ncsync/3b047089b1c61fd5d81550fc42a3a40369d1c5e3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fanotherhollow1125%2Fncsync" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/anotherhollow1125/ncsync on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/anotherhollow1125/ncsync [INFO] finished tweaking git repo https://github.com/anotherhollow1125/ncsync [INFO] tweaked toml for git repo https://github.com/anotherhollow1125/ncsync written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/anotherhollow1125/ncsync already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b51bcae4b290bf48176eca127aba486ef4e53b67df644ef6918f0a279a2f178c [INFO] running `Command { std: "docker" "start" "-a" "b51bcae4b290bf48176eca127aba486ef4e53b67df644ef6918f0a279a2f178c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b51bcae4b290bf48176eca127aba486ef4e53b67df644ef6918f0a279a2f178c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b51bcae4b290bf48176eca127aba486ef4e53b67df644ef6918f0a279a2f178c", kill_on_drop: false }` [INFO] [stdout] b51bcae4b290bf48176eca127aba486ef4e53b67df644ef6918f0a279a2f178c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8316a9bda0163011013687fcb441ceeaf88292c03820f917c3a199f2afc4a0af [INFO] running `Command { std: "docker" "start" "-a" "8316a9bda0163011013687fcb441ceeaf88292c03820f917c3a199f2afc4a0af", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling proc-macro2 v1.0.39 [INFO] [stderr] Compiling unicode-ident v1.0.0 [INFO] [stderr] Compiling syn v1.0.95 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Compiling parking_lot_core v0.9.3 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Compiling pkg-config v0.3.25 [INFO] [stderr] Checking once_cell v1.11.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Checking itoa v1.0.2 [INFO] [stderr] Compiling serde_derive v1.0.137 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Checking tracing-core v0.1.26 [INFO] [stderr] Compiling indexmap v1.8.1 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Compiling openssl v0.10.40 [INFO] [stderr] Checking http v0.2.7 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Checking mio v0.8.3 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Compiling openssl-sys v0.9.73 [INFO] [stderr] Compiling httparse v1.7.1 [INFO] [stderr] Checking parking_lot v0.12.0 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Compiling native-tls v0.2.10 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking slab v0.4.6 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling serde_json v1.0.81 [INFO] [stderr] Checking unicode-bidi v0.3.8 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking tower-service v0.3.1 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Checking regex-syntax v0.6.26 [INFO] [stderr] Compiling encoding_rs v0.8.31 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Compiling anyhow v1.0.57 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking xmlparser v0.13.3 [INFO] [stderr] Checking ipnet v2.5.0 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking roxmltree v0.14.1 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking uuid v1.1.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking if_chain v1.0.2 [INFO] [stderr] Checking urlencoding v2.1.0 [INFO] [stderr] Checking regex v1.5.6 [INFO] [stderr] Checking globset v0.4.8 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling tracing-attributes v0.1.21 [INFO] [stderr] Compiling openssl-macros v0.1.0 [INFO] [stderr] Compiling thiserror-impl v1.0.31 [INFO] [stderr] Compiling async-recursion v1.0.0 [INFO] [stderr] Checking tokio v1.18.2 [INFO] [stderr] Checking tracing v0.1.34 [INFO] [stderr] Checking thiserror v1.0.31 [INFO] [stderr] Checking tokio-util v0.7.2 [INFO] [stderr] Checking tokio-native-tls v0.3.0 [INFO] [stderr] Checking h2 v0.3.13 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking toml v0.5.9 [INFO] [stderr] Checking hyper v0.14.18 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.10 [INFO] [stderr] Checking ncsync_lib v0.1.0 (/opt/rustwide/workdir/ncsync_lib) [INFO] [stdout] warning: struct `NCPath` is never constructed [INFO] [stdout] --> ncsync_lib/src/path.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 52 | pub struct NCPath<'a> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static `RE_PATHRESOLVE` is never used [INFO] [stdout] --> ncsync_lib/src/path.rs:57:8 [INFO] [stdout] | [INFO] [stdout] 57 | static RE_PATHRESOLVE: Lazy = [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `new`, `get_username`, and `resolve` are never used [INFO] [stdout] --> ncsync_lib/src/path.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 60 | impl<'a> NCPath<'a> { [INFO] [stdout] | ------------------- associated functions in this implementation [INFO] [stdout] 61 | pub fn new(path: impl AsRef, profile: &'a Profile) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 66 | pub fn get_username(target: &str) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 72 | pub fn resolve( [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_default_profile` and `get_mut_default_profile` are never used [INFO] [stdout] --> ncsync_lib/src/setting.rs:211:19 [INFO] [stdout] | [INFO] [stdout] 115 | impl ClientHub { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 211 | pub(crate) fn get_default_profile(&self) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 224 | pub(crate) fn get_mut_default_profile(&mut self) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ncsync_lib/src/path.rs:58:18 [INFO] [stdout] | [INFO] [stdout] 58 | Lazy::new(|| Regex::new(r"^(?P[^:]*):(?P.*)$").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ncsync_lib/src/setting.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 90 | method: Method, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | _ => return Err(anyhow!("not logged in")), [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | Ok(req_client [INFO] [stdout] | ____________^ [INFO] [stdout] 102 | | .request(method, url) [INFO] [stdout] 103 | | .basic_auth(username, Some(password))) [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ncsync_lib/src/setting.rs:188:9 [INFO] [stdout] | [INFO] [stdout] 176 | let mut headers = header::HeaderMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | headers.insert("OCS-APIRequest", header::HeaderValue::from_static("true")); [INFO] [stdout] 178 | let builder = reqwest::ClientBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | builder.user_agent(&name).default_headers(headers) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ncsync_lib/src/setting.rs:294:12 [INFO] [stdout] | [INFO] [stdout] 285 | pub fn get_request_builder(&self, method: Method, url: Url) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 294 | Ok(req_client [INFO] [stdout] | ____________^ [INFO] [stdout] 295 | | .request(method, url) [INFO] [stdout] 296 | | .basic_auth(username, Some(password))) [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ncsync_lib/src/setting.rs:421:29 [INFO] [stdout] | [INFO] [stdout] 421 | .filter_map(|s| Regex::new(s).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ncsync_lib/src/setting.rs:427:29 [INFO] [stdout] | [INFO] [stdout] 427 | .filter_map(|s| Regex::new(s).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ncsync_lib/src/setting/readwrite.rs:172:8 [INFO] [stdout] | [INFO] [stdout] 165 | pub fn setting_from_toml(ncinfo_fp: P, localinfo_fp: Q) -> Result<(ClientHub, LocalInfo)> [INFO] [stdout] | ------------ --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | let hub = client_hub_from_toml(ncinfo_fp)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | let local_info = localinfo_from_toml(localinfo_fp)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | Ok((hub, local_info)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ncsync_lib` (lib) due to 8 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: struct `NCPath` is never constructed [INFO] [stdout] --> ncsync_lib/src/path.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 52 | pub struct NCPath<'a> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static `RE_PATHRESOLVE` is never used [INFO] [stdout] --> ncsync_lib/src/path.rs:57:8 [INFO] [stdout] | [INFO] [stdout] 57 | static RE_PATHRESOLVE: Lazy = [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `new`, `get_username`, and `resolve` are never used [INFO] [stdout] --> ncsync_lib/src/path.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 60 | impl<'a> NCPath<'a> { [INFO] [stdout] | ------------------- associated functions in this implementation [INFO] [stdout] 61 | pub fn new(path: impl AsRef, profile: &'a Profile) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 66 | pub fn get_username(target: &str) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 72 | pub fn resolve( [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_default_profile` and `get_mut_default_profile` are never used [INFO] [stdout] --> ncsync_lib/src/setting.rs:211:19 [INFO] [stdout] | [INFO] [stdout] 115 | impl ClientHub { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 211 | pub(crate) fn get_default_profile(&self) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 224 | pub(crate) fn get_mut_default_profile(&mut self) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ncsync_lib/src/path.rs:58:18 [INFO] [stdout] | [INFO] [stdout] 58 | Lazy::new(|| Regex::new(r"^(?P[^:]*):(?P.*)$").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ncsync_lib/src/setting.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 90 | method: Method, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | _ => return Err(anyhow!("not logged in")), [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | Ok(req_client [INFO] [stdout] | ____________^ [INFO] [stdout] 102 | | .request(method, url) [INFO] [stdout] 103 | | .basic_auth(username, Some(password))) [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ncsync_lib/src/setting.rs:188:9 [INFO] [stdout] | [INFO] [stdout] 176 | let mut headers = header::HeaderMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | headers.insert("OCS-APIRequest", header::HeaderValue::from_static("true")); [INFO] [stdout] 178 | let builder = reqwest::ClientBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | builder.user_agent(&name).default_headers(headers) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ncsync_lib/src/setting.rs:294:12 [INFO] [stdout] | [INFO] [stdout] 285 | pub fn get_request_builder(&self, method: Method, url: Url) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 294 | Ok(req_client [INFO] [stdout] | ____________^ [INFO] [stdout] 295 | | .request(method, url) [INFO] [stdout] 296 | | .basic_auth(username, Some(password))) [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ncsync_lib/src/setting.rs:421:29 [INFO] [stdout] | [INFO] [stdout] 421 | .filter_map(|s| Regex::new(s).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ncsync_lib/src/setting.rs:427:29 [INFO] [stdout] | [INFO] [stdout] 427 | .filter_map(|s| Regex::new(s).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ncsync_lib/src/setting/readwrite.rs:172:8 [INFO] [stdout] | [INFO] [stdout] 165 | pub fn setting_from_toml(ncinfo_fp: P, localinfo_fp: Q) -> Result<(ClientHub, LocalInfo)> [INFO] [stdout] | ------------ --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | let hub = client_hub_from_toml(ncinfo_fp)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | let local_info = localinfo_from_toml(localinfo_fp)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | Ok((hub, local_info)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ncsync_lib` (lib test) due to 8 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8316a9bda0163011013687fcb441ceeaf88292c03820f917c3a199f2afc4a0af", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8316a9bda0163011013687fcb441ceeaf88292c03820f917c3a199f2afc4a0af", kill_on_drop: false }` [INFO] [stdout] 8316a9bda0163011013687fcb441ceeaf88292c03820f917c3a199f2afc4a0af