[INFO] cloning repository https://github.com/annethereshewent/rustation [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/annethereshewent/rustation" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fannethereshewent%2Frustation", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fannethereshewent%2Frustation'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a1462bcf3b43d4750daeb8864abecd3a4ae33855 [INFO] checking annethereshewent/rustation/a1462bcf3b43d4750daeb8864abecd3a4ae33855 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fannethereshewent%2Frustation" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/annethereshewent/rustation on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/annethereshewent/rustation [INFO] finished tweaking git repo https://github.com/annethereshewent/rustation [INFO] tweaked toml for git repo https://github.com/annethereshewent/rustation written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/annethereshewent/rustation already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a9388a0ed9c05f424696404d6766d414ddfdb6367c12a57a7ea93d8d37f3d9df [INFO] running `Command { std: "docker" "start" "-a" "a9388a0ed9c05f424696404d6766d414ddfdb6367c12a57a7ea93d8d37f3d9df", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a9388a0ed9c05f424696404d6766d414ddfdb6367c12a57a7ea93d8d37f3d9df", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a9388a0ed9c05f424696404d6766d414ddfdb6367c12a57a7ea93d8d37f3d9df", kill_on_drop: false }` [INFO] [stdout] a9388a0ed9c05f424696404d6766d414ddfdb6367c12a57a7ea93d8d37f3d9df [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 00380aaba632fe38893a6db11a3f509228831771cf0b74d5633906a5e281b1a9 [INFO] running `Command { std: "docker" "start" "-a" "00380aaba632fe38893a6db11a3f509228831771cf0b74d5633906a5e281b1a9", kill_on_drop: false }` [INFO] [stderr] Checking rsx v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/cdrom.rs:1:65 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{rc::Rc, cell::Cell, collections::VecDeque, fs::{File, self}, io::{SeekFrom, Read, Seek}}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cmp` [INFO] [stdout] --> src/util/mod.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::cmp; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/cdrom.rs:1:65 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{rc::Rc, cell::Cell, collections::VecDeque, fs::{File, self}, io::{SeekFrom, Read, Seek}}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cmp` [INFO] [stdout] --> src/util/mod.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::cmp; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `is_wasm` [INFO] [stdout] --> src/cdrom.rs:237:110 [INFO] [stdout] | [INFO] [stdout] 237 | pub fn new(interrupts: Rc>, game_file: Option, game_bytes: Option>, is_wasm: bool) -> Self { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_is_wasm` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `reply` is never read [INFO] [stdout] --> src/controllers/memory_card.rs:127:13 [INFO] [stdout] | [INFO] [stdout] 127 | let mut reply = 0xff; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `reply` is never read [INFO] [stdout] --> src/controllers/memory_card.rs:157:13 [INFO] [stdout] | [INFO] [stdout] 157 | let mut reply = 0xff; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `reply` is never read [INFO] [stdout] --> src/controllers/memory_card.rs:228:13 [INFO] [stdout] | [INFO] [stdout] 228 | let mut reply = 0xff; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `EXP2_READ_ADDR` is never used [INFO] [stdout] --> src/cpu/bus.rs:10:7 [INFO] [stdout] | [INFO] [stdout] 10 | const EXP2_READ_ADDR: u32 = 0x1f802023; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `executed_commands` is never read [INFO] [stdout] --> src/gpu.rs:189:3 [INFO] [stdout] | [INFO] [stdout] 134 | pub struct GPU { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 189 | executed_commands: HashMap [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpu.rs:148:12 [INFO] [stdout] | [INFO] [stdout] 137 | pub fn new(bios: Vec, game_file: Option, game_bytes: Option>, is_wasm: bool) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | bus: Bus::new(bios, interrupts.clone(), dma.clone(), game_file, game_bytes, is_wasm), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpu/bus.rs:57:12 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn new(bios: Vec, interrupts: Rc>, dma: Rc>, game_file: Option, game_bytes: Option [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpu/bus.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn new(bios: Vec, interrupts: Rc>, dma: Rc>, game_file: Option, game_bytes: Option [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpu/bus.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn new(bios: Vec, interrupts: Rc>, dma: Rc>, game_file: Option, game_bytes: Option [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpu/bus.rs:61:14 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn new(bios: Vec, interrupts: Rc>, dma: Rc>, game_file: Option, game_bytes: Option [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpu/bus.rs:62:20 [INFO] [stdout] | [INFO] [stdout] 54 | ...b fn new(bios: Vec, interrupts: Rc>, dma: Rc>, game_file: Option, game_bytes: Option [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpu/bus.rs:70:19 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn new(bios: Vec, interrupts: Rc>, dma: Rc>, game_file: Option, game_bytes: Option [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controllers/memory_card.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 33 | let mut file = None; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | card: vec![0; MEMORY_CARD_SIZE].into_boxed_slice(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rsx` (lib test) due to 9 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `is_wasm` [INFO] [stdout] --> src/cdrom.rs:237:110 [INFO] [stdout] | [INFO] [stdout] 237 | pub fn new(interrupts: Rc>, game_file: Option, game_bytes: Option>, is_wasm: bool) -> Self { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_is_wasm` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `reply` is never read [INFO] [stdout] --> src/controllers/memory_card.rs:127:13 [INFO] [stdout] | [INFO] [stdout] 127 | let mut reply = 0xff; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `reply` is never read [INFO] [stdout] --> src/controllers/memory_card.rs:157:13 [INFO] [stdout] | [INFO] [stdout] 157 | let mut reply = 0xff; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `reply` is never read [INFO] [stdout] --> src/controllers/memory_card.rs:228:13 [INFO] [stdout] | [INFO] [stdout] 228 | let mut reply = 0xff; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `EXP2_READ_ADDR` is never used [INFO] [stdout] --> src/cpu/bus.rs:10:7 [INFO] [stdout] | [INFO] [stdout] 10 | const EXP2_READ_ADDR: u32 = 0x1f802023; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `executed_commands` is never read [INFO] [stdout] --> src/gpu.rs:189:3 [INFO] [stdout] | [INFO] [stdout] 134 | pub struct GPU { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 189 | executed_commands: HashMap [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpu.rs:148:12 [INFO] [stdout] | [INFO] [stdout] 137 | pub fn new(bios: Vec, game_file: Option, game_bytes: Option>, is_wasm: bool) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | bus: Bus::new(bios, interrupts.clone(), dma.clone(), game_file, game_bytes, is_wasm), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpu/bus.rs:57:12 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn new(bios: Vec, interrupts: Rc>, dma: Rc>, game_file: Option, game_bytes: Option [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpu/bus.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn new(bios: Vec, interrupts: Rc>, dma: Rc>, game_file: Option, game_bytes: Option [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpu/bus.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn new(bios: Vec, interrupts: Rc>, dma: Rc>, game_file: Option, game_bytes: Option [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpu/bus.rs:61:14 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn new(bios: Vec, interrupts: Rc>, dma: Rc>, game_file: Option, game_bytes: Option [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpu/bus.rs:62:20 [INFO] [stdout] | [INFO] [stdout] 54 | ...b fn new(bios: Vec, interrupts: Rc>, dma: Rc>, game_file: Option, game_bytes: Option [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpu/bus.rs:70:19 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn new(bios: Vec, interrupts: Rc>, dma: Rc>, game_file: Option, game_bytes: Option [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controllers/memory_card.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 33 | let mut file = None; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | card: vec![0; MEMORY_CARD_SIZE].into_boxed_slice(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rsx` (lib) due to 9 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "00380aaba632fe38893a6db11a3f509228831771cf0b74d5633906a5e281b1a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "00380aaba632fe38893a6db11a3f509228831771cf0b74d5633906a5e281b1a9", kill_on_drop: false }` [INFO] [stdout] 00380aaba632fe38893a6db11a3f509228831771cf0b74d5633906a5e281b1a9