[INFO] cloning repository https://github.com/anish-sinha1/symmetric-concurrent-v3 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/anish-sinha1/symmetric-concurrent-v3" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fanish-sinha1%2Fsymmetric-concurrent-v3", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fanish-sinha1%2Fsymmetric-concurrent-v3'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a345bc6ed960730c43e274c01dde098665fea645 [INFO] checking anish-sinha1/symmetric-concurrent-v3/a345bc6ed960730c43e274c01dde098665fea645 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fanish-sinha1%2Fsymmetric-concurrent-v3" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/anish-sinha1/symmetric-concurrent-v3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/anish-sinha1/symmetric-concurrent-v3 [INFO] finished tweaking git repo https://github.com/anish-sinha1/symmetric-concurrent-v3 [INFO] tweaked toml for git repo https://github.com/anish-sinha1/symmetric-concurrent-v3 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/anish-sinha1/symmetric-concurrent-v3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4f056643d76c5013eb9c8e100fc5d2cdef8f7f446df4abd5ab4cdf44ec45c79c [INFO] running `Command { std: "docker" "start" "-a" "4f056643d76c5013eb9c8e100fc5d2cdef8f7f446df4abd5ab4cdf44ec45c79c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4f056643d76c5013eb9c8e100fc5d2cdef8f7f446df4abd5ab4cdf44ec45c79c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4f056643d76c5013eb9c8e100fc5d2cdef8f7f446df4abd5ab4cdf44ec45c79c", kill_on_drop: false }` [INFO] [stdout] 4f056643d76c5013eb9c8e100fc5d2cdef8f7f446df4abd5ab4cdf44ec45c79c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a930263ae1d32188714d35f8e368213c46dea8ad27af84e0e03c3b817812deea [INFO] running `Command { std: "docker" "start" "-a" "a930263ae1d32188714d35f8e368213c46dea8ad27af84e0e03c3b817812deea", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.133 [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling unicode-ident v1.0.4 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling syn v1.0.100 [INFO] [stderr] Compiling crossbeam-utils v0.8.11 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling serde_derive v1.0.144 [INFO] [stderr] Checking once_cell v1.15.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.10 [INFO] [stderr] Compiling serde v1.0.144 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling rayon-core v1.9.3 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling lock_api v0.4.9 [INFO] [stderr] Compiling parking_lot_core v0.9.3 [INFO] [stderr] Compiling rayon v1.5.3 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Checking smallvec v1.9.0 [INFO] [stderr] Checking either v1.8.0 [INFO] [stderr] Checking iana-time-zone v0.1.48 [INFO] [stderr] Checking crossbeam-channel v0.5.6 [INFO] [stderr] Checking crossbeam-deque v0.8.2 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking positioned-io v0.3.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking chrono v0.4.22 [INFO] [stderr] Compiling darling_core v0.14.1 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling darling_macro v0.14.1 [INFO] [stderr] Compiling darling v0.14.1 [INFO] [stderr] Compiling serde_with_macros v2.0.1 [INFO] [stderr] Checking serde_with v2.0.1 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking serde_bytes v0.11.7 [INFO] [stderr] Checking symmetric-concurrent-v3 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `page` [INFO] [stdout] --> src/storage/bufmgr.rs:77:13 [INFO] [stdout] | [INFO] [stdout] 77 | let page = Page::new(page_id, &page_buf); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_page` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/bufmgr.rs:60:25 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn new(pool_size: usize, replacer_k: usize, diskmgr: DiskMgr) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let mut free_list_internal: LinkedList = LinkedList::new(); [INFO] [stdout] 49 | let mut frames_internal = Vec::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | page_table: Arc::new(parking_lot::RwLock::new(HashMap::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/bufmgr.rs:61:24 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn new(pool_size: usize, replacer_k: usize, diskmgr: DiskMgr) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let mut free_list_internal: LinkedList = LinkedList::new(); [INFO] [stdout] 49 | let mut frames_internal = Vec::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | free_list: Arc::new(parking_lot::RwLock::new(free_list_internal)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/bufmgr.rs:62:21 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn new(pool_size: usize, replacer_k: usize, diskmgr: DiskMgr) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let mut free_list_internal: LinkedList = LinkedList::new(); [INFO] [stdout] 49 | let mut frames_internal = Vec::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | frames: Arc::new(parking_lot::RwLock::new(frames_internal)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/storage/diskmgr.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | drop(self); [INFO] [stdout] | ^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&DiskMgrInternal` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 38 - drop(self); [INFO] [stdout] 38 + let _ = self; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `symmetric-concurrent-v3` (bin "symmetric-concurrent-v3") due to 4 previous errors; 2 warnings emitted [INFO] [stdout] warning: unused variable: `page` [INFO] [stdout] --> src/storage/bufmgr.rs:77:13 [INFO] [stdout] | [INFO] [stdout] 77 | let page = Page::new(page_id, &page_buf); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_page` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/bufmgr.rs:60:25 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn new(pool_size: usize, replacer_k: usize, diskmgr: DiskMgr) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let mut free_list_internal: LinkedList = LinkedList::new(); [INFO] [stdout] 49 | let mut frames_internal = Vec::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | page_table: Arc::new(parking_lot::RwLock::new(HashMap::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/bufmgr.rs:61:24 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn new(pool_size: usize, replacer_k: usize, diskmgr: DiskMgr) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let mut free_list_internal: LinkedList = LinkedList::new(); [INFO] [stdout] 49 | let mut frames_internal = Vec::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | free_list: Arc::new(parking_lot::RwLock::new(free_list_internal)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/bufmgr.rs:62:21 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn new(pool_size: usize, replacer_k: usize, diskmgr: DiskMgr) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let mut free_list_internal: LinkedList = LinkedList::new(); [INFO] [stdout] 49 | let mut frames_internal = Vec::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | frames: Arc::new(parking_lot::RwLock::new(frames_internal)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/storage/diskmgr.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | drop(self); [INFO] [stdout] | ^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&diskmgr::DiskMgrInternal` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 38 - drop(self); [INFO] [stdout] 38 + let _ = self; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `symmetric-concurrent-v3` (bin "symmetric-concurrent-v3" test) due to 4 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a930263ae1d32188714d35f8e368213c46dea8ad27af84e0e03c3b817812deea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a930263ae1d32188714d35f8e368213c46dea8ad27af84e0e03c3b817812deea", kill_on_drop: false }` [INFO] [stdout] a930263ae1d32188714d35f8e368213c46dea8ad27af84e0e03c3b817812deea