[INFO] cloning repository https://github.com/andygrn/flock [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/andygrn/flock" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fandygrn%2Fflock", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fandygrn%2Fflock'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 88b50285043c1d832908068be18cf00c0a14d8cd [INFO] checking andygrn/flock/88b50285043c1d832908068be18cf00c0a14d8cd against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fandygrn%2Fflock" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/andygrn/flock on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/andygrn/flock [INFO] finished tweaking git repo https://github.com/andygrn/flock [INFO] tweaked toml for git repo https://github.com/andygrn/flock written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/andygrn/flock already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ebe7c18eacdc7f32b19fe39edbb8329dcfb32be8c489e3b2956609157fb7509e [INFO] running `Command { std: "docker" "start" "-a" "ebe7c18eacdc7f32b19fe39edbb8329dcfb32be8c489e3b2956609157fb7509e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ebe7c18eacdc7f32b19fe39edbb8329dcfb32be8c489e3b2956609157fb7509e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ebe7c18eacdc7f32b19fe39edbb8329dcfb32be8c489e3b2956609157fb7509e", kill_on_drop: false }` [INFO] [stdout] ebe7c18eacdc7f32b19fe39edbb8329dcfb32be8c489e3b2956609157fb7509e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5b24da3790150c6b9a10c962849122df1feadba330f7c12c222c990407caffd8 [INFO] running `Command { std: "docker" "start" "-a" "5b24da3790150c6b9a10c962849122df1feadba330f7c12c222c990407caffd8", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking libc v0.2.34 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Compiling rayon-core v1.3.0 [INFO] [stderr] Checking either v1.4.0 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Checking atom v0.3.4 [INFO] [stderr] Checking nodrop v0.1.12 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Checking odds v0.2.26 [INFO] [stderr] Checking coco v0.1.1 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking smallvec v0.4.4 [INFO] [stderr] Compiling itertools v0.5.10 [INFO] [stderr] Checking mopa v0.2.2 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Compiling syn v0.10.8 [INFO] [stderr] Checking num-traits v0.1.41 [INFO] [stderr] Checking crossbeam v0.3.0 [INFO] [stderr] Checking tuple_utils v0.2.0 [INFO] [stderr] Checking arrayvec v0.3.24 [INFO] [stderr] Checking rand v0.3.18 [INFO] [stderr] Checking num_cpus v1.7.0 [INFO] [stderr] Checking time v0.1.38 [INFO] [stderr] Checking termion v1.5.1 [INFO] [stderr] Checking pulse v0.5.3 [INFO] [stderr] Checking noise v0.4.1 [INFO] [stderr] Compiling shred-derive v0.3.0 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Compiling derivative v1.0.0 [INFO] [stderr] Checking hibitset v0.3.2 [INFO] [stderr] Checking shred v0.5.0 [INFO] [stderr] Checking specs v0.10.0 [INFO] [stderr] Checking flock v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/renderable.rs:10:26 [INFO] [stdout] | [INFO] [stdout] 10 | fn render_map(&self, &TileMap, &TileMapView, &Player, &f32); [INFO] [stdout] | ^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &TileMap` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] = note: `#[warn(anonymous_parameters)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/renderable.rs:10:36 [INFO] [stdout] | [INFO] [stdout] 10 | fn render_map(&self, &TileMap, &TileMapView, &Player, &f32); [INFO] [stdout] | ^^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &TileMapView` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/renderable.rs:10:50 [INFO] [stdout] | [INFO] [stdout] 10 | fn render_map(&self, &TileMap, &TileMapView, &Player, &f32); [INFO] [stdout] | ^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &Player` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/renderable.rs:10:59 [INFO] [stdout] | [INFO] [stdout] 10 | fn render_map(&self, &TileMap, &TileMapView, &Player, &f32); [INFO] [stdout] | ^^^^ help: try naming the parameter or explicitly ignoring it: `_: &f32` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/renderable.rs:11:28 [INFO] [stdout] | [INFO] [stdout] 11 | fn render_world(&self, &World); [INFO] [stdout] | ^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &World` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/terminal_renderer.rs:24:19 [INFO] [stdout] | [INFO] [stdout] 24 | pub char_gen: (fn(f32, f32) -> char), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 24 - pub char_gen: (fn(f32, f32) -> char), [INFO] [stdout] 24 + pub char_gen: fn(f32, f32) -> char, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/terminal_renderer.rs:31:19 [INFO] [stdout] | [INFO] [stdout] 31 | char_gen: (fn(f32, f32) -> char), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 31 - char_gen: (fn(f32, f32) -> char), [INFO] [stdout] 31 + char_gen: fn(f32, f32) -> char, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/renderable.rs:10:26 [INFO] [stdout] | [INFO] [stdout] 10 | fn render_map(&self, &TileMap, &TileMapView, &Player, &f32); [INFO] [stdout] | ^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &TileMap` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] = note: `#[warn(anonymous_parameters)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/renderable.rs:10:36 [INFO] [stdout] | [INFO] [stdout] 10 | fn render_map(&self, &TileMap, &TileMapView, &Player, &f32); [INFO] [stdout] | ^^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &TileMapView` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/renderable.rs:10:50 [INFO] [stdout] | [INFO] [stdout] 10 | fn render_map(&self, &TileMap, &TileMapView, &Player, &f32); [INFO] [stdout] | ^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &Player` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/renderable.rs:10:59 [INFO] [stdout] | [INFO] [stdout] 10 | fn render_map(&self, &TileMap, &TileMapView, &Player, &f32); [INFO] [stdout] | ^^^^ help: try naming the parameter or explicitly ignoring it: `_: &f32` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/renderable.rs:11:28 [INFO] [stdout] | [INFO] [stdout] 11 | fn render_world(&self, &World); [INFO] [stdout] | ^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &World` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/terminal_renderer.rs:24:19 [INFO] [stdout] | [INFO] [stdout] 24 | pub char_gen: (fn(f32, f32) -> char), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 24 - pub char_gen: (fn(f32, f32) -> char), [INFO] [stdout] 24 + pub char_gen: fn(f32, f32) -> char, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/terminal_renderer.rs:31:19 [INFO] [stdout] | [INFO] [stdout] 31 | char_gen: (fn(f32, f32) -> char), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 31 - char_gen: (fn(f32, f32) -> char), [INFO] [stdout] 31 + char_gen: fn(f32, f32) -> char, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `text` is never read [INFO] [stdout] --> src/ecs_entities.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Utterance { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 6 | // utterer: &Entity, [INFO] [stdout] 7 | pub text: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Utterance` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `text` is never read [INFO] [stdout] --> src/ecs_entities.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Utterance { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 6 | // utterer: &Entity, [INFO] [stdout] 7 | pub text: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Utterance` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/terminal_renderer.rs:50:21 [INFO] [stdout] | [INFO] [stdout] 48 | let output = std::io::stdout().into_raw_mode().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Renderer { [INFO] [stdout] 50 | stdout: RefCell::new(output), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/terminal_renderer.rs:50:21 [INFO] [stdout] | [INFO] [stdout] 48 | let output = std::io::stdout().into_raw_mode().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Renderer { [INFO] [stdout] 50 | stdout: RefCell::new(output), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `flock` (bin "flock" test) due to 2 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `flock` (bin "flock") due to 2 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5b24da3790150c6b9a10c962849122df1feadba330f7c12c222c990407caffd8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5b24da3790150c6b9a10c962849122df1feadba330f7c12c222c990407caffd8", kill_on_drop: false }` [INFO] [stdout] 5b24da3790150c6b9a10c962849122df1feadba330f7c12c222c990407caffd8