[INFO] cloning repository https://github.com/andy128k/einstein [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/andy128k/einstein" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fandy128k%2Feinstein", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fandy128k%2Feinstein'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] fb8cd961e215299e3c81c01b4b1c9fca33d9b379 [INFO] checking andy128k/einstein/fb8cd961e215299e3c81c01b4b1c9fca33d9b379 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fandy128k%2Feinstein" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/andy128k/einstein on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/andy128k/einstein [INFO] finished tweaking git repo https://github.com/andy128k/einstein [INFO] tweaked toml for git repo https://github.com/andy128k/einstein written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/andy128k/einstein already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8b9e21244131af39e6338b245062e5d9490c834690c97bf502b633ecfb49b363 [INFO] running `Command { std: "docker" "start" "-a" "8b9e21244131af39e6338b245062e5d9490c834690c97bf502b633ecfb49b363", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8b9e21244131af39e6338b245062e5d9490c834690c97bf502b633ecfb49b363", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8b9e21244131af39e6338b245062e5d9490c834690c97bf502b633ecfb49b363", kill_on_drop: false }` [INFO] [stdout] 8b9e21244131af39e6338b245062e5d9490c834690c97bf502b633ecfb49b363 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3aecf1f71fb82c8ef6a0b4c3668ab721852189b70bc6edd458fc3acb6f9bfdf0 [INFO] running `Command { std: "docker" "start" "-a" "3aecf1f71fb82c8ef6a0b4c3668ab721852189b70bc6edd458fc3acb6f9bfdf0", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.150 [INFO] [stderr] Compiling proc-macro2 v1.0.70 [INFO] [stderr] Compiling serde v1.0.193 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling version-compare v0.1.1 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Compiling sdl2 v0.36.0 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling serde_json v1.0.108 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Compiling palette v0.7.3 [INFO] [stderr] Compiling sdl2-sys v0.36.0 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Checking str_indices v0.4.3 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking fast-srgb8 v1.0.0 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking never v0.1.0 [INFO] [stderr] Checking ropey v1.6.1 [INFO] [stderr] Checking object v0.32.1 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling backtrace v0.3.69 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking debug-cell v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Compiling phf_macros v0.11.2 [INFO] [stderr] Compiling palette_derive v0.7.3 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking einstein-puzzle v3.0.0 (/opt/rustwide/workdir/einstein-puzzle) [INFO] [stderr] Checking einstein-visuals v0.1.0 (/opt/rustwide/workdir/einstein-visuals) [INFO] [stderr] Checking einstein v3.0.0 (/opt/rustwide/workdir/einstein) [INFO] [stdout] warning: fields `anonymous`, `save_error`, `loading`, and `enable_sound` are never read [INFO] [stdout] --> einstein/src/resources/messages/base.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 1 | pub struct Messages<'a> { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 18 | pub anonymous: &'a str, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 23 | pub save_error: &'a str, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 34 | pub loading: &'a str, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 35 | pub einstein_flowix: &'a str, [INFO] [stdout] 36 | pub enable_sound: &'a str, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `contains` is never used [INFO] [stdout] --> einstein/src/ui/common.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 56 | impl Size { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 70 | pub fn contains(self, x: i32, y: i32) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Top` and `Bottom` are never constructed [INFO] [stdout] --> einstein/src/ui/common.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 83 | pub enum VerticalAlign { [INFO] [stdout] | ------------- variants in this enum [INFO] [stdout] 84 | Top, [INFO] [stdout] | ^^^ [INFO] [stdout] 85 | Middle, [INFO] [stdout] 86 | Bottom, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `VerticalAlign` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/dialog/mod.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 40 | background: B, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | widget: W, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | Container::::modal(screen, background).add(x, y, widget) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/dialog/mod.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn cond_dialog(condition: &Rc>>, factory: F) -> impl Widget [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let condition2 = condition.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | ConditionalWidget::new(condition.clone(), factory).flat_map_action(move |action, _| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/dialog/mod.rs:58:72 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn cond_dialog(condition: &Rc>>, factory: F) -> impl Widget [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let condition2 = condition.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | ConditionalWidget::new(condition.clone(), factory).flat_map_action(move |action, _| { [INFO] [stdout] | ________________________________________________________________________^ [INFO] [stdout] 59 | | *condition2.borrow_mut() = None; [INFO] [stdout] 60 | | Ok(EventReaction::action(action.clone())) [INFO] [stdout] 61 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/dialog/mod.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 57 | let condition2 = condition.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | Ok(EventReaction::action(action.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `anonymous`, `save_error`, `loading`, and `enable_sound` are never read [INFO] [stdout] --> einstein/src/resources/messages/base.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 1 | pub struct Messages<'a> { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 18 | pub anonymous: &'a str, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 23 | pub save_error: &'a str, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 34 | pub loading: &'a str, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 35 | pub einstein_flowix: &'a str, [INFO] [stdout] 36 | pub enable_sound: &'a str, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `contains` is never used [INFO] [stdout] --> einstein/src/ui/common.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 56 | impl Size { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 70 | pub fn contains(self, x: i32, y: i32) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Top` and `Bottom` are never constructed [INFO] [stdout] --> einstein/src/ui/common.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 83 | pub enum VerticalAlign { [INFO] [stdout] | ------------- variants in this enum [INFO] [stdout] 84 | Top, [INFO] [stdout] | ^^^ [INFO] [stdout] 85 | Middle, [INFO] [stdout] 86 | Bottom, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `VerticalAlign` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:111:12 [INFO] [stdout] | [INFO] [stdout] 111 | Ok(Rc::new(RefCell::new(GamePrivate { [INFO] [stdout] | ____________^ [INFO] [stdout] 112 | | solved_puzzle, [INFO] [stdout] 113 | | rules, [INFO] [stdout] 114 | | possibilities, [INFO] [stdout] ... | [INFO] [stdout] 123 | | hinted: false, [INFO] [stdout] 124 | | }))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:219:5 [INFO] [stdout] | [INFO] [stdout] 218 | let container = Container::container(Size::new(308, 70), None, None); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | / GridBuilder::new(container, 3, 2) [INFO] [stdout] 220 | | .add( [INFO] [stdout] 221 | | 0, [INFO] [stdout] 222 | | 0, [INFO] [stdout] ... | [INFO] [stdout] 240 | | ) [INFO] [stdout] 241 | | .add(2, 1, new_game_button(messages.help, &[], MenuAction::Help)) [INFO] [stdout] | |_________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:271:9 [INFO] [stdout] | [INFO] [stdout] 268 | let state2 = state.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 271 | new_puzzle_widget(&state).flat_map_action(move |puzzle_action, context| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:271:51 [INFO] [stdout] | [INFO] [stdout] 268 | let state2 = state.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 271 | new_puzzle_widget(&state).flat_map_action(move |puzzle_action, context| { [INFO] [stdout] | ___________________________________________________^ [INFO] [stdout] 272 | | let score = state2.borrow_mut().stop(); [INFO] [stdout] 273 | | match *puzzle_action { [INFO] [stdout] 274 | | PuzzleAction::Victory => { [INFO] [stdout] ... | [INFO] [stdout] 289 | | Ok(EventReaction::update()) [INFO] [stdout] 290 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:310:9 [INFO] [stdout] | [INFO] [stdout] 305 | let this_state = state.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | make_game_menu(messages).flat_map_action(move |menu_action, _| match menu_action { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:310:50 [INFO] [stdout] | [INFO] [stdout] 305 | let this_state = state.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | make_game_menu(messages).flat_map_action(move |menu_action, _| match menu_action { [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 311 | | MenuAction::Pause => { [INFO] [stdout] 312 | | this_state.borrow_mut().stop(); [INFO] [stdout] 313 | | *pause_trigger2.borrow_mut() = Some(()); [INFO] [stdout] ... | [INFO] [stdout] 335 | | } [INFO] [stdout] 336 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:342:9 [INFO] [stdout] | [INFO] [stdout] 340 | let this_state1 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 341 | let this_state2 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 342 | / cond_dialog(&pause_trigger, move |_| { [INFO] [stdout] 343 | | game_popup_background(messages, &this_state1).add(0, 0, new_pause_dialog(messages)) [INFO] [stdout] 344 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:345:26 [INFO] [stdout] | [INFO] [stdout] 340 | let this_state1 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 341 | let this_state2 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 345 | .flat_map_action(move |_, _| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 346 | | this_state2.borrow_mut().start(); [INFO] [stdout] 347 | | Ok(EventReaction::empty()) [INFO] [stdout] 348 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:354:9 [INFO] [stdout] | [INFO] [stdout] 352 | let this_state1 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 353 | let this_state2 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 354 | / cond_dialog(&show_help_trigger, move |_| { [INFO] [stdout] 355 | | game_popup_background(messages, &this_state1).add(0, 0, new_help_dialog(messages)) [INFO] [stdout] 356 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:357:26 [INFO] [stdout] | [INFO] [stdout] 352 | let this_state1 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 353 | let this_state2 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 357 | .flat_map_action(move |_, _| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 358 | | this_state2.borrow_mut().start(); [INFO] [stdout] 359 | | Ok(EventReaction::empty()) [INFO] [stdout] 360 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:368:9 [INFO] [stdout] | [INFO] [stdout] 364 | let storage1 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 365 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 366 | let this_state1 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 367 | let this_state2 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 368 | / cond_dialog(&show_opts_trigger, move |_| { [INFO] [stdout] 369 | | game_popup_background(messages, &this_state1).add( [INFO] [stdout] 370 | | 0, [INFO] [stdout] 371 | | 0, [INFO] [stdout] 372 | | new_options_dialog(&storage1.borrow(), messages), [INFO] [stdout] 373 | | ) [INFO] [stdout] 374 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/dialog/mod.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 40 | background: B, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | widget: W, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | Container::::modal(screen, background).add(x, y, widget) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:375:26 [INFO] [stdout] | [INFO] [stdout] 364 | let storage1 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 365 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 366 | let this_state1 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 367 | let this_state2 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 375 | .flat_map_action(move |result, context| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 376 | | this_state2.borrow_mut().start(); [INFO] [stdout] 377 | | match *result { [INFO] [stdout] 378 | | DialogResult::Ok(ref options) => { [INFO] [stdout] ... | [INFO] [stdout] 386 | | Ok(EventReaction::empty()) [INFO] [stdout] 387 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:395:9 [INFO] [stdout] | [INFO] [stdout] 391 | let storage1 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 392 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 393 | let state1 = state.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 394 | let this_state = state.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 395 | / cond_dialog(&save_game_trigger, move |_| { [INFO] [stdout] 396 | | game_popup_background(messages, &state1).add( [INFO] [stdout] 397 | | 0, [INFO] [stdout] 398 | | 0, [INFO] [stdout] 399 | | new_save_game_dialog(&storage1.borrow().saved_games, messages), [INFO] [stdout] 400 | | ) [INFO] [stdout] 401 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/dialog/mod.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn cond_dialog(condition: &Rc>>, factory: F) -> impl Widget [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let condition2 = condition.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | ConditionalWidget::new(condition.clone(), factory).flat_map_action(move |action, _| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/dialog/mod.rs:58:72 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn cond_dialog(condition: &Rc>>, factory: F) -> impl Widget [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let condition2 = condition.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | ConditionalWidget::new(condition.clone(), factory).flat_map_action(move |action, _| { [INFO] [stdout] | ________________________________________________________________________^ [INFO] [stdout] 59 | | *condition2.borrow_mut() = None; [INFO] [stdout] 60 | | Ok(EventReaction::action(action.clone())) [INFO] [stdout] 61 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:402:26 [INFO] [stdout] | [INFO] [stdout] 391 | let storage1 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 392 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 393 | let state1 = state.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 394 | let this_state = state.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 402 | .flat_map_action(move |result, _| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 403 | | match *result { [INFO] [stdout] 404 | | DialogResult::Ok((index, ref name)) => { [INFO] [stdout] 405 | | storage2.borrow_mut().saved_games[index] = Some(SavedGame { [INFO] [stdout] ... | [INFO] [stdout] 413 | | Ok(EventReaction::empty()) [INFO] [stdout] 414 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/dialog/mod.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 57 | let condition2 = condition.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | Ok(EventReaction::action(action.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:421:9 [INFO] [stdout] | [INFO] [stdout] 420 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 421 | / cond_dialog(&victory_trigger, move |score| { [INFO] [stdout] 422 | | let score = *score; [INFO] [stdout] 423 | | create_message_dialog(DialogTheme::White, messages.won).map_action(move |_| score) [INFO] [stdout] 424 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:425:26 [INFO] [stdout] | [INFO] [stdout] 420 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 425 | .flat_map_action(move |score, _| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 426 | | if let Some(score) = score.filter(|score| storage2.borrow().scores.is_deserving(*score)) [INFO] [stdout] 427 | | { [INFO] [stdout] 428 | | *save_score_trigger2.borrow_mut() = Some(score); [INFO] [stdout] ... | [INFO] [stdout] 432 | | Ok(EventReaction::update()) [INFO] [stdout] 433 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:111:12 [INFO] [stdout] | [INFO] [stdout] 111 | Ok(Rc::new(RefCell::new(GamePrivate { [INFO] [stdout] | ____________^ [INFO] [stdout] 112 | | solved_puzzle, [INFO] [stdout] 113 | | rules, [INFO] [stdout] 114 | | possibilities, [INFO] [stdout] ... | [INFO] [stdout] 123 | | hinted: false, [INFO] [stdout] 124 | | }))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:440:9 [INFO] [stdout] | [INFO] [stdout] 438 | let storage1 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 439 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 440 | / cond_dialog(&save_score_trigger, move |score| { [INFO] [stdout] 441 | | let score = *score; [INFO] [stdout] 442 | | let last_name = match storage1.borrow().last_name { [INFO] [stdout] 443 | | Some(ref n) => n.clone(), [INFO] [stdout] ... | [INFO] [stdout] 447 | | .map_action(move |name| (name.to_string(), score)) [INFO] [stdout] 448 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:219:5 [INFO] [stdout] | [INFO] [stdout] 218 | let container = Container::container(Size::new(308, 70), None, None); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | / GridBuilder::new(container, 3, 2) [INFO] [stdout] 220 | | .add( [INFO] [stdout] 221 | | 0, [INFO] [stdout] 222 | | 0, [INFO] [stdout] ... | [INFO] [stdout] 240 | | ) [INFO] [stdout] 241 | | .add(2, 1, new_game_button(messages.help, &[], MenuAction::Help)) [INFO] [stdout] | |_________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:449:26 [INFO] [stdout] | [INFO] [stdout] 438 | let storage1 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 439 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 449 | .flat_map_action(move |(name, score), _| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 450 | | storage2.borrow_mut().last_name = Some(name.to_string()); [INFO] [stdout] 451 | | let pos = storage2.borrow_mut().scores.add_score_entry(Score { [INFO] [stdout] 452 | | name: name.to_string(), [INFO] [stdout] ... | [INFO] [stdout] 456 | | Ok(EventReaction::empty()) [INFO] [stdout] 457 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:462:9 [INFO] [stdout] | [INFO] [stdout] 461 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 462 | / cond_dialog(&show_scores_trigger, move |index| { [INFO] [stdout] 463 | | create_topscores_dialog(&storage2.borrow().scores, messages, *index) [INFO] [stdout] 464 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:271:9 [INFO] [stdout] | [INFO] [stdout] 268 | let state2 = state.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 271 | new_puzzle_widget(&state).flat_map_action(move |puzzle_action, context| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:470:9 [INFO] [stdout] | [INFO] [stdout] 469 | let state2 = state.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 470 | cond_dialog(&failure_trigger, move |_| new_failure_dialog(messages)).flat_map_action( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:471:13 [INFO] [stdout] | [INFO] [stdout] 469 | let state2 = state.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 470 | cond_dialog(&failure_trigger, move |_| new_failure_dialog(messages)).flat_map_action( [INFO] [stdout] 471 | / move |result, _| match *result { [INFO] [stdout] 472 | | FailureChoice::StartNew => { [INFO] [stdout] 473 | | let g = GamePrivate::new().unwrap(); [INFO] [stdout] 474 | | *state2.borrow_mut() = g.borrow().clone(); [INFO] [stdout] ... | [INFO] [stdout] 481 | | FailureChoice::Cancel => Ok(EventReaction::action(())), [INFO] [stdout] 482 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:343:13 [INFO] [stdout] | [INFO] [stdout] 340 | let this_state1 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | game_popup_background(messages, &this_state1).add(0, 0, new_pause_dialog(messages)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:271:51 [INFO] [stdout] | [INFO] [stdout] 268 | let state2 = state.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 271 | new_puzzle_widget(&state).flat_map_action(move |puzzle_action, context| { [INFO] [stdout] | ___________________________________________________^ [INFO] [stdout] 272 | | let score = state2.borrow_mut().stop(); [INFO] [stdout] 273 | | match *puzzle_action { [INFO] [stdout] 274 | | PuzzleAction::Victory => { [INFO] [stdout] ... | [INFO] [stdout] 289 | | Ok(EventReaction::update()) [INFO] [stdout] 290 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:343:69 [INFO] [stdout] | [INFO] [stdout] 340 | let this_state1 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | game_popup_background(messages, &this_state1).add(0, 0, new_pause_dialog(messages)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:310:9 [INFO] [stdout] | [INFO] [stdout] 305 | let this_state = state.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | make_game_menu(messages).flat_map_action(move |menu_action, _| match menu_action { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:355:13 [INFO] [stdout] | [INFO] [stdout] 352 | let this_state1 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 355 | game_popup_background(messages, &this_state1).add(0, 0, new_help_dialog(messages)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:355:69 [INFO] [stdout] | [INFO] [stdout] 352 | let this_state1 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 355 | game_popup_background(messages, &this_state1).add(0, 0, new_help_dialog(messages)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:310:50 [INFO] [stdout] | [INFO] [stdout] 305 | let this_state = state.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | make_game_menu(messages).flat_map_action(move |menu_action, _| match menu_action { [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 311 | | MenuAction::Pause => { [INFO] [stdout] 312 | | this_state.borrow_mut().stop(); [INFO] [stdout] 313 | | *pause_trigger2.borrow_mut() = Some(()); [INFO] [stdout] ... | [INFO] [stdout] 335 | | } [INFO] [stdout] 336 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:369:13 [INFO] [stdout] | [INFO] [stdout] 364 | let storage1 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 365 | let storage2 = storage.clone(); [INFO] [stdout] 366 | let this_state1 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 369 | game_popup_background(messages, &this_state1).add( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:342:9 [INFO] [stdout] | [INFO] [stdout] 340 | let this_state1 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 341 | let this_state2 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 342 | / cond_dialog(&pause_trigger, move |_| { [INFO] [stdout] 343 | | game_popup_background(messages, &this_state1).add(0, 0, new_pause_dialog(messages)) [INFO] [stdout] 344 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:372:17 [INFO] [stdout] | [INFO] [stdout] 364 | let storage1 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 365 | let storage2 = storage.clone(); [INFO] [stdout] 366 | let this_state1 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 372 | new_options_dialog(&storage1.borrow(), messages), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:396:13 [INFO] [stdout] | [INFO] [stdout] 391 | let storage1 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 392 | let storage2 = storage.clone(); [INFO] [stdout] 393 | let state1 = state.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 396 | game_popup_background(messages, &state1).add( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:399:17 [INFO] [stdout] | [INFO] [stdout] 391 | let storage1 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 392 | let storage2 = storage.clone(); [INFO] [stdout] 393 | let state1 = state.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 399 | new_save_game_dialog(&storage1.borrow().saved_games, messages), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:426:55 [INFO] [stdout] | [INFO] [stdout] 426 | if let Some(score) = score.filter(|score| storage2.borrow().scores.is_deserving(*score)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:345:26 [INFO] [stdout] | [INFO] [stdout] 340 | let this_state1 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 341 | let this_state2 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 345 | .flat_map_action(move |_, _| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 346 | | this_state2.borrow_mut().start(); [INFO] [stdout] 347 | | Ok(EventReaction::empty()) [INFO] [stdout] 348 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:446:13 [INFO] [stdout] | [INFO] [stdout] 438 | let storage1 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 446 | new_player_name_dialog(&last_name, messages) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:463:38 [INFO] [stdout] | [INFO] [stdout] 461 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 462 | cond_dialog(&show_scores_trigger, move |index| { [INFO] [stdout] 463 | create_topscores_dialog(&storage2.borrow().scores, messages, *index) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:354:9 [INFO] [stdout] | [INFO] [stdout] 352 | let this_state1 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 353 | let this_state2 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 354 | / cond_dialog(&show_help_trigger, move |_| { [INFO] [stdout] 355 | | game_popup_background(messages, &this_state1).add(0, 0, new_help_dialog(messages)) [INFO] [stdout] 356 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/menu/mod.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 71 | let new_game_trigger2 = new_game_trigger.clone(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | / GridBuilder::new(Container::container(Size::new(220, 210), None, None), 1, 7) [INFO] [stdout] 78 | | .add( [INFO] [stdout] 79 | | 0, [INFO] [stdout] 80 | | 0, [INFO] [stdout] ... | [INFO] [stdout] 147 | | ) [INFO] [stdout] 148 | | .build() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:357:26 [INFO] [stdout] | [INFO] [stdout] 352 | let this_state1 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 353 | let this_state2 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 357 | .flat_map_action(move |_, _| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 358 | | this_state2.borrow_mut().start(); [INFO] [stdout] 359 | | Ok(EventReaction::empty()) [INFO] [stdout] 360 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:368:9 [INFO] [stdout] | [INFO] [stdout] 364 | let storage1 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 365 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 366 | let this_state1 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 367 | let this_state2 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 368 | / cond_dialog(&show_opts_trigger, move |_| { [INFO] [stdout] 369 | | game_popup_background(messages, &this_state1).add( [INFO] [stdout] 370 | | 0, [INFO] [stdout] 371 | | 0, [INFO] [stdout] 372 | | new_options_dialog(&storage1.borrow(), messages), [INFO] [stdout] 373 | | ) [INFO] [stdout] 374 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/menu/mod.rs:149:30 [INFO] [stdout] | [INFO] [stdout] 71 | let new_game_trigger2 = new_game_trigger.clone(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | .flat_map_action(move |menu_action, _| match menu_action { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 150 | | MainMenuAction::NewGame => { [INFO] [stdout] 151 | | let game = GamePrivate::new().unwrap(); [INFO] [stdout] 152 | | *new_game_trigger2.borrow_mut() = Some(game); [INFO] [stdout] ... | [INFO] [stdout] 175 | | MainMenuAction::Exit => Ok(EventReaction::action(MainLoopQuit)), [INFO] [stdout] 176 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:375:26 [INFO] [stdout] | [INFO] [stdout] 364 | let storage1 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 365 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 366 | let this_state1 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 367 | let this_state2 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 375 | .flat_map_action(move |result, context| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 376 | | this_state2.borrow_mut().start(); [INFO] [stdout] 377 | | match *result { [INFO] [stdout] 378 | | DialogResult::Ok(ref options) => { [INFO] [stdout] ... | [INFO] [stdout] 386 | | Ok(EventReaction::empty()) [INFO] [stdout] 387 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:395:9 [INFO] [stdout] | [INFO] [stdout] 391 | let storage1 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 392 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 393 | let state1 = state.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 394 | let this_state = state.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 395 | / cond_dialog(&save_game_trigger, move |_| { [INFO] [stdout] 396 | | game_popup_background(messages, &state1).add( [INFO] [stdout] 397 | | 0, [INFO] [stdout] 398 | | 0, [INFO] [stdout] 399 | | new_save_game_dialog(&storage1.borrow().saved_games, messages), [INFO] [stdout] 400 | | ) [INFO] [stdout] 401 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/menu/mod.rs:181:9 [INFO] [stdout] | [INFO] [stdout] 180 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | / cond_dialog(&new_game_trigger, move |game| { [INFO] [stdout] 182 | | game.borrow_mut().start(); [INFO] [stdout] 183 | | new_game_widget(storage2.clone(), game.clone(), messages) [INFO] [stdout] 184 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/menu/mod.rs:191:9 [INFO] [stdout] | [INFO] [stdout] 189 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | let new_game_trigger2 = new_game_trigger.clone(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | / cond_dialog(&load_game_trigger, move |_| { [INFO] [stdout] 192 | | new_load_game_dialog(&storage2.borrow().saved_games, messages) [INFO] [stdout] 193 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:402:26 [INFO] [stdout] | [INFO] [stdout] 391 | let storage1 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 392 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 393 | let state1 = state.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 394 | let this_state = state.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 402 | .flat_map_action(move |result, _| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 403 | | match *result { [INFO] [stdout] 404 | | DialogResult::Ok((index, ref name)) => { [INFO] [stdout] 405 | | storage2.borrow_mut().saved_games[index] = Some(SavedGame { [INFO] [stdout] ... | [INFO] [stdout] 413 | | Ok(EventReaction::empty()) [INFO] [stdout] 414 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/menu/mod.rs:194:26 [INFO] [stdout] | [INFO] [stdout] 189 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | let new_game_trigger2 = new_game_trigger.clone(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | .flat_map_action(move |result, _| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 195 | | match *result { [INFO] [stdout] 196 | | DialogResult::Ok(ref game_data) => { [INFO] [stdout] 197 | | let game = Rc::new(RefCell::new(game_data.clone())); [INFO] [stdout] ... | [INFO] [stdout] 203 | | Ok(EventReaction::empty()) [INFO] [stdout] 204 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/menu/mod.rs:209:9 [INFO] [stdout] | [INFO] [stdout] 208 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | / cond_dialog(&show_scores_trigger, move |_| { [INFO] [stdout] 210 | | create_topscores_dialog(&storage2.borrow().scores, messages, None) [INFO] [stdout] 211 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/menu/mod.rs:224:9 [INFO] [stdout] | [INFO] [stdout] 222 | let storage1 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | / cond_dialog(&show_opts_trigger, move |_| { [INFO] [stdout] 225 | | new_options_dialog(&storage1.borrow(), messages) [INFO] [stdout] 226 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:421:9 [INFO] [stdout] | [INFO] [stdout] 420 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 421 | / cond_dialog(&victory_trigger, move |score| { [INFO] [stdout] 422 | | let score = *score; [INFO] [stdout] 423 | | create_message_dialog(DialogTheme::White, messages.won).map_action(move |_| score) [INFO] [stdout] 424 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/menu/mod.rs:227:26 [INFO] [stdout] | [INFO] [stdout] 222 | let storage1 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | .flat_map_action(move |result, context| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 228 | | match *result { [INFO] [stdout] 229 | | DialogResult::Ok(ref options) => { [INFO] [stdout] 230 | | storage2.borrow_mut().fullscreen = options.fullscreen; [INFO] [stdout] ... | [INFO] [stdout] 237 | | Ok(EventReaction::empty()) [INFO] [stdout] 238 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:425:26 [INFO] [stdout] | [INFO] [stdout] 420 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 425 | .flat_map_action(move |score, _| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 426 | | if let Some(score) = score.filter(|score| storage2.borrow().scores.is_deserving(*score)) [INFO] [stdout] 427 | | { [INFO] [stdout] 428 | | *save_score_trigger2.borrow_mut() = Some(score); [INFO] [stdout] ... | [INFO] [stdout] 432 | | Ok(EventReaction::update()) [INFO] [stdout] 433 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/menu/mod.rs:183:29 [INFO] [stdout] | [INFO] [stdout] 180 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | new_game_widget(storage2.clone(), game.clone(), messages) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:440:9 [INFO] [stdout] | [INFO] [stdout] 438 | let storage1 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 439 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 440 | / cond_dialog(&save_score_trigger, move |score| { [INFO] [stdout] 441 | | let score = *score; [INFO] [stdout] 442 | | let last_name = match storage1.borrow().last_name { [INFO] [stdout] 443 | | Some(ref n) => n.clone(), [INFO] [stdout] ... | [INFO] [stdout] 447 | | .map_action(move |name| (name.to_string(), score)) [INFO] [stdout] 448 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/menu/mod.rs:183:47 [INFO] [stdout] | [INFO] [stdout] 180 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | new_game_widget(storage2.clone(), game.clone(), messages) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/menu/mod.rs:192:35 [INFO] [stdout] | [INFO] [stdout] 189 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 192 | new_load_game_dialog(&storage2.borrow().saved_games, messages) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:449:26 [INFO] [stdout] | [INFO] [stdout] 438 | let storage1 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 439 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 449 | .flat_map_action(move |(name, score), _| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 450 | | storage2.borrow_mut().last_name = Some(name.to_string()); [INFO] [stdout] 451 | | let pos = storage2.borrow_mut().scores.add_score_entry(Score { [INFO] [stdout] 452 | | name: name.to_string(), [INFO] [stdout] ... | [INFO] [stdout] 456 | | Ok(EventReaction::empty()) [INFO] [stdout] 457 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/menu/mod.rs:210:38 [INFO] [stdout] | [INFO] [stdout] 208 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | cond_dialog(&show_scores_trigger, move |_| { [INFO] [stdout] 210 | create_topscores_dialog(&storage2.borrow().scores, messages, None) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:462:9 [INFO] [stdout] | [INFO] [stdout] 461 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 462 | / cond_dialog(&show_scores_trigger, move |index| { [INFO] [stdout] 463 | | create_topscores_dialog(&storage2.borrow().scores, messages, *index) [INFO] [stdout] 464 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/menu/mod.rs:225:33 [INFO] [stdout] | [INFO] [stdout] 222 | let storage1 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 225 | new_options_dialog(&storage1.borrow(), messages) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:470:9 [INFO] [stdout] | [INFO] [stdout] 469 | let state2 = state.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 470 | cond_dialog(&failure_trigger, move |_| new_failure_dialog(messages)).flat_map_action( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/layout/grid.rs:17:23 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn new(container: Container, cols: usize, rows: usize) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | children: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/widget/checkbox.rs:25:19 [INFO] [stdout] | [INFO] [stdout] 20 | draw: impl Fn(Size, bool, bool, &dyn ResourceManager) -> Brick + 'static, [INFO] [stdout] | ------------------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | draw: Box::new(draw), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:471:13 [INFO] [stdout] | [INFO] [stdout] 469 | let state2 = state.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 470 | cond_dialog(&failure_trigger, move |_| new_failure_dialog(messages)).flat_map_action( [INFO] [stdout] 471 | / move |result, _| match *result { [INFO] [stdout] 472 | | FailureChoice::StartNew => { [INFO] [stdout] 473 | | let g = GamePrivate::new().unwrap(); [INFO] [stdout] 474 | | *state2.borrow_mut() = g.borrow().clone(); [INFO] [stdout] ... | [INFO] [stdout] 481 | | FailureChoice::Cancel => Ok(EventReaction::action(())), [INFO] [stdout] 482 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:343:13 [INFO] [stdout] | [INFO] [stdout] 340 | let this_state1 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | game_popup_background(messages, &this_state1).add(0, 0, new_pause_dialog(messages)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:343:69 [INFO] [stdout] | [INFO] [stdout] 340 | let this_state1 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | game_popup_background(messages, &this_state1).add(0, 0, new_pause_dialog(messages)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:355:13 [INFO] [stdout] | [INFO] [stdout] 352 | let this_state1 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 355 | game_popup_background(messages, &this_state1).add(0, 0, new_help_dialog(messages)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:355:69 [INFO] [stdout] | [INFO] [stdout] 352 | let this_state1 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 355 | game_popup_background(messages, &this_state1).add(0, 0, new_help_dialog(messages)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/widget/conditional.rs:29:22 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(condition: Rc>>, f: F) -> Self [INFO] [stdout] | --------------------------------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | wrapped: RefCell::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:369:13 [INFO] [stdout] | [INFO] [stdout] 364 | let storage1 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 365 | let storage2 = storage.clone(); [INFO] [stdout] 366 | let this_state1 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 369 | game_popup_background(messages, &this_state1).add( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:372:17 [INFO] [stdout] | [INFO] [stdout] 364 | let storage1 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 365 | let storage2 = storage.clone(); [INFO] [stdout] 366 | let this_state1 = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 372 | new_options_dialog(&storage1.borrow(), messages), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/widget/conditional.rs:30:22 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(condition: Rc>>, f: F) -> Self [INFO] [stdout] | --------------------------------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | factory: Box::new(f), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:396:13 [INFO] [stdout] | [INFO] [stdout] 391 | let storage1 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 392 | let storage2 = storage.clone(); [INFO] [stdout] 393 | let state1 = state.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 396 | game_popup_background(messages, &state1).add( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:399:17 [INFO] [stdout] | [INFO] [stdout] 391 | let storage1 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 392 | let storage2 = storage.clone(); [INFO] [stdout] 393 | let state1 = state.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 399 | new_save_game_dialog(&storage1.borrow().saved_games, messages), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/widget/container.rs:32:23 [INFO] [stdout] | [INFO] [stdout] 25 | background: impl Into>, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | border: impl Into>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | children: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/widget/container.rs:42:23 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn modal(size: Size, background: impl Into>) -> Self { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | children: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/widget/container.rs:52:23 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn screen_modal(background: impl Into>) -> Self { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | children: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/widget/input_field.rs:30:19 [INFO] [stdout] | [INFO] [stdout] 25 | let text = Rope::from(text); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | text: RefCell::new(text), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:426:55 [INFO] [stdout] | [INFO] [stdout] 426 | if let Some(score) = score.filter(|score| storage2.borrow().scores.is_deserving(*score)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:446:13 [INFO] [stdout] | [INFO] [stdout] 438 | let storage1 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 446 | new_player_name_dialog(&last_name, messages) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/widget/slider.rs:28:19 [INFO] [stdout] | [INFO] [stdout] 21 | draw: impl Fn(Size, Rect, bool, &dyn ResourceManager) -> Brick + 'static, [INFO] [stdout] | ------------------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | draw: Box::new(draw), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/widget/widget.rs:57:21 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn update_and_action(action: A) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | action: Some(action), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/game/mod.rs:463:38 [INFO] [stdout] | [INFO] [stdout] 461 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 462 | cond_dialog(&show_scores_trigger, move |index| { [INFO] [stdout] 463 | create_topscores_dialog(&storage2.borrow().scores, messages, *index) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/widget/widget.rs:65:21 [INFO] [stdout] | [INFO] [stdout] 62 | pub fn action(action: A) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | action: Some(action), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/widget/widget.rs:169:22 [INFO] [stdout] | [INFO] [stdout] 166 | fn map_action(self, convert: F) -> WidgetMapAction { [INFO] [stdout] | ---- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | convert: Box::new(move |a, _| Ok(EventReaction::action(convert(a)))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/widget/widget.rs:169:46 [INFO] [stdout] | [INFO] [stdout] 166 | fn map_action(self, convert: F) -> WidgetMapAction { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | convert: Box::new(move |a, _| Ok(EventReaction::action(convert(a)))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/widget/widget.rs:191:22 [INFO] [stdout] | [INFO] [stdout] 188 | fn flat_map_action(self, convert: F) -> WidgetMapAction { [INFO] [stdout] | ---- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | convert: Box::new(convert), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/widget/widget.rs:210:22 [INFO] [stdout] | [INFO] [stdout] 207 | fn no_action(self) -> WidgetMapAction { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | convert: Box::new(|_, _| Ok(EventReaction::empty())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/menu/mod.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 71 | let new_game_trigger2 = new_game_trigger.clone(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | / GridBuilder::new(Container::container(Size::new(220, 210), None, None), 1, 7) [INFO] [stdout] 78 | | .add( [INFO] [stdout] 79 | | 0, [INFO] [stdout] 80 | | 0, [INFO] [stdout] ... | [INFO] [stdout] 147 | | ) [INFO] [stdout] 148 | | .build() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/menu/mod.rs:149:30 [INFO] [stdout] | [INFO] [stdout] 71 | let new_game_trigger2 = new_game_trigger.clone(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | .flat_map_action(move |menu_action, _| match menu_action { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 150 | | MainMenuAction::NewGame => { [INFO] [stdout] 151 | | let game = GamePrivate::new().unwrap(); [INFO] [stdout] 152 | | *new_game_trigger2.borrow_mut() = Some(game); [INFO] [stdout] ... | [INFO] [stdout] 175 | | MainMenuAction::Exit => Ok(EventReaction::action(MainLoopQuit)), [INFO] [stdout] 176 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/widget/widget.rs:210:41 [INFO] [stdout] | [INFO] [stdout] 210 | convert: Box::new(|_, _| Ok(EventReaction::empty())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/menu/mod.rs:181:9 [INFO] [stdout] | [INFO] [stdout] 180 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | / cond_dialog(&new_game_trigger, move |game| { [INFO] [stdout] 182 | | game.borrow_mut().start(); [INFO] [stdout] 183 | | new_game_widget(storage2.clone(), game.clone(), messages) [INFO] [stdout] 184 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/menu/mod.rs:191:9 [INFO] [stdout] | [INFO] [stdout] 189 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | let new_game_trigger2 = new_game_trigger.clone(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | / cond_dialog(&load_game_trigger, move |_| { [INFO] [stdout] 192 | | new_load_game_dialog(&storage2.borrow().saved_games, messages) [INFO] [stdout] 193 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/menu/mod.rs:194:26 [INFO] [stdout] | [INFO] [stdout] 189 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | let new_game_trigger2 = new_game_trigger.clone(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | .flat_map_action(move |result, _| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 195 | | match *result { [INFO] [stdout] 196 | | DialogResult::Ok(ref game_data) => { [INFO] [stdout] 197 | | let game = Rc::new(RefCell::new(game_data.clone())); [INFO] [stdout] ... | [INFO] [stdout] 203 | | Ok(EventReaction::empty()) [INFO] [stdout] 204 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/menu/mod.rs:209:9 [INFO] [stdout] | [INFO] [stdout] 208 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | / cond_dialog(&show_scores_trigger, move |_| { [INFO] [stdout] 210 | | create_topscores_dialog(&storage2.borrow().scores, messages, None) [INFO] [stdout] 211 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/menu/mod.rs:224:9 [INFO] [stdout] | [INFO] [stdout] 222 | let storage1 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | / cond_dialog(&show_opts_trigger, move |_| { [INFO] [stdout] 225 | | new_options_dialog(&storage1.borrow(), messages) [INFO] [stdout] 226 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/menu/mod.rs:227:26 [INFO] [stdout] | [INFO] [stdout] 222 | let storage1 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | .flat_map_action(move |result, context| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 228 | | match *result { [INFO] [stdout] 229 | | DialogResult::Ok(ref options) => { [INFO] [stdout] 230 | | storage2.borrow_mut().fullscreen = options.fullscreen; [INFO] [stdout] ... | [INFO] [stdout] 237 | | Ok(EventReaction::empty()) [INFO] [stdout] 238 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/menu/mod.rs:183:29 [INFO] [stdout] | [INFO] [stdout] 180 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | new_game_widget(storage2.clone(), game.clone(), messages) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/menu/mod.rs:183:47 [INFO] [stdout] | [INFO] [stdout] 180 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | new_game_widget(storage2.clone(), game.clone(), messages) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/menu/mod.rs:192:35 [INFO] [stdout] | [INFO] [stdout] 189 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 192 | new_load_game_dialog(&storage2.borrow().saved_games, messages) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/menu/mod.rs:210:38 [INFO] [stdout] | [INFO] [stdout] 208 | let storage2 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | cond_dialog(&show_scores_trigger, move |_| { [INFO] [stdout] 210 | create_topscores_dialog(&storage2.borrow().scores, messages, None) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/component/menu/mod.rs:225:33 [INFO] [stdout] | [INFO] [stdout] 222 | let storage1 = storage.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 225 | new_options_dialog(&storage1.borrow(), messages) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/layout/grid.rs:17:23 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn new(container: Container, cols: usize, rows: usize) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | children: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/widget/checkbox.rs:25:19 [INFO] [stdout] | [INFO] [stdout] 20 | draw: impl Fn(Size, bool, bool, &dyn ResourceManager) -> Brick + 'static, [INFO] [stdout] | ------------------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | draw: Box::new(draw), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/widget/conditional.rs:29:22 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(condition: Rc>>, f: F) -> Self [INFO] [stdout] | --------------------------------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | wrapped: RefCell::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/widget/conditional.rs:30:22 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(condition: Rc>>, f: F) -> Self [INFO] [stdout] | --------------------------------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | factory: Box::new(f), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/widget/container.rs:32:23 [INFO] [stdout] | [INFO] [stdout] 25 | background: impl Into>, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | border: impl Into>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | children: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/widget/container.rs:42:23 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn modal(size: Size, background: impl Into>) -> Self { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | children: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/widget/container.rs:52:23 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn screen_modal(background: impl Into>) -> Self { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | children: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/widget/input_field.rs:30:19 [INFO] [stdout] | [INFO] [stdout] 25 | let text = Rope::from(text); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | text: RefCell::new(text), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/widget/slider.rs:28:19 [INFO] [stdout] | [INFO] [stdout] 21 | draw: impl Fn(Size, Rect, bool, &dyn ResourceManager) -> Brick + 'static, [INFO] [stdout] | ------------------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | draw: Box::new(draw), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/widget/widget.rs:57:21 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn update_and_action(action: A) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | action: Some(action), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/widget/widget.rs:65:21 [INFO] [stdout] | [INFO] [stdout] 62 | pub fn action(action: A) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | action: Some(action), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/widget/widget.rs:169:22 [INFO] [stdout] | [INFO] [stdout] 166 | fn map_action(self, convert: F) -> WidgetMapAction { [INFO] [stdout] | ---- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | convert: Box::new(move |a, _| Ok(EventReaction::action(convert(a)))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/widget/widget.rs:169:46 [INFO] [stdout] | [INFO] [stdout] 166 | fn map_action(self, convert: F) -> WidgetMapAction { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | convert: Box::new(move |a, _| Ok(EventReaction::action(convert(a)))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/widget/widget.rs:191:22 [INFO] [stdout] | [INFO] [stdout] 188 | fn flat_map_action(self, convert: F) -> WidgetMapAction { [INFO] [stdout] | ---- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | convert: Box::new(convert), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/widget/widget.rs:210:22 [INFO] [stdout] | [INFO] [stdout] 207 | fn no_action(self) -> WidgetMapAction { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | convert: Box::new(|_, _| Ok(EventReaction::empty())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> einstein/src/ui/widget/widget.rs:210:41 [INFO] [stdout] | [INFO] [stdout] 210 | convert: Box::new(|_, _| Ok(EventReaction::empty())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 65 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `einstein` (bin "einstein") due to 66 previous errors; 3 warnings emitted [INFO] [stdout] error: aborting due to 65 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `einstein` (bin "einstein" test) due to 66 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3aecf1f71fb82c8ef6a0b4c3668ab721852189b70bc6edd458fc3acb6f9bfdf0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3aecf1f71fb82c8ef6a0b4c3668ab721852189b70bc6edd458fc3acb6f9bfdf0", kill_on_drop: false }` [INFO] [stdout] 3aecf1f71fb82c8ef6a0b4c3668ab721852189b70bc6edd458fc3acb6f9bfdf0