[INFO] cloning repository https://github.com/andrewbanchich/parse_dont_validate_rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/andrewbanchich/parse_dont_validate_rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fandrewbanchich%2Fparse_dont_validate_rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fandrewbanchich%2Fparse_dont_validate_rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a5655aa8b597c620ff742e6b294678c425869364 [INFO] checking andrewbanchich/parse_dont_validate_rs/a5655aa8b597c620ff742e6b294678c425869364 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fandrewbanchich%2Fparse_dont_validate_rs" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/andrewbanchich/parse_dont_validate_rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/andrewbanchich/parse_dont_validate_rs [INFO] finished tweaking git repo https://github.com/andrewbanchich/parse_dont_validate_rs [INFO] tweaked toml for git repo https://github.com/andrewbanchich/parse_dont_validate_rs written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/andrewbanchich/parse_dont_validate_rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2e17da0561f928792813d33dfcbca61a103c8244be2ce80824db8efcf73b6641 [INFO] running `Command { std: "docker" "start" "-a" "2e17da0561f928792813d33dfcbca61a103c8244be2ce80824db8efcf73b6641", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2e17da0561f928792813d33dfcbca61a103c8244be2ce80824db8efcf73b6641", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2e17da0561f928792813d33dfcbca61a103c8244be2ce80824db8efcf73b6641", kill_on_drop: false }` [INFO] [stdout] 2e17da0561f928792813d33dfcbca61a103c8244be2ce80824db8efcf73b6641 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ba1a573da2636628e91c850deebd445e2287c069e874ac53795fcdf5ff646170 [INFO] running `Command { std: "docker" "start" "-a" "ba1a573da2636628e91c850deebd445e2287c069e874ac53795fcdf5ff646170", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Checking head v0.1.0 (/opt/rustwide/workdir/head) [INFO] [stderr] Checking configuration_directories v0.1.0 (/opt/rustwide/workdir/configuration_directories) [INFO] [stdout] warning: unused variable: `cache_dir` [INFO] [stdout] --> configuration_directories/src/non_empty.rs:27:21 [INFO] [stdout] | [INFO] [stdout] 27 | fn initialize_cache(cache_dir: &Path) { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cache_dir` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cache_dir` [INFO] [stdout] --> configuration_directories/src/main.rs:32:21 [INFO] [stdout] | [INFO] [stdout] 32 | fn initialize_cache(cache_dir: &Path) { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cache_dir` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `main` is never used [INFO] [stdout] --> configuration_directories/src/non_empty.rs:6:4 [INFO] [stdout] | [INFO] [stdout] 6 | fn main() { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_configuration_directories` is never used [INFO] [stdout] --> configuration_directories/src/non_empty.rs:11:4 [INFO] [stdout] | [INFO] [stdout] 11 | fn get_configuration_directories() -> NonEmptyVec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `NonEmptyVec` is never constructed [INFO] [stdout] --> configuration_directories/src/non_empty.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | struct NonEmptyVec(T, Vec); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `head` is never used [INFO] [stdout] --> configuration_directories/src/non_empty.rs:23:4 [INFO] [stdout] | [INFO] [stdout] 23 | fn head(vec: NonEmptyVec) -> T { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `initialize_cache` is never used [INFO] [stdout] --> configuration_directories/src/non_empty.rs:27:4 [INFO] [stdout] | [INFO] [stdout] 27 | fn initialize_cache(cache_dir: &Path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `validate_non_empty` is never used [INFO] [stdout] --> configuration_directories/src/non_empty.rs:31:4 [INFO] [stdout] | [INFO] [stdout] 31 | fn validate_non_empty(vec: Vec) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_non_empty` is never used [INFO] [stdout] --> configuration_directories/src/non_empty.rs:39:4 [INFO] [stdout] | [INFO] [stdout] 39 | fn parse_non_empty(mut vec: Vec) -> Result, String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> configuration_directories/src/non_empty.rs:40:11 [INFO] [stdout] | [INFO] [stdout] 39 | fn parse_non_empty(mut vec: Vec) -> Result, String> { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | match vec.pop() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cache_dir` [INFO] [stdout] --> configuration_directories/src/non_empty.rs:27:21 [INFO] [stdout] | [INFO] [stdout] 27 | fn initialize_cache(cache_dir: &Path) { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cache_dir` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cache_dir` [INFO] [stdout] --> configuration_directories/src/main.rs:32:21 [INFO] [stdout] | [INFO] [stdout] 32 | fn initialize_cache(cache_dir: &Path) { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cache_dir` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `main` is never used [INFO] [stdout] --> configuration_directories/src/non_empty.rs:6:4 [INFO] [stdout] | [INFO] [stdout] 6 | fn main() { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_configuration_directories` is never used [INFO] [stdout] --> configuration_directories/src/non_empty.rs:11:4 [INFO] [stdout] | [INFO] [stdout] 11 | fn get_configuration_directories() -> NonEmptyVec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `NonEmptyVec` is never constructed [INFO] [stdout] --> configuration_directories/src/non_empty.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | struct NonEmptyVec(T, Vec); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `head` is never used [INFO] [stdout] --> configuration_directories/src/non_empty.rs:23:4 [INFO] [stdout] | [INFO] [stdout] 23 | fn head(vec: NonEmptyVec) -> T { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `initialize_cache` is never used [INFO] [stdout] --> configuration_directories/src/non_empty.rs:27:4 [INFO] [stdout] | [INFO] [stdout] 27 | fn initialize_cache(cache_dir: &Path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `validate_non_empty` is never used [INFO] [stdout] --> configuration_directories/src/non_empty.rs:31:4 [INFO] [stdout] | [INFO] [stdout] 31 | fn validate_non_empty(vec: Vec) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_non_empty` is never used [INFO] [stdout] --> configuration_directories/src/non_empty.rs:39:4 [INFO] [stdout] | [INFO] [stdout] 39 | fn parse_non_empty(mut vec: Vec) -> Result, String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> configuration_directories/src/non_empty.rs:40:11 [INFO] [stdout] | [INFO] [stdout] 39 | fn parse_non_empty(mut vec: Vec) -> Result, String> { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | match vec.pop() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `configuration_directories` (bin "configuration_directories" test) due to 2 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `configuration_directories` (bin "configuration_directories") due to 2 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ba1a573da2636628e91c850deebd445e2287c069e874ac53795fcdf5ff646170", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ba1a573da2636628e91c850deebd445e2287c069e874ac53795fcdf5ff646170", kill_on_drop: false }` [INFO] [stdout] ba1a573da2636628e91c850deebd445e2287c069e874ac53795fcdf5ff646170