[INFO] cloning repository https://github.com/andreivasiliu/TinyRaytracerInRust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/andreivasiliu/TinyRaytracerInRust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fandreivasiliu%2FTinyRaytracerInRust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fandreivasiliu%2FTinyRaytracerInRust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] bdb19ebb49445a5193c4faed46c32c032477efd6 [INFO] checking andreivasiliu/TinyRaytracerInRust/bdb19ebb49445a5193c4faed46c32c032477efd6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fandreivasiliu%2FTinyRaytracerInRust" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/andreivasiliu/TinyRaytracerInRust on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/andreivasiliu/TinyRaytracerInRust [INFO] finished tweaking git repo https://github.com/andreivasiliu/TinyRaytracerInRust [INFO] tweaked toml for git repo https://github.com/andreivasiliu/TinyRaytracerInRust written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/andreivasiliu/TinyRaytracerInRust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7c1789917f985dd27872f68f4efd4fb9d5ada2ca98a0c9abe3f3074de7daaac1 [INFO] running `Command { std: "docker" "start" "-a" "7c1789917f985dd27872f68f4efd4fb9d5ada2ca98a0c9abe3f3074de7daaac1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7c1789917f985dd27872f68f4efd4fb9d5ada2ca98a0c9abe3f3074de7daaac1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7c1789917f985dd27872f68f4efd4fb9d5ada2ca98a0c9abe3f3074de7daaac1", kill_on_drop: false }` [INFO] [stdout] 7c1789917f985dd27872f68f4efd4fb9d5ada2ca98a0c9abe3f3074de7daaac1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3cc393a804cb5fdba493e4354c1d1ba27f390e33b6ccee9548b50825a707410a [INFO] running `Command { std: "docker" "start" "-a" "3cc393a804cb5fdba493e4354c1d1ba27f390e33b6ccee9548b50825a707410a", kill_on_drop: false }` [INFO] [stderr] Compiling pkg-config v0.3.15 [INFO] [stderr] Compiling libc v0.2.62 [INFO] [stderr] Compiling bitflags v1.1.0 [INFO] [stderr] Compiling proc-macro2 v1.0.3 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.5 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling gio v0.7.0 [INFO] [stderr] Compiling getrandom v0.1.12 [INFO] [stderr] Compiling gdk-pixbuf v0.7.0 [INFO] [stderr] Compiling ucd-trie v0.1.2 [INFO] [stderr] Compiling cairo-rs v0.7.1 [INFO] [stderr] Checking fragile v0.3.0 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Compiling pango v0.7.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling gdk v0.11.0 [INFO] [stderr] Compiling atk v0.7.0 [INFO] [stderr] Compiling maplit v1.0.2 [INFO] [stderr] Checking ppv-lite86 v0.2.5 [INFO] [stderr] Compiling pest v2.1.2 [INFO] [stderr] Compiling gtk v0.7.0 [INFO] [stderr] Checking rgb v0.8.14 [INFO] [stderr] Compiling glib-sys v0.9.0 [INFO] [stderr] Compiling gobject-sys v0.9.0 [INFO] [stderr] Compiling gio-sys v0.9.0 [INFO] [stderr] Compiling cairo-sys-rs v0.9.0 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.9.0 [INFO] [stderr] Compiling pango-sys v0.9.0 [INFO] [stderr] Compiling gdk-sys v0.9.0 [INFO] [stderr] Compiling atk-sys v0.9.0 [INFO] [stderr] Compiling gtk-sys v0.9.0 [INFO] [stderr] Checking c2-chacha v0.2.2 [INFO] [stderr] Checking num_cpus v1.10.1 [INFO] [stderr] Checking lodepng v2.5.0 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking threadpool v1.7.1 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking rand v0.7.1 [INFO] [stderr] Compiling pest_meta v2.1.2 [INFO] [stderr] Checking glib v0.8.1 [INFO] [stderr] Compiling pest_generator v2.1.1 [INFO] [stderr] Compiling proc-macro-hack v0.5.9 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Compiling arr_macro_impl v0.1.2 [INFO] [stderr] Checking arr_macro v0.1.2 [INFO] [stderr] Checking rust-tinyraytracer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raytracer/rt_object.rs:16:23 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn new(shape: Box, material: Option>) -> Self { [INFO] [stdout] | ------------------------- ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 16 | material: material.unwrap_or_else(|| Box::new(SolidColorMaterial::new( [INFO] [stdout] | _______________________^ [INFO] [stdout] 17 | | Color::BLACK, 0.0, 0.0 [INFO] [stdout] 18 | | ))), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raytracer/rt_object.rs:23:30 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn new_default(shape: Box) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | RTObject::new(shape, Some(Box::new(SolidColorMaterial::new( [INFO] [stdout] | ______________________________^ [INFO] [stdout] 24 | | Color::new(0.0, 1.0, 1.0, 1.0), 0.0, 0.0 [INFO] [stdout] 25 | | )))) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raydebugger/gui.rs:543:34 [INFO] [stdout] | [INFO] [stdout] 536 | let debugger_context = debugger_context.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 537 | let frame_spin_button = frame_spin_button.clone(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 543 | Continue(debugger_context.borrow().animating) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sceneparser/shape.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 43 | let material: Box = match &self.material { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | / match self.kind { [INFO] [stdout] 61 | | ShapeKind::Sphere { center, radius } => { [INFO] [stdout] 62 | | Box::new(MathSphere::new( [INFO] [stdout] 63 | | self.transformation.clone(), center, radius [INFO] [stdout] ... | [INFO] [stdout] 89 | | } [INFO] [stdout] 90 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sceneparser/shape.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 43 | let material: Box = match &self.material { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | Some(material), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raytracer/rt_object.rs:16:23 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn new(shape: Box, material: Option>) -> Self { [INFO] [stdout] | ------------------------- ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 16 | material: material.unwrap_or_else(|| Box::new(SolidColorMaterial::new( [INFO] [stdout] | _______________________^ [INFO] [stdout] 17 | | Color::BLACK, 0.0, 0.0 [INFO] [stdout] 18 | | ))), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raytracer/rt_object.rs:23:30 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn new_default(shape: Box) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | RTObject::new(shape, Some(Box::new(SolidColorMaterial::new( [INFO] [stdout] | ______________________________^ [INFO] [stdout] 24 | | Color::new(0.0, 1.0, 1.0, 1.0), 0.0, 0.0 [INFO] [stdout] 25 | | )))) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raydebugger/gui.rs:543:34 [INFO] [stdout] | [INFO] [stdout] 536 | let debugger_context = debugger_context.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 537 | let frame_spin_button = frame_spin_button.clone(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 543 | Continue(debugger_context.borrow().animating) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sceneparser/shape.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 43 | let material: Box = match &self.material { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | / match self.kind { [INFO] [stdout] 61 | | ShapeKind::Sphere { center, radius } => { [INFO] [stdout] 62 | | Box::new(MathSphere::new( [INFO] [stdout] 63 | | self.transformation.clone(), center, radius [INFO] [stdout] ... | [INFO] [stdout] 89 | | } [INFO] [stdout] 90 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sceneparser/shape.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 43 | let material: Box = match &self.material { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | Some(material), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-tinyraytracer` (bin "rust-tinyraytracer") due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-tinyraytracer` (bin "rust-tinyraytracer" test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "3cc393a804cb5fdba493e4354c1d1ba27f390e33b6ccee9548b50825a707410a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3cc393a804cb5fdba493e4354c1d1ba27f390e33b6ccee9548b50825a707410a", kill_on_drop: false }` [INFO] [stdout] 3cc393a804cb5fdba493e4354c1d1ba27f390e33b6ccee9548b50825a707410a