[INFO] cloning repository https://github.com/andpleas1/zcash [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/andpleas1/zcash" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fandpleas1%2Fzcash", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fandpleas1%2Fzcash'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 89434df20270cf452598cd68727b0ecc833fc06f [INFO] checking andpleas1/zcash/89434df20270cf452598cd68727b0ecc833fc06f against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fandpleas1%2Fzcash" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/andpleas1/zcash on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-7-tc2/source/rust-toolchain [INFO] started tweaking git repo https://github.com/andpleas1/zcash [INFO] finished tweaking git repo https://github.com/andpleas1/zcash [INFO] tweaked toml for git repo https://github.com/andpleas1/zcash written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/andpleas1/zcash already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 08550bfca34f8b267fb1285ba41402e55b9352dbdcb1a891252315da4d00bef3 [INFO] running `Command { std: "docker" "start" "-a" "08550bfca34f8b267fb1285ba41402e55b9352dbdcb1a891252315da4d00bef3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "08550bfca34f8b267fb1285ba41402e55b9352dbdcb1a891252315da4d00bef3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "08550bfca34f8b267fb1285ba41402e55b9352dbdcb1a891252315da4d00bef3", kill_on_drop: false }` [INFO] [stdout] 08550bfca34f8b267fb1285ba41402e55b9352dbdcb1a891252315da4d00bef3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9ccc7e51300b8655bbb4fc104e1206e9167c5e4bb0d89ac0c8a98e6249b40908 [INFO] running `Command { std: "docker" "start" "-a" "9ccc7e51300b8655bbb4fc104e1206e9167c5e4bb0d89ac0c8a98e6249b40908", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.103 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling proc-macro2 v1.0.29 [INFO] [stderr] Compiling syn v1.0.80 [INFO] [stderr] Compiling typenum v1.14.0 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Compiling radium v0.6.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking wyz v0.4.0 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling generic-array v0.14.4 [INFO] [stderr] Checking funty v1.2.0 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking constant_time_eq v0.1.5 [INFO] [stderr] Checking arrayref v0.3.6 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Checking cpufeatures v0.2.1 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Checking blake2b_simd v0.5.11 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking bitvec v0.22.3 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Compiling ahash v0.7.4 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Compiling crunchy v0.1.6 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking cipher v0.3.0 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking universal-hash v0.4.1 [INFO] [stderr] Checking sha2 v0.9.8 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling num-bigint v0.4.2 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking smallvec v1.7.0 [INFO] [stderr] Checking nonempty v0.7.0 [INFO] [stderr] Compiling futures-core v0.3.17 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling libm v0.2.1 [INFO] [stderr] Checking poly1305 v0.7.2 [INFO] [stderr] Checking aead v0.4.3 [INFO] [stderr] Checking crypto-mac v0.11.1 [INFO] [stderr] Checking tracing-core v0.1.21 [INFO] [stderr] Checking block-padding v0.2.1 [INFO] [stderr] Compiling regex-syntax v0.6.25 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Compiling aho-corasick v0.7.18 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Compiling futures-task v0.3.17 [INFO] [stderr] Checking base64ct v1.0.1 [INFO] [stderr] Checking tinyvec v1.5.0 [INFO] [stderr] Checking block-modes v0.8.1 [INFO] [stderr] Checking password-hash v0.3.2 [INFO] [stderr] Checking bigint v4.4.3 [INFO] [stderr] Checking ff v0.11.0 [INFO] [stderr] Checking group v0.11.0 [INFO] [stderr] Compiling tokio v1.12.0 [INFO] [stderr] Checking pairing v0.21.0 [INFO] [stderr] Checking bls12_381 v0.6.0 [INFO] [stderr] Checking pasta_curves v0.2.1 [INFO] [stderr] Compiling futures-util v0.3.17 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Checking instant v0.1.11 [INFO] [stderr] Compiling futures-channel v0.3.17 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Compiling metrics v0.17.0 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Compiling regex v1.5.4 [INFO] [stderr] Compiling httparse v1.5.1 [INFO] [stderr] Checking jubjub v0.8.0 [INFO] [stderr] Checking raw-cpuid v10.2.0 [INFO] [stderr] Checking halo2 v0.1.0-beta.1 [INFO] [stderr] Checking http v0.2.5 [INFO] [stderr] Checking fpe v0.5.0 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking pbkdf2 v0.9.0 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling synstructure v0.12.5 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking hmac v0.11.0 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking zcash_encoding v0.0.0 (https://github.com/zcash/librustzcash.git?rev=53d0a51d33a421cb76d3e3124d1e4c1c9036068e#53d0a51d) [INFO] [stderr] Checking memuse v0.2.0 [INFO] [stderr] Checking aes v0.7.5 [INFO] [stderr] Checking mio v0.7.13 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking blake2s_simd v0.5.11 [INFO] [stderr] Checking lock_api v0.4.5 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Checking arrayvec v0.7.1 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking http-body v0.4.3 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking matchers v0.0.1 [INFO] [stderr] Checking quanta v0.9.3 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking equihash v0.1.0 (https://github.com/zcash/librustzcash.git?rev=53d0a51d33a421cb76d3e3124d1e4c1c9036068e#53d0a51d) [INFO] [stderr] Checking ordered-float v2.8.0 [INFO] [stderr] Checking thread_local v1.1.3 [INFO] [stderr] Checking dashmap v4.0.2 [INFO] [stderr] Checking dirs-sys v0.3.6 [INFO] [stderr] Checking socket2 v0.3.19 [INFO] [stderr] Checking sharded-slab v0.1.3 [INFO] [stderr] Checking tower-service v0.3.1 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking sketches-ddsketch v0.1.2 [INFO] [stderr] Checking httpdate v0.3.2 [INFO] [stderr] Checking atomic-shim v0.1.0 [INFO] [stderr] Checking directories v4.0.1 [INFO] [stderr] Checking bellman v0.11.1 [INFO] [stderr] Checking bs58 v0.4.0 [INFO] [stderr] Checking f4jumble v0.0.0 (https://github.com/zcash/librustzcash.git?rev=53d0a51d33a421cb76d3e3124d1e4c1c9036068e#53d0a51d) [INFO] [stderr] Checking bech32 v0.8.1 [INFO] [stderr] Checking ipnet v2.3.1 [INFO] [stderr] Compiling zeroize_derive v1.2.0 [INFO] [stderr] Compiling thiserror-impl v1.0.29 [INFO] [stderr] Compiling tracing-attributes v0.1.18 [INFO] [stderr] Compiling metrics-macros v0.4.0 [INFO] [stderr] Compiling tokio-macros v1.4.1 [INFO] [stderr] Checking zeroize v1.4.2 [INFO] [stderr] Compiling pin-project-internal v1.0.8 [INFO] [stderr] Checking chacha20 v0.8.1 [INFO] [stderr] Checking chacha20poly1305 v0.9.0 [INFO] [stderr] Checking zcash_note_encryption v0.0.0 (https://github.com/zcash/librustzcash.git?rev=53d0a51d33a421cb76d3e3124d1e4c1c9036068e#53d0a51d) [INFO] [stderr] Checking bip0039 v0.9.0 [INFO] [stderr] Checking metrics-util v0.10.1 [INFO] [stderr] Checking curve25519-dalek v3.2.0 [INFO] [stderr] Checking zcash_address v0.0.0 (https://github.com/zcash/librustzcash.git?rev=53d0a51d33a421cb76d3e3124d1e4c1c9036068e#53d0a51d) [INFO] [stderr] Checking zcash_history v0.2.0 (https://github.com/zcash/librustzcash.git?rev=53d0a51d33a421cb76d3e3124d1e4c1c9036068e#53d0a51d) [INFO] [stderr] Checking tracing v0.1.29 [INFO] [stderr] Checking thiserror v1.0.29 [INFO] [stderr] Checking tracing-subscriber v0.2.25 [INFO] [stderr] Checking pin-project v1.0.8 [INFO] [stderr] Checking tracing-appender v0.1.2 [INFO] [stderr] Checking hyper v0.14.2 [INFO] [stderr] Checking metrics-exporter-prometheus v0.6.1 [INFO] [stderr] Checking reddsa v0.0.0 (https://github.com/str4d/redjubjub.git?rev=416a6a8ebf8bd42c114c938883016c04f338de72#416a6a8e) [INFO] [stderr] Checking incrementalmerkletree v0.1.0 (https://github.com/zcash/incrementalmerkletree?rev=b7bd6246122a6e9ace8edb51553fbf5228906cbb#b7bd6246) [INFO] [stderr] Checking ed25519-zebra v2.2.0 (https://github.com/ZcashFoundation/ed25519-zebra.git?rev=d3512400227a362d08367088ffaa9bd4142a69c7#d3512400) [INFO] [stderr] Checking orchard v0.0.0 (https://github.com/zcash/orchard.git?rev=2c8241f25b943aa05203eacf9905db117c69bd29#2c8241f2) [INFO] [stderr] Checking zcash_primitives v0.5.0 (https://github.com/zcash/librustzcash.git?rev=53d0a51d33a421cb76d3e3124d1e4c1c9036068e#53d0a51d) [INFO] [stderr] Checking zcash_proofs v0.5.0 (https://github.com/zcash/librustzcash.git?rev=53d0a51d33a421cb76d3e3124d1e4c1c9036068e#53d0a51d) [INFO] [stderr] Checking librustzcash v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/rust/src/rustzcash.rs:722:18 [INFO] [stdout] | [INFO] [stdout] 722 | unsafe { &SPROUT_GROTH16_PARAMS_PATH } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] = note: `#[warn(static_mut_refs)]` on by default [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 722 | unsafe { addr_of!(SPROUT_GROTH16_PARAMS_PATH) } [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/rust/src/rustzcash.rs:722:18 [INFO] [stdout] | [INFO] [stdout] 722 | unsafe { &SPROUT_GROTH16_PARAMS_PATH } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] = note: `#[warn(static_mut_refs)]` on by default [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 722 | unsafe { addr_of!(SPROUT_GROTH16_PARAMS_PATH) } [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/blake2b.rs:28:36 [INFO] [stdout] | [INFO] [stdout] 28 | .map(|state| Box::into_raw(Box::new(state.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/metrics_ffi.rs:105:19 [INFO] [stdout] | [INFO] [stdout] 99 | let labels: Vec<_> = labels [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | Box::into_raw(Box::new(FfiCallsite { [INFO] [stdout] | ___________________^ [INFO] [stdout] 106 | | key: Key::from_parts(name, labels), [INFO] [stdout] 107 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/tracing_ffi.rs:140:19 [INFO] [stdout] | [INFO] [stdout] 80 | let (file_logger, file_no_timestamps, file_guard) = if let Some(log_path) = log_path { [INFO] [stdout] | ----------- ------------------ ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | let file_appender = tracing_appender::rolling::never( [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | let (non_blocking, file_guard) = tracing_appender::non_blocking(file_appender); [INFO] [stdout] | ------------ ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | let (filter, reload_handle) = reload::Layer::new(EnvFilter::from(initial_filter)); [INFO] [stdout] | ------ ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | Box::into_raw(Box::new(TracingHandle { [INFO] [stdout] | ___________________^ [INFO] [stdout] 141 | | _file_guard: file_guard, [INFO] [stdout] 142 | | reload_handle: Box::new(reload_handle), [INFO] [stdout] 143 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/tracing_ffi.rs:527:19 [INFO] [stdout] | [INFO] [stdout] 463 | let span = if level_enabled!(*meta.level()) && callsite.is_enabled() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 527 | Box::into_raw(Box::new(span)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/tracing_ffi.rs:533:35 [INFO] [stdout] | [INFO] [stdout] 533 | .map(|span| Box::into_raw(Box::new(span.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/tracing_ffi.rs:547:35 [INFO] [stdout] | [INFO] [stdout] 547 | .map(|span| Box::into_raw(Box::new(span.enter()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/history_ffi.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 42 | let mut peaks: Vec<_> = indices [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let extra = peaks.split_off(p_len); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | [INFO] [stdout] 54 | Ok(MMRTree::new(t_len, peaks, extra)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/history_ffi.rs:46:35 [INFO] [stdout] | [INFO] [stdout] 46 | |(index, node)| match MMREntry::from_bytes(cbranch, &node[..]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/orchard_ffi.rs:29:37 [INFO] [stdout] | [INFO] [stdout] 29 | .map(|bundle| Box::into_raw(Box::new(bundle.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/orchard_ffi/incremental_sinsemilla_tree_ffi.rs:36:35 [INFO] [stdout] | [INFO] [stdout] 36 | .map(|tree| Box::into_raw(Box::new(tree.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/orchard_ffi/incremental_sinsemilla_tree_ffi.rs:168:35 [INFO] [stdout] | [INFO] [stdout] 168 | .map(|tree| Box::into_raw(Box::new(tree.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `CString::from_raw` that must be used [INFO] [stdout] --> src/rust/src/zip339_ffi.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | CString::from_raw(phrase as *mut c_char); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(from_raw(ptr))` if you intend to drop the `CString` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 66 | let _ = CString::from_raw(phrase as *mut c_char); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `librustzcash` (lib) due to 12 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/blake2b.rs:28:36 [INFO] [stdout] | [INFO] [stdout] 28 | .map(|state| Box::into_raw(Box::new(state.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/metrics_ffi.rs:105:19 [INFO] [stdout] | [INFO] [stdout] 99 | let labels: Vec<_> = labels [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | Box::into_raw(Box::new(FfiCallsite { [INFO] [stdout] | ___________________^ [INFO] [stdout] 106 | | key: Key::from_parts(name, labels), [INFO] [stdout] 107 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/tracing_ffi.rs:140:19 [INFO] [stdout] | [INFO] [stdout] 80 | let (file_logger, file_no_timestamps, file_guard) = if let Some(log_path) = log_path { [INFO] [stdout] | ----------- ------------------ ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | let file_appender = tracing_appender::rolling::never( [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | let (non_blocking, file_guard) = tracing_appender::non_blocking(file_appender); [INFO] [stdout] | ------------ ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | let (filter, reload_handle) = reload::Layer::new(EnvFilter::from(initial_filter)); [INFO] [stdout] | ------ ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | Box::into_raw(Box::new(TracingHandle { [INFO] [stdout] | ___________________^ [INFO] [stdout] 141 | | _file_guard: file_guard, [INFO] [stdout] 142 | | reload_handle: Box::new(reload_handle), [INFO] [stdout] 143 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/tracing_ffi.rs:527:19 [INFO] [stdout] | [INFO] [stdout] 463 | let span = if level_enabled!(*meta.level()) && callsite.is_enabled() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 527 | Box::into_raw(Box::new(span)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/tracing_ffi.rs:533:35 [INFO] [stdout] | [INFO] [stdout] 533 | .map(|span| Box::into_raw(Box::new(span.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/tracing_ffi.rs:547:35 [INFO] [stdout] | [INFO] [stdout] 547 | .map(|span| Box::into_raw(Box::new(span.enter()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/history_ffi.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 42 | let mut peaks: Vec<_> = indices [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let extra = peaks.split_off(p_len); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | [INFO] [stdout] 54 | Ok(MMRTree::new(t_len, peaks, extra)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/history_ffi.rs:46:35 [INFO] [stdout] | [INFO] [stdout] 46 | |(index, node)| match MMREntry::from_bytes(cbranch, &node[..]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/orchard_ffi.rs:29:37 [INFO] [stdout] | [INFO] [stdout] 29 | .map(|bundle| Box::into_raw(Box::new(bundle.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/orchard_ffi/incremental_sinsemilla_tree_ffi.rs:36:35 [INFO] [stdout] | [INFO] [stdout] 36 | .map(|tree| Box::into_raw(Box::new(tree.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/orchard_ffi/incremental_sinsemilla_tree_ffi.rs:168:35 [INFO] [stdout] | [INFO] [stdout] 168 | .map(|tree| Box::into_raw(Box::new(tree.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `CString::from_raw` that must be used [INFO] [stdout] --> src/rust/src/zip339_ffi.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | CString::from_raw(phrase as *mut c_char); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(from_raw(ptr))` if you intend to drop the `CString` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 66 | let _ = CString::from_raw(phrase as *mut c_char); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `librustzcash` (lib test) due to 12 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9ccc7e51300b8655bbb4fc104e1206e9167c5e4bb0d89ac0c8a98e6249b40908", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9ccc7e51300b8655bbb4fc104e1206e9167c5e4bb0d89ac0c8a98e6249b40908", kill_on_drop: false }` [INFO] [stdout] 9ccc7e51300b8655bbb4fc104e1206e9167c5e4bb0d89ac0c8a98e6249b40908