[INFO] cloning repository https://github.com/andersquist/aoc2020 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/andersquist/aoc2020" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fandersquist%2Faoc2020", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fandersquist%2Faoc2020'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] dcc4047f783dfa1369781a60f26c97cdd15f4c17 [INFO] checking andersquist/aoc2020/dcc4047f783dfa1369781a60f26c97cdd15f4c17 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fandersquist%2Faoc2020" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/andersquist/aoc2020 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/andersquist/aoc2020 [INFO] finished tweaking git repo https://github.com/andersquist/aoc2020 [INFO] tweaked toml for git repo https://github.com/andersquist/aoc2020 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/andersquist/aoc2020 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] aec702b930689ce17630af0aebae1394271c35ac448f5c1544135dc0b61261a7 [INFO] running `Command { std: "docker" "start" "-a" "aec702b930689ce17630af0aebae1394271c35ac448f5c1544135dc0b61261a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "aec702b930689ce17630af0aebae1394271c35ac448f5c1544135dc0b61261a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aec702b930689ce17630af0aebae1394271c35ac448f5c1544135dc0b61261a7", kill_on_drop: false }` [INFO] [stdout] aec702b930689ce17630af0aebae1394271c35ac448f5c1544135dc0b61261a7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1b1d02adfb969a897e1950009027969836f6c81942c93c73e665e3887db7b0f4 [INFO] running `Command { std: "docker" "start" "-a" "1b1d02adfb969a897e1950009027969836f6c81942c93c73e665e3887db7b0f4", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling syn v1.0.53 [INFO] [stderr] Compiling regex-syntax v0.6.21 [INFO] [stderr] Compiling once_cell v1.5.2 [INFO] [stderr] Compiling thread_local v1.0.1 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking aho-corasick v0.7.15 [INFO] [stderr] Compiling regex v1.4.2 [INFO] [stderr] Compiling thiserror-impl v1.0.22 [INFO] [stderr] Checking thiserror v1.0.22 [INFO] [stderr] Compiling parse-display-derive v0.4.0 [INFO] [stderr] Checking parse-display v0.4.0 [INFO] [stderr] Checking adventofcode v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/day2.rs:50:17 [INFO] [stdout] | [INFO] [stdout] 50 | _ => panic!(format!("Illegal value: [{}]", str_val)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 50 - _ => panic!(format!("Illegal value: [{}]", str_val)), [INFO] [stdout] 50 + _ => panic!("Illegal value: [{}]", str_val), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/day2.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | _ => panic!(format!("Illegal char: [{}]", str_val)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 57 - _ => panic!(format!("Illegal char: [{}]", str_val)), [INFO] [stdout] 57 + _ => panic!("Illegal char: [{}]", str_val), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/day2.rs:64:17 [INFO] [stdout] | [INFO] [stdout] 64 | _ => panic!(format!("Illegal char: [{}]", str_val)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 64 - _ => panic!(format!("Illegal char: [{}]", str_val)), [INFO] [stdout] 64 + _ => panic!("Illegal char: [{}]", str_val), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:11:6 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn read_lines

(filename: P) -> io::Result>> [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 10 | let file = File::open(filename)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | Ok(io::BufReader::new(file).lines()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 19 | let file = File::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let mut reader = io::BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | / std::iter::from_fn(move || { [INFO] [stdout] 38 | | buf.clear(); [INFO] [stdout] 39 | | while buf.is_empty() || !is_new_field(&buf) { [INFO] [stdout] 40 | | line += 1; [INFO] [stdout] ... | [INFO] [stdout] 64 | | }) [INFO] [stdout] 65 | | .fuse(), [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 74 | let file = File::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | let mut reader = io::BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | / std::iter::from_fn(move || { [INFO] [stdout] 93 | | buf.clear(); [INFO] [stdout] 94 | | while buf.is_empty() || !is_new_field(&buf) { [INFO] [stdout] 95 | | line += 1; [INFO] [stdout] ... | [INFO] [stdout] 119 | | }) [INFO] [stdout] 120 | | .fuse(), [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:136:5 [INFO] [stdout] | [INFO] [stdout] 130 | let mut reader = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | reader.read_line(&mut buf).ok().and_then(|_| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `adventofcode` (bin "adventofcode") due to 5 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/day2.rs:50:17 [INFO] [stdout] | [INFO] [stdout] 50 | _ => panic!(format!("Illegal value: [{}]", str_val)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 50 - _ => panic!(format!("Illegal value: [{}]", str_val)), [INFO] [stdout] 50 + _ => panic!("Illegal value: [{}]", str_val), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/day2.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | _ => panic!(format!("Illegal char: [{}]", str_val)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 57 - _ => panic!(format!("Illegal char: [{}]", str_val)), [INFO] [stdout] 57 + _ => panic!("Illegal char: [{}]", str_val), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/day2.rs:64:17 [INFO] [stdout] | [INFO] [stdout] 64 | _ => panic!(format!("Illegal char: [{}]", str_val)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 64 - _ => panic!(format!("Illegal char: [{}]", str_val)), [INFO] [stdout] 64 + _ => panic!("Illegal char: [{}]", str_val), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:11:6 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn read_lines

(filename: P) -> io::Result>> [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 10 | let file = File::open(filename)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | Ok(io::BufReader::new(file).lines()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 19 | let file = File::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let mut reader = io::BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | / std::iter::from_fn(move || { [INFO] [stdout] 38 | | buf.clear(); [INFO] [stdout] 39 | | while buf.is_empty() || !is_new_field(&buf) { [INFO] [stdout] 40 | | line += 1; [INFO] [stdout] ... | [INFO] [stdout] 64 | | }) [INFO] [stdout] 65 | | .fuse(), [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 74 | let file = File::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | let mut reader = io::BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | / std::iter::from_fn(move || { [INFO] [stdout] 93 | | buf.clear(); [INFO] [stdout] 94 | | while buf.is_empty() || !is_new_field(&buf) { [INFO] [stdout] 95 | | line += 1; [INFO] [stdout] ... | [INFO] [stdout] 119 | | }) [INFO] [stdout] 120 | | .fuse(), [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:136:5 [INFO] [stdout] | [INFO] [stdout] 130 | let mut reader = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | reader.read_line(&mut buf).ok().and_then(|_| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `adventofcode` (bin "adventofcode" test) due to 5 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1b1d02adfb969a897e1950009027969836f6c81942c93c73e665e3887db7b0f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1b1d02adfb969a897e1950009027969836f6c81942c93c73e665e3887db7b0f4", kill_on_drop: false }` [INFO] [stdout] 1b1d02adfb969a897e1950009027969836f6c81942c93c73e665e3887db7b0f4