[INFO] cloning repository https://github.com/anan44/aoc2022 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/anan44/aoc2022" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fanan44%2Faoc2022", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fanan44%2Faoc2022'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a1d627c2fcdac3ec7db476bacf3c7929e5de4708 [INFO] checking anan44/aoc2022/a1d627c2fcdac3ec7db476bacf3c7929e5de4708 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fanan44%2Faoc2022" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/anan44/aoc2022 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/anan44/aoc2022 [INFO] finished tweaking git repo https://github.com/anan44/aoc2022 [INFO] tweaked toml for git repo https://github.com/anan44/aoc2022 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/anan44/aoc2022 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 77154735933fcea5b7032ffdee112dfc11425840dffc80131b0480985cdf0493 [INFO] running `Command { std: "docker" "start" "-a" "77154735933fcea5b7032ffdee112dfc11425840dffc80131b0480985cdf0493", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "77154735933fcea5b7032ffdee112dfc11425840dffc80131b0480985cdf0493", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "77154735933fcea5b7032ffdee112dfc11425840dffc80131b0480985cdf0493", kill_on_drop: false }` [INFO] [stdout] 77154735933fcea5b7032ffdee112dfc11425840dffc80131b0480985cdf0493 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 14857cf9e86629892c00db86db550829daafce6cc7a77e58b6b4c7990ef34a5a [INFO] running `Command { std: "docker" "start" "-a" "14857cf9e86629892c00db86db550829daafce6cc7a77e58b6b4c7990ef34a5a", kill_on_drop: false }` [INFO] [stderr] Checking regex-syntax v0.6.28 [INFO] [stderr] Checking aho-corasick v0.7.20 [INFO] [stderr] Checking regex v1.7.0 [INFO] [stderr] Checking aoc2022 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `v` [INFO] [stdout] --> src/day10.rs:20:27 [INFO] [stdout] | [INFO] [stdout] 20 | Command::Addx(v) => vec![self.clone(), Command::Noop], [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/day7.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | Dir(String), [INFO] [stdout] | --- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `LsResult` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 8 | Dir(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_on_sprite` is never used [INFO] [stdout] --> src/day10.rs:59:4 [INFO] [stdout] | [INFO] [stdout] 59 | fn is_on_sprite(index: i32, sprite: i32) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 6 | let file = File::open(path).expect("no such file"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 7 | let buff = BufReader::new(file); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | / buff.lines() [INFO] [stdout] 9 | | .map(|x| x.expect("unable to parse line")) [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/day4.rs:31:18 [INFO] [stdout] | [INFO] [stdout] 31 | .unwrap() [INFO] [stdout] | __________________^ [INFO] [stdout] 32 | | .clone()); [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/day4.rs:34:18 [INFO] [stdout] | [INFO] [stdout] 34 | .unwrap() [INFO] [stdout] | __________________^ [INFO] [stdout] 35 | | .clone()); [INFO] [stdout] | |________________^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/day4.rs:45:41 [INFO] [stdout] | [INFO] [stdout] 45 | let start_str = ends.get(0).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/day4.rs:48:39 [INFO] [stdout] | [INFO] [stdout] 48 | let end_str = ends.get(1).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/day7.rs:14:38 [INFO] [stdout] | [INFO] [stdout] 14 | let first = split.get(0).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/day8.rs:169:22 [INFO] [stdout] | [INFO] [stdout] 169 | .filter(|t| t.clone() >= height) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `i32` does not implement `Clone`, so calling `clone` on `&i32` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/day10.rs:27:36 [INFO] [stdout] | [INFO] [stdout] 27 | let cmd = split.get(0).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v` [INFO] [stdout] --> src/day10.rs:20:27 [INFO] [stdout] | [INFO] [stdout] 20 | Command::Addx(v) => vec![self.clone(), Command::Noop], [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `aoc2022` (lib test) due to 2 previous errors; 10 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/day7.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | Dir(String), [INFO] [stdout] | --- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `LsResult` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 8 | Dir(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_on_sprite` is never used [INFO] [stdout] --> src/day10.rs:59:4 [INFO] [stdout] | [INFO] [stdout] 59 | fn is_on_sprite(index: i32, sprite: i32) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 6 | let file = File::open(path).expect("no such file"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 7 | let buff = BufReader::new(file); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | / buff.lines() [INFO] [stdout] 9 | | .map(|x| x.expect("unable to parse line")) [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/day4.rs:31:18 [INFO] [stdout] | [INFO] [stdout] 31 | .unwrap() [INFO] [stdout] | __________________^ [INFO] [stdout] 32 | | .clone()); [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/day4.rs:34:18 [INFO] [stdout] | [INFO] [stdout] 34 | .unwrap() [INFO] [stdout] | __________________^ [INFO] [stdout] 35 | | .clone()); [INFO] [stdout] | |________________^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/day4.rs:45:41 [INFO] [stdout] | [INFO] [stdout] 45 | let start_str = ends.get(0).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/day4.rs:48:39 [INFO] [stdout] | [INFO] [stdout] 48 | let end_str = ends.get(1).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/day7.rs:14:38 [INFO] [stdout] | [INFO] [stdout] 14 | let first = split.get(0).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/day8.rs:169:22 [INFO] [stdout] | [INFO] [stdout] 169 | .filter(|t| t.clone() >= height) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `i32` does not implement `Clone`, so calling `clone` on `&i32` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/day10.rs:27:36 [INFO] [stdout] | [INFO] [stdout] 27 | let cmd = split.get(0).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `aoc2022` (lib) due to 2 previous errors; 10 warnings emitted [INFO] running `Command { std: "docker" "inspect" "14857cf9e86629892c00db86db550829daafce6cc7a77e58b6b4c7990ef34a5a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "14857cf9e86629892c00db86db550829daafce6cc7a77e58b6b4c7990ef34a5a", kill_on_drop: false }` [INFO] [stdout] 14857cf9e86629892c00db86db550829daafce6cc7a77e58b6b4c7990ef34a5a