[INFO] cloning repository https://github.com/an-prata/whim [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/an-prata/whim" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fan-prata%2Fwhim", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fan-prata%2Fwhim'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ea9fc84f654e4b3d113b69070a45841680deb98c [INFO] checking an-prata/whim/ea9fc84f654e4b3d113b69070a45841680deb98c against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fan-prata%2Fwhim" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/an-prata/whim on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/an-prata/whim [INFO] finished tweaking git repo https://github.com/an-prata/whim [INFO] tweaked toml for git repo https://github.com/an-prata/whim written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/an-prata/whim already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 67165756b9317c15b43618361d648adffc845d9334cee3ec1568a713408b002b [INFO] running `Command { std: "docker" "start" "-a" "67165756b9317c15b43618361d648adffc845d9334cee3ec1568a713408b002b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "67165756b9317c15b43618361d648adffc845d9334cee3ec1568a713408b002b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "67165756b9317c15b43618361d648adffc845d9334cee3ec1568a713408b002b", kill_on_drop: false }` [INFO] [stdout] 67165756b9317c15b43618361d648adffc845d9334cee3ec1568a713408b002b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8ef8275e1c2e726980e5e79abde627a72e645684600adb48b0a531b055cf80e2 [INFO] running `Command { std: "docker" "start" "-a" "8ef8275e1c2e726980e5e79abde627a72e645684600adb48b0a531b055cf80e2", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.64 [INFO] [stderr] Compiling unicode-ident v1.0.10 [INFO] [stderr] Compiling quote v1.0.29 [INFO] [stderr] Compiling serde v1.0.171 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling unicase v2.6.0 [INFO] [stderr] Compiling pulldown-cmark v0.9.3 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Checking time-core v0.1.1 [INFO] [stderr] Checking num_threads v0.1.6 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking build_html v2.4.0 [INFO] [stderr] Compiling syn v2.0.25 [INFO] [stderr] Compiling serde_derive v1.0.171 [INFO] [stderr] Checking time v0.3.23 [INFO] [stderr] Checking ron v0.8.0 [INFO] [stderr] Checking whim v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `borrow::Cow` [INFO] [stdout] --> src/md_content.rs:8:11 [INFO] [stdout] | [INFO] [stdout] 8 | use std::{borrow::Cow, rc::Rc}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `borrow::Cow` [INFO] [stdout] --> src/md_content.rs:8:11 [INFO] [stdout] | [INFO] [stdout] 8 | use std::{borrow::Cow, rc::Rc}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `unwrap_command` and `unwrap_flag` are never used [INFO] [stdout] --> src/args.rs:237:12 [INFO] [stdout] | [INFO] [stdout] 236 | impl ArgsItem { [INFO] [stdout] | ------------- methods in this implementation [INFO] [stdout] 237 | pub fn unwrap_command(self) -> Command { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 244 | pub fn unwrap_flag(self) -> Flag { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `single_char` is never used [INFO] [stdout] --> src/args.rs:319:12 [INFO] [stdout] | [INFO] [stdout] 301 | impl Flag { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 319 | pub fn single_char(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/args.rs:372:23 [INFO] [stdout] | [INFO] [stdout] 372 | MalformedArgument(Rc), [INFO] [stdout] | ----------------- ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 372 | MalformedArgument(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `parent_accessors` is never used [INFO] [stdout] --> src/href.rs:19:8 [INFO] [stdout] | [INFO] [stdout] 5 | pub trait Href { [INFO] [stdout] | ---- method in this trait [INFO] [stdout] ... [INFO] [stdout] 19 | fn parent_accessors(&self) -> usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `mod_time` and `create_time` are never used [INFO] [stdout] --> src/library.rs:355:12 [INFO] [stdout] | [INFO] [stdout] 295 | impl Document { [INFO] [stdout] | ------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 355 | pub fn mod_time(&self) -> time::OffsetDateTime { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 362 | pub fn create_time(&self) -> time::OffsetDateTime { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `DirectoryReadError` is never constructed [INFO] [stdout] --> src/library.rs:400:5 [INFO] [stdout] | [INFO] [stdout] 382 | pub enum Error { [INFO] [stdout] | ----- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 400 | DirectoryReadError, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Error` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/library.rs:69:13 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn open(path: impl AsRef) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | ron::from_str( [INFO] [stdout] 69 | fs::read_to_string(path) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/library.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn save(&self, path: impl AsRef) -> Result<()> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | / fs::write( [INFO] [stdout] 82 | | path, [INFO] [stdout] 83 | | ron::ser::to_string_pretty(self, ron::ser::PrettyConfig::default()) [INFO] [stdout] 84 | | .map_err(|_| Error::SerializationError)?, [INFO] [stdout] 85 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/library.rs:306:25 [INFO] [stdout] | [INFO] [stdout] 301 | pub fn open(path: impl AsRef) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 306 | name: match content.title() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `whim` (bin "whim" test) due to 4 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `flag` is never used [INFO] [stdout] --> src/args.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 19 | / impl ArgsParser [INFO] [stdout] 20 | | where [INFO] [stdout] 21 | | T: Iterator, [INFO] [stdout] 22 | | I: AsRef, [INFO] [stdout] | |__________________- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 52 | pub fn flag(mut self, flag: Flag) -> Self { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `flags` is never read [INFO] [stdout] --> src/args.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 132 | pub struct ParsedArgs { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 133 | pub items: Vec, [INFO] [stdout] 134 | flags: Vec, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `flags` is never used [INFO] [stdout] --> src/args.rs:148:12 [INFO] [stdout] | [INFO] [stdout] 137 | impl ParsedArgs { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 148 | pub fn flags(&self) -> HashMap> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `unwrap_command` and `unwrap_flag` are never used [INFO] [stdout] --> src/args.rs:237:12 [INFO] [stdout] | [INFO] [stdout] 236 | impl ArgsItem { [INFO] [stdout] | ------------- methods in this implementation [INFO] [stdout] 237 | pub fn unwrap_command(self) -> Command { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 244 | pub fn unwrap_flag(self) -> Flag { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Bool`, `Uint`, `Int`, and `String` are never constructed [INFO] [stdout] --> src/args.rs:295:5 [INFO] [stdout] | [INFO] [stdout] 286 | pub enum Flag { [INFO] [stdout] | ---- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 295 | Bool(Rc), [INFO] [stdout] | ^^^^ [INFO] [stdout] 296 | Uint(Rc), [INFO] [stdout] | ^^^^ [INFO] [stdout] 297 | Int(Rc), [INFO] [stdout] | ^^^ [INFO] [stdout] 298 | String(Rc), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Flag` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `single_char` is never used [INFO] [stdout] --> src/args.rs:319:12 [INFO] [stdout] | [INFO] [stdout] 301 | impl Flag { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 319 | pub fn single_char(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/args.rs:372:23 [INFO] [stdout] | [INFO] [stdout] 372 | MalformedArgument(Rc), [INFO] [stdout] | ----------------- ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 372 | MalformedArgument(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `parent_accessors` is never used [INFO] [stdout] --> src/href.rs:19:8 [INFO] [stdout] | [INFO] [stdout] 5 | pub trait Href { [INFO] [stdout] | ---- method in this trait [INFO] [stdout] ... [INFO] [stdout] 19 | fn parent_accessors(&self) -> usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `mod_time` and `create_time` are never used [INFO] [stdout] --> src/library.rs:355:12 [INFO] [stdout] | [INFO] [stdout] 295 | impl Document { [INFO] [stdout] | ------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 355 | pub fn mod_time(&self) -> time::OffsetDateTime { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 362 | pub fn create_time(&self) -> time::OffsetDateTime { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `DirectoryReadError` is never constructed [INFO] [stdout] --> src/library.rs:400:5 [INFO] [stdout] | [INFO] [stdout] 382 | pub enum Error { [INFO] [stdout] | ----- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 400 | DirectoryReadError, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Error` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/library.rs:69:13 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn open(path: impl AsRef) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | ron::from_str( [INFO] [stdout] 69 | fs::read_to_string(path) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/library.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn save(&self, path: impl AsRef) -> Result<()> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | / fs::write( [INFO] [stdout] 82 | | path, [INFO] [stdout] 83 | | ron::ser::to_string_pretty(self, ron::ser::PrettyConfig::default()) [INFO] [stdout] 84 | | .map_err(|_| Error::SerializationError)?, [INFO] [stdout] 85 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/library.rs:306:25 [INFO] [stdout] | [INFO] [stdout] 301 | pub fn open(path: impl AsRef) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 306 | name: match content.title() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `whim` (bin "whim") due to 4 previous errors; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8ef8275e1c2e726980e5e79abde627a72e645684600adb48b0a531b055cf80e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8ef8275e1c2e726980e5e79abde627a72e645684600adb48b0a531b055cf80e2", kill_on_drop: false }` [INFO] [stdout] 8ef8275e1c2e726980e5e79abde627a72e645684600adb48b0a531b055cf80e2