[INFO] cloning repository https://github.com/amveiga/BitTorrent-Public [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/amveiga/BitTorrent-Public" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Famveiga%2FBitTorrent-Public", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Famveiga%2FBitTorrent-Public'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 318c01bd140b8294bec585635a59c270108b06f8 [INFO] checking amveiga/BitTorrent-Public/318c01bd140b8294bec585635a59c270108b06f8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Famveiga%2FBitTorrent-Public" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/amveiga/BitTorrent-Public on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/amveiga/BitTorrent-Public [INFO] finished tweaking git repo https://github.com/amveiga/BitTorrent-Public [INFO] tweaked toml for git repo https://github.com/amveiga/BitTorrent-Public written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/amveiga/BitTorrent-Public already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4c990f9059c852be6c3a49e86f6306498ec470127dfb0151646621059f13bedc [INFO] running `Command { std: "docker" "start" "-a" "4c990f9059c852be6c3a49e86f6306498ec470127dfb0151646621059f13bedc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4c990f9059c852be6c3a49e86f6306498ec470127dfb0151646621059f13bedc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4c990f9059c852be6c3a49e86f6306498ec470127dfb0151646621059f13bedc", kill_on_drop: false }` [INFO] [stdout] 4c990f9059c852be6c3a49e86f6306498ec470127dfb0151646621059f13bedc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 468561ade7f28a619f4c3f2dc0cde8fa7f33adddbc4ba355eae3bc25a578a996 [INFO] running `Command { std: "docker" "start" "-a" "468561ade7f28a619f4c3f2dc0cde8fa7f33adddbc4ba355eae3bc25a578a996", kill_on_drop: false }` [INFO] [stderr] Compiling pkg-config v0.3.25 [INFO] [stderr] Compiling serde v1.0.139 [INFO] [stderr] Compiling smallvec v1.9.0 [INFO] [stderr] Compiling version-compare v0.1.0 [INFO] [stderr] Compiling proc-macro2 v1.0.40 [INFO] [stderr] Compiling quote v1.0.20 [INFO] [stderr] Compiling unicode-ident v1.0.1 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling anyhow v1.0.58 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Checking slab v0.4.6 [INFO] [stderr] Compiling ucd-trie v0.1.3 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Compiling gio v0.15.12 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Compiling serde_derive v1.0.139 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Compiling openssl v0.10.40 [INFO] [stderr] Compiling pest v2.1.3 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling cfg-expr v0.10.3 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking regex-syntax v0.6.26 [INFO] [stderr] Compiling native-tls v0.2.10 [INFO] [stderr] Compiling serde_json v1.0.82 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Compiling hex-literal v0.3.4 [INFO] [stderr] Compiling openssl-sys v0.9.74 [INFO] [stderr] Compiling gtk v0.15.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking crypto-common v0.1.4 [INFO] [stderr] Checking block-buffer v0.10.2 [INFO] [stderr] Checking digest v0.10.3 [INFO] [stderr] Checking sha-1 v0.10.0 [INFO] [stderr] Checking regex v1.5.6 [INFO] [stderr] Compiling semver-parser v0.10.2 [INFO] [stderr] Compiling semver v0.11.0 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Compiling rustc_version v0.3.3 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Compiling field-offset v0.3.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling thiserror-impl v1.0.31 [INFO] [stderr] Compiling openssl-macros v0.1.0 [INFO] [stderr] Compiling toml v0.5.9 [INFO] [stderr] Compiling thiserror v1.0.31 [INFO] [stderr] Compiling system-deps v6.0.2 [INFO] [stderr] Compiling proc-macro-crate v1.1.3 [INFO] [stderr] Compiling glib-macros v0.15.11 [INFO] [stderr] Compiling gtk3-macros v0.15.4 [INFO] [stderr] Compiling glib-sys v0.15.10 [INFO] [stderr] Compiling gobject-sys v0.15.10 [INFO] [stderr] Compiling gio-sys v0.15.10 [INFO] [stderr] Compiling atk-sys v0.15.1 [INFO] [stderr] Compiling gdk-sys v0.15.1 [INFO] [stderr] Compiling pango-sys v0.15.10 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.15.10 [INFO] [stderr] Compiling cairo-sys-rs v0.15.1 [INFO] [stderr] Compiling gtk-sys v0.15.3 [INFO] [stderr] Checking glib v0.15.12 [INFO] [stderr] Checking cairo-rs v0.15.12 [INFO] [stderr] Checking pango v0.15.10 [INFO] [stderr] Checking atk v0.15.1 [INFO] [stderr] Checking gdk-pixbuf v0.15.11 [INFO] [stderr] Checking gdk v0.15.4 [INFO] [stderr] Checking sitos v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `networking::utils::get_available_port` [INFO] [stdout] --> src/bit_torrent/tracker/connection.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | networking::utils::get_available_port, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `networking::utils::get_available_port` [INFO] [stdout] --> src/bit_torrent/tracker/index.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | networking::utils::get_available_port, Connection, Ledger, TrackerError, TrackerStatus, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::Protocol` [INFO] [stdout] --> src/networking/protocol/bit_torrent/message/mod.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | pub use super::Protocol; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `networking::utils::get_available_port` [INFO] [stdout] --> src/bit_torrent/tracker/connection.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | networking::utils::get_available_port, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `networking::utils::get_available_port` [INFO] [stdout] --> src/bit_torrent/tracker/index.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | networking::utils::get_available_port, Connection, Ledger, TrackerError, TrackerStatus, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::Protocol` [INFO] [stdout] --> src/networking/protocol/bit_torrent/message/mod.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | pub use super::Protocol; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_torrent/peer/index.rs:45:20 [INFO] [stdout] | [INFO] [stdout] 27 | sender_torrent: Arc>>, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | sender_peers: Arc>>, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | let common_information = CommonInformation::new( [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let have = Arc::new(Mutex::new(Bitfield::new(common_information.total_pieces))); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let peers = Arc::new(Mutex::new(PeerList::new())); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | state: Arc::new(Mutex::new(PeerState::NoPieces(format!( [INFO] [stdout] | ____________________^ [INFO] [stdout] 46 | | "{}/{}", [INFO] [stdout] 47 | | temp_directory, common_information.file_name [INFO] [stdout] 48 | | )))), [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_torrent/peer/index.rs:53:23 [INFO] [stdout] | [INFO] [stdout] 27 | sender_torrent: Arc>>, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | sender_peers: Arc>>, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | let common_information = CommonInformation::new( [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let have = Arc::new(Mutex::new(Bitfield::new(common_information.total_pieces))); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let peers = Arc::new(Mutex::new(PeerList::new())); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | handlers: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_torrent/peer/index.rs:58:23 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn activate(mut self, remove_rx: Receiver) -> thread::JoinHandle<()> { [INFO] [stdout] | -------- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 59 | | self.handlers.push(RemoveTorrent::wait_signal( [INFO] [stdout] 60 | | self.common_information.torrent_pathname.clone(), [INFO] [stdout] 61 | | remove_rx, [INFO] [stdout] ... | [INFO] [stdout] 107 | | log::info!("Peer::activate(): All threads joined"); [INFO] [stdout] 108 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_torrent/peer/peer_connection.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 27 | bitfield: Arc>, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | peers: Arc>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | common_information: CommonInformation, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | peer: PeerRecord, [INFO] [stdout] 31 | peer_state: Arc>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let stream = client.connect(&address)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | [INFO] [stdout] 43 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 44 | | peer_state, [INFO] [stdout] 45 | | stream, [INFO] [stdout] 46 | | client, [INFO] [stdout] ... | [INFO] [stdout] 52 | | instant: Instant::now(), [INFO] [stdout] 53 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_torrent/peer/peer_connection.rs:63:23 [INFO] [stdout] | [INFO] [stdout] 57 | bitfield: Arc>, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | peers: Arc>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | common_information: CommonInformation, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | peer: PeerRecord, [INFO] [stdout] 61 | peer_state: Arc>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | ) -> thread::JoinHandle<()> { [INFO] [stdout] 63 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 64 | | match PeerConnection::new( [INFO] [stdout] 65 | | bitfield, [INFO] [stdout] 66 | | Arc::clone(&peers), [INFO] [stdout] ... | [INFO] [stdout] 110 | | }; [INFO] [stdout] 111 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_torrent/peer/peer_handler.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 18 | bitfield: Arc>, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | peers: Arc>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | common_information: CommonInformation, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | state: Arc>, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | ) -> Result { [INFO] [stdout] 23 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 24 | | state, [INFO] [stdout] 25 | | bitfield, [INFO] [stdout] 26 | | peers, [INFO] [stdout] 27 | | common_information, [INFO] [stdout] 28 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_torrent/peer/peer_handler.rs:32:23 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn activate(self) -> JoinHandle<()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 33 | | let mut connections: Vec> = vec![]; [INFO] [stdout] 34 | | [INFO] [stdout] 35 | | loop { [INFO] [stdout] ... | [INFO] [stdout] 111 | | } [INFO] [stdout] 112 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_torrent/peer/remove_torrent.rs:16:23 [INFO] [stdout] | [INFO] [stdout] 13 | remove_rx: Receiver, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | state: Arc>, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | ) -> JoinHandle<()> { [INFO] [stdout] 16 | thread::spawn(move || loop { [INFO] [stdout] | _______________________^ [INFO] [stdout] 17 | | if let PeerState::Broken = &*state.lock().unwrap() { [INFO] [stdout] 18 | | break; [INFO] [stdout] 19 | | } [INFO] [stdout] ... | [INFO] [stdout] 33 | | thread::yield_now(); [INFO] [stdout] 34 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_torrent/peer/server_connection.rs:37:23 [INFO] [stdout] | [INFO] [stdout] 30 | bitfield: Arc>, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | peer_state: Arc>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | common_information: CommonInformation, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | mut stream: TcpStream, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | ) -> thread::JoinHandle<()> { [INFO] [stdout] 35 | let mut connection = Self::new(bitfield, peer_state, common_information); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | [INFO] [stdout] 37 | thread::spawn(move || loop { [INFO] [stdout] | _______________________^ [INFO] [stdout] 38 | | let state_guard = connection.peer_state.lock().unwrap(); [INFO] [stdout] 39 | | [INFO] [stdout] 40 | | if let PeerState::Broken = &*state_guard { [INFO] [stdout] ... | [INFO] [stdout] 75 | | } [INFO] [stdout] 76 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_torrent/peer/server_handler.rs:76:23 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn activate(self) -> thread::JoinHandle<()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 77 | | let connections: Vec> = vec![]; [INFO] [stdout] 78 | | [INFO] [stdout] 79 | | self.socket.set_nonblocking(true).unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 100 | | } [INFO] [stdout] 101 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_torrent/peer/tracker_connection.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 26 | bitfield: Arc>, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | peers: Arc>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | common_information: CommonInformation, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | state: Arc>, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | ) -> Result { [INFO] [stdout] 31 | let (client, tracker_address) = InterfaceProtocolHandler::new(announce.clone())?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | [INFO] [stdout] 33 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 34 | | announce, [INFO] [stdout] 35 | | state, [INFO] [stdout] 36 | | client, [INFO] [stdout] ... | [INFO] [stdout] 41 | | sleep: 2, [INFO] [stdout] 42 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_torrent/peer/tracker_connection.rs:46:23 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn activate(mut self, listening_port: u16, listening_ip: String) -> thread::JoinHandle<()> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 47 | | let mut retries = 3; [INFO] [stdout] 48 | | [INFO] [stdout] 49 | | loop { [INFO] [stdout] ... | [INFO] [stdout] 151 | | } [INFO] [stdout] 152 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_torrent/tracker/connection.rs:33:23 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn activate(mut self) -> thread::JoinHandle<()> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 34 | | let mut buffer = [0_u8; 1024]; [INFO] [stdout] 35 | | [INFO] [stdout] 36 | | if self.stream.read(&mut buffer).is_ok() { [INFO] [stdout] ... | [INFO] [stdout] 100 | | } [INFO] [stdout] 101 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_torrent/tracker/index.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 18 | let listener = TcpListener::bind(String::from("127.0.0.1:8080")) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 26 | | listener, [INFO] [stdout] 27 | | ledger: Arc::new(Mutex::new(Ledger::new())), [INFO] [stdout] 28 | | status: Arc::new(Mutex::new(TrackerStatus::Active)), [INFO] [stdout] 29 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_torrent/tracker/index.rs:33:23 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn activate(self, rx: Receiver) -> thread::JoinHandle<()> { [INFO] [stdout] | ---- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 34 | | let mut connections: Vec> = [INFO] [stdout] 35 | | vec![TrackerStatus::await_signal(Arc::clone(&self.status), rx)]; [INFO] [stdout] ... | [INFO] [stdout] 70 | | } [INFO] [stdout] 71 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_torrent/tracker/tracker_status.rs:17:23 [INFO] [stdout] | [INFO] [stdout] 14 | state: Arc>, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | remove_rx: Receiver, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | ) -> JoinHandle<()> { [INFO] [stdout] 17 | thread::spawn(move || loop { [INFO] [stdout] | _______________________^ [INFO] [stdout] 18 | | if TrackerStatus::Break == *state.lock().unwrap() { [INFO] [stdout] 19 | | break; [INFO] [stdout] 20 | | } [INFO] [stdout] ... | [INFO] [stdout] 37 | | thread::yield_now(); [INFO] [stdout] 38 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_system/file/index.rs:111:12 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn new_file_from_piece>(piece: &[u8], pathname: T) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | let dir = fs::create_dir_all(format!( [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | let mut handler = File::open_file(&format!( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | Ok(Self { handler, pathname }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logger/index.rs:107:17 [INFO] [stdout] | [INFO] [stdout] 105 | fn new(tx: Sender) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | Self { [INFO] [stdout] 107 | tx: Mutex::new(tx), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logger/index.rs:147:20 [INFO] [stdout] | [INFO] [stdout] 116 | let (tx, rx): (Sender, Receiver) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | let new_logger = Self::new(tx); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | [INFO] [stdout] 147 | Self::init(Box::new(new_logger), max_level_filter) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/networking/client/index.rs:38:15 [INFO] [stdout] | [INFO] [stdout] 36 | message: M, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | ) -> Result<(), NetworkingError> { [INFO] [stdout] 38 | match to.write_all(message.as_ref()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/networking/protocol/https_tracker/index.rs:91:15 [INFO] [stdout] | [INFO] [stdout] 84 | let connector = TlsConnector::new().expect("Failed to creat TlsConnector"); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | match TcpStream::connect(format!("{}:443", split[0])) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_torrent/peer/index.rs:45:20 [INFO] [stdout] | [INFO] [stdout] 27 | sender_torrent: Arc>>, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | sender_peers: Arc>>, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | let common_information = CommonInformation::new( [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let have = Arc::new(Mutex::new(Bitfield::new(common_information.total_pieces))); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let peers = Arc::new(Mutex::new(PeerList::new())); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | state: Arc::new(Mutex::new(PeerState::NoPieces(format!( [INFO] [stdout] | ____________________^ [INFO] [stdout] 46 | | "{}/{}", [INFO] [stdout] 47 | | temp_directory, common_information.file_name [INFO] [stdout] 48 | | )))), [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_torrent/peer/index.rs:53:23 [INFO] [stdout] | [INFO] [stdout] 27 | sender_torrent: Arc>>, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | sender_peers: Arc>>, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | let common_information = CommonInformation::new( [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let have = Arc::new(Mutex::new(Bitfield::new(common_information.total_pieces))); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let peers = Arc::new(Mutex::new(PeerList::new())); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | handlers: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_torrent/peer/index.rs:58:23 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn activate(mut self, remove_rx: Receiver) -> thread::JoinHandle<()> { [INFO] [stdout] | -------- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 59 | | self.handlers.push(RemoveTorrent::wait_signal( [INFO] [stdout] 60 | | self.common_information.torrent_pathname.clone(), [INFO] [stdout] 61 | | remove_rx, [INFO] [stdout] ... | [INFO] [stdout] 107 | | log::info!("Peer::activate(): All threads joined"); [INFO] [stdout] 108 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 21 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_torrent/peer/peer_connection.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 27 | bitfield: Arc>, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | peers: Arc>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | common_information: CommonInformation, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | peer: PeerRecord, [INFO] [stdout] 31 | peer_state: Arc>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let stream = client.connect(&address)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | [INFO] [stdout] 43 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 44 | | peer_state, [INFO] [stdout] 45 | | stream, [INFO] [stdout] 46 | | client, [INFO] [stdout] ... | [INFO] [stdout] 52 | | instant: Instant::now(), [INFO] [stdout] 53 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_torrent/peer/peer_connection.rs:63:23 [INFO] [stdout] | [INFO] [stdout] 57 | bitfield: Arc>, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | peers: Arc>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | common_information: CommonInformation, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | peer: PeerRecord, [INFO] [stdout] 61 | peer_state: Arc>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | ) -> thread::JoinHandle<()> { [INFO] [stdout] 63 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 64 | | match PeerConnection::new( [INFO] [stdout] 65 | | bitfield, [INFO] [stdout] 66 | | Arc::clone(&peers), [INFO] [stdout] ... | [INFO] [stdout] 110 | | }; [INFO] [stdout] 111 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_torrent/peer/peer_handler.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 18 | bitfield: Arc>, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | peers: Arc>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | common_information: CommonInformation, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | state: Arc>, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | ) -> Result { [INFO] [stdout] 23 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 24 | | state, [INFO] [stdout] 25 | | bitfield, [INFO] [stdout] 26 | | peers, [INFO] [stdout] 27 | | common_information, [INFO] [stdout] 28 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_torrent/peer/peer_handler.rs:32:23 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn activate(self) -> JoinHandle<()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 33 | | let mut connections: Vec> = vec![]; [INFO] [stdout] 34 | | [INFO] [stdout] 35 | | loop { [INFO] [stdout] ... | [INFO] [stdout] 111 | | } [INFO] [stdout] 112 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_torrent/peer/remove_torrent.rs:16:23 [INFO] [stdout] | [INFO] [stdout] 13 | remove_rx: Receiver, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | state: Arc>, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | ) -> JoinHandle<()> { [INFO] [stdout] 16 | thread::spawn(move || loop { [INFO] [stdout] | _______________________^ [INFO] [stdout] 17 | | if let PeerState::Broken = &*state.lock().unwrap() { [INFO] [stdout] 18 | | break; [INFO] [stdout] 19 | | } [INFO] [stdout] ... | [INFO] [stdout] 33 | | thread::yield_now(); [INFO] [stdout] 34 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_torrent/peer/server_connection.rs:37:23 [INFO] [stdout] | [INFO] [stdout] 30 | bitfield: Arc>, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | peer_state: Arc>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | common_information: CommonInformation, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | mut stream: TcpStream, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | ) -> thread::JoinHandle<()> { [INFO] [stdout] 35 | let mut connection = Self::new(bitfield, peer_state, common_information); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | [INFO] [stdout] 37 | thread::spawn(move || loop { [INFO] [stdout] | _______________________^ [INFO] [stdout] 38 | | let state_guard = connection.peer_state.lock().unwrap(); [INFO] [stdout] 39 | | [INFO] [stdout] 40 | | if let PeerState::Broken = &*state_guard { [INFO] [stdout] ... | [INFO] [stdout] 75 | | } [INFO] [stdout] 76 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_torrent/peer/server_handler.rs:76:23 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn activate(self) -> thread::JoinHandle<()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 77 | | let connections: Vec> = vec![]; [INFO] [stdout] 78 | | [INFO] [stdout] 79 | | self.socket.set_nonblocking(true).unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 100 | | } [INFO] [stdout] 101 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_torrent/peer/tracker_connection.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 26 | bitfield: Arc>, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | peers: Arc>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | common_information: CommonInformation, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | state: Arc>, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | ) -> Result { [INFO] [stdout] 31 | let (client, tracker_address) = InterfaceProtocolHandler::new(announce.clone())?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | [INFO] [stdout] 33 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 34 | | announce, [INFO] [stdout] 35 | | state, [INFO] [stdout] 36 | | client, [INFO] [stdout] ... | [INFO] [stdout] 41 | | sleep: 2, [INFO] [stdout] 42 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_torrent/peer/tracker_connection.rs:46:23 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn activate(mut self, listening_port: u16, listening_ip: String) -> thread::JoinHandle<()> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 47 | | let mut retries = 3; [INFO] [stdout] 48 | | [INFO] [stdout] 49 | | loop { [INFO] [stdout] ... | [INFO] [stdout] 151 | | } [INFO] [stdout] 152 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_torrent/tracker/connection.rs:33:23 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn activate(mut self) -> thread::JoinHandle<()> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 34 | | let mut buffer = [0_u8; 1024]; [INFO] [stdout] 35 | | [INFO] [stdout] 36 | | if self.stream.read(&mut buffer).is_ok() { [INFO] [stdout] ... | [INFO] [stdout] 100 | | } [INFO] [stdout] 101 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_torrent/tracker/index.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 18 | let listener = TcpListener::bind(String::from("127.0.0.1:8080")) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 26 | | listener, [INFO] [stdout] 27 | | ledger: Arc::new(Mutex::new(Ledger::new())), [INFO] [stdout] 28 | | status: Arc::new(Mutex::new(TrackerStatus::Active)), [INFO] [stdout] 29 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_torrent/tracker/index.rs:33:23 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn activate(self, rx: Receiver) -> thread::JoinHandle<()> { [INFO] [stdout] | ---- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 34 | | let mut connections: Vec> = [INFO] [stdout] 35 | | vec![TrackerStatus::await_signal(Arc::clone(&self.status), rx)]; [INFO] [stdout] ... | [INFO] [stdout] 70 | | } [INFO] [stdout] 71 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_torrent/tracker/tracker_status.rs:17:23 [INFO] [stdout] | [INFO] [stdout] 14 | state: Arc>, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | remove_rx: Receiver, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | ) -> JoinHandle<()> { [INFO] [stdout] 17 | thread::spawn(move || loop { [INFO] [stdout] | _______________________^ [INFO] [stdout] 18 | | if TrackerStatus::Break == *state.lock().unwrap() { [INFO] [stdout] 19 | | break; [INFO] [stdout] 20 | | } [INFO] [stdout] ... | [INFO] [stdout] 37 | | thread::yield_now(); [INFO] [stdout] 38 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_system/file/index.rs:111:12 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn new_file_from_piece>(piece: &[u8], pathname: T) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | let dir = fs::create_dir_all(format!( [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | let mut handler = File::open_file(&format!( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | Ok(Self { handler, pathname }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logger/index.rs:107:17 [INFO] [stdout] | [INFO] [stdout] 105 | fn new(tx: Sender) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | Self { [INFO] [stdout] 107 | tx: Mutex::new(tx), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logger/index.rs:147:20 [INFO] [stdout] | [INFO] [stdout] 116 | let (tx, rx): (Sender, Receiver) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | let new_logger = Self::new(tx); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | [INFO] [stdout] 147 | Self::init(Box::new(new_logger), max_level_filter) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/networking/client/index.rs:38:15 [INFO] [stdout] | [INFO] [stdout] 36 | message: M, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | ) -> Result<(), NetworkingError> { [INFO] [stdout] 38 | match to.write_all(message.as_ref()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/networking/protocol/https_tracker/index.rs:91:15 [INFO] [stdout] | [INFO] [stdout] 84 | let connector = TlsConnector::new().expect("Failed to creat TlsConnector"); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | match TcpStream::connect(format!("{}:443", split[0])) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sitos` (lib) due to 22 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 21 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sitos` (lib test) due to 22 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "468561ade7f28a619f4c3f2dc0cde8fa7f33adddbc4ba355eae3bc25a578a996", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "468561ade7f28a619f4c3f2dc0cde8fa7f33adddbc4ba355eae3bc25a578a996", kill_on_drop: false }` [INFO] [stdout] 468561ade7f28a619f4c3f2dc0cde8fa7f33adddbc4ba355eae3bc25a578a996