[INFO] cloning repository https://github.com/amoilanen/bittorrent-client [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/amoilanen/bittorrent-client" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Famoilanen%2Fbittorrent-client", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Famoilanen%2Fbittorrent-client'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 30b9d0622234b7467cf0ad4d5156660f6c5af468 [INFO] checking amoilanen/bittorrent-client/30b9d0622234b7467cf0ad4d5156660f6c5af468 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Famoilanen%2Fbittorrent-client" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/amoilanen/bittorrent-client on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/amoilanen/bittorrent-client [INFO] finished tweaking git repo https://github.com/amoilanen/bittorrent-client [INFO] tweaked toml for git repo https://github.com/amoilanen/bittorrent-client written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/amoilanen/bittorrent-client already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c2e06279ede6834df92e5ef37bf2073d82e0549d4f558b857fcf59492a7bc892 [INFO] running `Command { std: "docker" "start" "-a" "c2e06279ede6834df92e5ef37bf2073d82e0549d4f558b857fcf59492a7bc892", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c2e06279ede6834df92e5ef37bf2073d82e0549d4f558b857fcf59492a7bc892", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c2e06279ede6834df92e5ef37bf2073d82e0549d4f558b857fcf59492a7bc892", kill_on_drop: false }` [INFO] [stdout] c2e06279ede6834df92e5ef37bf2073d82e0549d4f558b857fcf59492a7bc892 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c6acf74ea088d7d3c2458eb119bb0b31815164635782187732816027308c17d7 [INFO] running `Command { std: "docker" "start" "-a" "c6acf74ea088d7d3c2458eb119bb0b31815164635782187732816027308c17d7", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Checking pin-project-lite v0.2.12 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Checking bytes v1.3.0 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking socket2 v0.5.3 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Compiling slab v0.4.8 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Compiling serde v1.0.183 [INFO] [stderr] Compiling rustix v0.38.8 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling serde_derive v1.0.183 [INFO] [stderr] Compiling openssl v0.10.56 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling cc v1.0.82 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Checking linux-raw-sys v0.4.5 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Compiling syn v2.0.29 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Checking try-lock v0.2.4 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling syn v1.0.48 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Compiling openssl-sys v0.9.91 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Compiling serde_json v1.0.105 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking aho-corasick v1.0.4 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Compiling anyhow v1.0.68 [INFO] [stderr] Checking regex-syntax v0.7.4 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Compiling thiserror v1.0.38 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking clap_builder v4.3.22 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_bytes v0.11.12 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking encoding_rs v0.8.32 [INFO] [stderr] Checking ipnet v2.8.0 [INFO] [stderr] Checking base64 v0.21.2 [INFO] [stderr] Checking cpufeatures v0.2.9 [INFO] [stderr] Checking fastrand v2.0.0 [INFO] [stderr] Checking tempfile v3.7.1 [INFO] [stderr] Checking sha1 v0.10.5 [INFO] [stderr] Checking serde_bencode v0.2.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking regex-automata v0.3.6 [INFO] [stderr] Compiling thiserror-impl v1.0.38 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling clap_derive v4.3.12 [INFO] [stderr] Checking tokio v1.32.0 [INFO] [stderr] Checking clap v4.3.22 [INFO] [stderr] Checking regex v1.9.3 [INFO] [stderr] Checking tokio-util v0.7.8 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking h2 v0.3.20 [INFO] [stderr] Checking hyper v0.14.27 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.18 [INFO] [stderr] Checking bittorrent-starter-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::env` [INFO] [stdout] --> src/main.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::env; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::env` [INFO] [stdout] --> src/main.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::env; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `connection_id` [INFO] [stdout] --> src/tracker.rs:126:17 [INFO] [stdout] | [INFO] [stdout] 126 | let connection_id = connect_response.connection_id; [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_connection_id` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `request` [INFO] [stdout] --> src/tracker.rs:81:34 [INFO] [stdout] | [INFO] [stdout] 81 | fn get_udp(&self, url: &str, request: &TrackerRequest) -> Result { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_request` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `connection_id` [INFO] [stdout] --> src/tracker.rs:126:17 [INFO] [stdout] | [INFO] [stdout] 126 | let connection_id = connect_response.connection_id; [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_connection_id` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `request` [INFO] [stdout] --> src/tracker.rs:81:34 [INFO] [stdout] | [INFO] [stdout] 81 | fn get_udp(&self, url: &str, request: &TrackerRequest) -> Result { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_request` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `response` [INFO] [stdout] --> src/tracker.rs:193:13 [INFO] [stdout] | [INFO] [stdout] 193 | let response = tracker.get_udp(&tracker.url,&tracker_request).unwrap(); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_response` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `interval` is never read [INFO] [stdout] --> src/tracker.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 17 | pub(crate) struct TrackerResponse { [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] 18 | interval: u32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `action` is never read [INFO] [stdout] --> src/tracker/messages.rs:53:16 [INFO] [stdout] | [INFO] [stdout] 52 | pub(crate) struct ConnectResponse { [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] 53 | pub(crate) action: Action, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ConnectResponse` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `to_string` are never used [INFO] [stdout] --> src/peer.rs:76:19 [INFO] [stdout] | [INFO] [stdout] 68 | impl PeerMessage { [INFO] [stdout] | ---------------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 76 | pub(crate) fn new(message_id: PeerMessageId, payload: Vec) -> PeerMessage { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 92 | pub(crate) fn to_string(&self) -> String { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `read_piece_from` is never used [INFO] [stdout] --> src/file.rs:14:15 [INFO] [stdout] | [INFO] [stdout] 14 | pub(crate) fn read_piece_from(file_path: &str, begin: usize, length: usize) -> Result, anyhow::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/torrent.rs:96:85 [INFO] [stdout] | [INFO] [stdout] 96 | let length: Option = info.get_optional_by_key("length").and_then(|x| x.as_number().ok()).map(|x| x as usize); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/torrent.rs:98:77 [INFO] [stdout] | [INFO] [stdout] 98 | if let Some(files) = info.get_optional_by_key("files").and_then(|x| x.as_values().ok()) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tracker.rs:136:13 [INFO] [stdout] | [INFO] [stdout] 83 | let socket: UdpSocket = UdpSocket::bind("0.0.0.0:6969")?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | Err(std::io::Error::new(std::io::ErrorKind::Other, format!("UDP support is not yet implemented, url = {}", self.url)).into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer.rs:254:12 [INFO] [stdout] | [INFO] [stdout] 246 | let mut stream = TcpStream::connect(format!("{}:{}", peer_address.address.to_string(), peer_address.port.to_string()))?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 254 | Ok((PeerHandshake { [INFO] [stdout] | ____________^ [INFO] [stdout] 255 | | info_hash, [INFO] [stdout] 256 | | peer: Peer { id: peer_id } [INFO] [stdout] 257 | | }, stream)) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bittorrent-starter-rust` (bin "bittorrent-starter-rust") due to 5 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `interval` is never read [INFO] [stdout] --> src/tracker.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 17 | pub(crate) struct TrackerResponse { [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] 18 | interval: u32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `action` is never read [INFO] [stdout] --> src/tracker/messages.rs:53:16 [INFO] [stdout] | [INFO] [stdout] 52 | pub(crate) struct ConnectResponse { [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] 53 | pub(crate) action: Action, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ConnectResponse` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `to_string` is never used [INFO] [stdout] --> src/peer.rs:92:19 [INFO] [stdout] | [INFO] [stdout] 68 | impl PeerMessage { [INFO] [stdout] | ---------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 92 | pub(crate) fn to_string(&self) -> String { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `read_piece_from` is never used [INFO] [stdout] --> src/file.rs:14:15 [INFO] [stdout] | [INFO] [stdout] 14 | pub(crate) fn read_piece_from(file_path: &str, begin: usize, length: usize) -> Result, anyhow::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/torrent.rs:96:85 [INFO] [stdout] | [INFO] [stdout] 96 | let length: Option = info.get_optional_by_key("length").and_then(|x| x.as_number().ok()).map(|x| x as usize); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/torrent.rs:98:77 [INFO] [stdout] | [INFO] [stdout] 98 | if let Some(files) = info.get_optional_by_key("files").and_then(|x| x.as_values().ok()) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tracker.rs:136:13 [INFO] [stdout] | [INFO] [stdout] 83 | let socket: UdpSocket = UdpSocket::bind("0.0.0.0:6969")?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | Err(std::io::Error::new(std::io::ErrorKind::Other, format!("UDP support is not yet implemented, url = {}", self.url)).into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer.rs:254:12 [INFO] [stdout] | [INFO] [stdout] 246 | let mut stream = TcpStream::connect(format!("{}:{}", peer_address.address.to_string(), peer_address.port.to_string()))?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 254 | Ok((PeerHandshake { [INFO] [stdout] | ____________^ [INFO] [stdout] 255 | | info_hash, [INFO] [stdout] 256 | | peer: Peer { id: peer_id } [INFO] [stdout] 257 | | }, stream)) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bittorrent-starter-rust` (bin "bittorrent-starter-rust" test) due to 5 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c6acf74ea088d7d3c2458eb119bb0b31815164635782187732816027308c17d7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c6acf74ea088d7d3c2458eb119bb0b31815164635782187732816027308c17d7", kill_on_drop: false }` [INFO] [stdout] c6acf74ea088d7d3c2458eb119bb0b31815164635782187732816027308c17d7