[INFO] cloning repository https://github.com/amkillam/file_rw [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/amkillam/file_rw" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Famkillam%2Ffile_rw", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Famkillam%2Ffile_rw'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9f57683dcd2c5588502d7952256bf1ade4eb37fa [INFO] checking amkillam/file_rw/9f57683dcd2c5588502d7952256bf1ade4eb37fa against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Famkillam%2Ffile_rw" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/amkillam/file_rw on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/amkillam/file_rw [INFO] finished tweaking git repo https://github.com/amkillam/file_rw [INFO] tweaked toml for git repo https://github.com/amkillam/file_rw written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/amkillam/file_rw already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a05cb16126cd2bccf3ba160c6e433ab002cf97d165ad2133046a743b829b8ffc [INFO] running `Command { std: "docker" "start" "-a" "a05cb16126cd2bccf3ba160c6e433ab002cf97d165ad2133046a743b829b8ffc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a05cb16126cd2bccf3ba160c6e433ab002cf97d165ad2133046a743b829b8ffc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a05cb16126cd2bccf3ba160c6e433ab002cf97d165ad2133046a743b829b8ffc", kill_on_drop: false }` [INFO] [stdout] a05cb16126cd2bccf3ba160c6e433ab002cf97d165ad2133046a743b829b8ffc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d0c9b48660cbf4532eadb24acf663b91175c4da4cf829d58b6b8cadb09354d2c [INFO] running `Command { std: "docker" "start" "-a" "d0c9b48660cbf4532eadb24acf663b91175c4da4cf829d58b6b8cadb09354d2c", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling serde_json v1.0.118 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking clap_builder v4.5.7 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking keccak v0.1.5 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking filepath v0.1.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking clap v4.5.7 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking hex-literal v0.4.1 [INFO] [stderr] Checking file_rw v0.6.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 28 | bytes: B, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | pattern: P, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | find_iter(bytes.as_ref(), pattern.as_ref()).nth(n) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 38 | bytes: B, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | pattern: P, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | rfind_iter(bytes.as_ref(), pattern.as_ref()).nth(n) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 48 | pub(crate) fn find_bytes_all, P: AsRef<[u8]>>(bytes: B, pattern: P) -> Vec { [INFO] [stdout] | -------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | find_iter(bytes.as_ref(), pattern.as_ref()).collect::>() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 56 | pub(crate) fn rfind_bytes_all, P: AsRef<[u8]>>(bytes: B, pattern: P) -> Vec { [INFO] [stdout] | -------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | rfind_iter(bytes.as_ref(), pattern.as_ref()).collect::>() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:132:12 [INFO] [stdout] | [INFO] [stdout] 129 | fn new(file: File, path: P) -> io::Result { [INFO] [stdout] | ---------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | let mmap = unsafe { Mmap::map(&file)? }; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | [INFO] [stdout] 132 | Ok(Self { mmap, file, path }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:211:12 [INFO] [stdout] | [INFO] [stdout] 210 | pub fn as_writer(self) -> io::Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | Ok(FileWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 212 | | mmap: self.mmap.make_mut()?, [INFO] [stdout] 213 | | file: self.file, [INFO] [stdout] 214 | | path: self.path, [INFO] [stdout] 215 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:50:8 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn read_to>>(path: impl AsRef + Send + Sync) -> std::io::Result { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let mmap = get_mmap_read(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | Ok(T::from(mmap.to_vec())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 42 | fn new(file: File, path: P) -> io::Result { [INFO] [stdout] | ---------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | let mmap = unsafe { MmapMut::map_mut(&file)? }; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | [INFO] [stdout] 45 | Ok(Self { mmap, path, file }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:265:12 [INFO] [stdout] | [INFO] [stdout] 264 | pub fn as_reader(self) -> io::Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 265 | Ok(FileReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 266 | | mmap: self.mmap.make_read_only()?, [INFO] [stdout] 267 | | file: self.file, [INFO] [stdout] 268 | | path: self.path, [INFO] [stdout] 269 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `file_rw` (lib) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "d0c9b48660cbf4532eadb24acf663b91175c4da4cf829d58b6b8cadb09354d2c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d0c9b48660cbf4532eadb24acf663b91175c4da4cf829d58b6b8cadb09354d2c", kill_on_drop: false }` [INFO] [stdout] d0c9b48660cbf4532eadb24acf663b91175c4da4cf829d58b6b8cadb09354d2c