[INFO] cloning repository https://github.com/amiller68/tower-metrics [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/amiller68/tower-metrics" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Familler68%2Ftower-metrics", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Familler68%2Ftower-metrics'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ba90c117b757dedbfef7bba5cae65532ab6a0293 [INFO] checking amiller68/tower-metrics/ba90c117b757dedbfef7bba5cae65532ab6a0293 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Familler68%2Ftower-metrics" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/amiller68/tower-metrics on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/amiller68/tower-metrics [INFO] finished tweaking git repo https://github.com/amiller68/tower-metrics [INFO] tweaked toml for git repo https://github.com/amiller68/tower-metrics written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/amiller68/tower-metrics already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e2e02d2b406e2e15b5966d9a57fa08c13fca6a66a304a9231d5af25916a125ef [INFO] running `Command { std: "docker" "start" "-a" "e2e02d2b406e2e15b5966d9a57fa08c13fca6a66a304a9231d5af25916a125ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e2e02d2b406e2e15b5966d9a57fa08c13fca6a66a304a9231d5af25916a125ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e2e02d2b406e2e15b5966d9a57fa08c13fca6a66a304a9231d5af25916a125ef", kill_on_drop: false }` [INFO] [stdout] e2e02d2b406e2e15b5966d9a57fa08c13fca6a66a304a9231d5af25916a125ef [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 288cac981c867babc8795284b54f1cc306b619524f317b60a74b688aaf017120 [INFO] running `Command { std: "docker" "start" "-a" "288cac981c867babc8795284b54f1cc306b619524f317b60a74b688aaf017120", kill_on_drop: false }` [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking smallvec v1.11.1 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking socket2 v0.5.4 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Compiling async-trait v0.1.73 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Compiling axum-core v0.3.4 [INFO] [stderr] Checking try-lock v0.2.4 [INFO] [stderr] Checking percent-encoding v2.3.0 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Compiling axum v0.6.20 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Checking form_urlencoded v1.2.0 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking matchit v0.7.3 [INFO] [stderr] Checking uuid v1.4.1 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Checking http-range-header v0.3.1 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking serde_path_to_error v0.1.14 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling tracing-attributes v0.1.26 [INFO] [stderr] Compiling pin-project-internal v1.1.3 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking tokio v1.33.0 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking pin-project v1.1.3 [INFO] [stderr] Checking futures-executor v0.3.28 [INFO] [stderr] Checking tower-http v0.4.4 [INFO] [stderr] Checking futures v0.3.28 [INFO] [stderr] Checking hyper v0.14.27 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-util v0.7.9 [INFO] [stderr] Checking tokio-stream v0.1.14 [INFO] [stderr] Checking tokio-test v0.4.3 [INFO] [stderr] Checking axum-extra v0.8.0 [INFO] [stderr] Checking tower-metrics v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics/mod.rs:82:25 [INFO] [stdout] | [INFO] [stdout] 60 | fn call(&mut self, req: Request) -> Self::Future { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | let start = std::time::Instant::now(); [INFO] [stdout] 62 | let classifier = self.make_classifier.make_classifier(&req); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | let (parts, body) = req.into_parts(); [INFO] [stdout] | ----- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | let tracker = BodyTracker::new(body); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | let handle = tracker.handle(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | let req = Request::from_parts(parts, tracker); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | let fut = { self.inner.call(req) }; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | classifier: Some(classifier), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics/body.rs:67:21 [INFO] [stdout] | [INFO] [stdout] 40 | let result = if let Some(result) = ready!(this.inner.poll_data(cx)) { [INFO] [stdout] | ------ ------ -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | Poll::Ready(Some(result)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics/body_tracker.rs:27:19 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(body: B) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Self { [INFO] [stdout] 27 | read: Arc::new(AtomicUsize::new(0)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics/future.rs:78:47 [INFO] [stdout] | [INFO] [stdout] 72 | let res = res.map(|body| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let inner = BodyTracker::new(body); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let response_body_tracker_handle = inner.handle(); [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | classify_eos: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics/future.rs:92:47 [INFO] [stdout] | [INFO] [stdout] 85 | ClassifiedResponse::RequiresEos(classify_eos) => { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let res = res.map(|body| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let inner = BodyTracker::new(body); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | let response_body_tracker_handle = inner.handle(); [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | classify_eos: Some(classify_eos), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics/mod.rs:82:25 [INFO] [stdout] | [INFO] [stdout] 60 | fn call(&mut self, req: Request) -> Self::Future { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | let start = std::time::Instant::now(); [INFO] [stdout] 62 | let classifier = self.make_classifier.make_classifier(&req); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | let (parts, body) = req.into_parts(); [INFO] [stdout] | ----- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | let tracker = BodyTracker::new(body); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | let handle = tracker.handle(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | let req = Request::from_parts(parts, tracker); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | let fut = { self.inner.call(req) }; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | classifier: Some(classifier), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics/body.rs:67:21 [INFO] [stdout] | [INFO] [stdout] 40 | let result = if let Some(result) = ready!(this.inner.poll_data(cx)) { [INFO] [stdout] | ------ ------ -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | Poll::Ready(Some(result)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics/body_tracker.rs:27:19 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(body: B) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Self { [INFO] [stdout] 27 | read: Arc::new(AtomicUsize::new(0)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics/future.rs:78:47 [INFO] [stdout] | [INFO] [stdout] 72 | let res = res.map(|body| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let inner = BodyTracker::new(body); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let response_body_tracker_handle = inner.handle(); [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | classify_eos: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics/future.rs:92:47 [INFO] [stdout] | [INFO] [stdout] 85 | ClassifiedResponse::RequiresEos(classify_eos) => { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let res = res.map(|body| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let inner = BodyTracker::new(body); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | let response_body_tracker_handle = inner.handle(); [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | classify_eos: Some(classify_eos), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tower-metrics` (bin "tower-metrics" test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `tower-metrics` (bin "tower-metrics") due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "288cac981c867babc8795284b54f1cc306b619524f317b60a74b688aaf017120", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "288cac981c867babc8795284b54f1cc306b619524f317b60a74b688aaf017120", kill_on_drop: false }` [INFO] [stdout] 288cac981c867babc8795284b54f1cc306b619524f317b60a74b688aaf017120