[INFO] cloning repository https://github.com/amazingman128/rust-tree-demo [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/amazingman128/rust-tree-demo" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Famazingman128%2Frust-tree-demo", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Famazingman128%2Frust-tree-demo'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a7a9970498a55c0b4d3b60ce03cd6c76107c3f61 [INFO] checking amazingman128/rust-tree-demo/a7a9970498a55c0b4d3b60ce03cd6c76107c3f61 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Famazingman128%2Frust-tree-demo" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/amazingman128/rust-tree-demo on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/amazingman128/rust-tree-demo [INFO] finished tweaking git repo https://github.com/amazingman128/rust-tree-demo [INFO] tweaked toml for git repo https://github.com/amazingman128/rust-tree-demo written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/amazingman128/rust-tree-demo already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 871aed2d9fc19f7143782ffa91b4dc85d8860ff5c29c21ad6b5cd791682527b7 [INFO] running `Command { std: "docker" "start" "-a" "871aed2d9fc19f7143782ffa91b4dc85d8860ff5c29c21ad6b5cd791682527b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "871aed2d9fc19f7143782ffa91b4dc85d8860ff5c29c21ad6b5cd791682527b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "871aed2d9fc19f7143782ffa91b4dc85d8860ff5c29c21ad6b5cd791682527b7", kill_on_drop: false }` [INFO] [stdout] 871aed2d9fc19f7143782ffa91b4dc85d8860ff5c29c21ad6b5cd791682527b7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 35983859dc739ab5736d999b9ef907e9c9f811a773c7ff4178db7acc511ee9f2 [INFO] running `Command { std: "docker" "start" "-a" "35983859dc739ab5736d999b9ef907e9c9f811a773c7ff4178db7acc511ee9f2", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Checking tree-tool v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::ops::Deref` [INFO] [stdout] --> src/tree_builder.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::ops::Deref; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::Deref` [INFO] [stdout] --> src/tree_builder.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::ops::Deref; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `parent` is never read [INFO] [stdout] --> src/tree.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct Tree where T: Serialize + Clone { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] ... [INFO] [stdout] 30 | parent: Option>>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TreeBuilder` is never constructed [INFO] [stdout] --> src/tree_builder.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct TreeBuilder where T: Serialize + Clone { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/tree_builder.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 26 | impl TreeBuilder where T: Serialize + Clone { [INFO] [stdout] | ------------------------------------------------- associated items in this implementation [INFO] [stdout] 27 | pub fn new(root_id: String, tree_config: TreeNodeConfig) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 37 | pub fn of(root_id: String) -> Self { [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 41 | pub fn set_id(&mut self, root_id: String) -> &mut Self { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 46 | pub fn set_parent_id(&mut self, parent_id: String) -> &mut Self { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 51 | pub fn set_name(&mut self, name: String) -> &mut Self { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 55 | pub fn set_weight(&mut self, weight: u32) -> &mut Self { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 60 | pub fn put_extra(&mut self, key: String, value: T) -> &mut Self { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 65 | pub fn add_map(&mut self, map: HashMap>) -> &mut Self { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 75 | pub fn reset(&mut self) -> &mut Self { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 85 | pub fn add_node_list(&mut self, node_list: Vec>, node_parser: Box>) -> &mut Self { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 102 | pub fn check_build(&self) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree_node.rs:73:74 [INFO] [stdout] | [INFO] [stdout] 73 | Rc::new(RefCell::new(list.into_iter().map(|x| (x.id.clone(), Rc::new(RefCell::new(x)))).collect())); [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree_builder.rs:32:26 [INFO] [stdout] | [INFO] [stdout] 28 | let mut root_tree = Tree::new(Some(tree_config)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | id_tree_map: Rc::new(RefCell::new(Default::default())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tree-tool` (lib) due to 3 previous errors; 4 warnings emitted [INFO] [stdout] warning: field `parent` is never read [INFO] [stdout] --> src/tree.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct Tree where T: Serialize + Clone { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] ... [INFO] [stdout] 30 | parent: Option>>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: struct `TreeBuilder` is never constructed [INFO] [stdout] --> src/tree_builder.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct TreeBuilder where T: Serialize + Clone { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/tree_builder.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 26 | impl TreeBuilder where T: Serialize + Clone { [INFO] [stdout] | ------------------------------------------------- associated items in this implementation [INFO] [stdout] 27 | pub fn new(root_id: String, tree_config: TreeNodeConfig) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 37 | pub fn of(root_id: String) -> Self { [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 41 | pub fn set_id(&mut self, root_id: String) -> &mut Self { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 46 | pub fn set_parent_id(&mut self, parent_id: String) -> &mut Self { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 51 | pub fn set_name(&mut self, name: String) -> &mut Self { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 55 | pub fn set_weight(&mut self, weight: u32) -> &mut Self { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 60 | pub fn put_extra(&mut self, key: String, value: T) -> &mut Self { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 65 | pub fn add_map(&mut self, map: HashMap>) -> &mut Self { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 75 | pub fn reset(&mut self) -> &mut Self { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 85 | pub fn add_node_list(&mut self, node_list: Vec>, node_parser: Box>) -> &mut Self { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 102 | pub fn check_build(&self) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree_node.rs:73:74 [INFO] [stdout] | [INFO] [stdout] 73 | Rc::new(RefCell::new(list.into_iter().map(|x| (x.id.clone(), Rc::new(RefCell::new(x)))).collect())); [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree_builder.rs:32:26 [INFO] [stdout] | [INFO] [stdout] 28 | let mut root_tree = Tree::new(Some(tree_config)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | id_tree_map: Rc::new(RefCell::new(Default::default())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tree-tool` (lib test) due to 3 previous errors; 4 warnings emitted [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "35983859dc739ab5736d999b9ef907e9c9f811a773c7ff4178db7acc511ee9f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "35983859dc739ab5736d999b9ef907e9c9f811a773c7ff4178db7acc511ee9f2", kill_on_drop: false }` [INFO] [stdout] 35983859dc739ab5736d999b9ef907e9c9f811a773c7ff4178db7acc511ee9f2