[INFO] cloning repository https://github.com/alvaro17f/wrestic [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/alvaro17f/wrestic" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Falvaro17f%2Fwrestic", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Falvaro17f%2Fwrestic'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 07f68de40e5d1461dddd813ad7b538594389e044 [INFO] checking alvaro17f/wrestic/07f68de40e5d1461dddd813ad7b538594389e044 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Falvaro17f%2Fwrestic" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/alvaro17f/wrestic on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/alvaro17f/wrestic [INFO] finished tweaking git repo https://github.com/alvaro17f/wrestic [INFO] tweaked toml for git repo https://github.com/alvaro17f/wrestic written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/alvaro17f/wrestic already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 84b9ca6bced71475f2ad9b4ae58884ac36d41bd2720e36bea30f5f4729a1af95 [INFO] running `Command { std: "docker" "start" "-a" "84b9ca6bced71475f2ad9b4ae58884ac36d41bd2720e36bea30f5f4729a1af95", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "84b9ca6bced71475f2ad9b4ae58884ac36d41bd2720e36bea30f5f4729a1af95", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "84b9ca6bced71475f2ad9b4ae58884ac36d41bd2720e36bea30f5f4729a1af95", kill_on_drop: false }` [INFO] [stdout] 84b9ca6bced71475f2ad9b4ae58884ac36d41bd2720e36bea30f5f4729a1af95 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b6cebff5e907b55a47fb9208cd130f260e5fa04b02fa72ee8a8b598d94921e00 [INFO] running `Command { std: "docker" "start" "-a" "b6cebff5e907b55a47fb9208cd130f260e5fa04b02fa72ee8a8b598d94921e00", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.76 [INFO] [stderr] Compiling thiserror v1.0.49 [INFO] [stderr] Checking memchr v2.6.3 [INFO] [stderr] Compiling rustix v0.38.30 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Checking anstyle-parse v0.2.2 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking dlv-list v0.3.0 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Compiling serde_json v1.0.115 [INFO] [stderr] Compiling portable-atomic v1.4.3 [INFO] [stderr] Compiling async-trait v0.1.73 [INFO] [stderr] Checking anstream v0.6.8 [INFO] [stderr] Checking console v0.15.7 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking faccess v0.2.4 [INFO] [stderr] Checking filetime v0.2.22 [INFO] [stderr] Checking xattr v1.0.1 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking os_pipe v1.1.5 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking aho-corasick v1.1.1 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking zeroize v1.6.0 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Checking tar v0.4.40 [INFO] [stderr] Checking sudo v0.6.0 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking ordered-multimap v0.4.3 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking rust-ini v0.18.0 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Checking is-terminal v0.4.10 [INFO] [stderr] Checking tempfile v3.8.0 [INFO] [stderr] Checking which v6.0.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Compiling color-print-proc-macro v0.3.5 [INFO] [stderr] Compiling cmd_lib_macros v1.9.3 [INFO] [stderr] Checking env_logger v0.10.1 [INFO] [stderr] Compiling thiserror-impl v1.0.49 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking cmd_lib v1.9.3 [INFO] [stderr] Checking color-print v0.3.5 [INFO] [stderr] Compiling pest v2.7.4 [INFO] [stderr] Checking dialoguer v0.11.0 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking clap_complete v4.5.1 [INFO] [stderr] Compiling pest_meta v2.7.4 [INFO] [stderr] Compiling pest_generator v2.7.4 [INFO] [stderr] Compiling pest_derive v2.7.4 [INFO] [stderr] Checking ron v0.7.1 [INFO] [stderr] Checking json5 v0.4.1 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking config v0.13.4 [INFO] [stderr] Checking wrestic v1.6.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/update.rs:54:11 [INFO] [stdout] | [INFO] [stdout] 48 | let file = File::open(file_path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let gz = GzDecoder::new(file); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let tar = BufReader::new(gz); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let mut archive = Archive::new(tar); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | match archive.unpack(&extract_path_parent) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/utils/set_environment_variables.rs:8:16 [INFO] [stdout] | [INFO] [stdout] 8 | for env in &setting.env { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 8 | while let Some(env) = &setting.env { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 8 | if let Some(env) = &setting.env { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/update.rs:54:11 [INFO] [stdout] | [INFO] [stdout] 48 | let file = File::open(file_path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let gz = GzDecoder::new(file); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let tar = BufReader::new(gz); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let mut archive = Archive::new(tar); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | match archive.unpack(&extract_path_parent) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/utils/set_environment_variables.rs:8:16 [INFO] [stdout] | [INFO] [stdout] 8 | for env in &setting.env { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 8 | while let Some(env) = &setting.env { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 8 | if let Some(env) = &setting.env { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wrestic` (bin "wrestic") due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `wrestic` (bin "wrestic" test) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "b6cebff5e907b55a47fb9208cd130f260e5fa04b02fa72ee8a8b598d94921e00", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b6cebff5e907b55a47fb9208cd130f260e5fa04b02fa72ee8a8b598d94921e00", kill_on_drop: false }` [INFO] [stdout] b6cebff5e907b55a47fb9208cd130f260e5fa04b02fa72ee8a8b598d94921e00