[INFO] cloning repository https://github.com/alightgoesout/advent2022 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/alightgoesout/advent2022" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Falightgoesout%2Fadvent2022", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Falightgoesout%2Fadvent2022'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4855dcfb1bcc9e5311a98dfe9f5f12660a2c2596 [INFO] checking alightgoesout/advent2022/4855dcfb1bcc9e5311a98dfe9f5f12660a2c2596 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Falightgoesout%2Fadvent2022" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/alightgoesout/advent2022 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/alightgoesout/advent2022 [INFO] finished tweaking git repo https://github.com/alightgoesout/advent2022 [INFO] tweaked toml for git repo https://github.com/alightgoesout/advent2022 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/alightgoesout/advent2022 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] af4dcc5d6e31f3e60dee30bbed83c8d5708a4c51658e340e55d6afa20a377dd3 [INFO] running `Command { std: "docker" "start" "-a" "af4dcc5d6e31f3e60dee30bbed83c8d5708a4c51658e340e55d6afa20a377dd3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "af4dcc5d6e31f3e60dee30bbed83c8d5708a4c51658e340e55d6afa20a377dd3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "af4dcc5d6e31f3e60dee30bbed83c8d5708a4c51658e340e55d6afa20a377dd3", kill_on_drop: false }` [INFO] [stdout] af4dcc5d6e31f3e60dee30bbed83c8d5708a4c51658e340e55d6afa20a377dd3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f03fce8c713d99fea9bc2b910f19cdf67409f5d327406ad0884d3ec0942f7adf [INFO] running `Command { std: "docker" "start" "-a" "f03fce8c713d99fea9bc2b910f19cdf67409f5d327406ad0884d3ec0942f7adf", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling libc v0.2.138 [INFO] [stderr] Checking regex-syntax v0.6.28 [INFO] [stderr] Checking either v1.8.0 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking aho-corasick v0.7.20 [INFO] [stderr] Checking nom v7.1.1 [INFO] [stderr] Checking termion v2.0.1 [INFO] [stderr] Checking regex v1.7.0 [INFO] [stderr] Checking advent2022 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `OldRope` is never constructed [INFO] [stdout] --> src/day9/mod.rs:108:8 [INFO] [stdout] | [INFO] [stdout] 108 | struct OldRope { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `OldRope` has a derived impl for the trait `Default`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day14/mod.rs:151:20 [INFO] [stdout] | [INFO] [stdout] 143 | let rocks = rocks [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | sands: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day14/mod.rs:200:20 [INFO] [stdout] | [INFO] [stdout] 192 | let rocks = rocks [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | sands: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day2/mod.rs:173:5 [INFO] [stdout] | [INFO] [stdout] 172 | fn play_game(rounds: impl IntoIterator) -> (u32, u32) { [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | / rounds [INFO] [stdout] 174 | | .into_iter() [INFO] [stdout] 175 | | .map(|round| round.scores()) [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day5/mod.rs:140:12 [INFO] [stdout] | [INFO] [stdout] 139 | fn parse_stacks(lines: impl Iterator) -> Stacks { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | Stacks(lines.map(|line| parse_stack(&line)).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input.rs:32:34 [INFO] [stdout] | [INFO] [stdout] 32 | self.0.next().map(|item| item.to_string().parse().unwrap()) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn read_lines(reader: R) -> impl Iterator { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let buf_reader = BufReader::new(reader); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | / buf_reader [INFO] [stdout] 49 | | .lines() [INFO] [stdout] 50 | | .filter(Result::is_ok) [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `advent2022` (bin "advent2022") due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: struct `OldRope` is never constructed [INFO] [stdout] --> src/day9/mod.rs:108:8 [INFO] [stdout] | [INFO] [stdout] 108 | struct OldRope { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `OldRope` has a derived impl for the trait `Default`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day14/mod.rs:151:20 [INFO] [stdout] | [INFO] [stdout] 143 | let rocks = rocks [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | sands: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day14/mod.rs:200:20 [INFO] [stdout] | [INFO] [stdout] 192 | let rocks = rocks [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | sands: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day2/mod.rs:173:5 [INFO] [stdout] | [INFO] [stdout] 172 | fn play_game(rounds: impl IntoIterator) -> (u32, u32) { [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | / rounds [INFO] [stdout] 174 | | .into_iter() [INFO] [stdout] 175 | | .map(|round| round.scores()) [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day5/mod.rs:140:12 [INFO] [stdout] | [INFO] [stdout] 139 | fn parse_stacks(lines: impl Iterator) -> Stacks { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | Stacks(lines.map(|line| parse_stack(&line)).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input.rs:32:34 [INFO] [stdout] | [INFO] [stdout] 32 | self.0.next().map(|item| item.to_string().parse().unwrap()) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn read_lines(reader: R) -> impl Iterator { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let buf_reader = BufReader::new(reader); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | / buf_reader [INFO] [stdout] 49 | | .lines() [INFO] [stdout] 50 | | .filter(Result::is_ok) [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `advent2022` (bin "advent2022" test) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "f03fce8c713d99fea9bc2b910f19cdf67409f5d327406ad0884d3ec0942f7adf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f03fce8c713d99fea9bc2b910f19cdf67409f5d327406ad0884d3ec0942f7adf", kill_on_drop: false }` [INFO] [stdout] f03fce8c713d99fea9bc2b910f19cdf67409f5d327406ad0884d3ec0942f7adf