[INFO] cloning repository https://github.com/alfredotg/mqtt-bytes-v5 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/alfredotg/mqtt-bytes-v5" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Falfredotg%2Fmqtt-bytes-v5", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Falfredotg%2Fmqtt-bytes-v5'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d54f708995695e39a01895802d0cf57edf6f1caf [INFO] checking alfredotg/mqtt-bytes-v5/d54f708995695e39a01895802d0cf57edf6f1caf against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Falfredotg%2Fmqtt-bytes-v5" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/alfredotg/mqtt-bytes-v5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/alfredotg/mqtt-bytes-v5 [INFO] finished tweaking git repo https://github.com/alfredotg/mqtt-bytes-v5 [INFO] tweaked toml for git repo https://github.com/alfredotg/mqtt-bytes-v5 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/alfredotg/mqtt-bytes-v5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 38cf9a82fc6d8b8285d3b7500d2f2f65a904744d6af6b3dcdfd7d3cff595a471 [INFO] running `Command { std: "docker" "start" "-a" "38cf9a82fc6d8b8285d3b7500d2f2f65a904744d6af6b3dcdfd7d3cff595a471", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "38cf9a82fc6d8b8285d3b7500d2f2f65a904744d6af6b3dcdfd7d3cff595a471", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "38cf9a82fc6d8b8285d3b7500d2f2f65a904744d6af6b3dcdfd7d3cff595a471", kill_on_drop: false }` [INFO] [stdout] 38cf9a82fc6d8b8285d3b7500d2f2f65a904744d6af6b3dcdfd7d3cff595a471 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 80155acc964ca2d114da387a080b038263c4c38f760897cf65982711c2768c24 [INFO] running `Command { std: "docker" "start" "-a" "80155acc964ca2d114da387a080b038263c4c38f760897cf65982711c2768c24", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking half v2.4.0 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking rayon v1.9.0 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking clap v4.5.3 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Checking mqtt-bytes-v5 v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connack.rs:323:12 [INFO] [stdout] | [INFO] [stdout] 228 | let mut authentication_data = None; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 323 | Ok(Some(ConnAckProperties { [INFO] [stdout] | ____________^ [INFO] [stdout] 324 | | session_expiry_interval, [INFO] [stdout] 325 | | receive_max, [INFO] [stdout] 326 | | max_qos, [INFO] [stdout] ... | [INFO] [stdout] 340 | | authentication_data, [INFO] [stdout] 341 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connect.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 26 | mut bytes: Bytes, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let properties = ConnectProperties::read(&mut bytes)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | let will = LastWill::read(connect_flags, &mut bytes)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let connect = Connect { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok((connect, will, login)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connect.rs:241:12 [INFO] [stdout] | [INFO] [stdout] 183 | let mut authentication_data = None; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | Ok(Some(ConnectProperties { [INFO] [stdout] | ____________^ [INFO] [stdout] 242 | | session_expiry_interval, [INFO] [stdout] 243 | | receive_maximum, [INFO] [stdout] 244 | | max_packet_size, [INFO] [stdout] ... | [INFO] [stdout] 250 | | authentication_data, [INFO] [stdout] 251 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connect.rs:535:12 [INFO] [stdout] | [INFO] [stdout] 482 | let mut correlation_data = None; [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 535 | Ok(Some(LastWillProperties { [INFO] [stdout] | ____________^ [INFO] [stdout] 536 | | delay_interval, [INFO] [stdout] 537 | | payload_format_indicator, [INFO] [stdout] 538 | | message_expiry_interval, [INFO] [stdout] ... | [INFO] [stdout] 542 | | user_properties, [INFO] [stdout] 543 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/publish.rs:32:22 [INFO] [stdout] | [INFO] [stdout] 24 | topic: T, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | qos: QoS, [INFO] [stdout] 26 | payload: P, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | properties: Option, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | payload: payload.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/publish.rs:34:15 [INFO] [stdout] | [INFO] [stdout] 24 | topic: T, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | qos: QoS, [INFO] [stdout] 26 | payload: P, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | properties: Option, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/publish.rs:247:12 [INFO] [stdout] | [INFO] [stdout] 186 | let mut correlation_data = None; [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | Ok(Some(PublishProperties { [INFO] [stdout] | ____________^ [INFO] [stdout] 248 | | payload_format_indicator, [INFO] [stdout] 249 | | message_expiry_interval, [INFO] [stdout] 250 | | topic_alias, [INFO] [stdout] ... | [INFO] [stdout] 255 | | content_type, [INFO] [stdout] 256 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subscribe.rs:32:22 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn new_many(filters: F, properties: Option) -> Self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | filters: filters.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mqtt-bytes-v5` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "80155acc964ca2d114da387a080b038263c4c38f760897cf65982711c2768c24", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "80155acc964ca2d114da387a080b038263c4c38f760897cf65982711c2768c24", kill_on_drop: false }` [INFO] [stdout] 80155acc964ca2d114da387a080b038263c4c38f760897cf65982711c2768c24