[INFO] cloning repository https://github.com/alexniver/rustbook [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/alexniver/rustbook" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Falexniver%2Frustbook", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Falexniver%2Frustbook'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7d31fd21558c2818c9fdc5b094adbb12ad878e02 [INFO] checking alexniver/rustbook/7d31fd21558c2818c9fdc5b094adbb12ad878e02 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Falexniver%2Frustbook" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/alexniver/rustbook on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/alexniver/rustbook [INFO] finished tweaking git repo https://github.com/alexniver/rustbook [INFO] tweaked toml for git repo https://github.com/alexniver/rustbook written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/alexniver/rustbook already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: profiles for the non root package will be ignored, specify profiles at the workspace root: [INFO] [stderr] package: /workspace/builds/worker-6-tc2/source/chapter/ch-14-cargo/Cargo.toml [INFO] [stderr] workspace: /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f7342e7be5b642f7967cbc0089d49b77339c7fb28996e78595f853be92720c9a [INFO] running `Command { std: "docker" "start" "-a" "f7342e7be5b642f7967cbc0089d49b77339c7fb28996e78595f853be92720c9a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f7342e7be5b642f7967cbc0089d49b77339c7fb28996e78595f853be92720c9a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f7342e7be5b642f7967cbc0089d49b77339c7fb28996e78595f853be92720c9a", kill_on_drop: false }` [INFO] [stdout] f7342e7be5b642f7967cbc0089d49b77339c7fb28996e78595f853be92720c9a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f9c0bd513bfdcc4c3d1ce5d548227efc5e66d95e0540ade9beefd430a495490e [INFO] running `Command { std: "docker" "start" "-a" "f9c0bd513bfdcc4c3d1ce5d548227efc5e66d95e0540ade9beefd430a495490e", kill_on_drop: false }` [INFO] [stderr] warning: profiles for the non root package will be ignored, specify profiles at the workspace root: [INFO] [stderr] package: /opt/rustwide/workdir/chapter/ch-14-cargo/Cargo.toml [INFO] [stderr] workspace: /opt/rustwide/workdir/Cargo.toml [INFO] [stderr] Compiling libc v0.2.137 [INFO] [stderr] Checking ch-17-02-traitobj v0.1.0 (/opt/rustwide/workdir/chapter/ch-17-02-traitobj) [INFO] [stderr] Checking ch-12-grep v0.1.0 (/opt/rustwide/workdir/chapter/ch-12-grep) [INFO] [stderr] Checking rustbook v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking ch-20-webserver v0.1.0 (/opt/rustwide/workdir/chapter/ch-20-webserver) [INFO] [stderr] Checking ch-14-cargo v0.1.0 (/opt/rustwide/workdir/chapter/ch-14-cargo) [INFO] [stderr] Checking ch-17-03-state v0.1.0 (/opt/rustwide/workdir/chapter/ch-17-03-state) [INFO] [stderr] Checking ch-11-01-write-test v0.1.0 (/opt/rustwide/workdir/chapter/ch-11-01-write-test) [INFO] [stdout] warning: function `add_one` is never used [INFO] [stdout] --> chapter/ch-14-cargo/src/lib.rs:9:4 [INFO] [stdout] | [INFO] [stdout] 9 | fn add_one(n: i32) -> i32 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking ch-17-03-state-enum v0.1.0 (/opt/rustwide/workdir/chapter/ch-17-03-state-enum) [INFO] [stdout] warning: struct `Rect` is never constructed [INFO] [stdout] --> chapter/ch-11-01-write-test/src/lib.rs:2:8 [INFO] [stdout] | [INFO] [stdout] 2 | struct Rect { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `can_hold` is never used [INFO] [stdout] --> chapter/ch-11-01-write-test/src/lib.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 7 | impl Rect { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] 8 | pub fn can_hold(&self, other: Rect) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `value` is never read [INFO] [stdout] --> chapter/ch-11-01-write-test/src/lib.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 22 | pub struct Guess { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 23 | value: i32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> chapter/ch-11-01-write-test/src/lib.rs:27:8 [INFO] [stdout] | [INFO] [stdout] 26 | impl Guess { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] 27 | fn new(value: i32) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> chapter/ch-20-webserver/src/threadpool.rs:27:17 [INFO] [stdout] | [INFO] [stdout] 18 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let rx = Arc::new(Mutex::new(rx)); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let mut workers = Vec::with_capacity(size as usize); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | tx: Some(tx), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking ch-07-02-crates v0.1.0 (/opt/rustwide/workdir/chapter/ch-07-02-crates) [INFO] [stderr] Checking ch-15-05-refcell v0.1.0 (/opt/rustwide/workdir/chapter/ch-15-05-refcell) [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> chapter/ch-20-webserver/src/threadpool.rs:62:21 [INFO] [stdout] | [INFO] [stdout] 59 | fn new(id: u8, rx: Arc>>) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | thread: Some(thread::spawn(move || loop { [INFO] [stdout] | _____________________^ [INFO] [stdout] 63 | | let job = rx.lock().unwrap().recv(); [INFO] [stdout] 64 | | match job { [INFO] [stdout] 65 | | Ok(job) => { [INFO] [stdout] ... | [INFO] [stdout] 73 | | } [INFO] [stdout] 74 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking ch-07-03-mod v0.1.0 (/opt/rustwide/workdir/chapter/ch-07-03-mod) [INFO] [stderr] error: could not compile `ch-20-webserver` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "f9c0bd513bfdcc4c3d1ce5d548227efc5e66d95e0540ade9beefd430a495490e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f9c0bd513bfdcc4c3d1ce5d548227efc5e66d95e0540ade9beefd430a495490e", kill_on_drop: false }` [INFO] [stdout] f9c0bd513bfdcc4c3d1ce5d548227efc5e66d95e0540ade9beefd430a495490e