[INFO] cloning repository https://github.com/alexiwalker/mackley [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/alexiwalker/mackley" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Falexiwalker%2Fmackley", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Falexiwalker%2Fmackley'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 92f7577f953cf62232ef0306325b52bbb2f28ef8 [INFO] checking alexiwalker/mackley/92f7577f953cf62232ef0306325b52bbb2f28ef8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Falexiwalker%2Fmackley" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/alexiwalker/mackley on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/alexiwalker/mackley [INFO] finished tweaking git repo https://github.com/alexiwalker/mackley [INFO] tweaked toml for git repo https://github.com/alexiwalker/mackley written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/alexiwalker/mackley already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 101d380c484c791c586023c3491b15aedb02f0d60a803bc54e80330d580b40b8 [INFO] running `Command { std: "docker" "start" "-a" "101d380c484c791c586023c3491b15aedb02f0d60a803bc54e80330d580b40b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "101d380c484c791c586023c3491b15aedb02f0d60a803bc54e80330d580b40b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "101d380c484c791c586023c3491b15aedb02f0d60a803bc54e80330d580b40b8", kill_on_drop: false }` [INFO] [stdout] 101d380c484c791c586023c3491b15aedb02f0d60a803bc54e80330d580b40b8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4d8260da82d81ea6c4adefb39b2d0b2ad6ac4c98e798f71a7ec3e238ceaecb54 [INFO] running `Command { std: "docker" "start" "-a" "4d8260da82d81ea6c4adefb39b2d0b2ad6ac4c98e798f71a7ec3e238ceaecb54", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling serde_json v1.0.79 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Compiling quote v1.0.15 [INFO] [stderr] Checking lib v0.1.0 (/opt/rustwide/workdir/src/lib) [INFO] [stdout] warning: unused import: `Borrow` [INFO] [stdout] --> src/lib/src/queue.rs:6:23 [INFO] [stdout] | [INFO] [stdout] 6 | use std::borrow::{Borrow, BorrowMut}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::encoding::encoding::MmqpEncoding` [INFO] [stdout] --> src/lib/src/tcp_parse.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::encoding::encoding::MmqpEncoding; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::tcp_parse::tcp_parse::MmqpTcpFormat` [INFO] [stdout] --> src/lib/src/tcp_parse.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::tcp_parse::tcp_parse::MmqpTcpFormat; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::MmqpMessage` [INFO] [stdout] --> src/lib/src/tcp_parse.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::MmqpMessage; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `MmqpSerialisable` and `SerialisationStrategy` [INFO] [stdout] --> src/lib/src/tcp_parse.rs:7:30 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::{MmqpMessage, MmqpSerialisable, SerialisationStrategy}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::any::Any` [INFO] [stdout] --> src/lib/src/tcp_parse.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | use std::any::Any; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::encoding::encoding::MmqpEncoding` [INFO] [stdout] --> src/lib/src/tests.rs:2:9 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::encoding::encoding::MmqpEncoding; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `MmqpNormalisedMessage` and `Receivable` [INFO] [stdout] --> src/lib/src/tests.rs:3:57 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::normalised_message::normalised_message::{MmqpNormalisedMessage, Receivable}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::queue_readers::RotatingReadBuffers` [INFO] [stdout] --> src/lib/src/tests.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::queue_readers::RotatingReadBuffers; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `MmqpMessage` and `MmqpSerialisable` [INFO] [stdout] --> src/lib/src/tests.rs:5:17 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::{MmqpMessage, MmqpSerialisable}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::borrow::BorrowMut` [INFO] [stdout] --> src/lib/src/tests.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 6 | use std::borrow::BorrowMut; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::encoding::*` [INFO] [stdout] --> src/lib/src/lib.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub use crate::encoding::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::page_io::*` [INFO] [stdout] --> src/lib/src/lib.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub use crate::page_io::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::tcp_parse::*` [INFO] [stdout] --> src/lib/src/lib.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | pub use crate::tcp_parse::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib/src/queue.rs:166:17 [INFO] [stdout] | [INFO] [stdout] 166 | let mut map = self.pending_received.borrow_mut(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/src/queue.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn serialise_settings(self) -> String { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | serde_json::to_string(&config).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/src/queue.rs:193:32 [INFO] [stdout] | [INFO] [stdout] 193 | #[derive(serde::Serialize, serde::Deserialize, Copy, Clone, Debug)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib/src/tcp_parse.rs:121:21 [INFO] [stdout] | [INFO] [stdout] 121 | dbg!(version.clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lib` (lib) due to 3 previous errors; 16 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4d8260da82d81ea6c4adefb39b2d0b2ad6ac4c98e798f71a7ec3e238ceaecb54", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4d8260da82d81ea6c4adefb39b2d0b2ad6ac4c98e798f71a7ec3e238ceaecb54", kill_on_drop: false }` [INFO] [stdout] 4d8260da82d81ea6c4adefb39b2d0b2ad6ac4c98e798f71a7ec3e238ceaecb54