[INFO] cloning repository https://github.com/alesiong/tcp-over-redis [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/alesiong/tcp-over-redis" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Falesiong%2Ftcp-over-redis", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Falesiong%2Ftcp-over-redis'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8951562fcf790d053ed6df8936bc1816a5e43dea [INFO] checking alesiong/tcp-over-redis/8951562fcf790d053ed6df8936bc1816a5e43dea against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Falesiong%2Ftcp-over-redis" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/alesiong/tcp-over-redis on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/alesiong/tcp-over-redis [INFO] finished tweaking git repo https://github.com/alesiong/tcp-over-redis [INFO] tweaked toml for git repo https://github.com/alesiong/tcp-over-redis written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/alesiong/tcp-over-redis already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c7356258764d1ac717e9c93bd2094d71482353610d547d00d9a36eefe96c62f2 [INFO] running `Command { std: "docker" "start" "-a" "c7356258764d1ac717e9c93bd2094d71482353610d547d00d9a36eefe96c62f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c7356258764d1ac717e9c93bd2094d71482353610d547d00d9a36eefe96c62f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c7356258764d1ac717e9c93bd2094d71482353610d547d00d9a36eefe96c62f2", kill_on_drop: false }` [INFO] [stdout] c7356258764d1ac717e9c93bd2094d71482353610d547d00d9a36eefe96c62f2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d3c44e4c3721d34e75f220ba3e9007713dd015debb9f92df82de69748fcefdf3 [INFO] running `Command { std: "docker" "start" "-a" "d3c44e4c3721d34e75f220ba3e9007713dd015debb9f92df82de69748fcefdf3", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking writeable v0.5.5 [INFO] [stderr] Checking litemap v0.7.3 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking icu_locid_transform_data v1.5.0 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Checking icu_properties_data v1.5.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking utf8_iter v1.0.4 [INFO] [stderr] Checking utf16_iter v1.0.5 [INFO] [stderr] Checking write16 v1.0.0 [INFO] [stderr] Checking icu_normalizer_data v1.5.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking sha1_smol v1.0.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking winnow v0.6.13 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Compiling unicode-xid v0.2.4 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Compiling const_format_proc_macros v0.2.32 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking const_format v0.2.32 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling zerofrom-derive v0.1.4 [INFO] [stderr] Compiling yoke-derive v0.7.4 [INFO] [stderr] Compiling zerovec-derive v0.10.2 [INFO] [stderr] Compiling displaydoc v0.2.4 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Checking zerofrom v0.1.4 [INFO] [stderr] Checking yoke v0.7.4 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking zerovec v0.10.2 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tokio-retry v0.3.0 [INFO] [stderr] Checking deadpool-runtime v0.1.4 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking deadpool v0.12.1 [INFO] [stderr] Checking icu_properties v1.5.0 [INFO] [stderr] Checking combine v4.6.7 [INFO] [stderr] Checking serde_spanned v0.6.6 [INFO] [stderr] Checking toml_datetime v0.6.6 [INFO] [stderr] Checking toml_edit v0.22.14 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking idna v1.0.0 [INFO] [stderr] Checking url v2.5.1 [INFO] [stderr] Checking toml v0.8.14 [INFO] [stderr] Checking redis v0.25.4 [INFO] [stderr] Checking deadpool-redis v0.15.1 [INFO] [stderr] Checking tcp-over-redis v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `crate::cache::consts::REDIS_KEY_GLOBAL_REGISTRY` [INFO] [stdout] --> src/cache/pipe.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use crate::cache::consts::REDIS_KEY_GLOBAL_REGISTRY; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cmp::Ordering` [INFO] [stdout] --> src/cache/listener.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 110 | use std::cmp::Ordering; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cache::consts::REDIS_KEY_GLOBAL_REGISTRY` [INFO] [stdout] --> src/cache/pipe.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use crate::cache::consts::REDIS_KEY_GLOBAL_REGISTRY; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/cache/pipe.rs:25:1 [INFO] [stdout] | [INFO] [stdout] 25 | #[instrument(level = "info", skip(cache, data), fields(len = data.len()), err(Debug))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/cache/pipe.rs:35:14 [INFO] [stdout] | [INFO] [stdout] 35 | .query_async(&mut cache).await?; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default [INFO] [stdout] = note: this warning originates in the attribute macro `instrument` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/cache/pipe.rs:25:1 [INFO] [stdout] | [INFO] [stdout] 25 | #[instrument(level = "info", skip(cache, data), fields(len = data.len()), err(Debug))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/cache/pipe.rs:35:14 [INFO] [stdout] | [INFO] [stdout] 35 | .query_async(&mut cache).await?; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default [INFO] [stdout] = note: this warning originates in the attribute macro `instrument` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pipe_name_str` [INFO] [stdout] --> src/cache/pipe.rs:90:13 [INFO] [stdout] | [INFO] [stdout] 90 | let pipe_name_str = pipe_name.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pipe_name_str` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pipe_name_str` [INFO] [stdout] --> src/cache/pipe.rs:90:13 [INFO] [stdout] | [INFO] [stdout] 90 | let pipe_name_str = pipe_name.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pipe_name_str` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `read` [INFO] [stdout] --> src/cache/listener.rs:233:26 [INFO] [stdout] | [INFO] [stdout] 233 | let (mut read, write) = conn.split(); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_read` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cache/listener.rs:233:22 [INFO] [stdout] | [INFO] [stdout] 233 | let (mut read, write) = conn.split(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `redis_timeout` is never read [INFO] [stdout] --> src/cache/connection.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 28 | pub struct ConnectionReader { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 29 | redis_timeout: Duration, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `REDIS_KEY_PREFIX_CLIENT_HAND_SHAKE` is never used [INFO] [stdout] --> src/cache/consts.rs:6:18 [INFO] [stdout] | [INFO] [stdout] 6 | pub(crate) const REDIS_KEY_PREFIX_CLIENT_HAND_SHAKE: &str = concatcp!(REDIS_KEY_PREFIX, ":client:handshake:"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `REDIS_KEY_GLOBAL_REGISTRY` is never used [INFO] [stdout] --> src/cache/consts.rs:9:18 [INFO] [stdout] | [INFO] [stdout] 9 | pub(crate) const REDIS_KEY_GLOBAL_REGISTRY: &str = concatcp!("{}:registry", REDIS_KEY_PREFIX); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache/connection.rs:58:16 [INFO] [stdout] | [INFO] [stdout] 37 | connection_timeout: Duration, cache: Arc, shard_count: u32) -> Result { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | let recv_handshake = ReceiveHandle::start_receive(deadline, redis_timeout, Arc::clone(&cache), &server_handshake_pipe); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let recv_client_data = ReceiveHandle::start_receive(deadline, redis_timeout, Arc::clone(&cache), &client_data_pipe); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | [INFO] [stdout] 48 | let (mut server_handshake_handler, client_data_handler) = tokio::try_join!(recv_handshake, recv_client_data)?; [INFO] [stdout] | ------------------------ ------------------- -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let conn_req = pipe::send(deadline, connection_timeout, &cache, &listening, seq_bytes); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let recv_handshake = server_handshake_handler.receive(deadline); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Ok(Connection { [INFO] [stdout] | ________________^ [INFO] [stdout] 59 | | cache, [INFO] [stdout] 60 | | redis_timeout, [INFO] [stdout] 61 | | connection_timeout, [INFO] [stdout] 62 | | read_pipe: client_data_handler, [INFO] [stdout] 63 | | write_pipe_name: format!("{}{}", REDIS_KEY_PREFIX_SERVER_DATA, seq), [INFO] [stdout] 64 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache/connection.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn split(self) -> (ConnectionReader, ConnectionWriter) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | ( [INFO] [stdout] 72 | / ConnectionReader { [INFO] [stdout] 73 | | redis_timeout: self.redis_timeout, [INFO] [stdout] 74 | | connection_timeout: self.connection_timeout, [INFO] [stdout] 75 | | read_pipe: self.read_pipe, [INFO] [stdout] 76 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache/connection.rs:77:13 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn split(self) -> (ConnectionReader, ConnectionWriter) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | / ConnectionWriter { [INFO] [stdout] 78 | | cache: self.cache, [INFO] [stdout] 79 | | redis_timeout: self.redis_timeout, [INFO] [stdout] 80 | | connection_timeout: self.connection_timeout, [INFO] [stdout] 81 | | write_pipe_name: self.write_pipe_name, [INFO] [stdout] 82 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:37:8 [INFO] [stdout] | [INFO] [stdout] 37 | Ok(toml::from_str(&config_file)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `redis_timeout` is never read [INFO] [stdout] --> src/cache/connection.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 28 | pub struct ConnectionReader { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 29 | redis_timeout: Duration, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `REDIS_KEY_PREFIX_CLIENT_HAND_SHAKE` is never used [INFO] [stdout] --> src/cache/consts.rs:6:18 [INFO] [stdout] | [INFO] [stdout] 6 | pub(crate) const REDIS_KEY_PREFIX_CLIENT_HAND_SHAKE: &str = concatcp!(REDIS_KEY_PREFIX, ":client:handshake:"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `REDIS_KEY_GLOBAL_REGISTRY` is never used [INFO] [stdout] --> src/cache/consts.rs:9:18 [INFO] [stdout] | [INFO] [stdout] 9 | pub(crate) const REDIS_KEY_GLOBAL_REGISTRY: &str = concatcp!("{}:registry", REDIS_KEY_PREFIX); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tcp-over-redis` (lib) due to 5 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused `Result` in tuple element 0 that must be used [INFO] [stdout] --> src/cache/pipe.rs:319:13 [INFO] [stdout] | [INFO] [stdout] 319 | tokio::join!(handle); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this warning originates in the macro `$crate::join` which comes from the expansion of the macro `tokio::join` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache/connection.rs:58:16 [INFO] [stdout] | [INFO] [stdout] 37 | connection_timeout: Duration, cache: Arc, shard_count: u32) -> Result { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | let recv_handshake = ReceiveHandle::start_receive(deadline, redis_timeout, Arc::clone(&cache), &server_handshake_pipe); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let recv_client_data = ReceiveHandle::start_receive(deadline, redis_timeout, Arc::clone(&cache), &client_data_pipe); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | [INFO] [stdout] 48 | let (mut server_handshake_handler, client_data_handler) = tokio::try_join!(recv_handshake, recv_client_data)?; [INFO] [stdout] | ------------------------ ------------------- -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let conn_req = pipe::send(deadline, connection_timeout, &cache, &listening, seq_bytes); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let recv_handshake = server_handshake_handler.receive(deadline); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Ok(Connection { [INFO] [stdout] | ________________^ [INFO] [stdout] 59 | | cache, [INFO] [stdout] 60 | | redis_timeout, [INFO] [stdout] 61 | | connection_timeout, [INFO] [stdout] 62 | | read_pipe: client_data_handler, [INFO] [stdout] 63 | | write_pipe_name: format!("{}{}", REDIS_KEY_PREFIX_SERVER_DATA, seq), [INFO] [stdout] 64 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache/connection.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn split(self) -> (ConnectionReader, ConnectionWriter) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | ( [INFO] [stdout] 72 | / ConnectionReader { [INFO] [stdout] 73 | | redis_timeout: self.redis_timeout, [INFO] [stdout] 74 | | connection_timeout: self.connection_timeout, [INFO] [stdout] 75 | | read_pipe: self.read_pipe, [INFO] [stdout] 76 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache/connection.rs:77:13 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn split(self) -> (ConnectionReader, ConnectionWriter) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | / ConnectionWriter { [INFO] [stdout] 78 | | cache: self.cache, [INFO] [stdout] 79 | | redis_timeout: self.redis_timeout, [INFO] [stdout] 80 | | connection_timeout: self.connection_timeout, [INFO] [stdout] 81 | | write_pipe_name: self.write_pipe_name, [INFO] [stdout] 82 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` in tuple element 0 that must be used [INFO] [stdout] --> src/cache/listener.rs:169:13 [INFO] [stdout] | [INFO] [stdout] 169 | tokio::join!(handle_send); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: this warning originates in the macro `$crate::join` which comes from the expansion of the macro `tokio::join` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:37:8 [INFO] [stdout] | [INFO] [stdout] 37 | Ok(toml::from_str(&config_file)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tcp-over-redis` (lib test) due to 5 previous errors; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d3c44e4c3721d34e75f220ba3e9007713dd015debb9f92df82de69748fcefdf3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d3c44e4c3721d34e75f220ba3e9007713dd015debb9f92df82de69748fcefdf3", kill_on_drop: false }` [INFO] [stdout] d3c44e4c3721d34e75f220ba3e9007713dd015debb9f92df82de69748fcefdf3