[INFO] updating cached repository https://github.com/alberdingk-thijm/podesta [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "-c" "remote.origin.fetch=refs/heads/*:refs/heads/*" "fetch" "origin" "--force" "--prune", kill_on_drop: false }` [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2c546ca2fa4ae17505d61a78f547d57c5e1b68f7 [INFO] checking alberdingk-thijm/podesta/2c546ca2fa4ae17505d61a78f547d57c5e1b68f7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Falberdingk-thijm%2Fpodesta" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/alberdingk-thijm/podesta on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/alberdingk-thijm/podesta [INFO] finished tweaking git repo https://github.com/alberdingk-thijm/podesta [INFO] tweaked toml for git repo https://github.com/alberdingk-thijm/podesta written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/alberdingk-thijm/podesta already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3ab3ea4f715f3d9dcac3427673b99ff53441d22ae6de3bba78bc68e6025f26ef [INFO] running `Command { std: "docker" "start" "-a" "3ab3ea4f715f3d9dcac3427673b99ff53441d22ae6de3bba78bc68e6025f26ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3ab3ea4f715f3d9dcac3427673b99ff53441d22ae6de3bba78bc68e6025f26ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3ab3ea4f715f3d9dcac3427673b99ff53441d22ae6de3bba78bc68e6025f26ef", kill_on_drop: false }` [INFO] [stdout] 3ab3ea4f715f3d9dcac3427673b99ff53441d22ae6de3bba78bc68e6025f26ef [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f37466daaf3271b3d22bc8903438dda734f25e43e02d4b0f09cf528faa746105 [INFO] running `Command { std: "docker" "start" "-a" "f37466daaf3271b3d22bc8903438dda734f25e43e02d4b0f09cf528faa746105", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking libc v0.2.22 [INFO] [stderr] Compiling names v0.11.0 [INFO] [stderr] Checking num-traits v0.1.37 [INFO] [stderr] Checking serde v0.9.15 [INFO] [stderr] Checking unicode-width v0.1.4 [INFO] [stderr] Checking strsim v0.6.0 [INFO] [stderr] Checking byteorder v1.0.0 [INFO] [stderr] Checking pest v0.4.1 [INFO] [stderr] Checking ansi_term v0.9.0 [INFO] [stderr] Checking dtoa v0.4.1 [INFO] [stderr] Checking vec_map v0.8.0 [INFO] [stderr] Checking itoa v0.3.1 [INFO] [stderr] Checking bitflags v0.8.2 [INFO] [stderr] Checking unicode-segmentation v1.2.0 [INFO] [stderr] Checking macro-attr v0.2.0 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking enum_derive v0.1.7 [INFO] [stderr] Checking shlex v0.1.1 [INFO] [stderr] Checking rand v0.3.15 [INFO] [stderr] Checking term_size v0.3.0 [INFO] [stderr] Checking atty v0.2.2 [INFO] [stderr] Checking time v0.1.37 [INFO] [stderr] Checking clap v2.24.2 [INFO] [stderr] Checking rouler v0.1.3 [INFO] [stderr] Compiling serde_codegen_internals v0.14.2 [INFO] [stderr] Compiling serde_derive v0.9.15 [INFO] [stderr] Checking serde_json v0.9.10 [INFO] [stderr] Checking bincode v0.7.0 [INFO] [stderr] Checking podesta v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/buildings.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 207 | (self.occupants.len() as f64 * 0.04f64 [INFO] [stdout] | ^ [INFO] [stdout] 208 | + self.items.iter().fold(0.0, |acc, x| acc + x.borrow().collect_gold() * boost)) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 207 ~ self.occupants.len() as f64 * 0.04f64 [INFO] [stdout] 208 ~ + self.items.iter().fold(0.0, |acc, x| acc + x.borrow().collect_gold() * boost) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/buildings.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 207 | (self.occupants.len() as f64 * 0.04f64 [INFO] [stdout] | ^ [INFO] [stdout] 208 | + self.items.iter().fold(0.0, |acc, x| acc + x.borrow().collect_gold() * boost)) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 207 ~ self.occupants.len() as f64 * 0.04f64 [INFO] [stdout] 208 ~ + self.items.iter().fold(0.0, |acc, x| acc + x.borrow().collect_gold() * boost) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libdata.rs:238:32 [INFO] [stdout] | [INFO] [stdout] 238 | fn cause(&self) -> Option<&error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 238 | fn cause(&self) -> Option<&dyn error::Error> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/quarters.rs:147:32 [INFO] [stdout] | [INFO] [stdout] 147 | fn cause(&self) -> Option<&error::Error> { None } [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 147 | fn cause(&self) -> Option<&dyn error::Error> { None } [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/prompts.rs:48:32 [INFO] [stdout] | [INFO] [stdout] 48 | fn cause(&self) -> Option<&error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 48 | fn cause(&self) -> Option<&dyn error::Error> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/libdata.rs:238:32 [INFO] [stdout] | [INFO] [stdout] 238 | fn cause(&self) -> Option<&error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 238 | fn cause(&self) -> Option<&dyn error::Error> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/manager.rs:98:32 [INFO] [stdout] | [INFO] [stdout] 98 | fn cause(&self) -> Option<&error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 98 | fn cause(&self) -> Option<&dyn error::Error> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/quarters.rs:147:32 [INFO] [stdout] | [INFO] [stdout] 147 | fn cause(&self) -> Option<&error::Error> { None } [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 147 | fn cause(&self) -> Option<&dyn error::Error> { None } [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/prompts.rs:48:32 [INFO] [stdout] | [INFO] [stdout] 48 | fn cause(&self) -> Option<&error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 48 | fn cause(&self) -> Option<&dyn error::Error> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/manager.rs:98:32 [INFO] [stdout] | [INFO] [stdout] 98 | fn cause(&self) -> Option<&error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 98 | fn cause(&self) -> Option<&dyn error::Error> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/libdata.rs:230:45 [INFO] [stdout] | [INFO] [stdout] 230 | LibError::Serde(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/libdata.rs:231:47 [INFO] [stdout] | [INFO] [stdout] 231 | LibError::Bincode(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/libdata.rs:232:42 [INFO] [stdout] | [INFO] [stdout] 232 | LibError::Io(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/libdata.rs:233:46 [INFO] [stdout] | [INFO] [stdout] 233 | LibError::Prompt(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/libdata.rs:240:45 [INFO] [stdout] | [INFO] [stdout] 240 | LibError::Serde(ref err) => err.cause(), [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/libdata.rs:241:47 [INFO] [stdout] | [INFO] [stdout] 241 | LibError::Bincode(ref err) => err.cause(), [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/libdata.rs:242:42 [INFO] [stdout] | [INFO] [stdout] 242 | LibError::Io(ref err) => err.cause(), [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/libdata.rs:243:46 [INFO] [stdout] | [INFO] [stdout] 243 | LibError::Prompt(ref err) => err.cause(), [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/libdata.rs:230:45 [INFO] [stdout] | [INFO] [stdout] 230 | LibError::Serde(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/libdata.rs:231:47 [INFO] [stdout] | [INFO] [stdout] 231 | LibError::Bincode(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/libdata.rs:232:42 [INFO] [stdout] | [INFO] [stdout] 232 | LibError::Io(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/libdata.rs:233:46 [INFO] [stdout] | [INFO] [stdout] 233 | LibError::Prompt(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/libdata.rs:240:45 [INFO] [stdout] | [INFO] [stdout] 240 | LibError::Serde(ref err) => err.cause(), [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/libdata.rs:241:47 [INFO] [stdout] | [INFO] [stdout] 241 | LibError::Bincode(ref err) => err.cause(), [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/libdata.rs:242:42 [INFO] [stdout] | [INFO] [stdout] 242 | LibError::Io(ref err) => err.cause(), [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/libdata.rs:243:46 [INFO] [stdout] | [INFO] [stdout] 243 | LibError::Prompt(ref err) => err.cause(), [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/prompts.rs:39:45 [INFO] [stdout] | [INFO] [stdout] 39 | PromptError::Io(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/prompts.rs:40:48 [INFO] [stdout] | [INFO] [stdout] 40 | PromptError::Parse(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/prompts.rs:50:45 [INFO] [stdout] | [INFO] [stdout] 50 | PromptError::Io(ref err) => err.cause(), [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/prompts.rs:51:48 [INFO] [stdout] | [INFO] [stdout] 51 | PromptError::Parse(ref err) => err.cause(), [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/prompts.rs:39:45 [INFO] [stdout] | [INFO] [stdout] 39 | PromptError::Io(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/prompts.rs:40:48 [INFO] [stdout] | [INFO] [stdout] 40 | PromptError::Parse(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/prompts.rs:50:45 [INFO] [stdout] | [INFO] [stdout] 50 | PromptError::Io(ref err) => err.cause(), [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/prompts.rs:51:48 [INFO] [stdout] | [INFO] [stdout] 51 | PromptError::Parse(ref err) => err.cause(), [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/manager.rs:91:40 [INFO] [stdout] | [INFO] [stdout] 91 | Error::Lib(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/manager.rs:92:42 [INFO] [stdout] | [INFO] [stdout] 92 | Error::Build(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/manager.rs:91:40 [INFO] [stdout] | [INFO] [stdout] 91 | Error::Lib(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/manager.rs:92:42 [INFO] [stdout] | [INFO] [stdout] 92 | Error::Build(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `find_hero` is never used [INFO] [stdout] --> src/sett.rs:214:12 [INFO] [stdout] | [INFO] [stdout] 31 | impl Sett { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 214 | pub fn find_hero(&self, bname: &str, qname: &str, hname: &str) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `InvalidOccupant` and `InvalidItem` are never constructed [INFO] [stdout] --> src/buildings.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 43 | pub enum OccupyError { [INFO] [stdout] | ----------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 47 | InvalidOccupant, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 48 | /// Item not valid in building. [INFO] [stdout] 49 | InvalidItem, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `OccupyError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `find_by_name` is never used [INFO] [stdout] --> src/prompts.rs:209:8 [INFO] [stdout] | [INFO] [stdout] 209 | pub fn find_by_name<'a, 'b, T: Described>(v: &'a [T], name: &'b str) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `choose_by_name` is never used [INFO] [stdout] --> src/prompts.rs:214:8 [INFO] [stdout] | [INFO] [stdout] 214 | pub fn choose_by_name(a: &[Rc>]) -> Result>, PromptError> [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `step` is never read [INFO] [stdout] --> src/events.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 91 | pub struct EventMap { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 92 | pub step: i32, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `EventMap` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/libdata.rs:186:5 [INFO] [stdout] | [INFO] [stdout] 184 | let f = File::open(txtfile)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | let reader = BufReader::new(f); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | reader.lines().collect::>>() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/libdata.rs:266:5 [INFO] [stdout] | [INFO] [stdout] 263 | let f = File::create(fullname)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 264 | let mut writer = BufWriter::new(f); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 265 | // serialize the manager using bincode [INFO] [stdout] 266 | bincode::serialize_into(&mut writer, man, bincode::Infinite) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/libdata.rs:288:5 [INFO] [stdout] | [INFO] [stdout] 285 | let f = File::open(fullname)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 286 | let mut reader = BufReader::new(f); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 287 | // deserialize the manager using bincode [INFO] [stdout] 288 | bincode::deserialize_from(&mut reader, bincode::Infinite) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sett.rs:111:37 [INFO] [stdout] | [INFO] [stdout] 111 | if qrtrs.iter().any(|ref x| x.borrow().name == n) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sett.rs:172:37 [INFO] [stdout] | [INFO] [stdout] 172 | self.qrtrs.iter().find(|&q| q.borrow().name == name).map(|q| q.clone()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sett.rs:179:47 [INFO] [stdout] | [INFO] [stdout] 179 | self.find_quarter(qname).and_then(|q| q.borrow().find_building(bname)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sett.rs:186:34 [INFO] [stdout] | [INFO] [stdout] 186 | let qbs = qrtrs.map(|q| (q.borrow().name(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sett.rs:187:34 [INFO] [stdout] | [INFO] [stdout] 187 | ... q.borrow().bldgs.clone())); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sett.rs:203:24 [INFO] [stdout] | [INFO] [stdout] 203 | qrtrs.map(|q| (q.borrow().name(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sett.rs:204:29 [INFO] [stdout] | [INFO] [stdout] 204 | ... q.borrow().find_building(bname))) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sett.rs:218:27 [INFO] [stdout] | [INFO] [stdout] 218 | .and_then(|b| b.borrow().find_hero(hname)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sett.rs:224:49 [INFO] [stdout] | [INFO] [stdout] 224 | ... b.borrow().name(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sett.rs:225:49 [INFO] [stdout] | [INFO] [stdout] 225 | ... b.borrow().occupants.clone()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sett.rs:242:56 [INFO] [stdout] | [INFO] [stdout] 242 | bldgs.iter().map(|&(ref q, ref b)| (q.clone(), b.borrow().name(), b.borrow().find_hero(hname))) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sett.rs:242:75 [INFO] [stdout] | [INFO] [stdout] 242 | bldgs.iter().map(|&(ref q, ref b)| (q.clone(), b.borrow().name(), b.borrow().find_hero(hname))) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buildings.rs:208:55 [INFO] [stdout] | [INFO] [stdout] 208 | + self.items.iter().fold(0.0, |acc, x| acc + x.borrow().collect_gold() * boost)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buildings.rs:229:24 [INFO] [stdout] | [INFO] [stdout] 229 | .find(|&h| h.borrow().name == hname).map(|h| h.clone()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/quarters.rs:202:42 [INFO] [stdout] | [INFO] [stdout] 202 | if self.bldgs.iter().any(|ref b| b.borrow().name == plan.name) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/quarters.rs:216:52 [INFO] [stdout] | [INFO] [stdout] 216 | self.bldgs.iter().fold(0.0, |acc, b| acc + b.borrow_mut().collect_gold() * boost) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/quarters.rs:226:40 [INFO] [stdout] | [INFO] [stdout] 226 | self.bldgs.iter().find(|ref b| b.borrow().name == bname).map(|b| b.clone()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prompts.rs:217:38 [INFO] [stdout] | [INFO] [stdout] 217 | let names = a.iter().map(|ref e| e.borrow().name()).collect::>(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prompts.rs:225:38 [INFO] [stdout] | [INFO] [stdout] 225 | let names = a.iter().map(|ref e| e.borrow().name()).collect::>(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manager.rs:177:13 [INFO] [stdout] | [INFO] [stdout] 177 | / prompts::name_file(&format!(" to save to (default: {}): ", [INFO] [stdout] 178 | | self.savefile)) [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manager.rs:307:42 [INFO] [stdout] | [INFO] [stdout] 307 | ... .map(|ref q| q.borrow().name.clone()); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manager.rs:349:42 [INFO] [stdout] | [INFO] [stdout] 349 | ... .map(|ref q| q.borrow().name.clone()); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manager.rs:371:46 [INFO] [stdout] | [INFO] [stdout] 371 | ... .map(|ref b| b.borrow().name.clone()); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manager.rs:424:9 [INFO] [stdout] | [INFO] [stdout] 405 | let queue_up = match self.sett { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 424 | / queue_up.and_then(|_| { [INFO] [stdout] 425 | | // Pop events until queue is empty. [INFO] [stdout] 426 | | let activated = { [INFO] [stdout] 427 | | let mut a = Ok(vec!()); [INFO] [stdout] ... | [INFO] [stdout] 433 | | activated.map(|_| ()) [INFO] [stdout] 434 | | }).unwrap_or_else(|e| println!("Failed to perform step: {}", e)) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manager.rs:617:50 [INFO] [stdout] | [INFO] [stdout] 617 | .filter(|q| qtypes.contains(&q.borrow().qtype)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manager.rs:630:35 [INFO] [stdout] | [INFO] [stdout] 630 | .flat_map(|q| q.borrow().bldgs.clone().into_iter()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manager.rs:631:50 [INFO] [stdout] | [INFO] [stdout] 631 | .filter(|b| btypes.contains(&b.borrow().plan.btype) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manager.rs:633:44 [INFO] [stdout] | [INFO] [stdout] 633 | ... && enum_match!(b.borrow().cond, buildings::BldgCond::InUse(_))) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 31 previous errors; 24 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `find_hero` is never used [INFO] [stdout] --> src/sett.rs:214:12 [INFO] [stdout] | [INFO] [stdout] 31 | impl Sett { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 214 | pub fn find_hero(&self, bname: &str, qname: &str, hname: &str) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `InvalidOccupant` and `InvalidItem` are never constructed [INFO] [stdout] --> src/buildings.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 43 | pub enum OccupyError { [INFO] [stdout] | ----------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 47 | InvalidOccupant, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 48 | /// Item not valid in building. [INFO] [stdout] 49 | InvalidItem, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `OccupyError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `find_by_name` is never used [INFO] [stdout] --> src/prompts.rs:209:8 [INFO] [stdout] | [INFO] [stdout] 209 | pub fn find_by_name<'a, 'b, T: Described>(v: &'a [T], name: &'b str) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `choose_by_name` is never used [INFO] [stdout] --> src/prompts.rs:214:8 [INFO] [stdout] | [INFO] [stdout] 214 | pub fn choose_by_name(a: &[Rc>]) -> Result>, PromptError> [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `step` is never read [INFO] [stdout] --> src/events.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 91 | pub struct EventMap { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 92 | pub step: i32, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `EventMap` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/libdata.rs:186:5 [INFO] [stdout] | [INFO] [stdout] 184 | let f = File::open(txtfile)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | let reader = BufReader::new(f); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | reader.lines().collect::>>() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/libdata.rs:266:5 [INFO] [stdout] | [INFO] [stdout] 263 | let f = File::create(fullname)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 264 | let mut writer = BufWriter::new(f); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 265 | // serialize the manager using bincode [INFO] [stdout] 266 | bincode::serialize_into(&mut writer, man, bincode::Infinite) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/libdata.rs:288:5 [INFO] [stdout] | [INFO] [stdout] 285 | let f = File::open(fullname)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 286 | let mut reader = BufReader::new(f); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 287 | // deserialize the manager using bincode [INFO] [stdout] 288 | bincode::deserialize_from(&mut reader, bincode::Infinite) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sett.rs:111:37 [INFO] [stdout] | [INFO] [stdout] 111 | if qrtrs.iter().any(|ref x| x.borrow().name == n) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sett.rs:172:37 [INFO] [stdout] | [INFO] [stdout] 172 | self.qrtrs.iter().find(|&q| q.borrow().name == name).map(|q| q.clone()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sett.rs:179:47 [INFO] [stdout] | [INFO] [stdout] 179 | self.find_quarter(qname).and_then(|q| q.borrow().find_building(bname)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sett.rs:186:34 [INFO] [stdout] | [INFO] [stdout] 186 | let qbs = qrtrs.map(|q| (q.borrow().name(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sett.rs:187:34 [INFO] [stdout] | [INFO] [stdout] 187 | ... q.borrow().bldgs.clone())); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sett.rs:203:24 [INFO] [stdout] | [INFO] [stdout] 203 | qrtrs.map(|q| (q.borrow().name(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sett.rs:204:29 [INFO] [stdout] | [INFO] [stdout] 204 | ... q.borrow().find_building(bname))) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sett.rs:218:27 [INFO] [stdout] | [INFO] [stdout] 218 | .and_then(|b| b.borrow().find_hero(hname)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sett.rs:224:49 [INFO] [stdout] | [INFO] [stdout] 224 | ... b.borrow().name(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sett.rs:225:49 [INFO] [stdout] | [INFO] [stdout] 225 | ... b.borrow().occupants.clone()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sett.rs:242:56 [INFO] [stdout] | [INFO] [stdout] 242 | bldgs.iter().map(|&(ref q, ref b)| (q.clone(), b.borrow().name(), b.borrow().find_hero(hname))) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sett.rs:242:75 [INFO] [stdout] | [INFO] [stdout] 242 | bldgs.iter().map(|&(ref q, ref b)| (q.clone(), b.borrow().name(), b.borrow().find_hero(hname))) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buildings.rs:208:55 [INFO] [stdout] | [INFO] [stdout] 208 | + self.items.iter().fold(0.0, |acc, x| acc + x.borrow().collect_gold() * boost)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buildings.rs:229:24 [INFO] [stdout] | [INFO] [stdout] 229 | .find(|&h| h.borrow().name == hname).map(|h| h.clone()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/quarters.rs:202:42 [INFO] [stdout] | [INFO] [stdout] 202 | if self.bldgs.iter().any(|ref b| b.borrow().name == plan.name) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/quarters.rs:216:52 [INFO] [stdout] | [INFO] [stdout] 216 | self.bldgs.iter().fold(0.0, |acc, b| acc + b.borrow_mut().collect_gold() * boost) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/quarters.rs:226:40 [INFO] [stdout] | [INFO] [stdout] 226 | self.bldgs.iter().find(|ref b| b.borrow().name == bname).map(|b| b.clone()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prompts.rs:217:38 [INFO] [stdout] | [INFO] [stdout] 217 | let names = a.iter().map(|ref e| e.borrow().name()).collect::>(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prompts.rs:225:38 [INFO] [stdout] | [INFO] [stdout] 225 | let names = a.iter().map(|ref e| e.borrow().name()).collect::>(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `podesta` (lib test) due to 32 previous errors; 24 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manager.rs:177:13 [INFO] [stdout] | [INFO] [stdout] 177 | / prompts::name_file(&format!(" to save to (default: {}): ", [INFO] [stdout] 178 | | self.savefile)) [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manager.rs:307:42 [INFO] [stdout] | [INFO] [stdout] 307 | ... .map(|ref q| q.borrow().name.clone()); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manager.rs:349:42 [INFO] [stdout] | [INFO] [stdout] 349 | ... .map(|ref q| q.borrow().name.clone()); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manager.rs:371:46 [INFO] [stdout] | [INFO] [stdout] 371 | ... .map(|ref b| b.borrow().name.clone()); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manager.rs:424:9 [INFO] [stdout] | [INFO] [stdout] 405 | let queue_up = match self.sett { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 424 | / queue_up.and_then(|_| { [INFO] [stdout] 425 | | // Pop events until queue is empty. [INFO] [stdout] 426 | | let activated = { [INFO] [stdout] 427 | | let mut a = Ok(vec!()); [INFO] [stdout] ... | [INFO] [stdout] 433 | | activated.map(|_| ()) [INFO] [stdout] 434 | | }).unwrap_or_else(|e| println!("Failed to perform step: {}", e)) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manager.rs:617:50 [INFO] [stdout] | [INFO] [stdout] 617 | .filter(|q| qtypes.contains(&q.borrow().qtype)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manager.rs:630:35 [INFO] [stdout] | [INFO] [stdout] 630 | .flat_map(|q| q.borrow().bldgs.clone().into_iter()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manager.rs:631:50 [INFO] [stdout] | [INFO] [stdout] 631 | .filter(|b| btypes.contains(&b.borrow().plan.btype) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manager.rs:633:44 [INFO] [stdout] | [INFO] [stdout] 633 | ... && enum_match!(b.borrow().cond, buildings::BldgCond::InUse(_))) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 31 previous errors; 24 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `podesta` (lib) due to 32 previous errors; 24 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f37466daaf3271b3d22bc8903438dda734f25e43e02d4b0f09cf528faa746105", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f37466daaf3271b3d22bc8903438dda734f25e43e02d4b0f09cf528faa746105", kill_on_drop: false }` [INFO] [stdout] f37466daaf3271b3d22bc8903438dda734f25e43e02d4b0f09cf528faa746105