[INFO] cloning repository https://github.com/alamont/rustray [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/alamont/rustray" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Falamont%2Frustray", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Falamont%2Frustray'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3fbea086f43d72c3f0989aa5061405d20a2a1bb1 [INFO] checking alamont/rustray/3fbea086f43d72c3f0989aa5061405d20a2a1bb1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Falamont%2Frustray" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] [stderr] Updating files: 37% (18/48) Updating files: 39% (19/48) Updating files: 41% (20/48) Updating files: 43% (21/48) Updating files: 45% (22/48) Updating files: 47% (23/48) Updating files: 50% (24/48) Updating files: 52% (25/48) Updating files: 54% (26/48) Updating files: 56% (27/48) Updating files: 58% (28/48) Updating files: 60% (29/48) Updating files: 62% (30/48) Updating files: 64% (31/48) Updating files: 66% (32/48) Updating files: 68% (33/48) Updating files: 70% (34/48) Updating files: 72% (35/48) Updating files: 75% (36/48) Updating files: 77% (37/48) Updating files: 79% (38/48) Updating files: 81% (39/48) Updating files: 83% (40/48) Updating files: 85% (41/48) Updating files: 87% (42/48) Updating files: 89% (43/48) Updating files: 91% (44/48) Updating files: 93% (45/48) Updating files: 95% (46/48) Updating files: 97% (47/48) Updating files: 100% (48/48) Updating files: 100% (48/48), done. [INFO] validating manifest of git repo https://github.com/alamont/rustray on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/alamont/rustray [INFO] finished tweaking git repo https://github.com/alamont/rustray [INFO] tweaked toml for git repo https://github.com/alamont/rustray written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/alamont/rustray already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 04af30a2d24edd6939dac8338b4cbcc0b04c7014ab2bb3f0c7b018049e9496b1 [INFO] running `Command { std: "docker" "start" "-a" "04af30a2d24edd6939dac8338b4cbcc0b04c7014ab2bb3f0c7b018049e9496b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "04af30a2d24edd6939dac8338b4cbcc0b04c7014ab2bb3f0c7b018049e9496b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "04af30a2d24edd6939dac8338b4cbcc0b04c7014ab2bb3f0c7b018049e9496b1", kill_on_drop: false }` [INFO] [stdout] 04af30a2d24edd6939dac8338b4cbcc0b04c7014ab2bb3f0c7b018049e9496b1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1c4b4ccedcbc8df0eff95960687e0c08b0fb0c07457f5618e1807d6d613c75f8 [INFO] running `Command { std: "docker" "start" "-a" "1c4b4ccedcbc8df0eff95960687e0c08b0fb0c07457f5618e1807d6d613c75f8", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.68 [INFO] [stderr] Compiling proc-macro2 v1.0.9 [INFO] [stderr] Compiling cc v1.0.50 [INFO] [stderr] Compiling libm v0.2.1 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling xml-rs v0.8.0 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling memoffset v0.5.4 [INFO] [stderr] Compiling pkg-config v0.3.17 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling nix v0.17.0 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Checking adler32 v1.0.4 [INFO] [stderr] Compiling syn v1.0.17 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Checking smallvec v1.3.0 [INFO] [stderr] Checking once_cell v1.3.1 [INFO] [stderr] Compiling rayon-core v1.7.0 [INFO] [stderr] Compiling num-rational v0.2.4 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Compiling typenum v1.11.2 [INFO] [stderr] Compiling proc-macro-hack v0.5.15 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Checking downcast-rs v1.1.1 [INFO] [stderr] Compiling cast v0.2.3 [INFO] [stderr] Compiling num-iter v0.1.40 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Compiling xkbcommon-sys v0.7.4 [INFO] [stderr] Compiling x11-dl v2.18.5 [INFO] [stderr] Checking deflate v0.8.3 [INFO] [stderr] Checking crossbeam-queue v0.2.1 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Checking miniz_oxide v0.3.6 [INFO] [stderr] Checking remove_dir_all v0.5.2 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Checking bytemuck v1.2.0 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Checking matrixmultiply v0.2.3 [INFO] [stderr] Checking tobj v1.0.0 [INFO] [stderr] Checking gif v0.10.3 [INFO] [stderr] Checking slice_as_array v1.1.0 [INFO] [stderr] Checking png v0.16.1 [INFO] [stderr] Compiling libloading v0.5.2 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Compiling minifb v0.16.0 [INFO] [stderr] Checking tiff v0.4.0 [INFO] [stderr] Checking cmd_lib v0.7.8 [INFO] [stderr] Checking hsl v0.1.1 [INFO] [stderr] Compiling wayland-scanner v0.25.0 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking wayland-sys v0.25.0 [INFO] [stderr] Checking num_cpus v1.12.0 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking raw-window-handle v0.3.3 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking generic-array v0.13.2 [INFO] [stderr] Checking xkb v0.2.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rayon v1.3.0 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Compiling wayland-client v0.25.0 [INFO] [stderr] Compiling wayland-protocols v0.25.0 [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Checking rand_distr v0.2.2 [INFO] [stderr] Compiling paste-impl v0.1.10 [INFO] [stderr] Checking paste v0.1.10 [INFO] [stderr] Checking simba v0.1.2 [INFO] [stderr] Checking nalgebra v0.21.0 [INFO] [stderr] Checking jpeg-decoder v0.1.18 [INFO] [stderr] Checking wayland-commons v0.25.0 [INFO] [stderr] Checking image v0.23.2 [INFO] [stderr] Checking wayland-cursor v0.25.0 [INFO] [stderr] Checking rustray v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `earth_material` [INFO] [stdout] --> src/scenes/env_scene.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | let earth_material = Arc::new(Lambertian { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_earth_material` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `image_path` [INFO] [stdout] --> src/texture.rs:219:25 [INFO] [stdout] | [INFO] [stdout] 219 | pub fn hdr_image_loader(image_path: String) { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_image_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:258:9 [INFO] [stdout] | [INFO] [stdout] 257 | paths.filter_map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 258 | entry.ok().and_then(|e| [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hittable.rs:111:20 [INFO] [stdout] | [INFO] [stdout] 109 | pub fn new(obj: impl Hittable + 'static) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | Self { [INFO] [stdout] 111 | object:Arc::new(obj) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hittable.rs:156:20 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn new(obj: impl Hittable + 'static, offset: Vector3, rotation_deg: Vector3) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | object:Arc::new(obj), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scenes/cornell_box_texture_filtering.rs:91:18 [INFO] [stdout] | [INFO] [stdout] 20 | let mut objects: Vec> = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | let glass = Arc::new(Dielectric { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let earth_material = Arc::new(Lambertian { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | let small_light = Arc::new(DiffuseLight { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | objects: BVHNode::build(objects, 0), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scenes/cornell_box_texture_filtering.rs:92:22 [INFO] [stdout] | [INFO] [stdout] 20 | let mut objects: Vec> = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | let glass = Arc::new(Dielectric { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let earth_material = Arc::new(Lambertian { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | let small_light = Arc::new(DiffuseLight { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | environment: cornell_box_environment(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scenes/env_scene.rs:121:18 [INFO] [stdout] | [INFO] [stdout] 22 | let mut objects: Vec> = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | [INFO] [stdout] 24 | let glass = Arc::new(Dielectric { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | let aluminium = Arc::new(Metal { albedo: Arc::new(ConstantTex { color: vec3(0.8, 0.85, 0.85) } ), fuzz: 0.0}); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | let decoder = image::hdr::HdrDecoder::new(io::BufReader::new( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | let earth_material = Arc::new(Lambertian { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | let earth_material_new = Arc::new(DielectricSurfaceLambert{ [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | let env_material = Arc::new(Environment { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | let white = Arc::new(Lambertian { albedo: Arc::new(ConstantTex { color: vec3(0.73, 0.73, 0.73) })}); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | objects: BVHNode::build(objects, 0), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/volume.rs:23:23 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn new(boundary: impl Hittable + 'static, density: f32, material: Arc) -> Self { [INFO] [stdout] | --------------------------------- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Self { [INFO] [stdout] 23 | boundary: Arc::new(boundary), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/volume.rs:84:23 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn new(boundary: impl Hittable + 'static, density: Arc, max_density: f32, material: Arc) -> Self { [INFO] [stdout] | --------------------------------- ------------------------- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | Self { [INFO] [stdout] 84 | boundary: Arc::new(boundary), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mesh.rs:69:24 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn new(mesh_path: String, material: Arc, scale: Vector3) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | let triangles = mesh.indices.chunks(3).map(|iii| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | triangles: BVHNode::build(triangles, 0), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mesh.rs:70:23 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn new(mesh_path: String, material: Arc, scale: Vector3) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | let triangles = mesh.indices.chunks(3).map(|iii| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | material: material.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `earth_material` [INFO] [stdout] --> src/scenes/env_scene.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | let earth_material = Arc::new(Lambertian { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_earth_material` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustray` (bin "rustray") due to 11 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `image_path` [INFO] [stdout] --> src/texture.rs:219:25 [INFO] [stdout] | [INFO] [stdout] 219 | pub fn hdr_image_loader(image_path: String) { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_image_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:258:9 [INFO] [stdout] | [INFO] [stdout] 257 | paths.filter_map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 258 | entry.ok().and_then(|e| [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hittable.rs:111:20 [INFO] [stdout] | [INFO] [stdout] 109 | pub fn new(obj: impl Hittable + 'static) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | Self { [INFO] [stdout] 111 | object:Arc::new(obj) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hittable.rs:156:20 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn new(obj: impl Hittable + 'static, offset: Vector3, rotation_deg: Vector3) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | object:Arc::new(obj), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scenes/cornell_box_texture_filtering.rs:91:18 [INFO] [stdout] | [INFO] [stdout] 20 | let mut objects: Vec> = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | let glass = Arc::new(Dielectric { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let earth_material = Arc::new(Lambertian { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | let small_light = Arc::new(DiffuseLight { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | objects: BVHNode::build(objects, 0), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scenes/cornell_box_texture_filtering.rs:92:22 [INFO] [stdout] | [INFO] [stdout] 20 | let mut objects: Vec> = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | let glass = Arc::new(Dielectric { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let earth_material = Arc::new(Lambertian { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | let small_light = Arc::new(DiffuseLight { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | environment: cornell_box_environment(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scenes/env_scene.rs:121:18 [INFO] [stdout] | [INFO] [stdout] 22 | let mut objects: Vec> = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | [INFO] [stdout] 24 | let glass = Arc::new(Dielectric { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | let aluminium = Arc::new(Metal { albedo: Arc::new(ConstantTex { color: vec3(0.8, 0.85, 0.85) } ), fuzz: 0.0}); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | let decoder = image::hdr::HdrDecoder::new(io::BufReader::new( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | let earth_material = Arc::new(Lambertian { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | let earth_material_new = Arc::new(DielectricSurfaceLambert{ [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | let env_material = Arc::new(Environment { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | let white = Arc::new(Lambertian { albedo: Arc::new(ConstantTex { color: vec3(0.73, 0.73, 0.73) })}); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | objects: BVHNode::build(objects, 0), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/volume.rs:23:23 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn new(boundary: impl Hittable + 'static, density: f32, material: Arc) -> Self { [INFO] [stdout] | --------------------------------- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Self { [INFO] [stdout] 23 | boundary: Arc::new(boundary), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/volume.rs:84:23 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn new(boundary: impl Hittable + 'static, density: Arc, max_density: f32, material: Arc) -> Self { [INFO] [stdout] | --------------------------------- ------------------------- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | Self { [INFO] [stdout] 84 | boundary: Arc::new(boundary), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mesh.rs:69:24 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn new(mesh_path: String, material: Arc, scale: Vector3) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | let triangles = mesh.indices.chunks(3).map(|iii| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | triangles: BVHNode::build(triangles, 0), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mesh.rs:70:23 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn new(mesh_path: String, material: Arc, scale: Vector3) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | let triangles = mesh.indices.chunks(3).map(|iii| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | material: material.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustray` (bin "rustray" test) due to 11 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1c4b4ccedcbc8df0eff95960687e0c08b0fb0c07457f5618e1807d6d613c75f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1c4b4ccedcbc8df0eff95960687e0c08b0fb0c07457f5618e1807d6d613c75f8", kill_on_drop: false }` [INFO] [stdout] 1c4b4ccedcbc8df0eff95960687e0c08b0fb0c07457f5618e1807d6d613c75f8