[INFO] cloning repository https://github.com/al-jshen/vk [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/al-jshen/vk" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fal-jshen%2Fvk", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fal-jshen%2Fvk'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8312aed7c42556d7f15b2db206699900f9af39b8 [INFO] checking al-jshen/vk/8312aed7c42556d7f15b2db206699900f9af39b8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fal-jshen%2Fvk" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/al-jshen/vk on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/al-jshen/vk [INFO] finished tweaking git repo https://github.com/al-jshen/vk [INFO] tweaked toml for git repo https://github.com/al-jshen/vk written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/al-jshen/vk already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 37773cb16334811018b99d3031642015b14f3f6315c8461cb2a5830477d1f313 [INFO] running `Command { std: "docker" "start" "-a" "37773cb16334811018b99d3031642015b14f3f6315c8461cb2a5830477d1f313", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "37773cb16334811018b99d3031642015b14f3f6315c8461cb2a5830477d1f313", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "37773cb16334811018b99d3031642015b14f3f6315c8461cb2a5830477d1f313", kill_on_drop: false }` [INFO] [stdout] 37773cb16334811018b99d3031642015b14f3f6315c8461cb2a5830477d1f313 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b878f95df2ea8a9f87a973368483d06a5cd9b92f28787523c043cf58d8692af1 [INFO] running `Command { std: "docker" "start" "-a" "b878f95df2ea8a9f87a973368483d06a5cd9b92f28787523c043cf58d8692af1", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.97 [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Checking libloading v0.7.0 [INFO] [stderr] Compiling xml-rs v0.8.3 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Checking dlib v0.5.0 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling wayland-sys v0.28.5 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Checking nix v0.20.0 [INFO] [stderr] Checking ttf-parser v0.6.2 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling nom v6.1.2 [INFO] [stderr] Compiling crossbeam-queue v0.3.2 [INFO] [stderr] Checking downcast-rs v1.2.0 [INFO] [stderr] Compiling nix v0.18.0 [INFO] [stderr] Checking scoped-tls v1.0.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling wayland-scanner v0.28.5 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.4 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Compiling x11-dl v2.18.5 [INFO] [stderr] Checking instant v0.1.9 [INFO] [stderr] Checking libloading v0.6.7 [INFO] [stderr] Checking xdg v2.2.0 [INFO] [stderr] Checking crossbeam v0.8.1 [INFO] [stderr] Checking dlib v0.4.2 [INFO] [stderr] Checking owned_ttf_parser v0.6.0 [INFO] [stderr] Checking parking_lot_core v0.8.3 [INFO] [stderr] Checking mio v0.7.13 [INFO] [stderr] Checking rusttype v0.9.2 [INFO] [stderr] Checking memmap2 v0.1.0 [INFO] [stderr] Checking andrew v0.3.1 [INFO] [stderr] Checking raw-window-handle v0.3.3 [INFO] [stderr] Checking lock_api v0.4.4 [INFO] [stderr] Compiling winit v0.25.0 [INFO] [stderr] Checking mio-misc v1.2.1 [INFO] [stderr] Checking ash v0.32.1 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Compiling wayland-client v0.28.5 [INFO] [stderr] Compiling wayland-protocols v0.28.5 [INFO] [stderr] Checking xcursor v0.3.3 [INFO] [stderr] Checking wayland-commons v0.28.5 [INFO] [stderr] Checking calloop v0.6.5 [INFO] [stderr] Checking wayland-cursor v0.28.5 [INFO] [stderr] Checking ash-window v0.6.0 [INFO] [stderr] Checking smithay-client-toolkit v0.12.3 [INFO] [stderr] Checking vka v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/main.rs:478:13 [INFO] [stdout] | [INFO] [stdout] 478 | for i in 0..MAX_FRAMES_IN_FLIGHT { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `dynamic_state` [INFO] [stdout] --> src/main.rs:1160:13 [INFO] [stdout] | [INFO] [stdout] 1160 | let dynamic_state = vk::PipelineDynamicStateCreateInfo { [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_dynamic_state` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `swapchain_images`, `swapchain_format`, and `swapchain_extent` are never read [INFO] [stdout] --> src/main.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 29 | struct VkApp { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 41 | swapchain_images: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 42 | swapchain_format: vk::Format, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 43 | swapchain_extent: vk::Extent2D, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:395:9 [INFO] [stdout] | [INFO] [stdout] 394 | let file = File::open(fname).expect("could not read file!"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 395 | file.bytes().filter_map(|b| b.ok()).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:770:22 [INFO] [stdout] | [INFO] [stdout] 770 | .map(|x| CString::new(*x).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:776:22 [INFO] [stdout] | [INFO] [stdout] 776 | .map(|x| CString::new(*x).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:975:22 [INFO] [stdout] | [INFO] [stdout] 975 | .map(|x| CString::new(*x).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:1306:24 [INFO] [stdout] | [INFO] [stdout] 1305 | pub fn main_loop(mut self, event_loop: EventLoop<()>) { [INFO] [stdout] | -------- ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1306 | event_loop.run(move |event, _, control_flow| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 1307 | | *control_flow = ControlFlow::Wait; [INFO] [stdout] 1308 | | [INFO] [stdout] 1309 | | match event { [INFO] [stdout] ... | [INFO] [stdout] 1333 | | } [INFO] [stdout] 1334 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vka` (bin "vka") due to 6 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/main.rs:478:13 [INFO] [stdout] | [INFO] [stdout] 478 | for i in 0..MAX_FRAMES_IN_FLIGHT { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `dynamic_state` [INFO] [stdout] --> src/main.rs:1160:13 [INFO] [stdout] | [INFO] [stdout] 1160 | let dynamic_state = vk::PipelineDynamicStateCreateInfo { [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_dynamic_state` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `swapchain_images`, `swapchain_format`, and `swapchain_extent` are never read [INFO] [stdout] --> src/main.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 29 | struct VkApp { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 41 | swapchain_images: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 42 | swapchain_format: vk::Format, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 43 | swapchain_extent: vk::Extent2D, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:395:9 [INFO] [stdout] | [INFO] [stdout] 394 | let file = File::open(fname).expect("could not read file!"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 395 | file.bytes().filter_map(|b| b.ok()).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:770:22 [INFO] [stdout] | [INFO] [stdout] 770 | .map(|x| CString::new(*x).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:776:22 [INFO] [stdout] | [INFO] [stdout] 776 | .map(|x| CString::new(*x).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:975:22 [INFO] [stdout] | [INFO] [stdout] 975 | .map(|x| CString::new(*x).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:1306:24 [INFO] [stdout] | [INFO] [stdout] 1305 | pub fn main_loop(mut self, event_loop: EventLoop<()>) { [INFO] [stdout] | -------- ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1306 | event_loop.run(move |event, _, control_flow| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 1307 | | *control_flow = ControlFlow::Wait; [INFO] [stdout] 1308 | | [INFO] [stdout] 1309 | | match event { [INFO] [stdout] ... | [INFO] [stdout] 1333 | | } [INFO] [stdout] 1334 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vka` (bin "vka" test) due to 6 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b878f95df2ea8a9f87a973368483d06a5cd9b92f28787523c043cf58d8692af1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b878f95df2ea8a9f87a973368483d06a5cd9b92f28787523c043cf58d8692af1", kill_on_drop: false }` [INFO] [stdout] b878f95df2ea8a9f87a973368483d06a5cd9b92f28787523c043cf58d8692af1