[INFO] cloning repository https://github.com/akinnane/RayTracingInOneWeekend [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/akinnane/RayTracingInOneWeekend" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fakinnane%2FRayTracingInOneWeekend", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fakinnane%2FRayTracingInOneWeekend'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 184e57989a30a1e373c79ff219c3b6978a25a94a [INFO] checking akinnane/RayTracingInOneWeekend/184e57989a30a1e373c79ff219c3b6978a25a94a against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fakinnane%2FRayTracingInOneWeekend" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/akinnane/RayTracingInOneWeekend on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/akinnane/RayTracingInOneWeekend [INFO] finished tweaking git repo https://github.com/akinnane/RayTracingInOneWeekend [INFO] tweaked toml for git repo https://github.com/akinnane/RayTracingInOneWeekend written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/akinnane/RayTracingInOneWeekend already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f9dbaa45e036a22d7e9d773b79ac3e4b5cda3fe59adefead932d1d2e01a68c36 [INFO] running `Command { std: "docker" "start" "-a" "f9dbaa45e036a22d7e9d773b79ac3e4b5cda3fe59adefead932d1d2e01a68c36", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f9dbaa45e036a22d7e9d773b79ac3e4b5cda3fe59adefead932d1d2e01a68c36", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f9dbaa45e036a22d7e9d773b79ac3e4b5cda3fe59adefead932d1d2e01a68c36", kill_on_drop: false }` [INFO] [stdout] f9dbaa45e036a22d7e9d773b79ac3e4b5cda3fe59adefead932d1d2e01a68c36 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b451689a1d30a54682194d3ca0b71cba86c6d43b143b530365a1c4fa3cd0c6fe [INFO] running `Command { std: "docker" "start" "-a" "b451689a1d30a54682194d3ca0b71cba86c6d43b143b530365a1c4fa3cd0c6fe", kill_on_drop: false }` [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Compiling proc-macro2 v1.0.23 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling rayon-core v1.8.1 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling syn v1.0.42 [INFO] [stderr] Compiling rayon v1.4.0 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Checking crossbeam-channel v0.4.4 [INFO] [stderr] Compiling serde_derive v1.0.116 [INFO] [stderr] Compiling getrandom v0.1.15 [INFO] [stderr] Compiling num-iter v0.1.41 [INFO] [stderr] Compiling num-rational v0.3.0 [INFO] [stderr] Compiling sdl2-sys v0.33.0 [INFO] [stderr] Compiling cc v1.0.60 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Compiling serde v1.0.116 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Checking crossbeam-epoch v0.8.2 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Checking weezl v0.1.1 [INFO] [stderr] Compiling sdl2 v0.33.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking unicode-segmentation v1.6.0 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking ppv-lite86 v0.2.9 [INFO] [stderr] Checking bytemuck v1.4.1 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking tiff v0.5.0 [INFO] [stderr] Checking gif v0.11.1 [INFO] [stderr] Checking png v0.16.7 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking pbr v1.0.3 [INFO] [stderr] Compiling tinyfiledialogs v3.3.10 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking jpeg-decoder v0.1.20 [INFO] [stderr] Checking image v0.23.10 [INFO] [stderr] Checking keyboard-types v0.5.0 [INFO] [stderr] Checking show-image v0.6.4 [INFO] [stderr] Checking raytracing_in_one_weekend v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the feature `clamp` has been stable since 1.50.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(clamp)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `clamp` has been stable since 1.50.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(clamp)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `w` is never read [INFO] [stdout] --> src/camera.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Camera { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 13 | pub w: Point, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `Camera` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:227:5 [INFO] [stdout] | [INFO] [stdout] 177 | let world = random_scene(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | let (handle, sender, shutdown_receiver) = image_thread(image.clone()); [INFO] [stdout] | ------ ------ ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | handle.join().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:278:9 [INFO] [stdout] | [INFO] [stdout] 278 | show_image::save_image(Path::new("out.png"), &data, info); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 278 | let _ = show_image::save_image(Path::new("out.png"), &data, info); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `raytracing_in_one_weekend` (bin "raytracing_in_one_weekend" test) due to 2 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `w` is never read [INFO] [stdout] --> src/camera.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Camera { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 13 | pub w: Point, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `Camera` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:227:5 [INFO] [stdout] | [INFO] [stdout] 177 | let world = random_scene(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | let (handle, sender, shutdown_receiver) = image_thread(image.clone()); [INFO] [stdout] | ------ ------ ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | handle.join().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:278:9 [INFO] [stdout] | [INFO] [stdout] 278 | show_image::save_image(Path::new("out.png"), &data, info); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 278 | let _ = show_image::save_image(Path::new("out.png"), &data, info); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `raytracing_in_one_weekend` (bin "raytracing_in_one_weekend") due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b451689a1d30a54682194d3ca0b71cba86c6d43b143b530365a1c4fa3cd0c6fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b451689a1d30a54682194d3ca0b71cba86c6d43b143b530365a1c4fa3cd0c6fe", kill_on_drop: false }` [INFO] [stdout] b451689a1d30a54682194d3ca0b71cba86c6d43b143b530365a1c4fa3cd0c6fe