[INFO] cloning repository https://github.com/ajgrah2000/rusted_atari2600 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ajgrah2000/rusted_atari2600" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fajgrah2000%2Frusted_atari2600", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fajgrah2000%2Frusted_atari2600'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 449eb1f054c4707fbdde971a721a839baf1a8905 [INFO] checking ajgrah2000/rusted_atari2600/449eb1f054c4707fbdde971a721a839baf1a8905 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fajgrah2000%2Frusted_atari2600" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ajgrah2000/rusted_atari2600 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-7-tc2/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/ajgrah2000/rusted_atari2600 [INFO] finished tweaking git repo https://github.com/ajgrah2000/rusted_atari2600 [INFO] tweaked toml for git repo https://github.com/ajgrah2000/rusted_atari2600 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ajgrah2000/rusted_atari2600 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1cb869c8c3d2b85fa8e78d7c27611e8f1abfb9496455eb8a9c57c74db07dc6e2 [INFO] running `Command { std: "docker" "start" "-a" "1cb869c8c3d2b85fa8e78d7c27611e8f1abfb9496455eb8a9c57c74db07dc6e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1cb869c8c3d2b85fa8e78d7c27611e8f1abfb9496455eb8a9c57c74db07dc6e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1cb869c8c3d2b85fa8e78d7c27611e8f1abfb9496455eb8a9c57c74db07dc6e2", kill_on_drop: false }` [INFO] [stdout] 1cb869c8c3d2b85fa8e78d7c27611e8f1abfb9496455eb8a9c57c74db07dc6e2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 770b94d4b6049fb9d3dfdab564b1a2f734640e6843da86da91ddcbad26de828e [INFO] running `Command { std: "docker" "start" "-a" "770b94d4b6049fb9d3dfdab564b1a2f734640e6843da86da91ddcbad26de828e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling version-compare v0.1.1 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Compiling sdl2 v0.35.2 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking bitfield v0.14.0 [INFO] [stderr] Checking hound v3.5.1 [INFO] [stderr] Checking strum v0.25.0 [INFO] [stderr] Compiling sdl2-sys v0.35.2 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Compiling serde_derive v1.0.196 [INFO] [stderr] Compiling strum_macros v0.25.3 [INFO] [stderr] Checking argh_shared v0.1.12 [INFO] [stderr] Compiling argh_derive v0.1.12 [INFO] [stderr] Checking argh v0.1.12 [INFO] [stderr] Checking rusted_atari2600 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atari2600/atari2600.rs:127:26 [INFO] [stdout] | [INFO] [stdout] 118 | let core = Self::build_atari2600(cartridge_name, cartridge_type, debug, realtime, pal_palette); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | sdl_context: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atari2600/atari2600.rs:128:21 [INFO] [stdout] | [INFO] [stdout] 118 | let core = Self::build_atari2600(cartridge_name, cartridge_type, debug, realtime, pal_palette); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | canvas: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atari2600/atari2600.rs:129:26 [INFO] [stdout] | [INFO] [stdout] 118 | let core = Self::build_atari2600(cartridge_name, cartridge_type, debug, realtime, pal_palette); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | audio_queue: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atari2600/audio/sound.rs:80:15 [INFO] [stdout] | [INFO] [stdout] 72 | let audio_subsystem = sdl_context.audio().unwrap(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | match audio_subsystem.open_queue::(None, &desired_spec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atari2600/graphics/display.rs:93:15 [INFO] [stdout] | [INFO] [stdout] 87 | let video_subsystem = sdl_context.video().unwrap(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | let mut renderer = video_subsystem.window(name, frame_width as u32, frame_height as u32); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | match window.build().map_err(|e| e.to_string()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atari2600/memory/memory.rs:23:24 [INFO] [stdout] | [INFO] [stdout] 21 | ...artridge_name: &String, cartridge_type: &cartridge::CartridgeType, stella: Box, riot: Box) -> Self { [INFO] [stdout] | ----------------------------- ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | ... [INFO] [stdout] 23 | ...ridge: cartridge::get_new_cartridge(cartridge_name, cartridge_type), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rusted_atari2600` (bin "rusted_atari2600") due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atari2600/atari2600.rs:127:26 [INFO] [stdout] | [INFO] [stdout] 118 | let core = Self::build_atari2600(cartridge_name, cartridge_type, debug, realtime, pal_palette); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | sdl_context: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atari2600/atari2600.rs:128:21 [INFO] [stdout] | [INFO] [stdout] 118 | let core = Self::build_atari2600(cartridge_name, cartridge_type, debug, realtime, pal_palette); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | canvas: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atari2600/atari2600.rs:129:26 [INFO] [stdout] | [INFO] [stdout] 118 | let core = Self::build_atari2600(cartridge_name, cartridge_type, debug, realtime, pal_palette); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | audio_queue: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atari2600/audio/sound.rs:80:15 [INFO] [stdout] | [INFO] [stdout] 72 | let audio_subsystem = sdl_context.audio().unwrap(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | match audio_subsystem.open_queue::(None, &desired_spec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atari2600/graphics/display.rs:93:15 [INFO] [stdout] | [INFO] [stdout] 87 | let video_subsystem = sdl_context.video().unwrap(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | let mut renderer = video_subsystem.window(name, frame_width as u32, frame_height as u32); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | match window.build().map_err(|e| e.to_string()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atari2600/memory/memory.rs:23:24 [INFO] [stdout] | [INFO] [stdout] 21 | ...artridge_name: &String, cartridge_type: &cartridge::CartridgeType, stella: Box, riot: Box) -> Self { [INFO] [stdout] | ----------------------------- ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | ... [INFO] [stdout] 23 | ...ridge: cartridge::get_new_cartridge(cartridge_name, cartridge_type), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rusted_atari2600` (bin "rusted_atari2600" test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "770b94d4b6049fb9d3dfdab564b1a2f734640e6843da86da91ddcbad26de828e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "770b94d4b6049fb9d3dfdab564b1a2f734640e6843da86da91ddcbad26de828e", kill_on_drop: false }` [INFO] [stdout] 770b94d4b6049fb9d3dfdab564b1a2f734640e6843da86da91ddcbad26de828e