[INFO] cloning repository https://github.com/aisamanra/knurling [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/aisamanra/knurling" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faisamanra%2Fknurling", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faisamanra%2Fknurling'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] fe2caffffac1bbc10873555a709b456e34ae0098 [INFO] checking aisamanra/knurling/fe2caffffac1bbc10873555a709b456e34ae0098 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faisamanra%2Fknurling" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/aisamanra/knurling on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/aisamanra/knurling [INFO] finished tweaking git repo https://github.com/aisamanra/knurling [INFO] tweaked toml for git repo https://github.com/aisamanra/knurling written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/aisamanra/knurling already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a2f2ad3db0f4af16ba0db7b400ed98d413149e0f2eecbde54df7a47b2bbdc053 [INFO] running `Command { std: "docker" "start" "-a" "a2f2ad3db0f4af16ba0db7b400ed98d413149e0f2eecbde54df7a47b2bbdc053", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a2f2ad3db0f4af16ba0db7b400ed98d413149e0f2eecbde54df7a47b2bbdc053", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a2f2ad3db0f4af16ba0db7b400ed98d413149e0f2eecbde54df7a47b2bbdc053", kill_on_drop: false }` [INFO] [stdout] a2f2ad3db0f4af16ba0db7b400ed98d413149e0f2eecbde54df7a47b2bbdc053 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 32c5d597d39d23dcdd4e7617275e69882393a72bf527799176968e23e786291a [INFO] running `Command { std: "docker" "start" "-a" "32c5d597d39d23dcdd4e7617275e69882393a72bf527799176968e23e786291a", kill_on_drop: false }` [INFO] [stderr] Compiling pkg-config v0.3.14 [INFO] [stderr] Compiling libc v0.2.50 [INFO] [stderr] Compiling proc-macro2 v0.4.27 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling syn v0.15.29 [INFO] [stderr] Compiling cc v1.0.31 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Checking bitflags v1.0.4 [INFO] [stderr] Compiling autocfg v0.1.2 [INFO] [stderr] Compiling pango v0.6.0 [INFO] [stderr] Compiling serde v1.0.94 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Compiling failure_derive v0.1.5 [INFO] [stderr] Compiling cairo-rs v0.6.0 [INFO] [stderr] Checking rustc-demangle v0.1.13 [INFO] [stderr] Compiling pangocairo v0.7.0 [INFO] [stderr] Checking cfg-if v0.1.7 [INFO] [stderr] Compiling knurling v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking xdg v2.2.0 [INFO] [stderr] Compiling backtrace v0.3.14 [INFO] [stderr] Compiling glib-sys v0.8.0 [INFO] [stderr] Compiling gobject-sys v0.8.0 [INFO] [stderr] Compiling cairo-sys-rs v0.8.0 [INFO] [stderr] Compiling pango-sys v0.8.0 [INFO] [stderr] Compiling x11 v2.18.1 [INFO] [stderr] Compiling pangocairo-sys v0.9.0 [INFO] [stderr] Compiling backtrace-sys v0.1.28 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Compiling quote v0.6.11 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking glib v0.7.1 [INFO] [stderr] Checking toml v0.5.1 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Checking failure v0.1.5 [INFO] [stdout] warning: unused import: `Size` [INFO] [stdout] --> src/widgets/standard.rs:1:52 [INFO] [stdout] | [INFO] [stdout] 1 | pub use crate::widgets::widget::{Drawing, Located, Size, Widget}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/main.rs:51:50 [INFO] [stdout] | [INFO] [stdout] 51 | let window_fds: Vec = ws.iter_mut().map({ |w| w.get_fd() }).collect(); [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_braces)]` on by default [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 51 - let window_fds: Vec = ws.iter_mut().map({ |w| w.get_fd() }).collect(); [INFO] [stdout] 51 + let window_fds: Vec = ws.iter_mut().map(|w| w.get_fd()).collect(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Size` [INFO] [stdout] --> src/widgets/standard.rs:1:52 [INFO] [stdout] | [INFO] [stdout] 1 | pub use crate::widgets::widget::{Drawing, Located, Size, Widget}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/main.rs:51:50 [INFO] [stdout] | [INFO] [stdout] 51 | let window_fds: Vec = ws.iter_mut().map({ |w| w.get_fd() }).collect(); [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_braces)]` on by default [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 51 - let window_fds: Vec = ws.iter_mut().map({ |w| w.get_fd() }).collect(); [INFO] [stdout] 51 + let window_fds: Vec = ws.iter_mut().map(|w| w.get_fd()).collect(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `x` and `y` are never read [INFO] [stdout] --> src/window.rs:344:18 [INFO] [stdout] | [INFO] [stdout] 344 | MouseEvent { x: f64, y: f64 }, [INFO] [stdout] | ---------- ^ ^ [INFO] [stdout] | | [INFO] [stdout] | fields in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Event` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `x` and `y` are never read [INFO] [stdout] --> src/window.rs:344:18 [INFO] [stdout] | [INFO] [stdout] 344 | MouseEvent { x: f64, y: f64 }, [INFO] [stdout] | ---------- ^ ^ [INFO] [stdout] | | [INFO] [stdout] | fields in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Event` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/widgets/mod.rs:12:21 [INFO] [stdout] | [INFO] [stdout] 12 | ("box", &|_| Ok(Box::new(standard::Time::new()))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/widgets/mod.rs:13:25 [INFO] [stdout] | [INFO] [stdout] 13 | ("battery", &|_| Ok(Box::new(battery::Battery::new()?))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/widgets/mod.rs:12:21 [INFO] [stdout] | [INFO] [stdout] 12 | ("box", &|_| Ok(Box::new(standard::Time::new()))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/widgets/mod.rs:14:25 [INFO] [stdout] | [INFO] [stdout] 14 | ("caesura", &|_| Ok(Box::new(standard::Caesura))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/widgets/mod.rs:13:25 [INFO] [stdout] | [INFO] [stdout] 13 | ("battery", &|_| Ok(Box::new(battery::Battery::new()?))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/widgets/mod.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | Ok(Box::new(mpd::MPD::new(host.to_string(), port as usize))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/widgets/mod.rs:14:25 [INFO] [stdout] | [INFO] [stdout] 14 | ("caesura", &|_| Ok(Box::new(standard::Caesura))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/widgets/mod.rs:24:23 [INFO] [stdout] | [INFO] [stdout] 24 | ("stdin", &|_| Ok(Box::new(standard::Stdin::new()))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/widgets/mod.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | Ok(Box::new(mpd::MPD::new(host.to_string(), port as usize))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/widgets/mod.rs:25:22 [INFO] [stdout] | [INFO] [stdout] 25 | ("time", &|_| Ok(Box::new(standard::Time::new()))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/widgets/mod.rs:24:23 [INFO] [stdout] | [INFO] [stdout] 24 | ("stdin", &|_| Ok(Box::new(standard::Stdin::new()))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/widgets/mod.rs:25:22 [INFO] [stdout] | [INFO] [stdout] 25 | ("time", &|_| Ok(Box::new(standard::Time::new()))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `knurling` (bin "knurling" test) due to 7 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `knurling` (bin "knurling") due to 7 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "32c5d597d39d23dcdd4e7617275e69882393a72bf527799176968e23e786291a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "32c5d597d39d23dcdd4e7617275e69882393a72bf527799176968e23e786291a", kill_on_drop: false }` [INFO] [stdout] 32c5d597d39d23dcdd4e7617275e69882393a72bf527799176968e23e786291a