[INFO] cloning repository https://github.com/ahinchliff/phonon-client-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ahinchliff/phonon-client-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fahinchliff%2Fphonon-client-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fahinchliff%2Fphonon-client-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 946b1a22889b68884d0d9847b9a3930647ef6bec [INFO] checking ahinchliff/phonon-client-rust/946b1a22889b68884d0d9847b9a3930647ef6bec against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fahinchliff%2Fphonon-client-rust" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ahinchliff/phonon-client-rust on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ahinchliff/phonon-client-rust [INFO] finished tweaking git repo https://github.com/ahinchliff/phonon-client-rust [INFO] tweaked toml for git repo https://github.com/ahinchliff/phonon-client-rust written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ahinchliff/phonon-client-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3a8fda4fe3dcf8ee3976d5a4c901f70f459baa993186beeb187302196faec6fb [INFO] running `Command { std: "docker" "start" "-a" "3a8fda4fe3dcf8ee3976d5a4c901f70f459baa993186beeb187302196faec6fb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3a8fda4fe3dcf8ee3976d5a4c901f70f459baa993186beeb187302196faec6fb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3a8fda4fe3dcf8ee3976d5a4c901f70f459baa993186beeb187302196faec6fb", kill_on_drop: false }` [INFO] [stdout] 3a8fda4fe3dcf8ee3976d5a4c901f70f459baa993186beeb187302196faec6fb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] be2703c52dd89a23af6b91609106f8c2a65b7d84f713236c850da3580cf9c3ea [INFO] running `Command { std: "docker" "start" "-a" "be2703c52dd89a23af6b91609106f8c2a65b7d84f713236c850da3580cf9c3ea", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.135 [INFO] [stderr] Compiling generic-array v0.14.6 [INFO] [stderr] Compiling pkg-config v0.3.25 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Checking cpufeatures v0.2.5 [INFO] [stderr] Compiling pcsc-sys v1.2.0 [INFO] [stderr] Checking pcsc v2.7.0 [INFO] [stderr] Compiling secp256k1-sys v0.6.1 [INFO] [stderr] Checking block-buffer v0.10.3 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Checking digest v0.10.5 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking sha2 v0.10.6 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking secp256k1 v0.24.0 [INFO] [stderr] Checking phonon_client_rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `pairing_public_key` is never read [INFO] [stdout] --> src/phonon_card/channel.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 1 | pub struct Channel { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 2 | pub send: Box>, [INFO] [stdout] 3 | pairing_public_key: secp256k1::PublicKey, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/usb_phonon_card/mod.rs:33:14 [INFO] [stdout] | [INFO] [stdout] 32 | fn create_send(card: pcsc::Card) -> Box> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | Box::new(move |command: apdu::CommandApdu| { [INFO] [stdout] | ______________^ [INFO] [stdout] 34 | | let command = encode_command_apdu(command); [INFO] [stdout] 35 | | let mut rapdu_buf = [0; pcsc::MAX_BUFFER_SIZE]; [INFO] [stdout] 36 | | let rapdu = card.transmit(&command, &mut rapdu_buf)?; [INFO] [stdout] 37 | | Ok(parse_response_apdu(rapdu.to_vec())) [INFO] [stdout] 38 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/usb_phonon_card/mod.rs:47:8 [INFO] [stdout] | [INFO] [stdout] 42 | let ctx = pcsc::Context::establish(pcsc::Scope::User)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | Ok(readers [INFO] [stdout] | ________^ [INFO] [stdout] 48 | | .into_iter() [INFO] [stdout] 49 | | .map( [INFO] [stdout] 50 | | |reader| match ctx.connect(reader, pcsc::ShareMode::Shared, pcsc::Protocols::ANY) { [INFO] [stdout] ... | [INFO] [stdout] 63 | | }) [INFO] [stdout] 64 | | .collect::>()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/usb_phonon_card/mod.rs:50:28 [INFO] [stdout] | [INFO] [stdout] 50 | |reader| match ctx.connect(reader, pcsc::ShareMode::Shared, pcsc::Protocols::ANY) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `phonon_client_rust` (lib test) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `pairing_public_key` is never read [INFO] [stdout] --> src/phonon_card/channel.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 1 | pub struct Channel { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 2 | pub send: Box>, [INFO] [stdout] 3 | pairing_public_key: secp256k1::PublicKey, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/usb_phonon_card/mod.rs:33:14 [INFO] [stdout] | [INFO] [stdout] 32 | fn create_send(card: pcsc::Card) -> Box> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | Box::new(move |command: apdu::CommandApdu| { [INFO] [stdout] | ______________^ [INFO] [stdout] 34 | | let command = encode_command_apdu(command); [INFO] [stdout] 35 | | let mut rapdu_buf = [0; pcsc::MAX_BUFFER_SIZE]; [INFO] [stdout] 36 | | let rapdu = card.transmit(&command, &mut rapdu_buf)?; [INFO] [stdout] 37 | | Ok(parse_response_apdu(rapdu.to_vec())) [INFO] [stdout] 38 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/usb_phonon_card/mod.rs:47:8 [INFO] [stdout] | [INFO] [stdout] 42 | let ctx = pcsc::Context::establish(pcsc::Scope::User)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | Ok(readers [INFO] [stdout] | ________^ [INFO] [stdout] 48 | | .into_iter() [INFO] [stdout] 49 | | .map( [INFO] [stdout] 50 | | |reader| match ctx.connect(reader, pcsc::ShareMode::Shared, pcsc::Protocols::ANY) { [INFO] [stdout] ... | [INFO] [stdout] 63 | | }) [INFO] [stdout] 64 | | .collect::>()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/usb_phonon_card/mod.rs:50:28 [INFO] [stdout] | [INFO] [stdout] 50 | |reader| match ctx.connect(reader, pcsc::ShareMode::Shared, pcsc::Protocols::ANY) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `phonon_client_rust` (lib) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "be2703c52dd89a23af6b91609106f8c2a65b7d84f713236c850da3580cf9c3ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "be2703c52dd89a23af6b91609106f8c2a65b7d84f713236c850da3580cf9c3ea", kill_on_drop: false }` [INFO] [stdout] be2703c52dd89a23af6b91609106f8c2a65b7d84f713236c850da3580cf9c3ea